Compare commits

...

29 Commits
4.2.0 ... 4.3.0

Author SHA1 Message Date
UnlimitedStack
8da0713bf0 Ensure that TabWidget was not deleted by using it as context object (#612)
Co-authored-by: Marcus Venturi <marcus.venturi@visu-it.de>
2024-03-16 01:23:42 +01:00
NeroBurner
08da925fde readme: small wording improvements (#610)
Removes an extra `the` in the Readme about the tested Linux versions
2024-02-28 20:45:32 +01:00
Dominik Nussbaumer
fb58c435ef Fix ODR violations when using CMake unity builds. (#609) 2024-02-28 13:25:20 +01:00
Dominik Nussbaumer
6bf593ef4b fix forward declarations of QXmlStreamWriter (#608) 2024-02-27 17:34:42 +01:00
Uwe Kindler
6b3b7750cb Fixed #604 - AutoHide widgets disapears when last open DockWidget is closed 2024-02-12 08:18:33 +01:00
Uwe Kindler
541db8e214 Fixed wrong hiding/showing of dock area title bar buttons when DockAreaHideDisabledButtons flag is enabled 2024-02-12 08:11:56 +01:00
Uwe Kindler
644c828f00 Fixed crash caused by changes related to issue #594 - deletion of CFloatingWidget caused crash when loading a state from XML 2024-01-26 16:31:04 +01:00
Uwe Kindler
ed6636ae26 Added CDockManager::lockDockWidgetFeaturesGlobally functionality to globally "freeze" the current docking layout 2024-01-23 13:29:41 +01:00
Stefan Gerlach
1a543e946d Fix 'zero as null pointer constant' warning (#598) 2024-01-16 14:05:42 +01:00
Uwe Kindler
9bdefd6055 Fixed issue #597 - Crashes when the floating widget moves to the dock manager and then tries to drag it back 2024-01-16 14:03:53 +01:00
Uwe Kindler
8fd691968c Merge branch 'master' of https://github.com/githubuser0xFFFF/Qt-Advanced-Docking-System 2024-01-04 08:31:57 +01:00
Uwe Kindler
7abc698d09 Fixed #594 - Destruction of CDockWidget inside a CFloatingDockContainer 2024-01-04 08:31:18 +01:00
Uwe Kindler
5b23248fb8 Fixed debug output issues and improved debug output for CDockWidget destructor 2024-01-04 08:30:17 +01:00
Uwe Kindler
46a5cee9c9 Added .clang-format file 2024-01-02 09:11:36 +01:00
Benjamin Buch
6c2c9888be respect customized CMake install locations (#593) 2023-12-12 13:54:51 +01:00
Uwe Kindler
44ff9e9956 Fixed some compiler warnings on Ubuntu 22.04 2023-12-08 07:58:36 +01:00
tmartsum
f848df74c3 Improve safety in code (#588)
Delete areas later so that that they can be accessed by
(inherited) dock widgets in dtor. Add some QPointer to
prevent crashes.

Hence allow users to do more while dock widgets etc
are being destroyed.
2023-12-08 06:47:02 +01:00
tmartsum
6c98c29855 Update documentation regarding central widget (#589) 2023-12-07 10:00:30 +01:00
tmartsum
c34d479d5c Avoid dock manager double delete (crashes) (#587)
If a dockwidget has been manually deleted, the dockmanager
would delete it again when deleting the area in its dtor.
The 'optimal' solution would likely have been changing
CDockWidget::~CDockWidget to add
if (d->DockArea) d->DockArea->removeDockWidget(this);
(before delete d).
However, it is not trivial (for me) to conclude that such
a change would be safe on program shutdown.

Co-authored-by: Thorbjørn Lund Martsum <thorbjorn@luxion.com>
2023-12-06 15:12:48 +01:00
jporcher
a7a97e6978 Fix https://github.com/githubuser0xFFFF/Qt-Advanced-Docking-System/issues/585 (#586) 2023-12-05 14:44:31 +01:00
Uwe Kindler
ec018a4c70 Added documentation for new "ShowTabTextOnlyForActiveTab" config flag 2023-12-04 09:24:59 +01:00
Uwe Kindler
0fabebb0fe Merge branch 'master' of https://github.com/nitramr/Qt-Advanced-Docking-System into nitramr-master 2023-12-04 09:10:34 +01:00
Uwe Kindler
521e1fbe39 Updated default AutoHide config to use Minimize button 2023-12-04 09:10:02 +01:00
Uwe Kindler
5f2aeaef00 Updated gitignore 2023-12-04 09:09:37 +01:00
nitramr
818e568f4a new configuration of icon only tabs 2023-12-02 14:48:43 +01:00
tmartsum
5d6831d179 Fix DockWidget crach when area is a nullptr. (#582)
When requesting hide on a dockwidget that has been added
to a dockmanager, but isn't yet visible, there was a creash.
The crash has been fixed by moving the code to the existing
guard check for the area.

Co-authored-by: Thorbjørn Lund Martsum <thorbjorn@luxion.com>
2023-12-01 15:13:45 +01:00
Uwe Kindler
a2c94c16b5 Fixed bug in focus_highlighting.css stylesheet 2023-11-27 22:04:45 +01:00
Uwe Kindler
68f1084bf0 Added parentSplitter() fucntion to DockArea and removed dead code from DockContainerWidget 2023-11-27 21:48:14 +01:00
Uwe Kindler
761bfc50d6 Fixed #581 - FocusHighlighting is broken after detaching a dock widget 2023-11-24 13:54:19 +01:00
39 changed files with 643 additions and 152 deletions

146
.clang-format Normal file
View File

@@ -0,0 +1,146 @@
---
AccessModifierOffset: -4
AlignAfterOpenBracket: Align
AlignConsecutiveMacros: None
AlignConsecutiveAssignments: None
AlignConsecutiveDeclarations: None
AlignEscapedNewlines: Right
AlignOperands: Align
AlignTrailingComments: true
AllowAllArgumentsOnNextLine: true
AllowAllParametersOfDeclarationOnNextLine: true
AllowShortBlocksOnASingleLine: Never
AllowShortCaseLabelsOnASingleLine: true
AllowShortFunctionsOnASingleLine: InlineOnly
AllowShortIfStatementsOnASingleLine: Never
AllowShortLambdasOnASingleLine: Inline
AllowShortLoopsOnASingleLine: false
AlwaysBreakAfterReturnType: None
AlwaysBreakBeforeMultilineStrings: false
AlwaysBreakTemplateDeclarations: Yes
BinPackArguments: true
BinPackParameters: true
BraceWrapping:
AfterCaseLabel: true
AfterClass: true
AfterControlStatement: Always
AfterEnum: true
AfterFunction: true
AfterNamespace: true
AfterStruct: true
AfterUnion: true
AfterExternBlock: true
BeforeCatch: true
BeforeElse: true
BeforeLambdaBody: false
IndentBraces: false
SplitEmptyFunction: false
SplitEmptyRecord: false
SplitEmptyNamespace: false
BreakBeforeBinaryOperators: NonAssignment
BreakBeforeBraces: Custom
BreakBeforeTernaryOperators: false
BreakConstructorInitializers: BeforeColon
BreakInheritanceList: AfterColon
BreakStringLiterals: true
ColumnLimit: 82
CommentPragmas: '^(!.*|@c)'
CompactNamespaces: false
ConstructorInitializerAllOnOneLineOrOnePerLine: true
ContinuationIndentWidth: 4
Cpp11BracedListStyle: true
FixNamespaceComments: true
IncludeBlocks: Regroup
IncludeCategories:
- Regex: '^<windows(\.h)?>' # windows headers
Priority: -1
- Regex: '^<labbcan[[:alnum:]._/]+' # labbcan headers
Priority: 1
- Regex: '^<diag[[:alnum:]._/]+' # usl headers
Priority: 1
- Regex: '^<usl[[:alnum:]._/]+' # usl headers
Priority: 1
- Regex: '^<qt5compat[[:alnum:]._/]+' # qtlabb headers
Priority: 2
- Regex: '^<qtcoreaddons[[:alnum:]._/]+' # qtlabb headers
Priority: 2
- Regex: '^<qtlabb[[:alnum:]._/]+' # qtlabb headers
Priority: 2
- Regex: '<Q[[:alnum:].]+>' # Qt headers
Priority: 3
- Regex: '^<sila_cpp[[:alnum:]._/]+' # sila_cpp headers
Priority: 4
- Regex: '<[[:alnum:]._/]+\.h>' # other headers
Priority: 5
- Regex: '<[[:alnum:]._/]+>' # system headers
Priority: 6
- Regex: '.*'
Priority: 7
IncludeIsMainRegex: '(_p)?$'
IndentCaseBlocks: false
IndentCaseLabels: false
IndentPPDirectives: AfterHash
IndentWidth: 4
IndentWrappedFunctionNames: false
KeepEmptyLinesAtTheStartOfBlocks: false
MaxEmptyLinesToKeep: 1
NamespaceIndentation: None
PenaltyBreakAssignment: 20
PenaltyBreakBeforeFirstCallParameter: 15
PenaltyBreakComment: 10
PenaltyBreakFirstLessLess: 5
# PenaltyBreakOpenParenthesis: 30
PenaltyBreakString: 150
PenaltyBreakTemplateDeclaration: 10
PenaltyExcessCharacter: 100
PenaltyIndentedWhitespace: 0
PenaltyReturnTypeOnItsOwnLine: 150
PointerAlignment: Left
ReflowComments: true
SortIncludes: CaseSensitive
SortUsingDeclarations: true
SpaceAfterCStyleCast: false
SpaceAfterLogicalNot: false
SpaceAfterTemplateKeyword: false
SpaceBeforeAssignmentOperators: true
SpaceBeforeCpp11BracedList: false
SpaceBeforeCtorInitializerColon: true
SpaceBeforeInheritanceColon: true
SpaceBeforeParens: ControlStatements
SpaceBeforeRangeBasedForLoopColon: true
SpaceBeforeSquareBrackets: false
SpaceInEmptyBlock: false
SpaceInEmptyParentheses: false
SpacesBeforeTrailingComments: 2
SpacesInAngles: Never
SpacesInCStyleCastParentheses: false
SpacesInConditionalStatement: false
SpacesInParentheses: false
SpacesInSquareBrackets: false
Standard: c++17
StatementMacros: [ 'Q_UNUSED', 'PIMPL_D', 'PIMPL_Q', 'OD_ENTRY', 'OD_ENTRY_PROCIMG' ]
TabWidth: 4
UseTab: Never

5
.gitignore vendored
View File

@@ -1,4 +1,4 @@
*.pro.user *.pro.user*
/build /build
*.o *.o
*.dylib *.dylib
@@ -7,6 +7,9 @@ qrc_*
moc_* moc_*
ui_* ui_*
Makefile Makefile
*.dll
*.a
build-*
# IDEs # IDEs
.idea .idea

View File

@@ -368,7 +368,7 @@ The application can be compiled for macOS. A user reported, that the library wor
[![Build Status](https://travis-ci.org/githubuser0xFFFF/Qt-Advanced-Docking-System.svg?branch=master)](https://travis-ci.org/githubuser0xFFFF/Qt-Advanced-Docking-System) [![Build Status](https://travis-ci.org/githubuser0xFFFF/Qt-Advanced-Docking-System.svg?branch=master)](https://travis-ci.org/githubuser0xFFFF/Qt-Advanced-Docking-System)
[![Build status](https://github.com/githubuser0xFFFF/Qt-Advanced-Docking-System/workflows/linux-builds/badge.svg)](https://github.com/githubuser0xFFFF/Qt-Advanced-Docking-System/actions?query=workflow%3Alinux-builds) [![Build status](https://github.com/githubuser0xFFFF/Qt-Advanced-Docking-System/workflows/linux-builds/badge.svg)](https://github.com/githubuser0xFFFF/Qt-Advanced-Docking-System/actions?query=workflow%3Alinux-builds)
Unfortunately, there is no such thing as a Linux operating system. Linux is a heterogeneous environment with a variety of different distributions. So it is not possible to support "Linux" like this is possible for Windows. It is only possible to support and test a small subset of Linux distributions. The library can be compiled for and has been developed and tested with the some Linux distributions. Depending on the used window manager or compositor, dock widgets Unfortunately, there is no such thing as a Linux operating system. Linux is a heterogeneous environment with a variety of different distributions. So it is not possible to support "Linux" like it is possible for Windows. It is only possible to support and test a small subset of Linux distributions. The library can be compiled for and has been developed and tested with some Linux distributions. Depending on the used window manager or compositor, dock widgets
with native title bars are supported or not. If native title bars are not supported, with native title bars are supported or not. If native title bars are not supported,
the library switches to `QWidget` based title bars. the library switches to `QWidget` based title bars.

View File

@@ -592,19 +592,29 @@ void MainWindowPrivate::createActions()
ui.toolBar->addAction(ui.actionRestoreState); ui.toolBar->addAction(ui.actionRestoreState);
ui.actionRestoreState->setIcon(svgIcon(":/adsdemo/images/restore.svg")); ui.actionRestoreState->setIcon(svgIcon(":/adsdemo/images/restore.svg"));
SavePerspectiveAction = new QAction("Create Perspective", _this); ui.toolBar->addSeparator();
SavePerspectiveAction->setIcon(svgIcon(":/adsdemo/images/picture_in_picture.svg"));
_this->connect(SavePerspectiveAction, SIGNAL(triggered()), SLOT(savePerspective())); QAction* a = ui.toolBar->addAction("Lock Workspace");
a->setIcon(svgIcon(":/adsdemo/images/lock_outline.svg"));
a->setCheckable(true);
a->setChecked(false);
QObject::connect(a, &QAction::triggered, _this, &CMainWindow::lockWorkspace);
PerspectiveListAction = new QWidgetAction(_this); PerspectiveListAction = new QWidgetAction(_this);
PerspectiveComboBox = new QComboBox(_this); PerspectiveComboBox = new QComboBox(_this);
PerspectiveComboBox->setSizeAdjustPolicy(QComboBox::AdjustToContents); PerspectiveComboBox->setSizeAdjustPolicy(QComboBox::AdjustToContents);
PerspectiveComboBox->setSizePolicy(QSizePolicy::Preferred, QSizePolicy::Preferred); PerspectiveComboBox->setSizePolicy(QSizePolicy::Preferred, QSizePolicy::Fixed);
PerspectiveListAction->setDefaultWidget(PerspectiveComboBox); PerspectiveListAction->setDefaultWidget(PerspectiveComboBox);
ui.toolBar->addSeparator();
ui.toolBar->addAction(PerspectiveListAction); ui.toolBar->addAction(PerspectiveListAction);
a = SavePerspectiveAction = ui.toolBar->addAction("Create Perspective");
a->setIcon(svgIcon(":/adsdemo/images/picture_in_picture.svg"));
QObject::connect(a, &QAction::triggered, _this, &CMainWindow::savePerspective);
ui.toolBar->addAction(SavePerspectiveAction); ui.toolBar->addAction(SavePerspectiveAction);
QAction* a = ui.toolBar->addAction("Create Floating Editor"); ui.toolBar->addSeparator();
a = ui.toolBar->addAction("Create Floating Editor");
a->setProperty("Floating", true); a->setProperty("Floating", true);
a->setToolTip("Creates floating dynamic dockable editor windows that are deleted on close"); a->setToolTip("Creates floating dynamic dockable editor windows that are deleted on close");
a->setIcon(svgIcon(":/adsdemo/images/note_add.svg")); a->setIcon(svgIcon(":/adsdemo/images/note_add.svg"));
@@ -626,6 +636,7 @@ void MainWindowPrivate::createActions()
_this->connect(a, SIGNAL(triggered()), SLOT(createEditor())); _this->connect(a, SIGNAL(triggered()), SLOT(createEditor()));
ui.menuTests->addAction(a); ui.menuTests->addAction(a);
ui.toolBar->addSeparator();
a = ui.toolBar->addAction("Create Floating Table"); a = ui.toolBar->addAction("Create Floating Table");
a->setToolTip("Creates floating dynamic dockable table with millions of entries"); a->setToolTip("Creates floating dynamic dockable table with millions of entries");
a->setIcon(svgIcon(":/adsdemo/images/grid_on.svg")); a->setIcon(svgIcon(":/adsdemo/images/grid_on.svg"));
@@ -1030,3 +1041,17 @@ void CMainWindow::createImageViewer()
} }
} }
//============================================================================
void CMainWindow::lockWorkspace(bool Value)
{
if (Value)
{
d->DockManager->lockDockWidgetFeaturesGlobally();
}
else
{
d->DockManager->lockDockWidgetFeaturesGlobally(ads::CDockWidget::NoDockWidgetFeatures);
}
}

View File

@@ -68,6 +68,7 @@ private slots:
void toggleDockWidgetWindowTitle(); void toggleDockWidgetWindowTitle();
void applyVsStyle(); void applyVsStyle();
void createImageViewer(); void createImageViewer();
void lockWorkspace(bool Value);
}; };
#endif // MAINWINDOW_H #endif // MAINWINDOW_H

View File

@@ -36,5 +36,8 @@
<file>images/panorama.svg</file> <file>images/panorama.svg</file>
<file>images/ads_icon2.svg</file> <file>images/ads_icon2.svg</file>
<file>images/font_download.svg</file> <file>images/font_download.svg</file>
<file>images/lock_outline.svg</file>
<file>images/lock.svg</file>
<file>images/lock_open.svg</file>
</qresource> </qresource>
</RCC> </RCC>

6
demo/images/lock.svg Normal file
View File

@@ -0,0 +1,6 @@
<svg version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" viewBox="0,0,1024,1024">
<desc>lock icon - Licensed under Apache License v2.0 (http://www.apache.org/licenses/LICENSE-2.0) - Created with Iconfu.com - Derivative work of Material icons (Copyright Google Inc.)</desc>
<g fill="#03b8e5" fill-rule="nonzero" style="mix-blend-mode: normal">
<path d="M853.33,426.67v426.66c0,46.93 -38.4,85.34 -85.33,85.34h-512c-46.93,0 -85.33,-38.41 -85.33,-85.34v-426.66c0,-46.93 38.4,-85.34 85.33,-85.34h42.67v-85.33c0,-117.76 95.57,-213.33 213.33,-213.33c117.76,0 213.33,95.57 213.33,213.33v85.33h42.67c46.93,0 85.33,38.41 85.33,85.34zM644.27,256c0,-72.96 -59.31,-132.27 -132.27,-132.27c-72.96,0 -132.27,59.31 -132.27,132.27v85.33h264.54zM597.33,640c0,-46.93 -38.4,-85.33 -85.33,-85.33c-46.93,0 -85.33,38.4 -85.33,85.33c0,46.93 38.4,85.33 85.33,85.33c46.93,0 85.33,-38.4 85.33,-85.33z"/>
</g>
</svg>

After

Width:  |  Height:  |  Size: 932 B

View File

@@ -0,0 +1,6 @@
<svg version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" viewBox="0,0,1024,1024">
<desc>lock_open icon - Licensed under Apache License v2.0 (http://www.apache.org/licenses/LICENSE-2.0) - Created with Iconfu.com - Derivative work of Material icons (Copyright Google Inc.)</desc>
<g fill="#03b8e5" fill-rule="nonzero" style="mix-blend-mode: normal">
<path d="M853.33,426.67v426.66c0,46.93 -38.4,85.34 -85.33,85.34h-512c-46.93,0 -85.33,-38.41 -85.33,-85.34v-426.66c0,-46.93 38.4,-85.34 85.33,-85.34h388.27v-85.33c0,-72.96 -59.31,-132.27 -132.27,-132.27c-72.96,0 -132.27,59.31 -132.27,132.27h-81.06c0,-117.76 95.57,-213.33 213.33,-213.33c117.76,0 213.33,95.57 213.33,213.33v85.33h42.67c46.93,0 85.33,38.41 85.33,85.34zM768,426.67h-512v426.66h512zM426.67,640c0,-46.93 38.4,-85.33 85.33,-85.33c46.93,0 85.33,38.4 85.33,85.33c0,46.93 -38.4,85.33 -85.33,85.33c-46.93,0 -85.33,-38.4 -85.33,-85.33z"/>
</g>
</svg>

After

Width:  |  Height:  |  Size: 948 B

View File

@@ -0,0 +1,6 @@
<svg version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" viewBox="0,0,1024,1024">
<desc>lock_outline icon - Licensed under Apache License v2.0 (http://www.apache.org/licenses/LICENSE-2.0) - Created with Iconfu.com - Derivative work of Material icons (Copyright Google Inc.)</desc>
<g fill="#03b8e5" fill-rule="nonzero" style="mix-blend-mode: normal">
<path d="M853.33,426.67v426.66c0,46.93 -38.4,85.34 -85.33,85.34h-512c-46.93,0 -85.33,-38.41 -85.33,-85.34v-426.66c0,-46.93 38.4,-85.34 85.33,-85.34h42.67v-85.33c0,-117.76 95.57,-213.33 213.33,-213.33c117.76,0 213.33,95.57 213.33,213.33v85.33h42.67c46.93,0 85.33,38.41 85.33,85.34zM768,426.67h-512v426.66h512zM379.73,341.33h264.54v-85.33c0,-72.96 -59.31,-132.27 -132.27,-132.27c-72.96,0 -132.27,59.31 -132.27,132.27zM426.67,640c0,-46.93 38.4,-85.33 85.33,-85.33c46.93,0 85.33,38.4 85.33,85.33c0,46.93 -38.4,85.33 -85.33,85.33c-46.93,0 -85.33,-38.4 -85.33,-85.33z"/>
</g>
</svg>

After

Width:  |  Height:  |  Size: 972 B

View File

@@ -12,10 +12,10 @@ styles as much as possible.
## Features ## Features
### Docking everywhere - no central widget ### Docking everywhere - with or without a central widget
There is no central widget like in the Qt docking system. You can dock on every The Advanced Docking System works with or without a central widget.
border of the main window or you can dock into each dock area - so you are You can dock on every border of the main window or you can dock into each dock area - so you are
free to dock almost everywhere. free to dock almost everywhere.
![Dropping widgets](https://raw.githubusercontent.com/githubuser0xFFFF/Qt-Advanced-Docking-System/master/doc/preview-dragndrop.png) ![Dropping widgets](https://raw.githubusercontent.com/githubuser0xFFFF/Qt-Advanced-Docking-System/master/doc/preview-dragndrop.png)

Binary file not shown.

After

Width:  |  Height:  |  Size: 14 KiB

View File

@@ -28,6 +28,7 @@
- [`FloatingContainerForceQWidgetTitleBar` (Linux only)](#floatingcontainerforceqwidgettitlebar-linux-only) - [`FloatingContainerForceQWidgetTitleBar` (Linux only)](#floatingcontainerforceqwidgettitlebar-linux-only)
- [`MiddleMouseButtonClosesTab`](#middlemousebuttonclosestab) - [`MiddleMouseButtonClosesTab`](#middlemousebuttonclosestab)
- [`DisableTabTextEliding`](#disabletabtexteliding) - [`DisableTabTextEliding`](#disabletabtexteliding)
- [`ShowTabTextOnlyForActiveTab`](#showtabtextonlyforactivetab)
- [Auto-Hide Configuration Flags](#auto-hide-configuration-flags) - [Auto-Hide Configuration Flags](#auto-hide-configuration-flags)
- [Auto Hide Dock Widgets](#auto-hide-dock-widgets) - [Auto Hide Dock Widgets](#auto-hide-dock-widgets)
- [Pinning Auto-Hide Widgets to a certain border](#pinning-auto-hide-widgets-to-a-certain-border) - [Pinning Auto-Hide Widgets to a certain border](#pinning-auto-hide-widgets-to-a-certain-border)
@@ -302,8 +303,9 @@ or to close it via the close button.
![HideSingleCentralWidgetTitleBar true](cfg_flag_HideSingleCentralWidgetTitleBar_true.png) ![HideSingleCentralWidgetTitleBar true](cfg_flag_HideSingleCentralWidgetTitleBar_true.png)
The Advanced Docking System is meant for applications without a static central Unless a central widget explicitly has been set with setCentralWidget, the
widget and normally does not know anything about a central static widget. Advanced Docking System is without a static central widget and it wouldn't know
about a central static widget.
Therefore this flag is disabled by default and a central single dock widget Therefore this flag is disabled by default and a central single dock widget
still has a titlebar to drag it out of the main window. still has a titlebar to drag it out of the main window.
@@ -486,6 +488,13 @@ many tabs as possible even if there is not much space:
![DisableTabTextEliding false](cfg_flag_DisableTabTextEliding_false.png) ![DisableTabTextEliding false](cfg_flag_DisableTabTextEliding_false.png)
### `ShowTabTextOnlyForActiveTab`
Set this flag (default = false) to show label texts in dock area tabs only
for active tabs. Inactive tabs only show their icon:
![MShowTabTextOnlyForActiveTab true](cfg_flag_ShowTabTextOnlyForActiveTab_true.png)
## Auto-Hide Configuration Flags ## Auto-Hide Configuration Flags
### Auto Hide Dock Widgets ### Auto Hide Dock Widgets

View File

@@ -1,5 +1,5 @@
#include <QApplication> #include <QApplication>
#include "../../examples/simple/MainWindow.h" #include "mainframe.h"
int main(int argc, char *argv[]) int main(int argc, char *argv[])
{ {

View File

@@ -34,7 +34,7 @@
#include <QSplitter> #include <QSplitter>
#include "AutoHideTab.h" #include "AutoHideTab.h"
class QXmlStreamWriter; QT_FORWARD_DECLARE_CLASS(QXmlStreamWriter)
namespace ads namespace ads
{ {

View File

@@ -33,7 +33,7 @@
#include "ads_globals.h" #include "ads_globals.h"
#include "AutoHideTab.h" #include "AutoHideTab.h"
class QXmlStreamWriter; QT_FORWARD_DECLARE_CLASS(QXmlStreamWriter)
namespace ads namespace ads
{ {

View File

@@ -44,7 +44,6 @@
namespace ads namespace ads
{ {
static const char* const LocationProperty = "Location";
/** /**
* Private data class of CDockWidgetTab class (pimpl) * Private data class of CDockWidgetTab class (pimpl)
@@ -102,7 +101,7 @@ struct AutoHideTabPrivate
QMenu* Menu) QMenu* Menu)
{ {
auto Action = Menu->addAction(Title); auto Action = Menu->addAction(Title);
Action->setProperty("Location", Location); Action->setProperty(internal::LocationProperty, Location);
QObject::connect(Action, &QAction::triggered, _this, &CAutoHideTab::onAutoHideToActionClicked); QObject::connect(Action, &QAction::triggered, _this, &CAutoHideTab::onAutoHideToActionClicked);
Action->setEnabled(Location != _this->sideBarLocation()); Action->setEnabled(Location != _this->sideBarLocation());
return Action; return Action;
@@ -174,7 +173,7 @@ void AutoHideTabPrivate::updateOrientation()
bool AutoHideTabPrivate::startFloating(eDragState DraggingState) bool AutoHideTabPrivate::startFloating(eDragState DraggingState)
{ {
auto DockArea = DockWidget->dockAreaWidget(); auto DockArea = DockWidget->dockAreaWidget();
ADS_PRINT("isFloating " << dockContainer->isFloating()); ADS_PRINT("isFloating " << dockContainer()->isFloating());
ADS_PRINT("startFloating"); ADS_PRINT("startFloating");
DragState = DraggingState; DragState = DraggingState;
@@ -419,7 +418,7 @@ void CAutoHideTab::unpinDockWidget()
//=========================================================================== //===========================================================================
void CAutoHideTab::onAutoHideToActionClicked() void CAutoHideTab::onAutoHideToActionClicked()
{ {
int Location = sender()->property(LocationProperty).toInt(); int Location = sender()->property(internal::LocationProperty).toInt();
d->DockWidget->setAutoHide(true, (SideBarLocation)Location); d->DockWidget->setAutoHide(true, (SideBarLocation)Location);
} }

View File

@@ -36,7 +36,7 @@ set(ads_SRCS
AutoHideTab.cpp AutoHideTab.cpp
AutoHideDockContainer.cpp AutoHideDockContainer.cpp
PushButton.cpp PushButton.cpp
ResizeHandle.cpp ResizeHandle.cpp
ads.qrc ads.qrc
) )
set(ads_HEADERS set(ads_HEADERS
@@ -62,7 +62,7 @@ set(ads_HEADERS
AutoHideTab.h AutoHideTab.h
AutoHideDockContainer.h AutoHideDockContainer.h
PushButton.h PushButton.h
ResizeHandle.h ResizeHandle.h
) )
add_compile_options("$<$<CXX_COMPILER_ID:MSVC>:/utf-8>") add_compile_options("$<$<CXX_COMPILER_ID:MSVC>:/utf-8>")
if (UNIX AND NOT APPLE) if (UNIX AND NOT APPLE)
@@ -120,7 +120,7 @@ write_basic_package_version_file(
COMPATIBILITY SameMajorVersion COMPATIBILITY SameMajorVersion
) )
install(FILES ${ads_HEADERS} install(FILES ${ads_HEADERS}
DESTINATION include/${library_name} DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/${library_name}
COMPONENT headers COMPONENT headers
) )
install(FILES install(FILES
@@ -131,25 +131,25 @@ install(FILES
) )
install(TARGETS ${library_name} install(TARGETS ${library_name}
EXPORT adsTargets EXPORT adsTargets
RUNTIME DESTINATION bin RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
LIBRARY DESTINATION lib LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
ARCHIVE DESTINATION lib ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
INCLUDES DESTINATION include/${library_name} INCLUDES DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/${library_name}
) )
install(EXPORT adsTargets install(EXPORT adsTargets
FILE adsTargets.cmake FILE adsTargets.cmake
NAMESPACE ads:: NAMESPACE ads::
DESTINATION lib/cmake/${library_name} DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/${library_name}
) )
install(FILES qtadvanceddockingConfig.cmake RENAME ${library_name}Config.cmake install(FILES qtadvanceddockingConfig.cmake RENAME ${library_name}Config.cmake
DESTINATION lib/cmake/${library_name} DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/${library_name}
) )
install(FILES "${CMAKE_CURRENT_BINARY_DIR}/${library_name}ConfigVersion.cmake" install(FILES "${CMAKE_CURRENT_BINARY_DIR}/${library_name}ConfigVersion.cmake"
DESTINATION lib/cmake/${library_name} DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/${library_name}
) )
target_include_directories(${library_name} PUBLIC target_include_directories(${library_name} PUBLIC
$<INSTALL_INTERFACE:include> $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}> $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>
) )

View File

@@ -111,8 +111,9 @@ void DockAreaTabBarPrivate::updateTabs()
// Sometimes the synchronous calculation of the rectangular area fails // Sometimes the synchronous calculation of the rectangular area fails
// Therefore we use QTimer::singleShot here to execute the call // Therefore we use QTimer::singleShot here to execute the call
// within the event loop - see #520 // within the event loop - see #520
QTimer::singleShot(0, [&, TabWidget]{ QTimer::singleShot(0, TabWidget, [&, TabWidget]
_this->ensureWidgetVisible(TabWidget); {
_this->ensureWidgetVisible(TabWidget);
}); });
} }
else else

View File

@@ -60,7 +60,6 @@
namespace ads namespace ads
{ {
static const char* const LocationProperty = "Location";
/** /**
* Private data class of CDockAreaTitleBar class (pimpl) * Private data class of CDockAreaTitleBar class (pimpl)
@@ -159,7 +158,7 @@ struct DockAreaTitleBarPrivate
QMenu* Menu) QMenu* Menu)
{ {
auto Action = Menu->addAction(Title); auto Action = Menu->addAction(Title);
Action->setProperty("Location", Location); Action->setProperty(internal::LocationProperty, Location);
QObject::connect(Action, &QAction::triggered, _this, &CDockAreaTitleBar::onAutoHideToActionClicked); QObject::connect(Action, &QAction::triggered, _this, &CDockAreaTitleBar::onAutoHideToActionClicked);
return Action; return Action;
} }
@@ -179,7 +178,8 @@ void DockAreaTitleBarPrivate::createButtons()
QSizePolicy ButtonSizePolicy(QSizePolicy::Fixed, QSizePolicy::Expanding); QSizePolicy ButtonSizePolicy(QSizePolicy::Fixed, QSizePolicy::Expanding);
// Tabs menu button // Tabs menu button
TabsMenuButton = new CTitleBarButton(testConfigFlag(CDockManager::DockAreaHasTabsMenuButton)); TabsMenuButton = new CTitleBarButton(testConfigFlag(CDockManager::DockAreaHasTabsMenuButton),
false, TitleBarButtonTabsMenu);
TabsMenuButton->setObjectName("tabsMenuButton"); TabsMenuButton->setObjectName("tabsMenuButton");
TabsMenuButton->setAutoRaise(true); TabsMenuButton->setAutoRaise(true);
TabsMenuButton->setPopupMode(QToolButton::InstantPopup); TabsMenuButton->setPopupMode(QToolButton::InstantPopup);
@@ -197,7 +197,8 @@ void DockAreaTitleBarPrivate::createButtons()
SLOT(onTabsMenuActionTriggered(QAction*))); SLOT(onTabsMenuActionTriggered(QAction*)));
// Undock button // Undock button
UndockButton = new CTitleBarButton(testConfigFlag(CDockManager::DockAreaHasUndockButton)); UndockButton = new CTitleBarButton(testConfigFlag(CDockManager::DockAreaHasUndockButton),
true, TitleBarButtonUndock);
UndockButton->setObjectName("detachGroupButton"); UndockButton->setObjectName("detachGroupButton");
UndockButton->setAutoRaise(true); UndockButton->setAutoRaise(true);
internal::setToolTip(UndockButton, QObject::tr("Detach Group")); internal::setToolTip(UndockButton, QObject::tr("Detach Group"));
@@ -208,7 +209,8 @@ void DockAreaTitleBarPrivate::createButtons()
// AutoHide Button // AutoHide Button
const auto autoHideEnabled = testAutoHideConfigFlag(CDockManager::AutoHideFeatureEnabled); const auto autoHideEnabled = testAutoHideConfigFlag(CDockManager::AutoHideFeatureEnabled);
AutoHideButton = new CTitleBarButton(testAutoHideConfigFlag(CDockManager::DockAreaHasAutoHideButton) && autoHideEnabled); AutoHideButton = new CTitleBarButton(testAutoHideConfigFlag(CDockManager::DockAreaHasAutoHideButton) && autoHideEnabled,
true, TitleBarButtonAutoHide);
AutoHideButton->setObjectName("dockAreaAutoHideButton"); AutoHideButton->setObjectName("dockAreaAutoHideButton");
AutoHideButton->setAutoRaise(true); AutoHideButton->setAutoRaise(true);
internal::setToolTip(AutoHideButton, _this->titleBarButtonToolTip(TitleBarButtonAutoHide)); internal::setToolTip(AutoHideButton, _this->titleBarButtonToolTip(TitleBarButtonAutoHide));
@@ -220,7 +222,8 @@ void DockAreaTitleBarPrivate::createButtons()
_this->connect(AutoHideButton, SIGNAL(clicked()), SLOT(onAutoHideButtonClicked())); _this->connect(AutoHideButton, SIGNAL(clicked()), SLOT(onAutoHideButtonClicked()));
// Minimize button // Minimize button
MinimizeButton = new CTitleBarButton(testAutoHideConfigFlag(CDockManager::AutoHideHasMinimizeButton)); MinimizeButton = new CTitleBarButton(testAutoHideConfigFlag(CDockManager::AutoHideHasMinimizeButton),
false, TitleBarButtonMinimize);
MinimizeButton->setObjectName("dockAreaMinimizeButton"); MinimizeButton->setObjectName("dockAreaMinimizeButton");
MinimizeButton->setAutoRaise(true); MinimizeButton->setAutoRaise(true);
MinimizeButton->setVisible(false); MinimizeButton->setVisible(false);
@@ -231,7 +234,8 @@ void DockAreaTitleBarPrivate::createButtons()
_this->connect(MinimizeButton, SIGNAL(clicked()), SLOT(minimizeAutoHideContainer())); _this->connect(MinimizeButton, SIGNAL(clicked()), SLOT(minimizeAutoHideContainer()));
// Close button // Close button
CloseButton = new CTitleBarButton(testConfigFlag(CDockManager::DockAreaHasCloseButton)); CloseButton = new CTitleBarButton(testConfigFlag(CDockManager::DockAreaHasCloseButton),
true, TitleBarButtonClose);
CloseButton->setObjectName("dockAreaCloseButton"); CloseButton->setObjectName("dockAreaCloseButton");
CloseButton->setAutoRaise(true); CloseButton->setAutoRaise(true);
internal::setButtonIcon(CloseButton, QStyle::SP_TitleBarCloseButton, ads::DockAreaCloseIcon); internal::setButtonIcon(CloseButton, QStyle::SP_TitleBarCloseButton, ads::DockAreaCloseIcon);
@@ -510,7 +514,7 @@ void CDockAreaTitleBar::updateDockWidgetActionsButtons()
int InsertIndex = indexOf(d->TabsMenuButton); int InsertIndex = indexOf(d->TabsMenuButton);
for (auto Action : Actions) for (auto Action : Actions)
{ {
auto Button = new CTitleBarButton(true, this); auto Button = new CTitleBarButton(true, false, TitleBarButtonTabsMenu, this);
Button->setDefaultAction(Action); Button->setDefaultAction(Action);
Button->setAutoRaise(true); Button->setAutoRaise(true);
Button->setPopupMode(QToolButton::InstantPopup); Button->setPopupMode(QToolButton::InstantPopup);
@@ -564,7 +568,7 @@ void CDockAreaTitleBar::onAutoHideDockAreaActionClicked()
//============================================================================ //============================================================================
void CDockAreaTitleBar::onAutoHideToActionClicked() void CDockAreaTitleBar::onAutoHideToActionClicked()
{ {
int Location = sender()->property(LocationProperty).toInt(); int Location = sender()->property(internal::LocationProperty).toInt();
d->DockArea->toggleAutoHide((SideBarLocation)Location); d->DockArea->toggleAutoHide((SideBarLocation)Location);
} }
@@ -856,10 +860,25 @@ void CDockAreaTitleBar::showAutoHideControls(bool Show)
//============================================================================ //============================================================================
CTitleBarButton::CTitleBarButton(bool showInTitleBar, QWidget* parent) bool CDockAreaTitleBar::isAutoHide() const
{
return d->DockArea && d->DockArea->isAutoHide();
}
//============================================================================
CDockAreaWidget* CDockAreaTitleBar::dockAreaWidget() const
{
return d->DockArea;
}
//============================================================================
CTitleBarButton::CTitleBarButton(bool showInTitleBar, bool hideWhenDisabled, TitleBarButton ButtonId, QWidget* parent)
: tTitleBarButton(parent), : tTitleBarButton(parent),
ShowInTitleBar(showInTitleBar), ShowInTitleBar(showInTitleBar),
HideWhenDisabled(CDockManager::testConfigFlag(CDockManager::DockAreaHideDisabledButtons)) HideWhenDisabled(CDockManager::testConfigFlag(CDockManager::DockAreaHideDisabledButtons) && hideWhenDisabled),
TitleBarButtonId(ButtonId)
{ {
setFocusPolicy(Qt::NoFocus); setFocusPolicy(Qt::NoFocus);
} }
@@ -894,16 +913,47 @@ void CTitleBarButton::setShowInTitleBar(bool Show)
//============================================================================ //============================================================================
bool CTitleBarButton::event(QEvent *ev) bool CTitleBarButton::event(QEvent *ev)
{ {
if (QEvent::EnabledChange == ev->type() && HideWhenDisabled) if (QEvent::EnabledChange != ev->type() || !HideWhenDisabled || !ShowInTitleBar)
{ {
// force setVisible() call return Super::event(ev);
// Calling setVisible() directly here doesn't work well when button is expected to be shown first time
QMetaObject::invokeMethod(this, "setVisible", Qt::QueuedConnection, Q_ARG(bool, isEnabled()));
} }
bool Show = true;
if (isInAutoHideArea())
{
switch (TitleBarButtonId)
{
case TitleBarButtonClose: Show = CDockManager::testAutoHideConfigFlag(CDockManager::AutoHideHasCloseButton); break;
case TitleBarButtonUndock: Show = false; break;
default:
break;
}
}
// force setVisible() call - Calling setVisible() directly here doesn't
// work well when button is expected to be shown first time
QMetaObject::invokeMethod(this, "setVisible", Qt::QueuedConnection,
Q_ARG(bool, isEnabledTo(this->parentWidget()) & Show));
return Super::event(ev); return Super::event(ev);
} }
//============================================================================
CDockAreaTitleBar* CTitleBarButton::titleBar() const
{
return qobject_cast<CDockAreaTitleBar*>(parentWidget());
}
//============================================================================
bool CTitleBarButton::isInAutoHideArea() const
{
auto TitleBar = titleBar();
return TitleBar && TitleBar->isAutoHide();
}
//============================================================================ //============================================================================
CSpacerWidget::CSpacerWidget(QWidget* Parent /*= 0*/) : Super(Parent) CSpacerWidget::CSpacerWidget(QWidget* Parent /*= 0*/) : Super(Parent)
{ {

View File

@@ -43,6 +43,7 @@ class CDockAreaTabBar;
class CDockAreaWidget; class CDockAreaWidget;
struct DockAreaTitleBarPrivate; struct DockAreaTitleBarPrivate;
class CElidingLabel; class CElidingLabel;
class CDockAreaTitleBar;
using tTitleBarButton = QToolButton; using tTitleBarButton = QToolButton;
@@ -59,10 +60,12 @@ class CTitleBarButton : public tTitleBarButton
private: private:
bool ShowInTitleBar = true; bool ShowInTitleBar = true;
bool HideWhenDisabled = false; bool HideWhenDisabled = false;
TitleBarButton TitleBarButtonId;
public: public:
using Super = tTitleBarButton; using Super = tTitleBarButton;
CTitleBarButton(bool ShowInTitleBar = true, QWidget* parent = nullptr); CTitleBarButton(bool ShowInTitleBar, bool HideWhenDisabled, TitleBarButton ButtonId,
QWidget* parent = nullptr);
/** /**
* Adjust this visibility change request with our internal settings: * Adjust this visibility change request with our internal settings:
@@ -74,6 +77,22 @@ public:
*/ */
void setShowInTitleBar(bool Show); void setShowInTitleBar(bool Show);
/**
* Identifier for the title bar button
*/
TitleBarButton buttonId() const {return TitleBarButtonId;}
/**
* Return the title bar that contains this button
*/
CDockAreaTitleBar* titleBar() const;
/**
* Returns true, if the button is in a title bar in an auto hide area
*/
bool isInAutoHideArea() const;
protected: protected:
/** /**
* Handle EnabledChanged signal to set button invisible if the configured * Handle EnabledChanged signal to set button invisible if the configured
@@ -169,6 +188,11 @@ public:
*/ */
CElidingLabel* autoHideTitleLabel() const; CElidingLabel* autoHideTitleLabel() const;
/**
* Returns the dock area widget that contains this title bar
*/
CDockAreaWidget* dockAreaWidget() const;
/** /**
* Updates the visibility of the dock widget actions in the title bar * Updates the visibility of the dock widget actions in the title bar
*/ */
@@ -215,6 +239,11 @@ public:
*/ */
void showAutoHideControls(bool Show); void showAutoHideControls(bool Show);
/**
* Returns true, if the auto hide controls are visible
*/
bool isAutoHide() const;
Q_SIGNALS: Q_SIGNALS:
/** /**
* This signal is emitted if a tab in the tab bar is clicked by the user * This signal is emitted if a tab in the tab bar is clicked by the user

View File

@@ -52,7 +52,7 @@ class CSpacerWidget : public QWidget
Q_OBJECT Q_OBJECT
public: public:
using Super = QWidget; using Super = QWidget;
CSpacerWidget(QWidget* Parent = 0); CSpacerWidget(QWidget* Parent = nullptr);
virtual QSize sizeHint() const override {return QSize(0, 0);} virtual QSize sizeHint() const override {return QSize(0, 0);}
virtual QSize minimumSizeHint() const override {return QSize(0, 0);} virtual QSize minimumSizeHint() const override {return QSize(0, 0);}
}; };

View File

@@ -81,7 +81,7 @@ class CDockAreaLayout
{ {
private: private:
QBoxLayout* m_ParentLayout; QBoxLayout* m_ParentLayout;
QList<QWidget*> m_Widgets; QList<QPointer<QWidget>> m_Widgets;
int m_CurrentIndex = -1; int m_CurrentIndex = -1;
QWidget* m_CurrentWidget = nullptr; QWidget* m_CurrentWidget = nullptr;
@@ -370,10 +370,21 @@ void DockAreaWidgetPrivate::updateTitleBarButtonStates()
return; return;
} }
TitleBar->button(TitleBarButtonClose)->setEnabled( if (_this->isAutoHide())
_this->features().testFlag(CDockWidget::DockWidgetClosable)); {
TitleBar->button(TitleBarButtonUndock)->setEnabled( if (CDockManager::testAutoHideConfigFlag(CDockManager::AutoHideHasCloseButton))
_this->features().testFlag(CDockWidget::DockWidgetFloatable)); {
TitleBar->button(TitleBarButtonClose)->setEnabled(
_this->features().testFlag(CDockWidget::DockWidgetClosable));
}
}
else
{
TitleBar->button(TitleBarButtonUndock)->setEnabled(
_this->features().testFlag(CDockWidget::DockWidgetFloatable));
TitleBar->button(TitleBarButtonClose)->setEnabled(
_this->features().testFlag(CDockWidget::DockWidgetClosable));
}
TitleBar->button(TitleBarButtonAutoHide)->setEnabled( TitleBar->button(TitleBarButtonAutoHide)->setEnabled(
_this->features().testFlag(CDockWidget::DockWidgetPinnable)); _this->features().testFlag(CDockWidget::DockWidgetPinnable));
TitleBar->updateDockWidgetActionsButtons(); TitleBar->updateDockWidgetActionsButtons();
@@ -393,7 +404,7 @@ void DockAreaWidgetPrivate::updateTitleBarButtonVisibility(bool IsTopLevel)
bool IsAutoHide = _this->isAutoHide(); bool IsAutoHide = _this->isAutoHide();
if (IsAutoHide) if (IsAutoHide)
{ {
bool ShowCloseButton = CDockManager::autoHideConfigFlags().testFlag(CDockManager::AutoHideHasCloseButton); bool ShowCloseButton = CDockManager::testAutoHideConfigFlag(CDockManager::AutoHideHasCloseButton);
TitleBar->button(TitleBarButtonClose)->setVisible(ShowCloseButton); TitleBar->button(TitleBarButtonClose)->setVisible(ShowCloseButton);
TitleBar->button(TitleBarButtonAutoHide)->setVisible(true); TitleBar->button(TitleBarButtonAutoHide)->setVisible(true);
TitleBar->button(TitleBarButtonUndock)->setVisible(false); TitleBar->button(TitleBarButtonUndock)->setVisible(false);
@@ -410,7 +421,8 @@ void DockAreaWidgetPrivate::updateTitleBarButtonVisibility(bool IsTopLevel)
else else
{ {
TitleBar->button(TitleBarButtonClose)->setVisible(true); TitleBar->button(TitleBarButtonClose)->setVisible(true);
TitleBar->button(TitleBarButtonAutoHide)->setVisible(true); bool ShowAutoHideButton = CDockManager::testAutoHideConfigFlag(CDockManager::DockAreaHasAutoHideButton);
TitleBar->button(TitleBarButtonAutoHide)->setVisible(ShowAutoHideButton);
TitleBar->button(TitleBarButtonUndock)->setVisible(true); TitleBar->button(TitleBarButtonUndock)->setVisible(true);
TitleBar->button(TitleBarButtonTabsMenu)->setVisible(true); TitleBar->button(TitleBarButtonTabsMenu)->setVisible(true);
} }
@@ -464,6 +476,13 @@ CAutoHideDockContainer* CDockAreaWidget::autoHideDockContainer() const
return d->AutoHideDockContainer; return d->AutoHideDockContainer;
} }
//============================================================================
CDockSplitter* CDockAreaWidget::parentSplitter() const
{
return internal::findParent<CDockSplitter*>(this);
}
//============================================================================ //============================================================================
bool CDockAreaWidget::isAutoHide() const bool CDockAreaWidget::isAutoHide() const
{ {
@@ -600,7 +619,7 @@ void CDockAreaWidget::hideAreaWithNoVisibleContent()
this->toggleView(false); this->toggleView(false);
// Hide empty parent splitters // Hide empty parent splitters
auto Splitter = internal::findParent<CDockSplitter*>(this); auto Splitter = parentSplitter();
internal::hideEmptyParentSplitters(Splitter); internal::hideEmptyParentSplitters(Splitter);
//Hide empty floating widget //Hide empty floating widget
@@ -749,7 +768,7 @@ int CDockAreaWidget::openDockWidgetsCount() const
int Count = 0; int Count = 0;
for (int i = 0; i < d->ContentsLayout->count(); ++i) for (int i = 0; i < d->ContentsLayout->count(); ++i)
{ {
if (!dockWidget(i)->isClosed()) if (dockWidget(i) && !dockWidget(i)->isClosed())
{ {
++Count; ++Count;
} }
@@ -765,7 +784,7 @@ QList<CDockWidget*> CDockAreaWidget::openedDockWidgets() const
for (int i = 0; i < d->ContentsLayout->count(); ++i) for (int i = 0; i < d->ContentsLayout->count(); ++i)
{ {
CDockWidget* DockWidget = dockWidget(i); CDockWidget* DockWidget = dockWidget(i);
if (!DockWidget->isClosed()) if (DockWidget && !DockWidget->isClosed())
{ {
DockWidgetList.append(dockWidget(i)); DockWidgetList.append(dockWidget(i));
} }
@@ -779,7 +798,7 @@ int CDockAreaWidget::indexOfFirstOpenDockWidget() const
{ {
for (int i = 0; i < d->ContentsLayout->count(); ++i) for (int i = 0; i < d->ContentsLayout->count(); ++i)
{ {
if (!dockWidget(i)->isClosed()) if (dockWidget(i) && !dockWidget(i)->isClosed())
{ {
return i; return i;
} }
@@ -802,7 +821,6 @@ CDockWidget* CDockAreaWidget::dockWidget(int Index) const
return qobject_cast<CDockWidget*>(d->ContentsLayout->widget(Index)); return qobject_cast<CDockWidget*>(d->ContentsLayout->widget(Index));
} }
//============================================================================ //============================================================================
void CDockAreaWidget::reorderDockWidget(int fromIndex, int toIndex) void CDockAreaWidget::reorderDockWidget(int fromIndex, int toIndex)
{ {

View File

@@ -47,6 +47,7 @@ class CDockContainerWidget;
class DockContainerWidgetPrivate; class DockContainerWidgetPrivate;
class CDockAreaTitleBar; class CDockAreaTitleBar;
class CDockingStateReader; class CDockingStateReader;
class CDockSplitter;
/** /**
@@ -216,6 +217,11 @@ public:
*/ */
CAutoHideDockContainer* autoHideDockContainer() const; CAutoHideDockContainer* autoHideDockContainer() const;
/**
* Returns the parent splitter that contains this dock area
*/
CDockSplitter* parentSplitter() const;
/** /**
* Returns true if the dock area is in an auto hide container * Returns true if the dock area is in an auto hide container
*/ */

View File

@@ -141,7 +141,7 @@ public:
CDockContainerWidget* _this; CDockContainerWidget* _this;
QPointer<CDockManager> DockManager; QPointer<CDockManager> DockManager;
unsigned int zOrderIndex = 0; unsigned int zOrderIndex = 0;
QList<CDockAreaWidget*> DockAreas; QList<QPointer<CDockAreaWidget>> DockAreas;
QList<CAutoHideDockContainer*> AutoHideWidgets; QList<CAutoHideDockContainer*> AutoHideWidgets;
QMap<SideBarLocation, CAutoHideSideBar*> SideTabBarWidgets; QMap<SideBarLocation, CAutoHideSideBar*> SideTabBarWidgets;
QGridLayout* Layout = nullptr; QGridLayout* Layout = nullptr;
@@ -299,7 +299,11 @@ public:
VisibleDockAreaCount = 0; VisibleDockAreaCount = 0;
for (auto DockArea : DockAreas) for (auto DockArea : DockAreas)
{ {
VisibleDockAreaCount += DockArea->isHidden() ? 0 : 1; if (!DockArea)
{
continue;
}
VisibleDockAreaCount += (DockArea->isHidden() ? 0 : 1);
} }
} }
@@ -587,16 +591,7 @@ void DockContainerWidgetPrivate::dropIntoSection(CFloatingDockContainer* Floatin
auto InsertParam = internal::dockAreaInsertParameters(area); auto InsertParam = internal::dockAreaInsertParameters(area);
auto NewDockAreas = FloatingContainer->findChildren<CDockAreaWidget*>( auto NewDockAreas = FloatingContainer->findChildren<CDockAreaWidget*>(
QString(), Qt::FindChildrenRecursively); QString(), Qt::FindChildrenRecursively);
QSplitter* TargetAreaSplitter = internal::findParent<QSplitter*>(TargetArea); auto TargetAreaSplitter = TargetArea->parentSplitter();
if (!TargetAreaSplitter)
{
QSplitter* Splitter = newSplitter(InsertParam.orientation());
Layout->replaceWidget(TargetArea, Splitter);
Splitter->addWidget(TargetArea);
updateSplitterHandles(Splitter);
TargetAreaSplitter = Splitter;
}
int AreaIndex = TargetAreaSplitter->indexOf(TargetArea); int AreaIndex = TargetAreaSplitter->indexOf(TargetArea);
auto FloatingSplitter = FloatingContainer->rootSplitter(); auto FloatingSplitter = FloatingContainer->rootSplitter();
if (TargetAreaSplitter->orientation() == InsertParam.orientation()) if (TargetAreaSplitter->orientation() == InsertParam.orientation())
@@ -742,7 +737,7 @@ void DockContainerWidgetPrivate::moveToNewSection(QWidget* Widget, CDockAreaWidg
} }
auto InsertParam = internal::dockAreaInsertParameters(area); auto InsertParam = internal::dockAreaInsertParameters(area);
QSplitter* TargetAreaSplitter = internal::findParent<QSplitter*>(TargetArea); auto TargetAreaSplitter = TargetArea->parentSplitter();
int AreaIndex = TargetAreaSplitter->indexOf(TargetArea); int AreaIndex = TargetAreaSplitter->indexOf(TargetArea);
auto Sizes = TargetAreaSplitter->sizes(); auto Sizes = TargetAreaSplitter->sizes();
if (TargetAreaSplitter->orientation() == InsertParam.orientation()) if (TargetAreaSplitter->orientation() == InsertParam.orientation())
@@ -877,7 +872,7 @@ void DockContainerWidgetPrivate::moveToContainer(QWidget* Widget, DockWidgetArea
// it already has and do nothing, if it is the same place. It would // it already has and do nothing, if it is the same place. It would
// also work without this check, but it looks nicer with the check // also work without this check, but it looks nicer with the check
// because there will be no layout updates // because there will be no layout updates
auto Splitter = internal::findParent<CDockSplitter*>(DroppedDockArea); auto Splitter = DroppedDockArea->parentSplitter();
auto InsertParam = internal::dockAreaInsertParameters(area); auto InsertParam = internal::dockAreaInsertParameters(area);
if (Splitter == RootSplitter && InsertParam.orientation() == Splitter->orientation()) if (Splitter == RootSplitter && InsertParam.orientation() == Splitter->orientation())
{ {
@@ -933,7 +928,10 @@ void DockContainerWidgetPrivate::addDockAreasToList(const QList<CDockAreaWidget*
//============================================================================ //============================================================================
void DockContainerWidgetPrivate::appendDockAreas(const QList<CDockAreaWidget*> NewDockAreas) void DockContainerWidgetPrivate::appendDockAreas(const QList<CDockAreaWidget*> NewDockAreas)
{ {
DockAreas.append(NewDockAreas); for (auto *newDockArea : NewDockAreas)
{
DockAreas.append(newDockArea);
}
for (auto DockArea : NewDockAreas) for (auto DockArea : NewDockAreas)
{ {
QObject::connect(DockArea, QObject::connect(DockArea,
@@ -1364,7 +1362,7 @@ CDockAreaWidget* DockContainerWidgetPrivate::addDockWidgetToDockArea(DockWidgetA
NewDockArea->addDockWidget(Dockwidget); NewDockArea->addDockWidget(Dockwidget);
auto InsertParam = internal::dockAreaInsertParameters(area); auto InsertParam = internal::dockAreaInsertParameters(area);
QSplitter* TargetAreaSplitter = internal::findParent<QSplitter*>(TargetDockArea); auto TargetAreaSplitter = TargetDockArea->parentSplitter();
int index = TargetAreaSplitter ->indexOf(TargetDockArea); int index = TargetAreaSplitter ->indexOf(TargetDockArea);
if (TargetAreaSplitter->orientation() == InsertParam.orientation()) if (TargetAreaSplitter->orientation() == InsertParam.orientation())
{ {
@@ -1381,7 +1379,7 @@ CDockAreaWidget* DockContainerWidgetPrivate::addDockWidgetToDockArea(DockWidgetA
{ {
ADS_PRINT("TargetAreaSplitter->orientation() != InsertParam.orientation()"); ADS_PRINT("TargetAreaSplitter->orientation() != InsertParam.orientation()");
auto TargetAreaSizes = TargetAreaSplitter->sizes(); auto TargetAreaSizes = TargetAreaSplitter->sizes();
QSplitter* NewSplitter = newSplitter(InsertParam.orientation()); auto NewSplitter = newSplitter(InsertParam.orientation());
NewSplitter->addWidget(TargetDockArea); NewSplitter->addWidget(TargetDockArea);
insertWidgetIntoSplitter(NewSplitter, NewDockArea, InsertParam.append()); insertWidgetIntoSplitter(NewSplitter, NewDockArea, InsertParam.append());
@@ -1572,7 +1570,7 @@ void CDockContainerWidget::removeDockArea(CDockAreaWidget* area)
area->disconnect(this); area->disconnect(this);
d->DockAreas.removeAll(area); d->DockAreas.removeAll(area);
CDockSplitter* Splitter = internal::findParent<CDockSplitter*>(area); auto Splitter = area->parentSplitter();
// Remove are from parent splitter and recursively hide tree of parent // Remove are from parent splitter and recursively hide tree of parent
// splitters if it has no visible content // splitters if it has no visible content
@@ -1645,12 +1643,21 @@ emitAndExit:
} }
//============================================================================
QList<QPointer<CDockAreaWidget>> CDockContainerWidget::removeAllDockAreas()
{
auto Result = d->DockAreas;
d->DockAreas.clear();
return Result;
}
//============================================================================ //============================================================================
CDockAreaWidget* CDockContainerWidget::dockAreaAt(const QPoint& GlobalPos) const CDockAreaWidget* CDockContainerWidget::dockAreaAt(const QPoint& GlobalPos) const
{ {
for (const auto& DockArea : d->DockAreas) for (const auto& DockArea : d->DockAreas)
{ {
if (DockArea->isVisible() && DockArea->rect().contains(DockArea->mapFromGlobal(GlobalPos))) if (DockArea && DockArea->isVisible() && DockArea->rect().contains(DockArea->mapFromGlobal(GlobalPos)))
{ {
return DockArea; return DockArea;
} }
@@ -1687,7 +1694,7 @@ int CDockContainerWidget::visibleDockAreaCount() const
int Result = 0; int Result = 0;
for (auto DockArea : d->DockAreas) for (auto DockArea : d->DockAreas)
{ {
Result += DockArea->isHidden() ? 0 : 1; Result += (!DockArea || DockArea->isHidden()) ? 0 : 1;
} }
return Result; return Result;
@@ -1758,7 +1765,7 @@ void CDockContainerWidget::dropFloatingWidget(CFloatingDockContainer* FloatingWi
if (Dropped) if (Dropped)
{ {
// Fix https://github.com/githubuser0xFFFF/Qt-Advanced-Docking-System/issues/351 // Fix https://github.com/githubuser0xFFFF/Qt-Advanced-Docking-System/issues/351
FloatingWidget->hideAndDeleteLater(); FloatingWidget->finishDropOperation();
// If we dropped a floating widget with only one single dock widget, then we // If we dropped a floating widget with only one single dock widget, then we
// drop a top level widget that changes from floating to docked now // drop a top level widget that changes from floating to docked now
@@ -1811,7 +1818,7 @@ QList<CDockAreaWidget*> CDockContainerWidget::openedDockAreas() const
QList<CDockAreaWidget*> Result; QList<CDockAreaWidget*> Result;
for (auto DockArea : d->DockAreas) for (auto DockArea : d->DockAreas)
{ {
if (!DockArea->isHidden()) if (DockArea && !DockArea->isHidden())
{ {
Result.append(DockArea); Result.append(DockArea);
} }
@@ -1827,7 +1834,7 @@ QList<CDockWidget*> CDockContainerWidget::openedDockWidgets() const
QList<CDockWidget*> DockWidgetList; QList<CDockWidget*> DockWidgetList;
for (auto DockArea : d->DockAreas) for (auto DockArea : d->DockAreas)
{ {
if (!DockArea->isHidden()) if (DockArea && !DockArea->isHidden())
{ {
DockWidgetList.append(DockArea->openedDockWidgets()); DockWidgetList.append(DockArea->openedDockWidgets());
} }
@@ -1842,7 +1849,7 @@ bool CDockContainerWidget::hasOpenDockAreas() const
{ {
for (auto DockArea : d->DockAreas) for (auto DockArea : d->DockAreas)
{ {
if (!DockArea->isHidden()) if (DockArea && !DockArea->isHidden())
{ {
return true; return true;
} }
@@ -1943,7 +1950,7 @@ bool CDockContainerWidget::restoreState(CDockingStateReader& s, bool Testing)
//============================================================================ //============================================================================
QSplitter* CDockContainerWidget::rootSplitter() const CDockSplitter* CDockContainerWidget::rootSplitter() const
{ {
return d->RootSplitter; return d->RootSplitter;
} }
@@ -2065,8 +2072,12 @@ CDockAreaWidget* CDockContainerWidget::topLevelDockArea() const
QList<CDockWidget*> CDockContainerWidget::dockWidgets() const QList<CDockWidget*> CDockContainerWidget::dockWidgets() const
{ {
QList<CDockWidget*> Result; QList<CDockWidget*> Result;
for (const auto DockArea : d->DockAreas) for (const auto& DockArea : d->DockAreas)
{ {
if (!DockArea)
{
continue;
}
Result.append(DockArea->dockWidgets()); Result.append(DockArea->dockWidgets());
} }
@@ -2097,8 +2108,12 @@ void CDockContainerWidget::removeAutoHideWidget(CAutoHideDockContainer* Autohide
CDockWidget::DockWidgetFeatures CDockContainerWidget::features() const CDockWidget::DockWidgetFeatures CDockContainerWidget::features() const
{ {
CDockWidget::DockWidgetFeatures Features(CDockWidget::AllDockWidgetFeatures); CDockWidget::DockWidgetFeatures Features(CDockWidget::AllDockWidgetFeatures);
for (const auto DockArea : d->DockAreas) for (const auto& DockArea : d->DockAreas)
{ {
if (!DockArea)
{
continue;
}
Features &= DockArea->features(); Features &= DockArea->features();
} }
@@ -2116,9 +2131,9 @@ CFloatingDockContainer* CDockContainerWidget::floatingWidget() const
//============================================================================ //============================================================================
void CDockContainerWidget::closeOtherAreas(CDockAreaWidget* KeepOpenArea) void CDockContainerWidget::closeOtherAreas(CDockAreaWidget* KeepOpenArea)
{ {
for (const auto DockArea : d->DockAreas) for (const auto& DockArea : d->DockAreas)
{ {
if (DockArea == KeepOpenArea) if (!DockArea || DockArea == KeepOpenArea)
{ {
continue; continue;
} }

View File

@@ -53,6 +53,7 @@ struct FloatingDragPreviewPrivate;
class CDockingStateReader; class CDockingStateReader;
class CAutoHideSideBar; class CAutoHideSideBar;
class CAutoHideTab; class CAutoHideTab;
class CDockSplitter;
struct AutoHideTabPrivate; struct AutoHideTabPrivate;
struct AutoHideDockContainerPrivate; struct AutoHideDockContainerPrivate;
@@ -94,7 +95,7 @@ protected:
/** /**
* Access function for the internal root splitter * Access function for the internal root splitter
*/ */
QSplitter* rootSplitter() const; CDockSplitter* rootSplitter() const;
/** /**
* Creates and initializes a dockwidget auto hide container into the given area. * Creates and initializes a dockwidget auto hide container into the given area.
@@ -138,6 +139,11 @@ protected:
*/ */
void removeDockArea(CDockAreaWidget* area); void removeDockArea(CDockAreaWidget* area);
/**
* Remove all dock areas and returns the list of removed dock areas
*/
QList<QPointer<CDockAreaWidget>> removeAllDockAreas();
/** /**
* Saves the state into the given stream * Saves the state into the given stream
*/ */

View File

@@ -115,6 +115,7 @@ DockFocusControllerPrivate::DockFocusControllerPrivate(
//============================================================================ //============================================================================
void DockFocusControllerPrivate::updateDockWidgetFocus(CDockWidget* DockWidget) void DockFocusControllerPrivate::updateDockWidgetFocus(CDockWidget* DockWidget)
{ {
if (!DockWidget) return;
if (!DockWidget->features().testFlag(CDockWidget::DockWidgetFocusable)) if (!DockWidget->features().testFlag(CDockWidget::DockWidgetFocusable))
{ {
return; return;

View File

@@ -103,8 +103,8 @@ static QString FloatingContainersTitle;
struct DockManagerPrivate struct DockManagerPrivate
{ {
CDockManager* _this; CDockManager* _this;
QList<CFloatingDockContainer*> FloatingWidgets; QList<QPointer<CFloatingDockContainer>> FloatingWidgets;
QList<CFloatingDockContainer*> HiddenFloatingWidgets; QList<QPointer<CFloatingDockContainer>> HiddenFloatingWidgets;
QList<CDockContainerWidget*> Containers; QList<CDockContainerWidget*> Containers;
CDockOverlay* ContainerOverlay; CDockOverlay* ContainerOverlay;
CDockOverlay* DockAreaOverlay; CDockOverlay* DockAreaOverlay;
@@ -122,6 +122,7 @@ struct DockManagerPrivate
Qt::ToolButtonStyle ToolBarStyleFloating = Qt::ToolButtonTextUnderIcon; Qt::ToolButtonStyle ToolBarStyleFloating = Qt::ToolButtonTextUnderIcon;
QSize ToolBarIconSizeDocked = QSize(16, 16); QSize ToolBarIconSizeDocked = QSize(16, 16);
QSize ToolBarIconSizeFloating = QSize(24, 24); QSize ToolBarIconSizeFloating = QSize(24, 24);
CDockWidget::DockWidgetFeatures LockedDockWidgetFeatures;
/** /**
* Private data constructor * Private data constructor
@@ -153,7 +154,10 @@ struct DockManagerPrivate
// Hide updates of floating widgets from user // Hide updates of floating widgets from user
for (auto FloatingWidget : FloatingWidgets) for (auto FloatingWidget : FloatingWidgets)
{ {
FloatingWidget->hide(); if (FloatingWidget)
{
FloatingWidget->hide();
}
} }
} }
@@ -333,7 +337,8 @@ bool DockManagerPrivate::restoreStateFromXml(const QByteArray &state, int versi
int FloatingWidgetIndex = DockContainerCount - 1; int FloatingWidgetIndex = DockContainerCount - 1;
for (int i = FloatingWidgetIndex; i < FloatingWidgets.count(); ++i) for (int i = FloatingWidgetIndex; i < FloatingWidgets.count(); ++i)
{ {
auto* floatingWidget = FloatingWidgets[i]; CFloatingDockContainer* floatingWidget = FloatingWidgets[i];
if (!floatingWidget) continue;
_this->removeDockContainer(floatingWidget->dockContainer()); _this->removeDockContainer(floatingWidget->dockContainer());
floatingWidget->deleteLater(); floatingWidget->deleteLater();
} }
@@ -536,25 +541,41 @@ CDockManager::CDockManager(QWidget *parent) :
CDockManager::~CDockManager() CDockManager::~CDockManager()
{ {
// fix memory leaks, see https://github.com/githubuser0xFFFF/Qt-Advanced-Docking-System/issues/307 // fix memory leaks, see https://github.com/githubuser0xFFFF/Qt-Advanced-Docking-System/issues/307
std::vector<ads::CDockAreaWidget*> areas; std::vector<QPointer<ads::CDockAreaWidget>> areas;
for ( int i = 0; i != dockAreaCount(); ++i ) for (int i = 0; i != dockAreaCount(); ++i)
{ {
areas.push_back( dockArea(i) ); areas.push_back( dockArea(i) );
} }
for ( auto area : areas ) for ( auto area : areas )
{ {
for ( auto widget : area->dockWidgets() ) if (!area || area->dockManager() != this) continue;
delete widget;
delete area; // QPointer delete safety - just in case some dock wigdet in destruction
} // deletes another related/twin or child dock widget.
std::vector<QPointer<QWidget>> deleteWidgets;
for ( auto widget : area->dockWidgets() )
{
deleteWidgets.push_back(widget);
}
for ( auto ptrWdg : deleteWidgets)
{
delete ptrWdg;
}
}
auto FloatingWidgets = d->FloatingWidgets; auto FloatingWidgets = d->FloatingWidgets;
for (auto FloatingWidget : FloatingWidgets) for (auto FloatingWidget : FloatingWidgets)
{ {
FloatingWidget->deleteContent();
delete FloatingWidget; delete FloatingWidget;
} }
// Delete Dock Widgets before Areas so widgets can access them late (like dtor)
for ( auto area : areas )
{
delete area;
}
delete d; delete d;
} }
@@ -568,7 +589,7 @@ bool CDockManager::eventFilter(QObject *obj, QEvent *e)
// Window always on top of the MainWindow. // Window always on top of the MainWindow.
if (e->type() == QEvent::WindowActivate) if (e->type() == QEvent::WindowActivate)
{ {
for (auto _window : floatingWidgets()) for (auto _window : d->FloatingWidgets)
{ {
if (!_window->isVisible() || window()->isMinimized()) if (!_window->isVisible() || window()->isMinimized())
{ {
@@ -590,7 +611,7 @@ bool CDockManager::eventFilter(QObject *obj, QEvent *e)
} }
else if (e->type() == QEvent::WindowDeactivate) else if (e->type() == QEvent::WindowDeactivate)
{ {
for (auto _window : floatingWidgets()) for (auto _window : d->FloatingWidgets)
{ {
if (!_window->isVisible() || window()->isMinimized()) if (!_window->isVisible() || window()->isMinimized())
{ {
@@ -613,7 +634,7 @@ bool CDockManager::eventFilter(QObject *obj, QEvent *e)
// Sync minimize with MainWindow // Sync minimize with MainWindow
if (e->type() == QEvent::WindowStateChange) if (e->type() == QEvent::WindowStateChange)
{ {
for (auto _window : floatingWidgets()) for (auto _window : d->FloatingWidgets)
{ {
if (! _window->isVisible()) if (! _window->isVisible())
{ {
@@ -725,7 +746,12 @@ const QList<CDockContainerWidget*> CDockManager::dockContainers() const
//============================================================================ //============================================================================
const QList<CFloatingDockContainer*> CDockManager::floatingWidgets() const const QList<CFloatingDockContainer*> CDockManager::floatingWidgets() const
{ {
return d->FloatingWidgets; QList<CFloatingDockContainer*> res;
for (auto &fl : d->FloatingWidgets)
{
if (fl) res.append(fl);
}
return res;
} }
@@ -1125,7 +1151,7 @@ QAction* CDockManager::addToggleViewActionToMenu(QAction* ToggleViewAction,
bool AlphabeticallySorted = (MenuAlphabeticallySorted == d->MenuInsertionOrder); bool AlphabeticallySorted = (MenuAlphabeticallySorted == d->MenuInsertionOrder);
if (!Group.isEmpty()) if (!Group.isEmpty())
{ {
QMenu* GroupMenu = d->ViewMenuGroups.value(Group, 0); QMenu* GroupMenu = d->ViewMenuGroups.value(Group, nullptr);
if (!GroupMenu) if (!GroupMenu)
{ {
GroupMenu = new QMenu(Group, this); GroupMenu = new QMenu(Group, this);
@@ -1318,7 +1344,7 @@ QList<int> CDockManager::splitterSizes(CDockAreaWidget *ContainedArea) const
{ {
if (ContainedArea) if (ContainedArea)
{ {
auto Splitter = internal::findParent<CDockSplitter*>(ContainedArea); auto Splitter = ContainedArea->parentSplitter();
if (Splitter) if (Splitter)
{ {
return Splitter->sizes(); return Splitter->sizes();
@@ -1335,7 +1361,7 @@ void CDockManager::setSplitterSizes(CDockAreaWidget *ContainedArea, const QList<
return; return;
} }
auto Splitter = internal::findParent<CDockSplitter*>(ContainedArea); auto Splitter = ContainedArea->parentSplitter();
if (Splitter && Splitter->count() == sizes.count()) if (Splitter && Splitter->count() == sizes.count())
{ {
Splitter->setSizes(sizes); Splitter->setSizes(sizes);
@@ -1422,6 +1448,33 @@ QSize CDockManager::dockWidgetToolBarIconSize(CDockWidget::eState State) const
} }
//===========================================================================
void CDockManager::lockDockWidgetFeaturesGlobally(CDockWidget::DockWidgetFeatures Value)
{
// Limit the features to CDockWidget::GloballyLockableFeatures
Value &= CDockWidget::GloballyLockableFeatures;
if (d->LockedDockWidgetFeatures == Value)
{
return;
}
d->LockedDockWidgetFeatures = Value;
// Call the notifyFeaturesChanged() function for all dock widgets to update
// the state of the close and detach buttons
for (auto DockWidget : d->DockWidgetsMap)
{
DockWidget->notifyFeaturesChanged();
}
}
//===========================================================================
CDockWidget::DockWidgetFeatures CDockManager::globallyLockedDockWidgetFeatures() const
{
return d->LockedDockWidgetFeatures;
}
} // namespace ads } // namespace ads
//--------------------------------------------------------------------------- //---------------------------------------------------------------------------

View File

@@ -214,6 +214,7 @@ public:
//! Users can overwrite this by setting the environment variable ADS_UseNativeTitle to "1" or "0". //! Users can overwrite this by setting the environment variable ADS_UseNativeTitle to "1" or "0".
MiddleMouseButtonClosesTab = 0x2000000, //! If the flag is set, the user can use the mouse middle button to close the tab under the mouse MiddleMouseButtonClosesTab = 0x2000000, //! If the flag is set, the user can use the mouse middle button to close the tab under the mouse
DisableTabTextEliding = 0x4000000, //! Set this flag to disable eliding of tab texts in dock area tabs DisableTabTextEliding = 0x4000000, //! Set this flag to disable eliding of tab texts in dock area tabs
ShowTabTextOnlyForActiveTab =0x8000000, //! Set this flag to show label texts in dock area tabs only for active tabs
DefaultDockAreaButtons = DockAreaHasCloseButton DefaultDockAreaButtons = DockAreaHasCloseButton
| DockAreaHasUndockButton | DockAreaHasUndockButton
@@ -256,8 +257,7 @@ public:
DefaultAutoHideConfig = AutoHideFeatureEnabled DefaultAutoHideConfig = AutoHideFeatureEnabled
| DockAreaHasAutoHideButton | DockAreaHasAutoHideButton
| AutoHideCloseButtonCollapsesDock | AutoHideHasMinimizeButton
| AutoHideHasCloseButton
}; };
Q_DECLARE_FLAGS(AutoHideFlags, eAutoHideFlag) Q_DECLARE_FLAGS(AutoHideFlags, eAutoHideFlag)
@@ -660,6 +660,38 @@ public:
*/ */
QSize dockWidgetToolBarIconSize(CDockWidget::eState State) const; QSize dockWidgetToolBarIconSize(CDockWidget::eState State) const;
/**
* Returns all dock widget features that are globally locked by the dock
* manager.
* Globally locked features are removed from the features of all dock
* widgets.
*/
CDockWidget::DockWidgetFeatures globallyLockedDockWidgetFeatures() const;
/**
* Globally Lock features of all dock widgets to "freeze" the current
* workspace layout.
* For example, it is now possible to lock the workspace to avoid
* accidentally dragging a docked view. Locking wasnt possible before.
* So, users had to manually dock it back to the desired place after
* each accidental undock.
* You can use a combination of the following feature flags:
* - CDockWidget::DockWidgetClosable
* - CDockWidget::DockWidgetMovable
* - CDockWidget::DockWidgetFloatable
* - CDockWidget::DockWidgetPinable
*
* To clear the locked features, you can use CDockWidget::NoDockWidgetFeatures
* The following code shows how to lock and unlock dock widget features
* globally.
*
* \code
* DockManager->lockDockWidgetFeaturesGlobally();
* DockManager->lockDockWidgetFeaturesGlobally(CDockWidget::NoDockWidgetFeatures);
* \code
*/
void lockDockWidgetFeaturesGlobally(CDockWidget::DockWidgetFeatures Features = CDockWidget::GloballyLockableFeatures);
public Q_SLOTS: public Q_SLOTS:
/** /**
* Opens the perspective with the given name. * Opens the perspective with the given name.

View File

@@ -80,8 +80,8 @@ struct DockWidgetPrivate
QWidget* Widget = nullptr; QWidget* Widget = nullptr;
CDockWidgetTab* TabWidget = nullptr; CDockWidgetTab* TabWidget = nullptr;
CDockWidget::DockWidgetFeatures Features = CDockWidget::DefaultDockWidgetFeatures; CDockWidget::DockWidgetFeatures Features = CDockWidget::DefaultDockWidgetFeatures;
CDockManager* DockManager = nullptr; QPointer<CDockManager> DockManager;
CDockAreaWidget* DockArea = nullptr; QPointer<CDockAreaWidget> DockArea;
QAction* ToggleViewAction = nullptr; QAction* ToggleViewAction = nullptr;
bool Closed = false; bool Closed = false;
QScrollArea* ScrollArea = nullptr; QScrollArea* ScrollArea = nullptr;
@@ -184,11 +184,11 @@ void DockWidgetPrivate::showDockWidget()
DockArea->setCurrentDockWidget(_this); DockArea->setCurrentDockWidget(_this);
DockArea->toggleView(true); DockArea->toggleView(true);
TabWidget->show(); TabWidget->show();
QSplitter* Splitter = internal::findParent<QSplitter*>(DockArea); auto Splitter = DockArea->parentSplitter();
while (Splitter && !Splitter->isVisible() && !DockArea->isAutoHide()) while (Splitter && !Splitter->isVisible() && !DockArea->isAutoHide())
{ {
Splitter->show(); Splitter->show();
Splitter = internal::findParent<QSplitter*>(Splitter); Splitter = internal::findParent<CDockSplitter*>(Splitter);
} }
CDockContainerWidget* Container = DockArea->dockContainer(); CDockContainerWidget* Container = DockArea->dockContainer();
@@ -271,7 +271,10 @@ void DockWidgetPrivate::closeAutoHideDockWidgetsIfNeeded()
return; return;
} }
if (!DockContainer->openedDockWidgets().isEmpty()) // If the dock container is the dock manager, or if it is not empty, then we
// don't need to do anything
if ((DockContainer == _this->dockManager())
|| !DockContainer->openedDockWidgets().isEmpty())
{ {
return; return;
} }
@@ -382,7 +385,7 @@ CDockWidget::CDockWidget(const QString &title, QWidget *parent) :
//============================================================================ //============================================================================
CDockWidget::~CDockWidget() CDockWidget::~CDockWidget()
{ {
ADS_PRINT("~CDockWidget()"); ADS_PRINT("~CDockWidget(): " << this->windowTitle());
delete d; delete d;
} }
@@ -511,10 +514,19 @@ void CDockWidget::setFeatures(DockWidgetFeatures features)
return; return;
} }
d->Features = features; d->Features = features;
notifyFeaturesChanged();
}
//============================================================================
void CDockWidget::notifyFeaturesChanged()
{
Q_EMIT featuresChanged(d->Features); Q_EMIT featuresChanged(d->Features);
d->TabWidget->onDockWidgetFeaturesChanged(); d->TabWidget->onDockWidgetFeaturesChanged();
if(CDockAreaWidget* DockArea = dockAreaWidget()) if(CDockAreaWidget* DockArea = dockAreaWidget())
{
DockArea->onDockWidgetFeaturesChanged(); DockArea->onDockWidgetFeaturesChanged();
}
} }
@@ -530,7 +542,14 @@ void CDockWidget::setFeature(DockWidgetFeature flag, bool on)
//============================================================================ //============================================================================
CDockWidget::DockWidgetFeatures CDockWidget::features() const CDockWidget::DockWidgetFeatures CDockWidget::features() const
{ {
return d->Features; if (d->DockManager)
{
return d->Features &~ d->DockManager->globallyLockedDockWidgetFeatures();
}
else
{
return d->Features;
}
} }
@@ -566,7 +585,7 @@ CDockContainerWidget* CDockWidget::dockContainer() const
} }
else else
{ {
return 0; return nullptr;
} }
} }
@@ -749,11 +768,10 @@ void CDockWidget::toggleViewInternal(bool Open)
if (d->DockArea) if (d->DockArea)
{ {
d->DockArea->toggleDockWidgetView(this, Open); d->DockArea->toggleDockWidgetView(this, Open);
} if (d->DockArea->isAutoHide())
{
if (d->DockArea->isAutoHide()) d->DockArea->autoHideDockContainer()->toggleView(Open);
{ }
d->DockArea->autoHideDockContainer()->toggleView(Open);
} }
if (Open && TopLevelDockWidgetBefore) if (Open && TopLevelDockWidgetBefore)

View File

@@ -165,6 +165,7 @@ public:
DefaultDockWidgetFeatures = DockWidgetClosable | DockWidgetMovable | DockWidgetFloatable | DockWidgetFocusable | DockWidgetPinnable, DefaultDockWidgetFeatures = DockWidgetClosable | DockWidgetMovable | DockWidgetFloatable | DockWidgetFocusable | DockWidgetPinnable,
AllDockWidgetFeatures = DefaultDockWidgetFeatures | DockWidgetDeleteOnClose | CustomCloseHandling, AllDockWidgetFeatures = DefaultDockWidgetFeatures | DockWidgetDeleteOnClose | CustomCloseHandling,
DockWidgetAlwaysCloseAndDelete = DockWidgetForceCloseWithArea | DockWidgetDeleteOnClose, DockWidgetAlwaysCloseAndDelete = DockWidgetForceCloseWithArea | DockWidgetDeleteOnClose,
GloballyLockableFeatures = DockWidgetClosable | DockWidgetMovable | DockWidgetFloatable | DockWidgetPinnable,
NoDockWidgetFeatures = 0x000 NoDockWidgetFeatures = 0x000
}; };
Q_DECLARE_FLAGS(DockWidgetFeatures, DockWidgetFeature) Q_DECLARE_FLAGS(DockWidgetFeatures, DockWidgetFeature)
@@ -256,7 +257,7 @@ public:
* by calling setObjectName() after construction. * by calling setObjectName() after construction.
* Use the layoutFlags to configure the layout of the dock widget. * Use the layoutFlags to configure the layout of the dock widget.
*/ */
CDockWidget(const QString &title, QWidget* parent = 0); CDockWidget(const QString &title, QWidget* parent = nullptr);
/** /**
* Virtual Destructor * Virtual Destructor
@@ -336,6 +337,11 @@ public:
*/ */
DockWidgetFeatures features() const; DockWidgetFeatures features() const;
/**
* Triggers notification of feature change signals and functions
*/
void notifyFeaturesChanged();
/** /**
* Returns the dock manager that manages the dock widget or 0 if the widget * Returns the dock manager that manages the dock widget or 0 if the widget
* has not been assigned to any dock manager yet * has not been assigned to any dock manager yet

View File

@@ -56,7 +56,6 @@
namespace ads namespace ads
{ {
static const char* const LocationProperty = "Location";
using tTabLabel = CElidingLabel; using tTabLabel = CElidingLabel;
/** /**
@@ -225,7 +224,7 @@ struct DockWidgetTabPrivate
QMenu* Menu) QMenu* Menu)
{ {
auto Action = Menu->addAction(Title); auto Action = Menu->addAction(Title);
Action->setProperty("Location", Location); Action->setProperty(internal::LocationProperty, Location);
QObject::connect(Action, &QAction::triggered, _this, &CDockWidgetTab::onAutoHideToActionClicked); QObject::connect(Action, &QAction::triggered, _this, &CDockWidgetTab::onAutoHideToActionClicked);
return Action; return Action;
} }
@@ -421,11 +420,12 @@ void CDockWidgetTab::mouseReleaseEvent(QMouseEvent* ev)
break; break;
default: default:
if (CDockManager::testConfigFlag(CDockManager::FocusHighlighting)) break;
{ }
d->focusController()->setDockWidgetTabPressed(false);
} if (CDockManager::testConfigFlag(CDockManager::FocusHighlighting))
break; // do nothing {
d->focusController()->setDockWidgetTabPressed(false);
} }
} }
else if (ev->button() == Qt::MiddleButton) else if (ev->button() == Qt::MiddleButton)
@@ -580,6 +580,14 @@ void CDockWidgetTab::setActiveTab(bool active)
{ {
d->updateCloseButtonVisibility(active); d->updateCloseButtonVisibility(active);
if(CDockManager::testConfigFlag(CDockManager::ShowTabTextOnlyForActiveTab) && !d->Icon.isNull())
{
if(active)
d->TitleLabel->setVisible(true);
else
d->TitleLabel->setVisible(false);
}
// Focus related stuff // Focus related stuff
if (CDockManager::testConfigFlag(CDockManager::FocusHighlighting) && !d->DockWidget->dockManager()->isRestoringState()) if (CDockManager::testConfigFlag(CDockManager::FocusHighlighting) && !d->DockWidget->dockManager()->isRestoringState())
{ {
@@ -755,7 +763,7 @@ void CDockWidgetTab::autoHideDockWidget()
//=========================================================================== //===========================================================================
void CDockWidgetTab::onAutoHideToActionClicked() void CDockWidgetTab::onAutoHideToActionClicked()
{ {
int Location = sender()->property(LocationProperty).toInt(); int Location = sender()->property(internal::LocationProperty).toInt();
d->DockWidget->toggleAutoHide((SideBarLocation)Location); d->DockWidget->toggleAutoHide((SideBarLocation)Location);
} }

View File

@@ -84,7 +84,7 @@ public:
* param[in] DockWidget The dock widget this title bar belongs to * param[in] DockWidget The dock widget this title bar belongs to
* param[in] parent The parent widget of this title bar * param[in] parent The parent widget of this title bar
*/ */
CDockWidgetTab(CDockWidget* DockWidget, QWidget* parent = 0); CDockWidgetTab(CDockWidget* DockWidget, QWidget* parent = nullptr);
/** /**
* Virtual Destructor * Virtual Destructor

View File

@@ -58,8 +58,8 @@ protected:
public: public:
using Super = QLabel; using Super = QLabel;
CElidingLabel(QWidget* parent = 0, Qt::WindowFlags f = Qt::WindowFlags ()); CElidingLabel(QWidget* parent = nullptr, Qt::WindowFlags f = Qt::WindowFlags ());
CElidingLabel(const QString& text, QWidget* parent = 0, Qt::WindowFlags f = Qt::WindowFlags ()); CElidingLabel(const QString& text, QWidget* parent = nullptr, Qt::WindowFlags f = Qt::WindowFlags ());
virtual ~CElidingLabel(); virtual ~CElidingLabel();
/** /**

View File

@@ -357,7 +357,7 @@ static const char* windowsMessageString(int MessageId)
#endif #endif
static unsigned int zOrderCounter = 0; static unsigned int zOrderCounterFloating = 0;
/** /**
* Private data class of CFloatingDockContainer class (pimpl) * Private data class of CFloatingDockContainer class (pimpl)
*/ */
@@ -365,7 +365,7 @@ struct FloatingDockContainerPrivate
{ {
CFloatingDockContainer *_this; CFloatingDockContainer *_this;
CDockContainerWidget *DockContainer; CDockContainerWidget *DockContainer;
unsigned int zOrderIndex = ++zOrderCounter; unsigned int zOrderIndex = ++zOrderCounterFloating;
QPointer<CDockManager> DockManager; QPointer<CDockManager> DockManager;
eDragState DraggingState = DraggingInactive; eDragState DraggingState = DraggingInactive;
QPoint DragStartMousePosition; QPoint DragStartMousePosition;
@@ -760,6 +760,7 @@ CFloatingDockContainer::CFloatingDockContainer(CDockWidget *DockWidget) :
d->DockManager->notifyWidgetOrAreaRelocation(DockWidget); d->DockManager->notifyWidgetOrAreaRelocation(DockWidget);
} }
//============================================================================ //============================================================================
CFloatingDockContainer::~CFloatingDockContainer() CFloatingDockContainer::~CFloatingDockContainer()
{ {
@@ -771,6 +772,36 @@ CFloatingDockContainer::~CFloatingDockContainer()
delete d; delete d;
} }
//============================================================================
void CFloatingDockContainer::deleteContent()
{
std::vector<QPointer<ads::CDockAreaWidget>> areas;
for (int i = 0; i != dockContainer()->dockAreaCount(); ++i)
{
areas.push_back( dockContainer()->dockArea(i) );
}
for (auto area : areas)
{
if (!area)
{
continue;
}
// QPointer delete safety - just in case some dock widget in destruction
// deletes another related/twin or child dock widget.
std::vector<QPointer<QWidget>> deleteWidgets;
for (auto widget : area->dockWidgets())
{
deleteWidgets.push_back(widget);
}
for (auto ptrWdg : deleteWidgets)
{
delete ptrWdg;
}
}
}
//============================================================================ //============================================================================
CDockContainerWidget* CFloatingDockContainer::dockContainer() const CDockContainerWidget* CFloatingDockContainer::dockContainer() const
{ {
@@ -787,7 +818,7 @@ void CFloatingDockContainer::changeEvent(QEvent *event)
if (isActiveWindow()) if (isActiveWindow())
{ {
ADS_PRINT("FloatingWidget::changeEvent QEvent::ActivationChange "); ADS_PRINT("FloatingWidget::changeEvent QEvent::ActivationChange ");
d->zOrderIndex = ++zOrderCounter; d->zOrderIndex = ++zOrderCounterFloating;
#if defined(Q_OS_UNIX) && !defined(Q_OS_MACOS) #if defined(Q_OS_UNIX) && !defined(Q_OS_MACOS)
if (d->DraggingState == DraggingFloatingWidget) if (d->DraggingState == DraggingFloatingWidget)
@@ -1142,7 +1173,7 @@ QList<CDockWidget*> CFloatingDockContainer::dockWidgets() const
} }
//============================================================================ //============================================================================
void CFloatingDockContainer::hideAndDeleteLater() void CFloatingDockContainer::finishDropOperation()
{ {
// Widget has been redocked, so it must be hidden right way (see // Widget has been redocked, so it must be hidden right way (see
// https://github.com/githubuser0xFFFF/Qt-Advanced-Docking-System/issues/351) // https://github.com/githubuser0xFFFF/Qt-Advanced-Docking-System/issues/351)
@@ -1150,6 +1181,11 @@ void CFloatingDockContainer::hideAndDeleteLater()
// dock widgets that shall not be toggled hidden. // dock widgets that shall not be toggled hidden.
d->AutoHideChildren = false; d->AutoHideChildren = false;
hide(); hide();
// The floating widget will be deleted now. Ensure, that the destructor
// of the floating widget does not delete any dock areas that have been
// moved to a new container - simply remove all dock areas before deleting
// the floating widget
d->DockContainer->removeAllDockAreas();
deleteLater(); deleteLater();
if (d->DockManager) if (d->DockManager)
{ {

View File

@@ -146,6 +146,13 @@ protected:
*/ */
virtual void finishDragging() override; virtual void finishDragging() override;
/**
* This function deletes all dock widgets in it.
* This functions should be called only from dock manager in its
* destructor before deleting the floating widget
*/
void deleteContent();
/** /**
* Call this function if you just want to initialize the position * Call this function if you just want to initialize the position
* and size of the floating widget * and size of the floating widget
@@ -258,9 +265,9 @@ public:
QList<CDockWidget*> dockWidgets() const; QList<CDockWidget*> dockWidgets() const;
/** /**
* This function hides the floating bar instantely and delete it later. * This function hides the floating widget instantly and delete it later.
*/ */
void hideAndDeleteLater(); void finishDropOperation();
#if defined(Q_OS_UNIX) && !defined(Q_OS_MACOS) #if defined(Q_OS_UNIX) && !defined(Q_OS_MACOS)
/** /**

View File

@@ -92,7 +92,7 @@ xcb_atom_t xcb_get_atom(const char *name)
} }
xcb_connection_t *connection = x11_connection(); xcb_connection_t *connection = x11_connection();
xcb_intern_atom_cookie_t request = xcb_intern_atom(connection, 1, strlen(name), name); xcb_intern_atom_cookie_t request = xcb_intern_atom(connection, 1, strlen(name), name);
xcb_intern_atom_reply_t *reply = xcb_intern_atom_reply(connection, request, NULL); xcb_intern_atom_reply_t *reply = xcb_intern_atom_reply(connection, request, nullptr);
if (!reply) if (!reply)
{ {
return XCB_ATOM_NONE; return XCB_ATOM_NONE;

View File

@@ -167,6 +167,7 @@ static const bool RestoreTesting = true;
static const bool Restore = false; static const bool Restore = false;
static const char* const ClosedProperty = "close"; static const char* const ClosedProperty = "close";
static const char* const DirtyProperty = "dirty"; static const char* const DirtyProperty = "dirty";
static const char* const LocationProperty = "Location";
extern const int FloatingWidgetDragStartEvent; extern const int FloatingWidgetDragStartEvent;
extern const int DockedWidgetDragStartEvent; extern const int DockedWidgetDragStartEvent;
@@ -268,7 +269,7 @@ T findParent(const QWidget* w)
} }
parentWidget = parentWidget->parentWidget(); parentWidget = parentWidget->parentWidget();
} }
return 0; return nullptr;
} }
/** /**

View File

@@ -137,11 +137,11 @@ CFloatingWidgetTitleBar::CFloatingWidgetTitleBar(CFloatingDockContainer *parent)
d->FloatingWidget = parent; d->FloatingWidget = parent;
d->createLayout(); d->createLayout();
auto normalPixmap = this->style()->standardPixmap(QStyle::SP_TitleBarNormalButton, 0, d->MaximizeButton); auto normalPixmap = this->style()->standardPixmap(QStyle::SP_TitleBarNormalButton, nullptr, d->MaximizeButton);
d->NormalIcon.addPixmap(normalPixmap, QIcon::Normal); d->NormalIcon.addPixmap(normalPixmap, QIcon::Normal);
d->NormalIcon.addPixmap(internal::createTransparentPixmap(normalPixmap, 0.25), QIcon::Disabled); d->NormalIcon.addPixmap(internal::createTransparentPixmap(normalPixmap, 0.25), QIcon::Disabled);
auto maxPixmap = this->style()->standardPixmap(QStyle::SP_TitleBarMaxButton, 0, d->MaximizeButton); auto maxPixmap = this->style()->standardPixmap(QStyle::SP_TitleBarMaxButton, nullptr, d->MaximizeButton);
d->MaximizeIcon.addPixmap(maxPixmap, QIcon::Normal); d->MaximizeIcon.addPixmap(maxPixmap, QIcon::Normal);
d->MaximizeIcon.addPixmap(internal::createTransparentPixmap(maxPixmap, 0.25), QIcon::Disabled); d->MaximizeIcon.addPixmap(internal::createTransparentPixmap(maxPixmap, 0.25), QIcon::Disabled);
setMaximizedIcon(d->Maximized); setMaximizedIcon(d->Maximized);

View File

@@ -333,7 +333,7 @@ ads--CAutoHideDockContainer ads--CDockAreaWidget[focused="true"] ads--CDockAreaT
ads--CAutoHideDockContainer #dockAreaAutoHideButton { ads--CAutoHideDockContainer #dockAreaAutoHideButton {
qproperty-icon: url(:/ads/images/vs-pin-button-pinned-focused.svg), qproperty-icon: url(:/ads/images/vs-pin-button-pinned-focused.svg);
qproperty-iconSize: 16px; qproperty-iconSize: 16px;
} }