diff --git a/code/AssetLib/M3D/M3DWrapper.h b/code/AssetLib/M3D/M3DWrapper.h index 7cc2d0eef..c75ff1027 100644 --- a/code/AssetLib/M3D/M3DWrapper.h +++ b/code/AssetLib/M3D/M3DWrapper.h @@ -57,9 +57,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. // Assimp specific M3D configuration. Comment out these defines to remove functionality //#define ASSIMP_USE_M3D_READFILECB -// Share stb_image's PNG loader with other importers/exporters instead of bringing our own copy. -#define STBI_ONLY_PNG -#include +#include "Common/StbCommon.h" #include "m3d.h" diff --git a/code/CMakeLists.txt b/code/CMakeLists.txt index 53394543a..12dc3b0d4 100644 --- a/code/CMakeLists.txt +++ b/code/CMakeLists.txt @@ -167,6 +167,7 @@ SET( Logging_SRCS SOURCE_GROUP(Logging FILES ${Logging_SRCS}) SET( Common_SRCS + Common/StbCommon.h Common/Compression.cpp Common/Compression.h Common/BaseImporter.cpp diff --git a/code/Common/Assimp.cpp b/code/Common/Assimp.cpp index 71e312cee..ee798238e 100644 --- a/code/Common/Assimp.cpp +++ b/code/Common/Assimp.cpp @@ -5,8 +5,6 @@ Open Asset Import Library (assimp) Copyright (c) 2006-2022, assimp team - - All rights reserved. Redistribution and use of this software in source and binary forms, @@ -1282,18 +1280,13 @@ ASSIMP_API void aiQuaternionInterpolate( # define STBI_ONLY_PNG #endif +// Ensure all symbols are linked correctly #if ASSIMP_NEEDS_STB_IMAGE - -# if _MSC_VER // "unreferenced function has been removed" (SSE2 detection routine in x64 builds) -# pragma warning(push) -# pragma warning(disable: 4505) + // Share stb_image's PNG loader with other importers/exporters instead of bringing our own copy. +# define STBI_ONLY_PNG +# ifdef ASSIMP_USE_STB_IMAGE_STATIC +# define STB_IMAGE_STATIC # endif - # define STB_IMAGE_IMPLEMENTATION -# include "stb/stb_image.h" - -# if _MSC_VER -# pragma warning(pop) -# endif - +# include "Common/StbCommon.h" #endif diff --git a/code/Common/StbCommon.h b/code/Common/StbCommon.h new file mode 100644 index 000000000..1265d25da --- /dev/null +++ b/code/Common/StbCommon.h @@ -0,0 +1,58 @@ +/* +Open Asset Import Library (assimp) +---------------------------------------------------------------------- + +Copyright (c) 2006-2022, assimp team + +All rights reserved. + +Redistribution and use of this software in source and binary forms, +with or without modification, are permitted provided that the +following conditions are met: + +* Redistributions of source code must retain the above +copyright notice, this list of conditions and the +following disclaimer. + +* Redistributions in binary form must reproduce the above +copyright notice, this list of conditions and the +following disclaimer in the documentation and/or other +materials provided with the distribution. + +* Neither the name of the assimp team, nor the names of its +contributors may be used to endorse or promote products +derived from this software without specific prior +written permission of the assimp team. + +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +---------------------------------------------------------------------- +*/ +#pragma once + +#if _MSC_VER // "unreferenced function has been removed" (SSE2 detection routine in x64 builds) +#pragma warning(push) +#pragma warning(disable : 4505) +#else +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Wunused-function" +#endif + +#include "stb/stb_image.h" + +#if _MSC_VER +#pragma warning(pop) +#else +#pragma GCC diagnostic pop +#endif + diff --git a/code/Pbrt/PbrtExporter.cpp b/code/Pbrt/PbrtExporter.cpp index 9590c4954..6a26d3261 100644 --- a/code/Pbrt/PbrtExporter.cpp +++ b/code/Pbrt/PbrtExporter.cpp @@ -83,7 +83,7 @@ Other: #include #include -#include "stb/stb_image.h" +#include "Common/StbCommon.h" using namespace Assimp; diff --git a/test/unit/Main.cpp b/test/unit/Main.cpp index d5049faad..573c26a96 100644 --- a/test/unit/Main.cpp +++ b/test/unit/Main.cpp @@ -1,6 +1,5 @@ #include "../../include/assimp/DefaultLogger.hpp" #include "UnitTestPCH.h" - #include #include