Fixed bug in DefaultLogger::set: (#5826)

assigning s_pNullLogger to the parameter "logger" is definitely wrong.
However, custom logger previously set from user must not be deleted.
The user itself must handle allocation / deallocation.
This commit is contained in:
chefrolle695
2024-10-17 21:14:14 +02:00
committed by GitHub
parent 2591d0e490
commit 4b9ac76815
2 changed files with 8 additions and 7 deletions
+3 -5
View File
@@ -221,13 +221,11 @@ void DefaultLogger::set(Logger *logger) {
#endif
if (nullptr == logger) {
logger = &s_pNullLogger;
m_pLogger = &s_pNullLogger;
}
if (nullptr != m_pLogger && !isNullLogger()) {
delete m_pLogger;
else {
m_pLogger = logger;
}
DefaultLogger::m_pLogger = logger;
}
// ----------------------------------------------------------------------------------