diff --git a/code/AssetLib/Collada/ColladaExporter.cpp b/code/AssetLib/Collada/ColladaExporter.cpp index e15e81985..480d6790b 100644 --- a/code/AssetLib/Collada/ColladaExporter.cpp +++ b/code/AssetLib/Collada/ColladaExporter.cpp @@ -1227,8 +1227,8 @@ void ColladaExporter::WriteFloatArray(const std::string &pIdString, FloatDataTyp // ------------------------------------------------------------------------------------------------ // Writes the scene library void ColladaExporter::WriteSceneLibrary() { - const std::string sceneName = GetNodeUniqueId(mScene->mRootNode); - const std::string sceneId = GetNodeName(mScene->mRootNode); + const std::string sceneId = GetNodeUniqueId(mScene->mRootNode); + const std::string sceneName = GetNodeName(mScene->mRootNode); mOutput << startstr << "" << endstr; PushTag(); diff --git a/code/AssetLib/X3D/X3DImporter_Postprocess.cpp b/code/AssetLib/X3D/X3DImporter_Postprocess.cpp index a8bc1a00c..993aff02c 100644 --- a/code/AssetLib/X3D/X3DImporter_Postprocess.cpp +++ b/code/AssetLib/X3D/X3DImporter_Postprocess.cpp @@ -787,8 +787,10 @@ void X3DImporter::Postprocess_CollectMetadata(const CX3DImporter_NodeElement& pN // Add an element according to its type. if((*it)->Type == CX3DImporter_NodeElement::ENET_MetaBoolean) { - if(((CX3DImporter_NodeElement_MetaBoolean*)cur_meta)->Value.size() > 0) - pSceneNode.mMetaData->Set(static_cast(meta_idx), cur_meta->Name, *(((CX3DImporter_NodeElement_MetaBoolean*)cur_meta)->Value.begin())); + if(((CX3DImporter_NodeElement_MetaBoolean*)cur_meta)->Value.size() > 0) { + const bool v = (bool) *( ( (CX3DImporter_NodeElement_MetaBoolean*) cur_meta )->Value.begin()); + pSceneNode.mMetaData->Set(static_cast(meta_idx), cur_meta->Name, v); + } } else if((*it)->Type == CX3DImporter_NodeElement::ENET_MetaDouble) { diff --git a/include/assimp/metadata.h b/include/assimp/metadata.h index cd7569ffe..684508a71 100644 --- a/include/assimp/metadata.h +++ b/include/assimp/metadata.h @@ -86,6 +86,14 @@ typedef enum aiMetadataType { struct aiMetadataEntry { aiMetadataType mType; void *mData; + +#ifdef __cplusplus + aiMetadataEntry() : + mType(AI_META_MAX), + mData( nullptr ) { + // empty + } +#endif }; #ifdef __cplusplus @@ -313,8 +321,13 @@ struct aiMetadata { // Set metadata type mValues[index].mType = GetAiType(value); + // Copy the given value to the dynamic storage - mValues[index].mData = new T(value); + if (nullptr != mValues[index].mData) { + ::memcpy(mValues[index].mData, &value, sizeof(T)); + } else { + mValues[index].mData = new T(value); + } return true; }