Scarfski/assimp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid undefined-shift in Assimp::ASE::Parser::ParseLV4MeshFace.

Browse Source
This commit is contained in:
Kim Kulling
2022-12-05 13:07:52 +01:00
parent 28c155bfb4
commit 81f85a6f93
2 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
code/AssetLib/ASE/ASEParser.cpp
View File

@@ -1774,7 +1774,13 @@ void Parser::ParseLV4MeshFace(ASE::Face &out) {
// FIX: There needn't always be a value, sad but true
while (true) {
if (*filePtr < '9' && *filePtr >= '0') {
out.iSmoothGroup |= (1 << strtoul10(filePtr, &filePtr));
uint32_t value = strtoul10(filePtr, &filePtr);
if (value < 32) {
out.iSmoothGroup |= (1 << strtoul10(filePtr, &filePtr));
} else {
const std::string message = std::string("Unable to set smooth group, value with ") + ai_to_string(value) + std::string(" out of range");
LogWarning(message.c_str());
}
}
SkipSpaces(&filePtr);
if (',' != *filePtr) {