From 6a8e11dbb2da81e3f2562442b51b608b03a6b482 Mon Sep 17 00:00:00 2001 From: Kim Kulling Date: Tue, 13 Nov 2018 13:10:16 +0100 Subject: [PATCH 1/2] Update Exporter.cpp Fix review finding. --- code/Exporter.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/code/Exporter.cpp b/code/Exporter.cpp index 63a934091..0acde75bf 100644 --- a/code/Exporter.cpp +++ b/code/Exporter.cpp @@ -212,6 +212,7 @@ public: for( unsigned int a = 0; a < mPostProcessingSteps.size(); a++) { delete mPostProcessingSteps[a]; } + delete mProgressHandler; } public: @@ -246,10 +247,6 @@ Exporter :: Exporter() // ------------------------------------------------------------------------------------------------ Exporter::~Exporter() { FreeBlob(); - if (pimpl->mIsDefaultProgressHandler) { - delete pimpl->mProgressHandler; - pimpl->mProgressHandler = nullptr; - } delete pimpl; } From e1404d349c1588c6b52d2b9da2fc50ce8a8dc98f Mon Sep 17 00:00:00 2001 From: Kim Kulling Date: Tue, 13 Nov 2018 14:44:34 +0100 Subject: [PATCH 2/2] Update utExporter.cpp Remove misuse of the API. --- test/unit/ImportExport/utExporter.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/test/unit/ImportExport/utExporter.cpp b/test/unit/ImportExport/utExporter.cpp index 1efe9e132..9ce4bfdd7 100644 --- a/test/unit/ImportExport/utExporter.cpp +++ b/test/unit/ImportExport/utExporter.cpp @@ -70,5 +70,4 @@ TEST_F(ExporterTest, ProgressHandlerTest) { Exporter exporter; TestProgressHandler *ph(new TestProgressHandler); exporter.SetProgressHandler(ph); - delete ph; }