From 87cac888e474880efdacba4cddd28f83c582fd97 Mon Sep 17 00:00:00 2001 From: Marco Feuerstein Date: Tue, 4 Jul 2023 13:18:22 +0200 Subject: [PATCH] More simplifications. --- code/Common/BaseImporter.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/code/Common/BaseImporter.cpp b/code/Common/BaseImporter.cpp index d03b2adfc..39c93e4be 100644 --- a/code/Common/BaseImporter.cpp +++ b/code/Common/BaseImporter.cpp @@ -244,12 +244,12 @@ void BaseImporter::GetExtensionList(std::set &extensions) { // GetExtension() returns the part after the *last* dot, but some extensions // have dots inside them, e.g. ogre.mesh.xml. Compare the entire end of the // string. - for (auto it = extensions.cbegin(); it != extensions.cend(); ++it) { + for (const std::string& ext : extensions) { // Yay for C++<20 not having std::string::ends_with() - const std::string extension = "." + *it; - if (extension.length() > pFile.length()) continue; + const std::string dotExt = "." + ext; + if (dotExt.length() > pFile.length()) continue; // Possible optimization: Fetch the lowercase filename! - if (0 == ASSIMP_stricmp(pFile.c_str() + pFile.length() - extension.length(), extension.c_str())) { + if (0 == ASSIMP_stricmp(pFile.c_str() + pFile.length() - dotExt.length(), dotExt.c_str())) { return true; } }