diff --git a/CMakeLists.txt b/CMakeLists.txt
index 8aaaf36de..99f799c74 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -185,9 +185,9 @@ if (ASSIMP_COVERALLS)
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -g -O0 -fprofile-arcs -ftest-coverage")
endif()
-INCLUDE (FindPkgConfig)
INCLUDE_DIRECTORIES( include )
+INCLUDE (FindPkgMacros)
INCLUDE (PrecompiledHeader)
# If this is an in-source build (CMAKE_SOURCE_DIR == CMAKE_BINARY_DIR),
@@ -255,9 +255,7 @@ ENDIF(NOT ZLIB_FOUND)
INCLUDE_DIRECTORIES(${ZLIB_INCLUDE_DIR})
# Search for unzip
-IF (PKG_CONFIG_FOUND)
- PKG_CHECK_MODULES(UNZIP minizip)
-ENDIF (PKG_CONFIG_FOUND)
+use_pkgconfig(UNZIP minizip)
IF ( ASSIMP_NO_EXPORT )
ADD_DEFINITIONS( -DASSIMP_BUILD_NO_EXPORT)
diff --git a/CREDITS b/CREDITS
index 744173cc7..219079168 100644
--- a/CREDITS
+++ b/CREDITS
@@ -81,7 +81,7 @@ Many bugreports, improving Assimp's portability, regular testing & feedback.
Bugreport and fix for a obj-materialloader crash.
- David Nadlinger
-D bindings, CMake install support.
+D bindings, CMake install support.
- Dario Accornero
Contributed several patches regarding Mac OS/XCode targets, bug reports.
@@ -92,7 +92,7 @@ Contributed the 'SimpleTexturedOpenGl' sample.
- Matthias Fauconneau
Contributed a fix for the Q3-BSP loader.
-- J�rgen P. Tjern�
+- Jørgen P. Tjernø
Contributed updated and improved xcode workspaces
- drparallax
@@ -113,7 +113,7 @@ Contributes a fix for the configure script environment.
- Ed Diana
Contributed AssimpDelphi (/port/AssimpDelphi).
-- rdb
+- rdb
Contributes a bundle of fixes and improvements for the bsp-importer.
- Mick P
@@ -137,7 +137,7 @@ GCC/Linux fixes for the SimpleOpenGL sample.
- Brian Miller
Bugfix for a compiler fix for iOS on arm.
-- S�verin Lemaignan
+- Séverin Lemaignan
Rewrite of PyAssimp, distutils and Python3 support
- albert-wang
diff --git a/Readme.md b/Readme.md
index af8225bda..5d4214d89 100644
--- a/Readme.md
+++ b/Readme.md
@@ -18,6 +18,11 @@ This is the development trunk containing the latest features and bugfixes. For p
The current build status is:
Gitter chat: [](https://gitter.im/assimp/assimp?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
+
+And we also have an IRC-channel at freenode: #assetimporterlib . You can easily join us via: [KiwiIRC/freenote](https://kiwiirc.com/client/irc.freenode.net), choose your nickname and type
+> /join #assetimporterlib
+
+
__[open3mod](https://github.com/acgessler/open3mod) is a powerful 3D model viewer based on Assimp's import and export abilities.__
Please check our Wiki as well: https://github.com/assimp/assimp/wiki
diff --git a/cmake-modules/FindPkgMacros.cmake b/cmake-modules/FindPkgMacros.cmake
index e67d8dc62..074cce352 100644
--- a/cmake-modules/FindPkgMacros.cmake
+++ b/cmake-modules/FindPkgMacros.cmake
@@ -59,10 +59,13 @@ endmacro(clear_if_changed)
# Try to get some hints from pkg-config, if available
macro(use_pkgconfig PREFIX PKGNAME)
- find_package(PkgConfig)
- if (PKG_CONFIG_FOUND)
- pkg_check_modules(${PREFIX} ${PKGNAME})
- endif ()
+ # Android does not support PKG_CONFIG so we disable it
+ IF ( NOT ANDROID )
+ find_package(PkgConfig)
+ if (PKG_CONFIG_FOUND)
+ pkg_check_modules(${PREFIX} ${PKGNAME})
+ endif ()
+ ENDIF ( NOT ANDROID )
endmacro (use_pkgconfig)
# Couple a set of release AND debug libraries (or frameworks)
diff --git a/cmake-modules/FindZLIB.cmake b/cmake-modules/FindZLIB.cmake
index f6806b4ee..95eb51547 100644
--- a/cmake-modules/FindZLIB.cmake
+++ b/cmake-modules/FindZLIB.cmake
@@ -11,7 +11,7 @@
# Once done, this will define
#
# ZLIB_FOUND - system has ZLIB
-# ZLIB_INCLUDE_DIRS - the ZLIB include directories
+# ZLIB_INCLUDE_DIRS - the ZLIB include directories
# ZLIB_LIBRARIES - link these to use ZLIB
include(FindPkgMacros)
diff --git a/code/ASEParser.cpp b/code/ASEParser.cpp
index 9fa4ee617..b06447cfa 100644
--- a/code/ASEParser.cpp
+++ b/code/ASEParser.cpp
@@ -1857,7 +1857,7 @@ void Parser::ParseLV3MeshCFaceListBlock(unsigned int iNumFaces, ASE::Mesh& mesh)
++filePtr;
// Face entry
- if (TokenMatch(filePtr,"MESH_CFACE" ,11))
+ if (TokenMatch(filePtr,"MESH_CFACE" ,10))
{
unsigned int aiValues[3];
unsigned int iIndex = 0;
diff --git a/code/BlenderLoader.cpp b/code/BlenderLoader.cpp
index 438828388..ea443b14b 100644
--- a/code/BlenderLoader.cpp
+++ b/code/BlenderLoader.cpp
@@ -166,6 +166,7 @@ void BlenderImporter::InternReadFile( const std::string& pFile,
free_it free_it_really(dest);
#endif
+
FileDatabase file;
std::shared_ptr stream(pIOHandler->Open(pFile,"rb"));
if (!stream) {
diff --git a/code/CMakeLists.txt b/code/CMakeLists.txt
index 92199c234..6d3cfb0fe 100644
--- a/code/CMakeLists.txt
+++ b/code/CMakeLists.txt
@@ -187,10 +187,16 @@ IF ( ASSIMP_BUILD_NONFREE_C4D_IMPORTER )
SOURCE_GROUP( C4D FILES ${C4D_SRCS})
ENDIF ( ASSIMP_BUILD_NONFREE_C4D_IMPORTER )
+# if this variable is set to TRUE, the user can manually disable importers by setting
+# ASSIMP_BUILD_XXX_IMPORTER to FALSE for each importer
+# if this variable is set to FALSE, the user can manually enable importers by setting
+# ASSIMP_BUILD_XXX_IMPORTER to TRUE for each importer
+OPTION(ASSIMP_BUILD_ALL_IMPORTERS_BY_DEFAULT "default value of all ASSIMP_BUILD_XXX_IMPORTER value" TRUE)
+
# macro to add the CMake Option ADD_ASSIMP_IMPORTER_ which enables compile of loader
# this way selective loaders can be compiled (reduces filesize + compile time)
MACRO(ADD_ASSIMP_IMPORTER name)
- OPTION(ASSIMP_BUILD_${name}_IMPORTER "build the ${name} importer" TRUE)
+ OPTION(ASSIMP_BUILD_${name}_IMPORTER "build the ${name} importer" ${ASSIMP_BUILD_ALL_IMPORTERS_BY_DEFAULT})
IF(ASSIMP_BUILD_${name}_IMPORTER)
LIST(APPEND ASSIMP_LOADER_SRCS ${ARGN})
SET(ASSIMP_IMPORTERS_ENABLED "${ASSIMP_IMPORTERS_ENABLED} ${name}")
diff --git a/code/D3MFImporter.cpp b/code/D3MFImporter.cpp
index 9e4a84642..9b4f6d2f9 100644
--- a/code/D3MFImporter.cpp
+++ b/code/D3MFImporter.cpp
@@ -49,7 +49,6 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#include "StringComparison.h"
#include "StringUtils.h"
-
#include
#include
#include