From 8e9c0235d38f3819304f8ff2126f3ff75332bb3f Mon Sep 17 00:00:00 2001 From: wise86Android Date: Sun, 25 Sep 2016 15:21:30 +0200 Subject: [PATCH] 153083/2 Buffer not null terminated --- code/MDLLoader.cpp | 2 +- code/SMDLoader.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/code/MDLLoader.cpp b/code/MDLLoader.cpp index 3e0e91f6c..f82e7abfe 100644 --- a/code/MDLLoader.cpp +++ b/code/MDLLoader.cpp @@ -1557,7 +1557,7 @@ void MDLImporter::InternReadFile_3DGS_MDL7( ) } else { pcNode->mName.length = ::strlen(szBuffer); } - ::strncpy(pcNode->mName.data,szBuffer,MAXLEN); + ::strncpy(pcNode->mName.data,szBuffer,MAXLEN-1); ++p; } } diff --git a/code/SMDLoader.cpp b/code/SMDLoader.cpp index a868d9cb0..b06fa8c96 100644 --- a/code/SMDLoader.cpp +++ b/code/SMDLoader.cpp @@ -641,7 +641,7 @@ void SMDImporter::ComputeAbsoluteBoneTransformations() bone.mOffsetMatrix.Inverse(); } } - +\ // ------------------------------------------------------------------------------------------------ // create output materials void SMDImporter::CreateOutputMaterials() @@ -660,7 +660,7 @@ void SMDImporter::CreateOutputMaterials() if (aszTextures[iMat].length()) { - ::strncpy(szName.data, aszTextures[iMat].c_str(),MAXLEN ); + ::strncpy(szName.data, aszTextures[iMat].c_str(),MAXLEN-1); szName.length = aszTextures[iMat].length(); pcMat->AddProperty(&szName,AI_MATKEY_TEXTURE_DIFFUSE(0)); }