Scarfski/assimp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Zero-length mChildren arrays should be nullptr (#5749)

Browse Source 
- Children: Don't allocate a zero-length array
- aiNode::mChildren should be left nullptr instead.
This commit is contained in:
RichardTea
2024-09-03 09:26:27 +01:00
committed by GitHub
parent c35200e38e
commit c1ffbfec06
5 changed files with 27 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
code/AssetLib/COB/COBLoader.cpp
View File

@@ -372,9 +372,11 @@ aiNode *COBImporter::BuildNodes(const Node &root, const Scene &scin, aiScene *fi
}
// add children recursively
nd->mChildren = new aiNode *[root.temp_children.size()]();
for (const Node *n : root.temp_children) {
(nd->mChildren[nd->mNumChildren++] = BuildNodes(*n, scin, fill))->mParent = nd;
if (!root.temp_children.empty()) {
nd->mChildren = new aiNode *[root.temp_children.size()]();
for (const Node *n : root.temp_children) {
(nd->mChildren[nd->mNumChildren++] = BuildNodes(*n, scin, fill))->mParent = nd;
}
}
return nd;