style fix - initializing and assigning empty std::string properly

std::string s(""); s = ""; calls the copy constructor, which in turn calls strlen(), … assigning a default-constructed string generates fewer instructions and is therefore preferred.

With C++11 uniform initialization, you’d simply write s = { } instead.
This commit is contained in:
Krishty
2021-04-16 23:43:56 +02:00
parent cd42b9954b
commit f761dc72f4
34 changed files with 48 additions and 48 deletions
+1 -1
View File
@@ -91,7 +91,7 @@ namespace pmx
std::vector<char> buffer;
if (size == 0)
{
return std::string("");
return std::string();
}
buffer.reserve(size);
stream->read((char*) buffer.data(), size);