From f8bb7704ad439e1f070d489d5fd0b2e81785f111 Mon Sep 17 00:00:00 2001 From: Kim Kulling Date: Fri, 2 Dec 2022 09:43:59 +0100 Subject: [PATCH] Fix: MAke quaternion check in unittest more robust Just add an epsilon test by using the correct comparator from gtest. --- test/unit/AssimpAPITest_aiQuaternion.cpp | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/test/unit/AssimpAPITest_aiQuaternion.cpp b/test/unit/AssimpAPITest_aiQuaternion.cpp index 8f57bc586..7e93033cf 100644 --- a/test/unit/AssimpAPITest_aiQuaternion.cpp +++ b/test/unit/AssimpAPITest_aiQuaternion.cpp @@ -120,7 +120,11 @@ TEST_F(AssimpAPITest_aiQuaternion, aiQuaternionMultiplyTest) { result_c = result_cpp = random_quat(); result_cpp = result_cpp * temp; aiQuaternionMultiply(&result_c, &temp); - EXPECT_EQ(result_cpp, result_c); + + EXPECT_FLOAT_EQ(result_cpp.x, result_c.x); + EXPECT_FLOAT_EQ(result_cpp.y, result_c.y); + EXPECT_FLOAT_EQ(result_cpp.z, result_c.z); + EXPECT_FLOAT_EQ(result_cpp.w, result_c.w); } TEST_F(AssimpAPITest_aiQuaternion, aiQuaternionInterpolateTest) { @@ -131,5 +135,9 @@ TEST_F(AssimpAPITest_aiQuaternion, aiQuaternionInterpolateTest) { const auto q2 = aiQuaternion(aiVector3D(1,2,1).Normalize(), Math::aiPi() / 2.0f); aiQuaternion::Interpolate(result_cpp, q1, q2, INTERPOLATION); aiQuaternionInterpolate(&result_c, &q1, &q2, INTERPOLATION); - EXPECT_EQ(result_cpp, result_c); + + EXPECT_FLOAT_EQ(result_cpp.x, result_c.x); + EXPECT_FLOAT_EQ(result_cpp.y, result_c.y); + EXPECT_FLOAT_EQ(result_cpp.z, result_c.z); + EXPECT_FLOAT_EQ(result_cpp.w, result_c.w); }