From 1706f948a2f0992d7a6dc2a909f35690b508571c Mon Sep 17 00:00:00 2001 From: Richard Geldreich Date: Fri, 16 Oct 2026 03:31:44 -0400 Subject: [PATCH] Adding HDR source parm nullptr check Fixing typo that could lead to a null pointer deref --- encoder/basisu_comp.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/encoder/basisu_comp.cpp b/encoder/basisu_comp.cpp index 37ecd49..0ca3e77 100644 --- a/encoder/basisu_comp.cpp +++ b/encoder/basisu_comp.cpp @@ -5607,7 +5607,7 @@ namespace basisu } else { - if (!pSource_images_hdr->size()) + if ((!pSource_images_hdr) || (!pSource_images_hdr->size())) { error_printf("basis_compress: No source HDR images\n"); assert(0); @@ -5687,7 +5687,7 @@ namespace basisu comp_params.m_source_mipmap_images_hdr.resize(1); comp_params.m_source_mipmap_images_hdr[0].resize(pSource_images_hdr->size() - 1); - for (uint32_t i = 1; i < pSource_images->size(); i++) + for (uint32_t i = 1; i < pSource_images_hdr->size(); i++) comp_params.m_source_mipmap_images_hdr[0][i - 1] = (*pSource_images_hdr)[i]; } }