Scarfski/basis_universal
1
0
Fork 0
mirror of https://github.com/BinomialLLC/basis_universal.git synced 2026-11-02 22:25:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixing a very rare 1-bit overflow in ETC1S SSE optimized colorspace error calculations (which are 32-bit vs. the plain C++ code's 64-bit). Ultimately the output would still be correct and transcodable, but this could cause a compressor assertion check to fail. Found during compressor fuzz testing.

Browse Source
This commit is contained in:
Richard Geldreich
2025-11-18 17:27:51 -05:00
parent 6e54503437
commit 5a1ae5d65d
4 changed files with 280 additions and 95 deletions
Download Patch File Download Diff File Expand all files Collapse all files
encoder/basisu_etc.cpp
+4 -1
View File
@@ -811,7 +811,8 @@ namespace basisu
#if defined(DEBUG) || defined(_DEBUG)
{
// sanity check the returned error
// Ultimate sanity check on the returned error.
// If this check fails, it likely means the SSE code diverged from C++ somehow, or there was an overflow somewhere.
color_rgba block_colors[4];
m_best_solution.m_coords.get_block_colors(block_colors);
@@ -1234,6 +1235,8 @@ namespace basisu
perceptual_distance_rgb_4_N_sse41((int64_t*)&total_error, pSelectors_to_use, block_colors, pSrc_pixels, n, trial_solution.m_error);
else
linear_distance_rgb_4_N_sse41((int64_t*)&total_error, pSelectors_to_use, block_colors, pSrc_pixels, n, trial_solution.m_error);
for (uint32_t i = 0; i < n; i++)
m_temp_selectors[i] = pSelectors_to_use[i];
}
else
{