Scarfski/bgfx
1
0
Fork 0
mirror of https://github.com/bkaradzic/bgfx.git synced 2026-06-08 03:13:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Metal: Honor BGFX_RESET_DEPTH_CLAMP via setDepthClipMode:. (#3696)

Browse Source 
The flag was already in `maskFlags` but never wired to any rasterizer
state, so it was a no-op on Metal. Set MTLDepthClipModeClamp on each
render command encoder when requested. Capability-gated: macOS always,
Apple-GPU platforms gated by GPUFamilyApple4+.
This commit is contained in:
Kyle Emmerich
2026-05-01 23:35:39 -04:00
committed by GitHub
parent 5761ae09e4
commit 7abefde6bd
1 changed files with 30 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
src/renderer_mtl.cpp
View File

@@ -785,6 +785,8 @@ static_assert(BX_COUNTOF(s_accessNames) == Access::Count, "Invalid s_accessNames
, m_capture(NULL) , m_capture(NULL)
, m_captureSize(0) , m_captureSize(0)
, m_variableRateShadingSupported(false) , m_variableRateShadingSupported(false)
, m_supportsDepthClipMode(false)
, m_depthClamp(false)
, m_screenshotTarget(NULL) , m_screenshotTarget(NULL)
, m_screenshotBlitRenderPipelineState(NULL) , m_screenshotBlitRenderPipelineState(NULL)
, m_commandBuffer(NULL) , m_commandBuffer(NULL)
@@ -892,6 +894,9 @@ static_assert(BX_COUNTOF(s_accessNames) == Access::Count, "Invalid s_accessNames
m_variableRateShadingSupported = false; //m_device.supportsVariableRasterizationRate(); m_variableRateShadingSupported = false; //m_device.supportsVariableRasterizationRate();
m_supportsDepthClipMode = BX_ENABLED(BX_PLATFORM_OSX)
|| m_device->supportsFamily(MTL::GPUFamilyApple4);
g_caps.numGPUs = 1; g_caps.numGPUs = 1;
g_caps.gpu[0].vendorId = g_caps.vendorId; g_caps.gpu[0].vendorId = g_caps.vendorId;
g_caps.gpu[0].deviceId = g_caps.deviceId; g_caps.gpu[0].deviceId = g_caps.deviceId;
@@ -1619,6 +1624,11 @@ static_assert(BX_COUNTOF(s_accessNames) == Access::Count, "Invalid s_accessNames
m_renderCommandEncoderFrameBufferHandle = fbh; m_renderCommandEncoderFrameBufferHandle = fbh;
MTL_RELEASE(renderPassDescriptor, 0); MTL_RELEASE(renderPassDescriptor, 0);
if (m_depthClamp)
{
rce->setDepthClipMode(MTL::DepthClipModeClamp);
}
{ {
MTL::Viewport viewport = { 0.0f, 0.0f, (float)width, (float)height, 0.0f, 1.0f }; MTL::Viewport viewport = { 0.0f, 0.0f, (float)width, (float)height, 0.0f, 1.0f };
rce->setViewport(viewport); rce->setViewport(viewport);
@@ -1743,6 +1753,9 @@ static_assert(BX_COUNTOF(s_accessNames) == Access::Count, "Invalid s_accessNames
; ;
} }
m_depthClamp = m_supportsDepthClipMode
&& !!(_resolution.reset & BGFX_RESET_DEPTH_CLAMP);
const uint32_t maskFlags = ~(0 const uint32_t maskFlags = ~(0
| BGFX_RESET_MAXANISOTROPY | BGFX_RESET_MAXANISOTROPY
| BGFX_RESET_DEPTH_CLAMP | BGFX_RESET_DEPTH_CLAMP
@@ -1884,6 +1897,11 @@ static_assert(BX_COUNTOF(s_accessNames) == Access::Count, "Invalid s_accessNames
m_renderCommandEncoder = m_commandBuffer->renderCommandEncoder(renderPassDescriptor); m_renderCommandEncoder = m_commandBuffer->renderCommandEncoder(renderPassDescriptor);
MTL_RELEASE(renderPassDescriptor, 0); MTL_RELEASE(renderPassDescriptor, 0);
if (m_depthClamp)
{
m_renderCommandEncoder->setDepthClipMode(MTL::DepthClipModeClamp);
}
} }
} }
@@ -3008,6 +3026,8 @@ static_assert(BX_COUNTOF(s_accessNames) == Access::Count, "Invalid s_accessNames
uint32_t m_captureSize; uint32_t m_captureSize;
bool m_variableRateShadingSupported; bool m_variableRateShadingSupported;
bool m_supportsDepthClipMode;
bool m_depthClamp;
MTL::RenderPipelineDescriptor* m_renderPipelineDescriptor; MTL::RenderPipelineDescriptor* m_renderPipelineDescriptor;
MTL::DepthStencilDescriptor* m_depthStencilDescriptor; MTL::DepthStencilDescriptor* m_depthStencilDescriptor;
@@ -4847,6 +4867,11 @@ static_assert(BX_COUNTOF(s_accessNames) == Access::Count, "Invalid s_accessNames
m_renderCommandEncoderFrameBufferHandle = fbh; m_renderCommandEncoderFrameBufferHandle = fbh;
MTL_RELEASE(renderPassDescriptor, 0); MTL_RELEASE(renderPassDescriptor, 0);
if (m_depthClamp)
{
rce->setDepthClipMode(MTL::DepthClipModeClamp);
}
} }
else if (BX_ENABLED(BGFX_CONFIG_DEBUG_ANNOTATION) ) else if (BX_ENABLED(BGFX_CONFIG_DEBUG_ANNOTATION) )
{ {
@@ -5736,6 +5761,11 @@ static_assert(BX_COUNTOF(s_accessNames) == Access::Count, "Invalid s_accessNames
MTL_RELEASE(renderPassDescriptor, 0); MTL_RELEASE(renderPassDescriptor, 0);
if (m_depthClamp)
{
rce->setDepthClipMode(MTL::DepthClipModeClamp);
}
rce->setCullMode( (MTL::CullMode)MTL::CullModeNone); rce->setCullMode( (MTL::CullMode)MTL::CullModeNone);
rce->setRenderPipelineState(m_screenshotBlitRenderPipelineState); rce->setRenderPipelineState(m_screenshotBlitRenderPipelineState);