Scarfski/bgfx
1
0
Fork 0
mirror of https://github.com/bkaradzic/bgfx.git synced 2026-10-25 18:25:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix MSAA + mipmaps combination on D3D11/D3D12/Vulkan/Metal. (#3717)

Browse Source
This commit is contained in:
Branimir Karadžić
2026-05-21 22:53:17 +00:00
committed by GitHub
parent 526b886105
commit 7d03e160fa
4 changed files with 36 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/renderer_vk.cpp
+16 -10
View File
@@ -6504,6 +6504,18 @@ retry:
;
ici.tiling = VK_IMAGE_TILING_OPTIMAL;
const bool needResolve = true
&& 1 < m_sampler.Count
&& 0 != (ici.usage & VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT)
&& 0 == (m_flags & BGFX_TEXTURE_MSAA_SAMPLE)
&& 0 == (m_flags & BGFX_TEXTURE_RT_WRITE_ONLY)
;
ici.mipLevels = needResolve
? 1
: ici.mipLevels
;
if (0 != _external)
{
static_assert(sizeof(m_textureImage) == sizeof(_external), "Size must match!");
@@ -6545,19 +6557,13 @@ retry:
: VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL
;
const bool needResolve = true
&& 1 < m_sampler.Count
&& 0 != (ici.usage & VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT)
&& 0 == (m_flags & BGFX_TEXTURE_MSAA_SAMPLE)
&& 0 == (m_flags & BGFX_TEXTURE_RT_WRITE_ONLY)
;
if (needResolve)
{
VkImageCreateInfo ici_resolve = ici;
ici_resolve.samples = s_msaa[0].Sample;
ici_resolve.usage &= ~VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT;
ici_resolve.flags &= ~VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT;
ici_resolve.samples = s_msaa[0].Sample;
ici_resolve.mipLevels = m_numMips;
ici_resolve.usage &= ~VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT;
ici_resolve.flags &= ~VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT;
result = vkCreateImage(device, &ici_resolve, allocatorCb, &m_singleMsaaImage);
if (VK_SUCCESS != result)