new stream adapter, and lots of refactorings

2026-08-10 23:39:33 +00:00 · 2017-10-06 13:50:04 +03:00
parent 5ede853954
commit f3c9a33849
46 changed files with 967 additions and 701 deletions
--- a/tests/data_reading_errors.cpp
+++ b/tests/data_reading_errors.cpp
@@ -0,0 +1,121 @@
+//MIT License
+//
+//Copyright (c) 2017 Mindaugas Vinkelis
+//
+//Permission is hereby granted, free of charge, to any person obtaining a copy
+//of this software and associated documentation files (the "Software"), to deal
+//in the Software without restriction, including without limitation the rights
+//to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+//copies of the Software, and to permit persons to whom the Software is
+//furnished to do so, subject to the following conditions:
+//
+//The above copyright notice and this permission notice shall be included in all
+//copies or substantial portions of the Software.
+//
+//THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+//IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+//FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+//AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+//LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+//OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+//SOFTWARE.
+
+#include <gmock/gmock.h>
+#include "serialization_test_utils.h"
+#include <bitsery/traits/string.h>
+
+using testing::Eq;
+using SessionsEnabledWriter = bitsery::AdapterWriter<OutputAdapter, SessionsEnabledConfig>;
+using SessionsEnabledReader = bitsery::AdapterReader<InputAdapter, SessionsEnabledConfig>;
+
+TEST(DataReadingErrors, WhenContainerOrTextSizeIsMoreThanMaxThenInvalidDataError) {
+    SerializationContext ctx;
+    std::string tmp = "larger text then allowed";
+    ctx.createSerializer().text1b(tmp,100);
+    ctx.createDeserializer().text1b(tmp, 10);
+    EXPECT_THAT(ctx.br->error(), Eq(bitsery::ReaderError::InvalidData));
+}
+
+TEST(DataReadingErrors, WhenReadingBoolByteReadsMoreThanOneThenInvalidBufferDataErrorAndResultIsFalse) {
+    SerializationContext ctx;
+    auto& ser = ctx.createSerializer();
+    ser.value1b(uint8_t{1});
+    ser.value1b(uint8_t{2});
+    bool res{};
+    auto& des = ctx.createDeserializer();
+    des.boolValue(res);
+    EXPECT_THAT(res, Eq(true));
+    des.boolValue(res);
+    EXPECT_THAT(res, Eq(false));
+    EXPECT_THAT(ctx.br->error(), Eq(bitsery::ReaderError::InvalidData));
+}
+
+TEST(DataReadingErrors, WhenReadingAlignHasNonZerosThenInvalidDataError) {
+    Buffer buf{};
+    Writer bw{buf};
+    uint8_t tmp{0xFF};
+    bw.writeBytes<1>(tmp);
+    bw.flush();
+
+    Reader br{InputAdapter{buf.begin(), bw.writtenBytesCount()}};
+    bitsery::AdapterReaderBitPackingWrapper<Reader> bpr{br};
+
+    bpr.readBits(tmp,3);
+    bpr.align();
+    EXPECT_THAT(bpr.error(), Eq(bitsery::ReaderError::InvalidData));
+}
+
+TEST(DataReadingErrors, WhenReadingNewSessionInMiddleOfOldDataThenInvalidDataError) {
+    uint8_t tmp{0xFF};
+    Buffer buf{};
+    SessionsEnabledWriter bw{buf};
+    for (auto i = 0; i < 2; ++i) {
+        bw.beginSession();
+        bw.writeBytes<1>(tmp);
+        bw.writeBytes<1>(tmp);
+        bw.endSession();
+    }
+    bw.flush();
+    SessionsEnabledReader br{InputAdapter{buf.begin(), bw.writtenBytesCount()}};
+    for (auto i = 0; i < 2; ++i) {
+        br.beginSession();
+        br.readBytes<1>(tmp);
+        br.beginSession();
+        br.readBytes<1>(tmp);
+        br.endSession();
+        br.endSession();
+    }
+    EXPECT_THAT(br.error(), Eq(bitsery::ReaderError::InvalidData));
+}
+
+
+TEST(DataReadingErrors, WhenInitializingSessionsWhenNotEnoughDataThenInvalidData) {
+    uint8_t tmp1{0xFF};
+    Buffer buf1{};
+    SessionsEnabledWriter bw1{buf1};
+    bw1.writeBytes<1>(tmp1);
+    bw1.flush();
+    SessionsEnabledReader br1{InputAdapter{buf1.begin(), bw1.writtenBytesCount()}};
+    br1.beginSession();
+    EXPECT_THAT(br1.error(), Eq(bitsery::ReaderError::InvalidData));
+
+    Buffer buf2{};
+    SessionsEnabledWriter bw2{buf2};
+    uint16_t tmp2{0x8000};
+    bw2.writeBytes<2>(tmp2);
+    bw2.flush();
+    SessionsEnabledReader br2{InputAdapter{buf2.begin(), bw2.writtenBytesCount()}};
+    br2.beginSession();
+    EXPECT_THAT(br2.error(), Eq(bitsery::ReaderError::InvalidData));
+}
+
+TEST(DataReadingErrors, WhenInitializingSessionsWhereSessionsDataOffsetIsCorruptedThenInvalidData) {
+    Buffer buf{};
+    SessionsEnabledWriter bw{buf};
+    bw.writeBytes<1>(uint8_t{1});
+    bw.writeBytes<1>(uint8_t{1});
+    bw.writeBytes<2>(uint16_t{10});
+    SessionsEnabledReader br{InputAdapter{buf.begin(), bw.writtenBytesCount()}};
+    br.beginSession();
+    EXPECT_THAT(br.error(), Eq(bitsery::ReaderError::InvalidData));
+}