fix(ai): address security and robustness issues from code review

Security fixes:
- Add escapeUserInput() to prevent Prompt injection via user input
- Validate msgId belongs to dialogId in updateMessageStatus()
- Add type parameter whitelist validation in ai-apply/ai-dismiss
- Add event record validation in task__ai_dismiss

Robustness fixes:
- Use atomic update for markProcessing to prevent concurrent processing
- Add subtask count limit check before creation (max 50)
- Disable similar task feature until vector search is implemented
- Fix Promise anti-pattern in frontend actions

Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)

Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
This commit is contained in:
kuaifan
2026-01-21 02:37:29 +00:00
parent d4d7a0d69f
commit 75073d4320
4 changed files with 75 additions and 31 deletions

View File

@@ -3851,6 +3851,11 @@ class ProjectController extends AbstractController
$type = trim(Request::input('type'));
$data = Request::input('data', []);
// 验证建议类型
if (!in_array($type, ProjectTaskAiEvent::getEventTypes())) {
return Base::retError('无效的建议类型');
}
// 验证任务
$task = ProjectTask::userTask($taskId);
if (!$task) {
@@ -3884,6 +3889,13 @@ class ProjectController extends AbstractController
case ProjectTaskAiEvent::EVENT_SUBTASKS:
// 创建子任务
$subtasks = $result['content'] ?? [];
// 检查子任务数量限制
$existingCount = ProjectTask::where('parent_id', $task->id)
->whereNull('deleted_at')
->count();
if ($existingCount + count($subtasks) > 50) {
return Base::retError('子任务数量超过限制最多50个');
}
\DB::transaction(function () use ($task, $subtasks) {
foreach ($subtasks as $name) {
ProjectTask::addTask([
@@ -3963,12 +3975,27 @@ class ProjectController extends AbstractController
$msgId = intval(Request::input('msg_id'));
$type = trim(Request::input('type'));
// 验证建议类型
if (!in_array($type, ProjectTaskAiEvent::getEventTypes())) {
return Base::retError('无效的建议类型');
}
// 验证任务
$task = ProjectTask::userTask($taskId);
if (!$task) {
return Base::retError('任务不存在或无权限');
}
// 验证事件记录存在
$event = ProjectTaskAiEvent::where('task_id', $taskId)
->where('event_type', $type)
->where('msg_id', $msgId)
->first();
if (!$event || $event->status !== ProjectTaskAiEvent::STATUS_COMPLETED) {
return Base::retError('建议不存在或已处理');
}
// 更新消息状态
if ($msgId > 0 && $task->dialog_id) {
AiTaskSuggestion::updateMessageStatus($msgId, $task->dialog_id, $type, 'dismissed');