From 0f6e1d8aefce730d12cfa13e109005c863282d2c Mon Sep 17 00:00:00 2001 From: Michele Caini Date: Wed, 10 Jan 2024 17:44:34 +0100 Subject: [PATCH] test: drop a bunch of NOLINT --- test/entt/core/any.cpp | 196 ++++++++++++++++++++--------------------- 1 file changed, 98 insertions(+), 98 deletions(-) diff --git a/test/entt/core/any.cpp b/test/entt/core/any.cpp index a29bdad20..e3d50a26c 100644 --- a/test/entt/core/any.cpp +++ b/test/entt/core/any.cpp @@ -93,14 +93,14 @@ TEST_F(Any, Empty) { } TEST_F(Any, SBOInPlaceTypeConstruction) { - entt::any any{std::in_place_type, 42}; // NOLINT + entt::any any{std::in_place_type, 2}; ASSERT_TRUE(any); ASSERT_TRUE(any.owner()); // NOLINT ASSERT_EQ(any.policy(), entt::any_policy::owner); ASSERT_EQ(any.type(), entt::type_id()); ASSERT_EQ(entt::any_cast(&any), nullptr); - ASSERT_EQ(entt::any_cast(any), 42); + ASSERT_EQ(entt::any_cast(any), 2); auto other = any.as_ref(); @@ -108,12 +108,12 @@ TEST_F(Any, SBOInPlaceTypeConstruction) { ASSERT_FALSE(other.owner()); // NOLINT ASSERT_EQ(other.policy(), entt::any_policy::ref); ASSERT_EQ(other.type(), entt::type_id()); - ASSERT_EQ(entt::any_cast(other), 42); + ASSERT_EQ(entt::any_cast(other), 2); ASSERT_EQ(other.data(), any.data()); } TEST_F(Any, SBOAsRefConstruction) { - int value = 42; // NOLINT + int value = 2; entt::any any{entt::forward_as_any(value)}; ASSERT_TRUE(any); @@ -127,8 +127,8 @@ TEST_F(Any, SBOAsRefConstruction) { ASSERT_EQ(entt::any_cast(&std::as_const(any)), &value); ASSERT_EQ(entt::any_cast(&std::as_const(any)), &value); - ASSERT_EQ(entt::any_cast(any), 42); - ASSERT_EQ(entt::any_cast(any), 42); + ASSERT_EQ(entt::any_cast(any), 2); + ASSERT_EQ(entt::any_cast(any), 2); ASSERT_EQ(any.data(), &value); ASSERT_EQ(std::as_const(any).data(), &value); @@ -147,12 +147,12 @@ TEST_F(Any, SBOAsRefConstruction) { ASSERT_FALSE(other.owner()); // NOLINT ASSERT_EQ(other.policy(), entt::any_policy::ref); ASSERT_EQ(other.type(), entt::type_id()); - ASSERT_EQ(entt::any_cast(other), 42); + ASSERT_EQ(entt::any_cast(other), 2); ASSERT_EQ(other.data(), any.data()); } TEST_F(Any, SBOAsConstRefConstruction) { - const int value = 42; + const int value = 2; entt::any any{entt::forward_as_any(value)}; ASSERT_TRUE(any); @@ -166,8 +166,8 @@ TEST_F(Any, SBOAsConstRefConstruction) { ASSERT_EQ(entt::any_cast(&std::as_const(any)), &value); ASSERT_EQ(entt::any_cast(&std::as_const(any)), &value); - ASSERT_EQ(entt::any_cast(any), 42); - ASSERT_EQ(entt::any_cast(any), 42); + ASSERT_EQ(entt::any_cast(any), 2); + ASSERT_EQ(entt::any_cast(any), 2); ASSERT_EQ(any.data(), nullptr); ASSERT_EQ(std::as_const(any).data(), &value); @@ -186,12 +186,12 @@ TEST_F(Any, SBOAsConstRefConstruction) { ASSERT_FALSE(other.owner()); // NOLINT ASSERT_EQ(other.policy(), entt::any_policy::cref); ASSERT_EQ(other.type(), entt::type_id()); - ASSERT_EQ(entt::any_cast(other), 42); + ASSERT_EQ(entt::any_cast(other), 2); ASSERT_EQ(other.data(), any.data()); } TEST_F(Any, SBOCopyConstruction) { - const entt::any any{42}; + const entt::any any{2}; entt::any other{any}; ASSERT_TRUE(any); @@ -201,11 +201,11 @@ TEST_F(Any, SBOCopyConstruction) { ASSERT_EQ(any.type(), entt::type_id()); ASSERT_EQ(other.type(), entt::type_id()); ASSERT_EQ(entt::any_cast(&other), nullptr); - ASSERT_EQ(entt::any_cast(other), 42); + ASSERT_EQ(entt::any_cast(other), 2); } TEST_F(Any, SBOCopyAssignment) { - const entt::any any{42}; + const entt::any any{2}; entt::any other{3}; other = any; @@ -217,11 +217,11 @@ TEST_F(Any, SBOCopyAssignment) { ASSERT_EQ(any.type(), entt::type_id()); ASSERT_EQ(other.type(), entt::type_id()); ASSERT_EQ(entt::any_cast(&other), nullptr); - ASSERT_EQ(entt::any_cast(other), 42); + ASSERT_EQ(entt::any_cast(other), 2); } TEST_F(Any, SBOMoveConstruction) { - entt::any any{42}; // NOLINT + entt::any any{2}; entt::any other{std::move(any)}; ASSERT_TRUE(any); // NOLINT @@ -232,11 +232,11 @@ TEST_F(Any, SBOMoveConstruction) { ASSERT_EQ(any.type(), entt::type_id()); ASSERT_EQ(other.type(), entt::type_id()); ASSERT_EQ(entt::any_cast(&other), nullptr); - ASSERT_EQ(entt::any_cast(other), 42); + ASSERT_EQ(entt::any_cast(other), 2); } TEST_F(Any, SBOMoveAssignment) { - entt::any any{42}; // NOLINT + entt::any any{2}; entt::any other{3}; other = std::move(any); @@ -249,27 +249,27 @@ TEST_F(Any, SBOMoveAssignment) { ASSERT_EQ(any.type(), entt::type_id()); ASSERT_EQ(other.type(), entt::type_id()); ASSERT_EQ(entt::any_cast(&other), nullptr); - ASSERT_EQ(entt::any_cast(other), 42); + ASSERT_EQ(entt::any_cast(other), 2); } TEST_F(Any, SBODirectAssignment) { entt::any any{}; - any = 42; // NOLINT + any = 2; ASSERT_TRUE(any); ASSERT_EQ(any.policy(), entt::any_policy::owner); ASSERT_EQ(any.type(), entt::type_id()); ASSERT_EQ(entt::any_cast(&any), nullptr); - ASSERT_EQ(entt::any_cast(any), 42); + ASSERT_EQ(entt::any_cast(any), 2); } TEST_F(Any, SBOAssignValue) { - entt::any any{42}; // NOLINT + entt::any any{2}; const entt::any other{3}; const entt::any invalid{'c'}; ASSERT_TRUE(any); - ASSERT_EQ(entt::any_cast(any), 42); + ASSERT_EQ(entt::any_cast(any), 2); ASSERT_TRUE(any.assign(other)); ASSERT_FALSE(any.assign(invalid)); @@ -277,13 +277,13 @@ TEST_F(Any, SBOAssignValue) { } TEST_F(Any, SBOAsRefAssignValue) { - int value = 42; // NOLINT + int value = 2; entt::any any{entt::forward_as_any(value)}; const entt::any other{3}; const entt::any invalid{'c'}; ASSERT_TRUE(any); - ASSERT_EQ(entt::any_cast(any), 42); + ASSERT_EQ(entt::any_cast(any), 2); ASSERT_TRUE(any.assign(other)); ASSERT_FALSE(any.assign(invalid)); @@ -292,25 +292,25 @@ TEST_F(Any, SBOAsRefAssignValue) { } TEST_F(Any, SBOAsConstRefAssignValue) { - const int value = 42; + const int value = 2; entt::any any{entt::forward_as_any(value)}; const entt::any other{3}; const entt::any invalid{'c'}; ASSERT_TRUE(any); - ASSERT_EQ(entt::any_cast(any), 42); + ASSERT_EQ(entt::any_cast(any), 2); ASSERT_FALSE(any.assign(other)); ASSERT_FALSE(any.assign(invalid)); - ASSERT_EQ(entt::any_cast(any), 42); - ASSERT_EQ(value, 42); + ASSERT_EQ(entt::any_cast(any), 2); + ASSERT_EQ(value, 2); } TEST_F(Any, SBOTransferValue) { - entt::any any{42}; // NOLINT + entt::any any{2}; ASSERT_TRUE(any); - ASSERT_EQ(entt::any_cast(any), 42); + ASSERT_EQ(entt::any_cast(any), 2); ASSERT_TRUE(any.assign(3)); ASSERT_FALSE(any.assign('c')); @@ -319,21 +319,21 @@ TEST_F(Any, SBOTransferValue) { TEST_F(Any, SBOTransferConstValue) { const int value = 3; - entt::any any{42}; // NOLINT + entt::any any{2}; ASSERT_TRUE(any); - ASSERT_EQ(entt::any_cast(any), 42); + ASSERT_EQ(entt::any_cast(any), 2); ASSERT_TRUE(any.assign(entt::forward_as_any(value))); ASSERT_EQ(entt::any_cast(any), 3); } TEST_F(Any, SBOAsRefTransferValue) { - int value = 42; // NOLINT + int value = 2; entt::any any{entt::forward_as_any(value)}; ASSERT_TRUE(any); - ASSERT_EQ(entt::any_cast(any), 42); + ASSERT_EQ(entt::any_cast(any), 2); ASSERT_TRUE(any.assign(3)); ASSERT_FALSE(any.assign('c')); @@ -342,16 +342,16 @@ TEST_F(Any, SBOAsRefTransferValue) { } TEST_F(Any, SBOAsConstRefTransferValue) { - const int value = 42; + const int value = 2; entt::any any{entt::forward_as_any(value)}; ASSERT_TRUE(any); - ASSERT_EQ(entt::any_cast(any), 42); + ASSERT_EQ(entt::any_cast(any), 2); ASSERT_FALSE(any.assign(3)); ASSERT_FALSE(any.assign('c')); - ASSERT_EQ(entt::any_cast(any), 42); - ASSERT_EQ(value, 42); + ASSERT_EQ(entt::any_cast(any), 2); + ASSERT_EQ(value, 2); } TEST_F(Any, NoSBOInPlaceTypeConstruction) { @@ -655,7 +655,7 @@ TEST_F(Any, VoidCopyConstruction) { TEST_F(Any, VoidCopyAssignment) { entt::any any{std::in_place_type}; - entt::any other{42}; // NOLINT + entt::any other{2}; other = any; @@ -685,7 +685,7 @@ TEST_F(Any, VoidMoveConstruction) { TEST_F(Any, VoidMoveAssignment) { entt::any any{std::in_place_type}; - entt::any other{42}; // NOLINT + entt::any other{2}; other = std::move(any); @@ -700,7 +700,7 @@ TEST_F(Any, VoidMoveAssignment) { } TEST_F(Any, SBOMoveValidButUnspecifiedState) { - entt::any any{42}; // NOLINT + entt::any any{2}; entt::any other{std::move(any)}; const entt::any valid = std::move(other); @@ -761,13 +761,13 @@ TEST_F(Any, VoidDestruction) { TEST_F(Any, Emplace) { entt::any any{}; - any.emplace(42); // NOLINT + any.emplace(2); ASSERT_TRUE(any); ASSERT_EQ(any.policy(), entt::any_policy::owner); ASSERT_EQ(any.type(), entt::type_id()); ASSERT_EQ(entt::any_cast(&any), nullptr); - ASSERT_EQ(entt::any_cast(any), 42); + ASSERT_EQ(entt::any_cast(any), 2); } TEST_F(Any, EmplaceVoid) { @@ -780,7 +780,7 @@ TEST_F(Any, EmplaceVoid) { } TEST_F(Any, Reset) { - entt::any any{42}; // NOLINT + entt::any any{2}; ASSERT_TRUE(any); ASSERT_EQ(any.policy(), entt::any_policy::owner); @@ -792,7 +792,7 @@ TEST_F(Any, Reset) { ASSERT_EQ(any.policy(), entt::any_policy::owner); ASSERT_EQ(any.type(), entt::type_id()); - int value = 42; // NOLINT + int value = 2; any.emplace(value); ASSERT_TRUE(any); @@ -808,7 +808,7 @@ TEST_F(Any, Reset) { TEST_F(Any, SBOSwap) { entt::any lhs{'c'}; - entt::any rhs{42}; // NOLINT + entt::any rhs{2}; std::swap(lhs, rhs); @@ -819,7 +819,7 @@ TEST_F(Any, SBOSwap) { ASSERT_EQ(rhs.type(), entt::type_id()); ASSERT_EQ(entt::any_cast(&lhs), nullptr); ASSERT_EQ(entt::any_cast(&rhs), nullptr); - ASSERT_EQ(entt::any_cast(lhs), 42); + ASSERT_EQ(entt::any_cast(lhs), 2); ASSERT_EQ(entt::any_cast(rhs), 'c'); } @@ -1037,7 +1037,7 @@ TEST_F(Any, NoSBOWithVoidSwap) { } TEST_F(Any, AsRef) { - entt::any any{42}; // NOLINT + entt::any any{2}; auto ref = any.as_ref(); auto cref = std::as_const(any).as_ref(); @@ -1052,20 +1052,20 @@ TEST_F(Any, AsRef) { ASSERT_EQ(entt::any_cast(&ref), any.data()); ASSERT_EQ(entt::any_cast(&cref), any.data()); - ASSERT_EQ(entt::any_cast(any), 42); - ASSERT_EQ(entt::any_cast(ref), 42); - ASSERT_EQ(entt::any_cast(cref), 42); + ASSERT_EQ(entt::any_cast(any), 2); + ASSERT_EQ(entt::any_cast(ref), 2); + ASSERT_EQ(entt::any_cast(cref), 2); - ASSERT_EQ(entt::any_cast(any), 42); - ASSERT_EQ(entt::any_cast(ref), 42); - ASSERT_EQ(entt::any_cast(cref), 42); + ASSERT_EQ(entt::any_cast(any), 2); + ASSERT_EQ(entt::any_cast(ref), 2); + ASSERT_EQ(entt::any_cast(cref), 2); - ASSERT_EQ(entt::any_cast(any), 42); - ASSERT_EQ(entt::any_cast(any), 42); - ASSERT_EQ(entt::any_cast(ref), 42); - ASSERT_EQ(entt::any_cast(ref), 42); + ASSERT_EQ(entt::any_cast(any), 2); + ASSERT_EQ(entt::any_cast(any), 2); + ASSERT_EQ(entt::any_cast(ref), 2); + ASSERT_EQ(entt::any_cast(ref), 2); ASSERT_EQ(entt::any_cast(&cref), nullptr); - ASSERT_EQ(entt::any_cast(cref), 42); + ASSERT_EQ(entt::any_cast(cref), 2); entt::any_cast(any) = 3; @@ -1098,18 +1098,18 @@ TEST_F(Any, AsRef) { ASSERT_EQ(entt::any_cast(ref), 3); ASSERT_EQ(entt::any_cast(cref), 3); - ref = 42; // NOLINT - cref = 42; // NOLINT + ref = 2; + cref = 2; ASSERT_EQ(ref.policy(), entt::any_policy::owner); ASSERT_EQ(cref.policy(), entt::any_policy::owner); ASSERT_NE(entt::any_cast(&ref), nullptr); ASSERT_NE(entt::any_cast(&cref), nullptr); - ASSERT_EQ(entt::any_cast(ref), 42); - ASSERT_EQ(entt::any_cast(cref), 42); - ASSERT_EQ(entt::any_cast(ref), 42); - ASSERT_EQ(entt::any_cast(cref), 42); + ASSERT_EQ(entt::any_cast(ref), 2); + ASSERT_EQ(entt::any_cast(cref), 2); + ASSERT_EQ(entt::any_cast(ref), 2); + ASSERT_EQ(entt::any_cast(cref), 2); ASSERT_NE(entt::any_cast(&ref), any.data()); ASSERT_NE(entt::any_cast(&cref), any.data()); } @@ -1143,7 +1143,7 @@ TEST_F(Any, NoSBOComparable) { } TEST_F(Any, RefComparable) { - int value = 42; // NOLINT + int value = 2; const entt::any any{entt::forward_as_any(value)}; const entt::any other{3}; @@ -1158,7 +1158,7 @@ TEST_F(Any, RefComparable) { } TEST_F(Any, ConstRefComparable) { - int value = 42; // NOLINT + int value = 2; const entt::any any{3}; const entt::any other{entt::make_any(value)}; @@ -1174,7 +1174,7 @@ TEST_F(Any, ConstRefComparable) { TEST_F(Any, UnrelatedComparable) { const entt::any any{'c'}; - const entt::any other{42}; + const entt::any other{2}; ASSERT_EQ(any, any); ASSERT_NE(other, any); @@ -1241,42 +1241,42 @@ TEST_F(Any, CompareVoid) { } TEST_F(Any, AnyCast) { - entt::any any{42}; // NOLINT + entt::any any{2}; const auto &cany = any; ASSERT_EQ(entt::any_cast(&any), nullptr); ASSERT_EQ(entt::any_cast(&cany), nullptr); - ASSERT_EQ(*entt::any_cast(&any), 42); - ASSERT_EQ(*entt::any_cast(&cany), 42); - ASSERT_EQ(entt::any_cast(any), 42); - ASSERT_EQ(entt::any_cast(cany), 42); + ASSERT_EQ(*entt::any_cast(&any), 2); + ASSERT_EQ(*entt::any_cast(&cany), 2); + ASSERT_EQ(entt::any_cast(any), 2); + ASSERT_EQ(entt::any_cast(cany), 2); - auto instance = std::make_unique(42.); + auto instance = std::make_unique(2.); entt::any ref{entt::forward_as_any(instance)}; entt::any cref{entt::forward_as_any(std::as_const(*instance))}; - ASSERT_EQ(entt::any_cast(std::move(cref)), 42.); - ASSERT_EQ(*entt::any_cast>(std::move(ref)), 42.); - ASSERT_EQ(entt::any_cast(entt::any{42}), 42); + ASSERT_EQ(entt::any_cast(std::move(cref)), 2.); + ASSERT_EQ(*entt::any_cast>(std::move(ref)), 2.); + ASSERT_EQ(entt::any_cast(entt::any{2}), 2); } ENTT_DEBUG_TEST_F(AnyDeathTest, AnyCast) { - entt::any any{42}; // NOLINT + entt::any any{2}; const auto &cany = any; ASSERT_DEATH([[maybe_unused]] auto &elem = entt::any_cast(any), ""); ASSERT_DEATH([[maybe_unused]] const auto &elem = entt::any_cast(cany), ""); - auto instance = std::make_unique(42.); + auto instance = std::make_unique(2.); entt::any ref{entt::forward_as_any(instance)}; const entt::any cref{entt::forward_as_any(std::as_const(*instance))}; ASSERT_DEATH([[maybe_unused]] auto elem = entt::any_cast>(std::as_const(ref).as_ref()), ""); - ASSERT_DEATH([[maybe_unused]] auto elem = entt::any_cast(entt::any{42}), ""); + ASSERT_DEATH([[maybe_unused]] auto elem = entt::any_cast(entt::any{2}), ""); } TEST_F(Any, MakeAny) { - int value = 42; // NOLINT + int value = 2; auto any = entt::make_any(value); auto ext = entt::make_any(value); auto ref = entt::make_any(value); @@ -1289,9 +1289,9 @@ TEST_F(Any, MakeAny) { ASSERT_EQ(ext.policy(), entt::any_policy::owner); ASSERT_EQ(ref.policy(), entt::any_policy::ref); - ASSERT_EQ(entt::any_cast(any), 42); - ASSERT_EQ(entt::any_cast(ext), 42); - ASSERT_EQ(entt::any_cast(ref), 42); + ASSERT_EQ(entt::any_cast(any), 2); + ASSERT_EQ(entt::any_cast(ext), 2); + ASSERT_EQ(entt::any_cast(ref), 2); ASSERT_EQ(decltype(any)::length, entt::any::length); ASSERT_NE(decltype(ext)::length, entt::any::length); @@ -1303,7 +1303,7 @@ TEST_F(Any, MakeAny) { } TEST_F(Any, ForwardAsAny) { - int value = 42; // NOLINT + int value = 2; auto ref = entt::forward_as_any(value); auto cref = entt::forward_as_any(std::as_const(value)); auto any = entt::forward_as_any(static_cast(value)); @@ -1320,9 +1320,9 @@ TEST_F(Any, ForwardAsAny) { ASSERT_NE(entt::any_cast(&ref), nullptr); ASSERT_EQ(entt::any_cast(&cref), nullptr); - ASSERT_EQ(entt::any_cast(any), 42); - ASSERT_EQ(entt::any_cast(ref), 42); - ASSERT_EQ(entt::any_cast(cref), 42); + ASSERT_EQ(entt::any_cast(any), 2); + ASSERT_EQ(entt::any_cast(ref), 2); + ASSERT_EQ(entt::any_cast(cref), 2); ASSERT_NE(any.data(), &value); ASSERT_EQ(ref.data(), &value); @@ -1420,9 +1420,9 @@ TEST_F(Any, Array) { ASSERT_EQ(entt::any_cast(&any), nullptr); // NOLINT ASSERT_EQ(entt::any_cast(&any), nullptr); - entt::any_cast(any)[0] = 42; // NOLINT + entt::any_cast(any)[0] = 2; // NOLINT - ASSERT_EQ(entt::any_cast(std::as_const(any))[0], 42); // NOLINT + ASSERT_EQ(entt::any_cast(std::as_const(any))[0], 2); // NOLINT } TEST_F(Any, CopyMoveReference) { @@ -1448,9 +1448,9 @@ TEST_F(Any, CopyMoveReference) { ASSERT_EQ(entt::any_cast(move), 3); ASSERT_EQ(entt::any_cast(copy), 3); - value = 42; // NOLINT + value = 2; - ASSERT_EQ(entt::any_cast(move), 42); + ASSERT_EQ(entt::any_cast(move), 2); ASSERT_EQ(entt::any_cast(copy), 3); } @@ -1477,20 +1477,20 @@ TEST_F(Any, CopyMoveConstReference) { ASSERT_EQ(entt::any_cast(move), 3); ASSERT_EQ(entt::any_cast(copy), 3); - value = 42; // NOLINT + value = 2; - ASSERT_EQ(entt::any_cast(move), 42); + ASSERT_EQ(entt::any_cast(move), 2); ASSERT_EQ(entt::any_cast(copy), 3); } TEST_F(Any, SBOVsZeroedSBOSize) { - entt::any sbo{42}; // NOLINT + entt::any sbo{2}; const auto *broken = sbo.data(); entt::any other = std::move(sbo); ASSERT_NE(broken, other.data()); - entt::basic_any<0u> dyn{42}; // NOLINT + entt::basic_any<0u> dyn{2}; const auto *valid = dyn.data(); entt::basic_any<0u> same = std::move(dyn); @@ -1531,7 +1531,7 @@ TEST_F(Any, NoSboAlignment) { TEST_F(Any, AggregatesMustWork) { // the goal of this test is to enforce the requirements for aggregate types - entt::any{std::in_place_type, 42}.emplace(42); // NOLINT + entt::any{std::in_place_type, 2}.emplace(2); } TEST_F(Any, DeducedArrayType) {