From 30772848e6ced939c753fdf4d4d650592d2092aa Mon Sep 17 00:00:00 2001 From: Michele Caini Date: Fri, 24 Feb 2023 15:04:40 +0100 Subject: [PATCH] meta: avoid unnecessary calls to std::move --- src/entt/meta/factory.hpp | 8 ++++---- src/entt/meta/meta.hpp | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/entt/meta/factory.hpp b/src/entt/meta/factory.hpp index 8637bccd7..d0cd1e113 100644 --- a/src/entt/meta/factory.hpp +++ b/src/entt/meta/factory.hpp @@ -36,19 +36,19 @@ namespace internal { } inline meta_base_node &meta_extend(internal::meta_type_node &parent, const id_type id, meta_base_node node) { - return parent.details->base.insert_or_assign(id, std::move(node)).first->second; + return parent.details->base.insert_or_assign(id, node).first->second; } inline meta_conv_node &meta_extend(internal::meta_type_node &parent, const id_type id, meta_conv_node node) { - return parent.details->conv.insert_or_assign(id, std::move(node)).first->second; + return parent.details->conv.insert_or_assign(id, node).first->second; } inline meta_ctor_node &meta_extend(internal::meta_type_node &parent, const id_type id, meta_ctor_node node) { - return parent.details->ctor.insert_or_assign(id, std::move(node)).first->second; + return parent.details->ctor.insert_or_assign(id, node).first->second; } inline meta_dtor_node &meta_extend(internal::meta_type_node &parent, meta_dtor_node node) { - return (parent.dtor = std::move(node)); + return (parent.dtor = node); } inline meta_data_node &meta_extend(internal::meta_type_node &parent, const id_type id, meta_data_node node) { diff --git a/src/entt/meta/meta.hpp b/src/entt/meta/meta.hpp index 2cffaabde..c5210f976 100644 --- a/src/entt/meta/meta.hpp +++ b/src/entt/meta/meta.hpp @@ -1634,7 +1634,7 @@ public: explicit meta_iterator(const meta_ctx &area, It iter) noexcept : ctx{&area}, vtable{&basic_vtable}, - handle{std::move(iter)} {} + handle{iter} {} meta_iterator &operator++() noexcept { vtable(operation::incr, handle, 1, nullptr); @@ -1728,7 +1728,7 @@ public: meta_iterator(const meta_ctx &area, std::integral_constant, It iter) noexcept : ctx{&area}, vtable{&basic_vtable}, - handle{std::move(iter)} {} + handle{iter} {} meta_iterator &operator++() noexcept { vtable(operation::incr, handle, nullptr); @@ -1838,7 +1838,7 @@ inline meta_sequence_container::iterator meta_sequence_container::insert(iterato * @return A possibly invalid iterator following the last removed element. */ inline meta_sequence_container::iterator meta_sequence_container::erase(iterator it) { - return insert(std::move(it), {}); + return insert(it, {}); } /**