From 991d16084d2dbb0fac357639d2a4bd819aa2af46 Mon Sep 17 00:00:00 2001 From: Michele Caini Date: Tue, 21 May 2024 10:19:03 +0200 Subject: [PATCH] test: noexcept-ness review --- test/entt/core/any.cpp | 2 +- test/entt/entity/registry.cpp | 2 +- test/entt/entity/storage.cpp | 2 +- test/entt/locator/locator.cpp | 2 +- test/entt/meta/meta_any.cpp | 6 +++--- test/entt/meta/meta_data.cpp | 2 +- test/entt/meta/meta_func.cpp | 2 +- test/entt/meta/meta_type.cpp | 2 +- test/entt/resource/resource.cpp | 2 +- 9 files changed, 11 insertions(+), 11 deletions(-) diff --git a/test/entt/core/any.cpp b/test/entt/core/any.cpp index 68ee9745e..2bb8a961f 100644 --- a/test/entt/core/any.cpp +++ b/test/entt/core/any.cpp @@ -24,7 +24,7 @@ struct tracker { tracker(const tracker &) = default; tracker &operator=(const tracker &) = delete; - ~tracker() { + ~tracker() noexcept { ++(*counter); } diff --git a/test/entt/entity/registry.cpp b/test/entt/entity/registry.cpp index 810a1c9e4..13b1e190f 100644 --- a/test/entt/entity/registry.cpp +++ b/test/entt/entity/registry.cpp @@ -70,7 +70,7 @@ struct destruction_order { destruction_order(const destruction_order &) = delete; destruction_order &operator=(const destruction_order &) = delete; - ~destruction_order() { + ~destruction_order() noexcept { *ctx_check = *ctx_check && (registry->ctx().find() != nullptr); } diff --git a/test/entt/entity/storage.cpp b/test/entt/entity/storage.cpp index f629b9b54..b93a7c163 100644 --- a/test/entt/entity/storage.cpp +++ b/test/entt/entity/storage.cpp @@ -39,7 +39,7 @@ struct update_from_destructor { return *this; } - ~update_from_destructor() { + ~update_from_destructor() noexcept { if(target != entt::null && storage->contains(target)) { storage->erase(target); } diff --git a/test/entt/locator/locator.cpp b/test/entt/locator/locator.cpp index f7709a2c1..3a42d4f47 100644 --- a/test/entt/locator/locator.cpp +++ b/test/entt/locator/locator.cpp @@ -4,7 +4,7 @@ #include "../../common/config.h" struct base_service { - virtual ~base_service() = default; + virtual ~base_service() noexcept = default; virtual int invoke(int) = 0; }; diff --git a/test/entt/meta/meta_any.cpp b/test/entt/meta/meta_any.cpp index 9bde20c5c..462c84d52 100644 --- a/test/entt/meta/meta_any.cpp +++ b/test/entt/meta/meta_any.cpp @@ -34,7 +34,7 @@ struct empty { empty(const empty &) = default; empty &operator=(const empty &) = default; - virtual ~empty() { + virtual ~empty() noexcept { ++destructor_counter; } @@ -53,7 +53,7 @@ struct fat: empty { fat(double v1, double v2, double v3, double v4) : value{v1, v2, v3, v4} {} - ~fat() override = default; + ~fat() noexcept override = default; fat(const fat &) = default; fat &operator=(const fat &) = default; @@ -74,7 +74,7 @@ struct unmanageable { unmanageable() : value{std::make_unique(3)} {} - ~unmanageable() = default; + ~unmanageable() noexcept = default; unmanageable(const unmanageable &) = delete; unmanageable(unmanageable &&) = delete; diff --git a/test/entt/meta/meta_data.cpp b/test/entt/meta/meta_data.cpp index e891ab3dd..88a2c252f 100644 --- a/test/entt/meta/meta_data.cpp +++ b/test/entt/meta/meta_data.cpp @@ -15,7 +15,7 @@ #include "../../common/config.h" struct base { - virtual ~base() = default; + virtual ~base() noexcept = default; static void destroy(base &) { ++counter; diff --git a/test/entt/meta/meta_func.cpp b/test/entt/meta/meta_func.cpp index 7035d67ba..6f6e19750 100644 --- a/test/entt/meta/meta_func.cpp +++ b/test/entt/meta/meta_func.cpp @@ -13,7 +13,7 @@ struct base { base() = default; - virtual ~base() = default; + virtual ~base() noexcept = default; void setter(int v) { value = v; diff --git a/test/entt/meta/meta_type.cpp b/test/entt/meta/meta_type.cpp index 4638a8819..3a14ae0d0 100644 --- a/test/entt/meta/meta_type.cpp +++ b/test/entt/meta/meta_type.cpp @@ -38,7 +38,7 @@ struct derived: base { }; struct abstract { - virtual ~abstract() = default; + virtual ~abstract() noexcept = default; virtual void func(int) {} void base_only(int) {} diff --git a/test/entt/resource/resource.cpp b/test/entt/resource/resource.cpp index 10845e4b8..5e3c27bac 100644 --- a/test/entt/resource/resource.cpp +++ b/test/entt/resource/resource.cpp @@ -6,7 +6,7 @@ #include "../../common/linter.hpp" struct base { - virtual ~base() = default; + virtual ~base() noexcept = default; [[nodiscard]] virtual const entt::type_info &type() const noexcept { return entt::type_id();