From 15d124b225a559ddca7d6a9da580143da4e200cd Mon Sep 17 00:00:00 2001 From: Mathias Agopian Date: Tue, 17 Jan 2023 22:12:45 -0800 Subject: [PATCH] disable KHR_debug messages there were never useful and in fact harmful, because confusing to our users. --- filament/backend/src/opengl/OpenGLContext.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/filament/backend/src/opengl/OpenGLContext.cpp b/filament/backend/src/opengl/OpenGLContext.cpp index 62005f78a0..10c6f541bd 100644 --- a/filament/backend/src/opengl/OpenGLContext.cpp +++ b/filament/backend/src/opengl/OpenGLContext.cpp @@ -268,7 +268,9 @@ OpenGLContext::OpenGLContext() noexcept { } #endif -#if !defined(NDEBUG) && defined(GL_KHR_debug) + // in practice KHR_Debug has never been useful, and actually is confusing. We keep this + // only for our own debugging, in case we need it some day. +#if false && !defined(NDEBUG) && defined(GL_KHR_debug) if (ext.KHR_debug) { auto cb = +[](GLenum, GLenum type, GLuint, GLenum severity, GLsizei length, const GLchar* message, const void *) {