From 3e644b25f09ecbe2e06a3d8ca664dda9d054f701 Mon Sep 17 00:00:00 2001 From: Benjamin Doherty Date: Wed, 21 Feb 2024 13:32:30 -0800 Subject: [PATCH] Fix an out-of-bounds memory access when no renderables are visible --- filament/src/RenderPass.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/filament/src/RenderPass.cpp b/filament/src/RenderPass.cpp index d5063043f5..5282fb32ca 100644 --- a/filament/src/RenderPass.cpp +++ b/filament/src/RenderPass.cpp @@ -99,6 +99,10 @@ RenderPass::RenderPass(FEngine& engine, RenderPassBuilder const& builder) noexce mScissorViewport(builder.mScissorViewport), mCustomCommands(engine.getPerRenderPassArena()) { + if (mVisibleRenderables.empty()) { + return; + } + // compute the number of commands we need updateSummedPrimitiveCounts( const_cast(mRenderableSoa), mVisibleRenderables);