From 45636e5afe84a4dbb36bbdf63097e202b5381981 Mon Sep 17 00:00:00 2001 From: Gareth Morgan Date: Wed, 1 May 2019 20:09:32 -0400 Subject: [PATCH] Correct JS bindings for (#1137) * Correct bindings for TransformManager::create and VertexBuffer::Builder::attribute * Correct types --- web/filament-js/jsbindings.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/web/filament-js/jsbindings.cpp b/web/filament-js/jsbindings.cpp index 832c610745..53bbffecdd 100644 --- a/web/filament-js/jsbindings.cpp +++ b/web/filament-js/jsbindings.cpp @@ -695,7 +695,11 @@ class_("TransformManager") /// ::retval:: a transform component that can be passed to `setTransform`. .function("getInstance", &TransformManager::getInstance) - .function("create", &TransformManager::create) + .function("create", EMBIND_LAMBDA(void, + (TransformManager* self, utils::Entity entity), { + self->create(entity); + }), allow_raw_pointers()) + .function("destroy", &TransformManager::destroy) .function("setParent", &TransformManager::setParent) .function("getParent", &TransformManager::getParent) @@ -772,7 +776,7 @@ class_("VertexBuffer$Builder") VertexAttribute attr, uint8_t bufferIndex, VertexBuffer::AttributeType attrType, - uint8_t byteOffset, + uint32_t byteOffset, uint8_t byteStride), { return &builder->attribute(attr, bufferIndex, attrType, byteOffset, byteStride); }) .BUILDER_FUNCTION("vertexCount", VertexBuilder, (VertexBuilder* builder, int count), {