From 4df214003e77bbbcec66b463ebeca52d363a75b3 Mon Sep 17 00:00:00 2001 From: Philip Rideout Date: Thu, 13 May 2021 08:56:43 -0700 Subject: [PATCH] Revert accidental Vulkan diagnostic commit. This reverts commit 59a6758fce8a0b7efcc36d97f59e38226a9081f3. --- .../main/java/com/google/android/filament/utils/ModelViewer.kt | 2 +- android/samples/sample-gltf-viewer/build.gradle | 3 --- filament/backend/src/vulkan/VulkanConstants.h | 2 +- samples/hellopbr.cpp | 1 - samples/hellotriangle.cpp | 1 - 5 files changed, 2 insertions(+), 7 deletions(-) diff --git a/android/filament-utils-android/src/main/java/com/google/android/filament/utils/ModelViewer.kt b/android/filament-utils-android/src/main/java/com/google/android/filament/utils/ModelViewer.kt index 3e4f242bbc..005473eb92 100644 --- a/android/filament-utils-android/src/main/java/com/google/android/filament/utils/ModelViewer.kt +++ b/android/filament-utils-android/src/main/java/com/google/android/filament/utils/ModelViewer.kt @@ -129,7 +129,7 @@ class ModelViewer(val engine: Engine) : android.view.View.OnTouchListener { scene.addEntity(light) } - constructor(surfaceView: SurfaceView, engine: Engine = Engine.create(Engine.Backend.VULKAN), manipulator: Manipulator? = null) : this(engine) { + constructor(surfaceView: SurfaceView, engine: Engine = Engine.create(), manipulator: Manipulator? = null) : this(engine) { cameraManipulator = manipulator ?: Manipulator.Builder() .targetPosition(kDefaultObjectPosition.x, kDefaultObjectPosition.y, kDefaultObjectPosition.z) .viewport(surfaceView.width, surfaceView.height) diff --git a/android/samples/sample-gltf-viewer/build.gradle b/android/samples/sample-gltf-viewer/build.gradle index 8b74ad2190..ec503fccf7 100644 --- a/android/samples/sample-gltf-viewer/build.gradle +++ b/android/samples/sample-gltf-viewer/build.gradle @@ -29,9 +29,6 @@ android { targetSdkVersion versions.targetSdk missingDimensionStrategy 'functionality', 'full' } - sourceSets.main.jniLibs { - srcDirs = ["/Users/prideout/Library/Android/sdk/ndk/22.1.7171670/sources/third_party/vulkan/src/build-android/jniLibs"] - } } dependencies { diff --git a/filament/backend/src/vulkan/VulkanConstants.h b/filament/backend/src/vulkan/VulkanConstants.h index e59219bc03..65b1bcba64 100644 --- a/filament/backend/src/vulkan/VulkanConstants.h +++ b/filament/backend/src/vulkan/VulkanConstants.h @@ -32,7 +32,7 @@ // } // #if defined(NDEBUG) -#define VK_ENABLE_VALIDATION 1 +#define VK_ENABLE_VALIDATION 0 #else #define VK_ENABLE_VALIDATION 1 #endif diff --git a/samples/hellopbr.cpp b/samples/hellopbr.cpp index f4ced280b8..44acda07bd 100644 --- a/samples/hellopbr.cpp +++ b/samples/hellopbr.cpp @@ -52,7 +52,6 @@ int main(int argc, char** argv) { Config config; config.title = "hellopbr"; config.iblDirectory = FilamentApp::getRootAssetsPath() + IBL_FOLDER; - config.backend = Backend::VULKAN; App app; auto setup = [config, &app](Engine* engine, View* view, Scene* scene) { diff --git a/samples/hellotriangle.cpp b/samples/hellotriangle.cpp index 3fd0fd2e90..8c237c68b1 100644 --- a/samples/hellotriangle.cpp +++ b/samples/hellotriangle.cpp @@ -65,7 +65,6 @@ static constexpr uint16_t TRIANGLE_INDICES[3] = { 0, 1, 2 }; int main(int argc, char** argv) { Config config; config.title = "hellotriangle"; - config.backend = Engine::Backend::VULKAN; App app; auto setup = [&app](Engine* engine, View* view, Scene* scene) {