From 50045edb4f3acce4a34e9446ebf820451b3c4e12 Mon Sep 17 00:00:00 2001 From: JEONG TAEHUN <52663419+jeongth9446@users.noreply.github.com> Date: Mon, 26 Jun 2023 13:05:43 +0900 Subject: [PATCH] [ModelViewer.kt, Remove Lint warning] (#6917) - Use of getter method instead of property access syntax (for getInstance) - 'rangeTo' or the '..' call should be replaced with 'until' (in for) Co-authored-by: jeongth9446 --- .../java/com/google/android/filament/utils/ModelViewer.kt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/android/filament-utils-android/src/main/java/com/google/android/filament/utils/ModelViewer.kt b/android/filament-utils-android/src/main/java/com/google/android/filament/utils/ModelViewer.kt index 81bd795659..2f11466b49 100644 --- a/android/filament-utils-android/src/main/java/com/google/android/filament/utils/ModelViewer.kt +++ b/android/filament-utils-android/src/main/java/com/google/android/filament/utils/ModelViewer.kt @@ -191,7 +191,7 @@ class ModelViewer( asset = assetLoader.createAsset(buffer) asset?.let { asset -> resourceLoader.asyncBeginLoad(asset) - animator = asset.getInstance().animator + animator = asset.instance.animator asset.releaseSourceData() } } @@ -214,7 +214,7 @@ class ModelViewer( resourceLoader.addResourceData(uri, resourceBuffer) } resourceLoader.asyncBeginLoad(asset) - animator = asset.getInstance().animator + animator = asset.instance.animator asset.releaseSourceData() } } @@ -311,7 +311,7 @@ class ModelViewer( var count = 0 val popRenderables = { count = asset.popRenderables(readyRenderables); count != 0 } while (popRenderables()) { - for (i in 0..count - 1) { + for (i in 0 until count) { val ri = rcm.getInstance(readyRenderables[i]) rcm.setScreenSpaceContactShadows(ri, true) } @@ -371,7 +371,7 @@ class ModelViewer( resourceLoader.addResourceData(uri, buffer) } resourceLoader.asyncBeginLoad(asset) - animator = asset.getInstance().animator + animator = asset.instance.animator asset.releaseSourceData() } }