renderdiff: enable webgpu and improvements (#9219)

- Allow for presets to override selected models when presented
   in order.
 - Add 'gltf' for model search path
 - Add a few simple gltf models to the 'base' preset
 - Improve UI so that missing tests do not generate any html
   bits.
 - Add documentation on using the viewer
 - Add renderdiff documentation to the project webpage.

RDIFF_BRANCH=pf/renderdiff-enable-webgpu
This commit is contained in:
Powei Feng
2025-09-18 21:29:00 +00:00
committed by GitHub
parent 1fb3d48e90
commit 60df8ac6b8
12 changed files with 167 additions and 44 deletions
-1
View File
@@ -22,7 +22,6 @@ import concurrent.futures
from utils import execute, ArgParseImpl, mkdir_p, mv_f, important_print
import test_config
from golden_manager import GoldenManager
from image_diff import same_image
from results import RESULT_OK, RESULT_FAILED
@@ -0,0 +1,6 @@
Mako==1.3.10
MarkupSafe==3.0.2
numpy==2.3.3
PyYAML==6.0.2
setuptools==80.9.0
tifffile==2025.9.9
+4 -1
View File
@@ -76,9 +76,12 @@ class TestConfig(RenderingConfig):
given_presets = {p.name: p for p in presets}
assert all((name in given_presets) for name in apply_presets),\
f'used preset {name} which is not in {given_presets}'
# Note that this needs to applied in order. Models will be overwritten.
# Properties will be "added" in order.
for preset in apply_presets:
rendering.update(given_presets[preset].rendering)
preset_models += given_presets[preset].models
preset_models = given_presets[preset].models
assert 'rendering' in data
rendering.update(data['rendering'])
+40 -29
View File
@@ -113,7 +113,7 @@ class ExpandedComparisonResult extends LitElement {
#diffCanvas {
width: 100%;
height: 100%;
margin-top: 35px;
margin-top: 22px;
margin-bottom: 5px;
}
.selector {
@@ -151,33 +151,9 @@ class ExpandedComparisonResult extends LitElement {
_viewer(name, choices, current, viewType) {
const url = viewType == 'rendered' ? getCompUrl(current) : getGoldenUrl(current);
const onSelect = (ev) => {
const testName = ev.target.value;
const test = this.tests.find((t) => t.name == testName);
if (name == 'left') {
this.left = test;
this.leftImageLoaded = false;
} else {
this.right = test;
this.rightImageLoaded = false;
}
this.showDiff = false;
};
const dropdown = () => {
if (this.disableDropdowns) {
return html`<div class="selector">${current.name} (${viewType})</div>`;
}
return html`
<select class="selector" @change=${onSelect}>
${choices.map((c) => html`<option value=${c.name} ?selected=${c.name == current.name}>${c.name}</option>`)}
</select>
`;
}
return html`
<div style="flex: 1; margin: 0 5px;">
${dropdown()}
<div>${current.name}</div>
<tiff-viewer id="viewer-${name}" class="viewer"
name="${current.name}"
fileurl="${url}"></tiff-viewer>
@@ -405,6 +381,9 @@ class App extends LitElement {
selectedTests: {type: Array},
comparisonContent: {type: Object},
compareMode: {type: Boolean},
// This is used to cache urls that are not found
missingFile: {type: Object},
};
async _init() {
@@ -420,12 +399,27 @@ class App extends LitElement {
this.selectedTests = [];
this.comparisonContent = null;
this.compareMode = false;
this.missingFile = {
[getDiffUrl('undefined')]: true,
};
this._init();
this.addEventListener('dialog-closed', () => {
this.dialogContent = null;
this.comparisonContent = null;
});
this.addEventListener('url-hit', (ev) => {
delete this.missingFile[ev.detail.value];
this.missingFile = this.missingFile;
this.requestUpdate();
});
this.addEventListener('url-miss', (ev) => {
this.missingFile[ev.detail.value] = true;
this.missingFile = this.missingFile;
this.requestUpdate();
});
}
updated(props) {
@@ -470,8 +464,24 @@ class App extends LitElement {
}
render() {
let passed = this.tests.filter((t) => t.result == 'ok');
let failed = this.tests.filter((t) => t.result != 'ok');
const sortFn = (a, b) => {
const aparts = a.name.split('.');
const bparts = b.name.split('.');
// 0 = test names
// 1 = backend
// 2 = model
for (let i of [0, 2, 1]) {
if (aparts[i] < bparts[i]) {
return -1;
}
if (aparts[i] > bparts[i]) {
return 1;
}
}
return 0;
};
let passed = this.tests.filter((t) => t.result == 'ok').sort(sortFn);
let failed = this.tests.filter((t) => t.result != 'ok').sort(sortFn);
const singleTiff = (url) => {
return html`<tiff-viewer style="max-width:100px" fileurl="${url}"></tiff-viewer>`;
};
@@ -502,7 +512,8 @@ class App extends LitElement {
[goldenUrl, 'golden'],
[compUrl, 'rendered'],
[diffUrl, 'diff']
].map((a) => [singleTiff(a[0]), a[1]])
].filter((a) => !this.missingFile[a[0]])
.map((a) => [singleTiff(a[0]), a[1]])
.map((a) => wrap(...a));
return html`
<div class="test-item" @click="${(e)=>this._onClick(t, e)}" >
+32 -1
View File
@@ -30,15 +30,20 @@ export class TiffViewer extends LitElement {
static properties = {
fileurl: {type: String, attribute: 'fileurl'},
name: {type: String, attribute: 'name'},
failedToFetch: {type: Boolean },
};
constructor() {
super();
this.fileurl = null;
this.name = null;
this.failedToFetch = false;
}
render() {
if (this.failedToFetch) {
return html``;
}
return html`<canvas id="tiffCanvas"></canvas>`;
}
@@ -49,7 +54,33 @@ export class TiffViewer extends LitElement {
}
async _updateImage(fileurl) {
const fileblob = await ((await fetch(this.fileurl)).arrayBuffer());
this.failedToFetch = false;
let fileblob = null;
try {
let res = await fetch(this.fileurl);
if (!res.ok) {
throw new Error(`Could not find ${this.fileurl}`);
}
fileblob = await res.arrayBuffer();
} catch (error) {
this.failedToFetch = true;
}
if (!fileblob) {
const event = new CustomEvent('url-miss', {
detail: { value: fileurl },
bubbles: true,
composed: true,
});
this.dispatchEvent(event);
return;
} else {
const event = new CustomEvent('url-hit', {
detail: { value: fileurl },
bubbles: true,
composed: true,
});
this.dispatchEvent(event);
}
const canvas = this.shadowRoot.getElementById('tiffCanvas');
const ctx = canvas.getContext('2d');
@@ -0,0 +1,13 @@
blinker==1.9.0
certifi==2025.8.3
charset-normalizer==3.4.3
click==8.2.1
Flask==3.1.2
idna==3.10
itsdangerous==2.2.0
Jinja2==3.1.6
MarkupSafe==3.0.2
requests==2.32.5
urllib3==2.5.0
waitress==3.0.2
Werkzeug==3.1.3