From 9914eb84a4d613d609ae77a1d031fadf973db02c Mon Sep 17 00:00:00 2001 From: Mathias Agopian Date: Fri, 23 Apr 2021 15:18:48 -0700 Subject: [PATCH] Fix documentation for getNormalizedViewportCoord Fixes #3821 --- docs/Materials.md.html | 2 +- shaders/src/getters.fs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/Materials.md.html b/docs/Materials.md.html index 464ff9714e..24aadc23b3 100644 --- a/docs/Materials.md.html +++ b/docs/Materials.md.html @@ -1936,7 +1936,7 @@ The following APIs are only available from the fragment block: **getWorldNormalVector()** | float3 | Normalized normal in world space, after bump mapping (must be used after `prepareMaterial()`) **getWorldGeometricNormalVector()** | float3 | Normalized normal in world space, before bump mapping (can be used before `prepareMaterial()`) **getWorldReflectedVector()** | float3 | Reflection of the view vector about the normal (must be used after `prepareMaterial()`) -**getNormalizedViewportCoord()** | float2 | Normalized viewport position (i.e. clip-space position normalized to [0, 1], can be used before `prepareMaterial()`) +**getNormalizedViewportCoord()** | float3 | Normalized viewport position (i.e. NDC coordinates normalized to [0, 1], can be used before `prepareMaterial()`) **getNdotV()** | float | The result of `dot(normal, view)`, always strictly greater than 0 (must be used after `prepareMaterial()`) **getColor()** | float4 | Interpolated color of the fragment, if the color attribute is required **getUV0()** | float2 | First interpolated set of UV coordinates, only available if the uv0 attribute is required diff --git a/shaders/src/getters.fs b/shaders/src/getters.fs index b946faa9a4..d4d660fcf8 100644 --- a/shaders/src/getters.fs +++ b/shaders/src/getters.fs @@ -101,7 +101,7 @@ highp vec3 getLightSpacePosition() { * @public-api */ highp vec3 getNormalizedViewportCoord() { - // make sure handle our reversed-z + // make sure to handle our reversed-z return vec3(shading_normalizedViewportCoord, 1.0 - gl_FragCoord.z); }