Scarfski/filament
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use our own constants instead of M_PI, M_*, etc. (#1733)

Browse Source 
These constants are not part of the standard. We instead use our own
constexpr definitions in the filament::math namespace, as part of
the scalar.h include.
This commit is contained in:
Romain Guy
2019-10-02 15:31:38 -07:00
committed by GitHub
parent 7ea7d1d5f2
commit a4a1bf07aa
22 changed files with 218 additions and 193 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
libs/math/tests/test_quat.cpp
View File

@@ -24,6 +24,7 @@
#include <math/mat4.h>
#include <math/vec4.h>
#include <math/vec3.h>
#include <math/scalar.h>
using namespace filament::math;
@@ -235,7 +236,7 @@ TEST_F(QuatTest, ArithmeticFunc) {
EXPECT_DOUBLE_EQ(1, length(qn));
EXPECT_DOUBLE_EQ(1, dot(qn, qn));
quat qr = quat::fromAxisAngle(double3(0, 0, 1), M_PI / 2);
quat qr = quat::fromAxisAngle(double3(0, 0, 1), F_PI / 2);
EXPECT_EQ(mat4(qr).toQuaternion(), qr);
EXPECT_EQ(1_i, mat4(1_i).toQuaternion());
EXPECT_EQ(1_j, mat4(1_j).toQuaternion());
@@ -252,9 +253,9 @@ TEST_F(QuatTest, ArithmeticFunc) {
EXPECT_NEAR(qq.w, q2.w, 1e-15);
quat qa = quat::fromAxisAngle(double3(0, 0, 1), 0);
quat qb = quat::fromAxisAngle(double3(0, 0, 1), M_PI / 2);
quat qb = quat::fromAxisAngle(double3(0, 0, 1), F_PI / 2);
quat qs = slerp(qa, qb, 0.5);
qr = quat::fromAxisAngle(double3(0, 0, 1), M_PI / 4);
qr = quat::fromAxisAngle(double3(0, 0, 1), F_PI / 4);
EXPECT_DOUBLE_EQ(qr.x, qs.x);
EXPECT_DOUBLE_EQ(qr.y, qs.y);
EXPECT_DOUBLE_EQ(qr.z, qs.z);