From a8765b1dc0c1503267367aac062d7ef28e53cd2a Mon Sep 17 00:00:00 2001 From: Mathias Agopian Date: Tue, 13 Sep 2022 14:51:59 -0700 Subject: [PATCH] fix some trivial ide warnings --- filament/backend/src/metal/MetalHandles.mm | 2 ++ filament/backend/src/vulkan/VulkanHandles.h | 8 ++++---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/filament/backend/src/metal/MetalHandles.mm b/filament/backend/src/metal/MetalHandles.mm index b56c8813ca..a16d149135 100644 --- a/filament/backend/src/metal/MetalHandles.mm +++ b/filament/backend/src/metal/MetalHandles.mm @@ -22,6 +22,8 @@ #include +#include + #include "private/backend/BackendUtils.h" #include diff --git a/filament/backend/src/vulkan/VulkanHandles.h b/filament/backend/src/vulkan/VulkanHandles.h index 8835d2b7b0..c6dbb71042 100644 --- a/filament/backend/src/vulkan/VulkanHandles.h +++ b/filament/backend/src/vulkan/VulkanHandles.h @@ -117,18 +117,18 @@ struct VulkanRenderPrimitive : public HwRenderPrimitive { }; struct VulkanFence : public HwFence { - VulkanFence(const VulkanCommandBuffer& commands) : fence(commands.fence) {} + explicit VulkanFence(const VulkanCommandBuffer& commands) : fence(commands.fence) {} std::shared_ptr fence; }; struct VulkanSync : public HwSync { - VulkanSync() {} - VulkanSync(const VulkanCommandBuffer& commands) : fence(commands.fence) {} + VulkanSync() = default; + explicit VulkanSync(const VulkanCommandBuffer& commands) : fence(commands.fence) {} std::shared_ptr fence; }; struct VulkanTimerQuery : public HwTimerQuery { - VulkanTimerQuery(VulkanContext& context); + explicit VulkanTimerQuery(VulkanContext& context); ~VulkanTimerQuery(); uint32_t startingQueryIndex; uint32_t stoppingQueryIndex;