Scarfski/filament
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Incorporate feedback from code review.

Browse Source
This commit is contained in:
Philip Rideout
2022-04-14 11:12:20 -07:00
parent 9aeec3a759
commit d52a24b6e9
9 changed files with 197 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
libs/imageio/src/BasisEncoder.cpp
View File

@@ -46,7 +46,6 @@ struct BasisEncoderImpl {
};
Builder::Builder(size_t mipCount, size_t layerCount) noexcept : mImpl(new BasisEncoderBuilderImpl) {
const size_t mipsPerImage = mipCount > 0 ? mipCount : 1;
const bool multiple = mImpl->params.m_source_images.size() > 1;
mImpl->params.m_tex_type = multiple ? basist::cBASISTexType2DArray : basist::cBASISTexType2D;
mImpl->params.m_uastc = true;
@@ -200,7 +199,7 @@ BasisEncoder::~BasisEncoder() noexcept {
basisu::basisu_encoder_deinit();
}
BasisEncoder::BasisEncoder(BasisEncoder&& that) noexcept {
BasisEncoder::BasisEncoder(BasisEncoder&& that) noexcept : mImpl(nullptr) {
std::swap(mImpl, that.mImpl);
}