Scarfski/filament
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

vk: fix VulkanPlatform CString usage (#9266) (#9260)

Browse Source 
Since #9259, CString in VulkanPlatform fall into the literal
constructor path. But we really want the null-terminated
(char const*) path.  So we cast the strings to (char const*)
to enforce null-teriminated behavior.

RDIFF_BRANCH=pf/renderdiff-add-tolerance
This commit is contained in:
Powei Feng
2025-09-26 16:42:56 -07:00
committed by GitHub
parent 33a4ab3d88
commit d8e8aafad7
7 changed files with 391 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
test/renderdiff/tests/sample.json
View File

@@ -25,6 +25,19 @@
// 'presets' field in the top-level struct.
"model": [], // [optional] List of models used in this test. The list is
// *appended* onto the lists provided by the presets.
"tolerance": { // [optional] Image comparison tolerance specification
"operator": "OR", // [optional] How to combine criteria: "AND" or "OR" (default: "AND")
"criteria": [
{
"max_pixel_diff": 3, // [optional] Max absolute difference per channel (0-255)
"allowed_diff_pixels": 1.0 // [optional] Percentage of pixels allowed to exceed (0-100%)
},
{
"max_pixel_diff_percent": 2.0, // [optional] Max difference as percentage (0-100%)
"allowed_diff_pixels": 0.5 // [optional] Percentage of pixels allowed to exceed (0-100%)
}
]
},
"rendering": { // [required] See description in 'presets'
"view.bloom.enabled": true,
"view.bloom.lensFlare": true