Scarfski/filament
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix huge memory allocation when decoding PNG, which can end up with std::bad_alloc (#43)

Browse Source
This commit is contained in:
emmcbd
2018-08-08 16:45:57 +02:00
committed by Romain Guy
parent bb75923b79
commit de1743c572
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
libs/imageio/src/ImageDecoder.cpp
View File

@@ -290,7 +290,7 @@ Image PNGDecoder::decode() {
uint32_t height = png_get_image_height(mPNG, mInfo);
size_t rowBytes = png_get_rowbytes(mPNG, mInfo);
imageData.reset(new uint8_t[width * height * rowBytes]);
imageData.reset(new uint8_t[height * rowBytes]);
std::unique_ptr<png_bytep[]> rowPointers(new png_bytep[height]);
for (size_t y = 0 ; y < height ; y++) {
rowPointers[y] = &imageData[y * rowBytes];