Scarfski/filament
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use utils::Status in MaterialParser (#9285)

Browse Source 
* Use utils::Status in MaterialParser

* Use utils::sstream instead of std::stringstream

* Remove remaining std::cerr and dep; update MaterialParser::reflectParameters

* make error message in utils::Status more generic

---------

Co-authored-by: Powei Feng <powei@google.com>
This commit is contained in:
yein
2025-10-07 11:27:11 -07:00
committed by GitHub
co-authored by Powei Feng
parent c839915a00
commit f52476a323
11 changed files with 554 additions and 535 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libs/utils/test/test_Status.cpp
+11 -5
View File
@@ -29,13 +29,13 @@ TEST(StatusTest, Constructor) {
std::string_view errorMessage = "invalid";
Status status(StatusCode::INVALID_ARGUMENT, errorMessage);
EXPECT_EQ(status.getCode(), StatusCode::INVALID_ARGUMENT);
EXPECT_EQ(status.getErrorMessage(), errorMessage);
EXPECT_EQ(status.getMessage(), errorMessage);
}
TEST(StatusTest, CopyOperator) {
Status status1 = Status::ok();
EXPECT_EQ(status1.getCode(), StatusCode::OK);
EXPECT_EQ(status1.getErrorMessage(), "");
EXPECT_EQ(status1.getMessage(), "");
Status status2(StatusCode::INTERNAL, "internal error");
status1 = status2;
@@ -52,14 +52,14 @@ TEST(StatusTest, CopyConstructor) {
TEST(StatusTest, MoveOperator) {
Status status;
EXPECT_EQ(status.getCode(), StatusCode::OK);
EXPECT_EQ(status.getErrorMessage(), "");
EXPECT_EQ(status.getMessage(), "");
std::string_view errorMessage = "internal error";
Status another(StatusCode::INTERNAL, errorMessage);
status = std::move(another);
EXPECT_EQ(status.getCode(), StatusCode::INTERNAL);
EXPECT_EQ(status.getErrorMessage(), errorMessage);
EXPECT_EQ(status.getMessage(), errorMessage);
}
TEST(StatusTest, MoveConstructor) {
@@ -68,7 +68,7 @@ TEST(StatusTest, MoveConstructor) {
Status moved(std::move(original));
EXPECT_EQ(moved.getCode(), StatusCode::INTERNAL);
EXPECT_EQ(moved.getErrorMessage(), errorMessage);
EXPECT_EQ(moved.getMessage(), errorMessage);
}
TEST(StatusTest, Equality) {
@@ -97,6 +97,12 @@ TEST(StatusTest, StaticOk) {
EXPECT_EQ(Status::ok(), expected);
}
TEST(StatusTest, StaticOkWithMessage) {
std::string_view supplementaryMessage = "some debug string";
Status expected(StatusCode::OK, supplementaryMessage);
EXPECT_EQ(Status::ok(supplementaryMessage), expected);
}
TEST(StatusTest, StaticInvalidArgumentError) {
std::string_view errorMessage = "invalid argument";
Status expected(StatusCode::INVALID_ARGUMENT, errorMessage);