Scarfski/filament
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

canonicalize id pass must always run last

Browse Source
This commit is contained in:
Mathias Agopian
2025-08-11 15:45:23 -07:00
committed by Mathias Agopian
parent a6d5231beb
commit f85955f77b
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libs/filamat/src/GLSLPostProcessor.cpp
+5 -2
View File
@@ -998,6 +998,11 @@ std::shared_ptr<Optimizer> GLSLPostProcessor::createOptimizer(
}
void GLSLPostProcessor::optimizeSpirv(OptimizerPtr optimizer, SpirvBlob& spirv) {
// always add the CanonicalizeIds Pass
optimizer->RegisterPass(CreateCanonicalizeIdsPass());
// run optimizer
if (!optimizer->Run(spirv.data(), spirv.size(), &spirv)) {
slog.e << "SPIR-V optimizer pass failed" << io::endl;
return;
@@ -1090,7 +1095,6 @@ void GLSLPostProcessor::registerPerformancePasses(Optimizer& optimizer, Config c
RegisterPass(CreateDeadBranchElimPass());
RegisterPass(CreateBlockMergePass());
RegisterPass(CreateSimplificationPass(), MaterialBuilder::TargetApi::METAL);
RegisterPass(CreateCanonicalizeIdsPass());
}
void GLSLPostProcessor::registerSizePasses(Optimizer& optimizer, Config const& config) {
@@ -1133,7 +1137,6 @@ void GLSLPostProcessor::registerSizePasses(Optimizer& optimizer, Config const& c
RegisterPass(CreateRedundancyEliminationPass());
RegisterPass(CreateAggressiveDCEPass());
RegisterPass(CreateCFGCleanupPass());
RegisterPass(CreateCanonicalizeIdsPass());
}
} // namespace filamat