Since #9259, CString in VulkanPlatform fall into the literal
constructor path. But we really want the null-terminated
(char const*) path. So we cast the strings to (char const*)
to enforce null-teriminated behavior.
RDIFF_BRANCH=pf/renderdiff-add-tolerance
- Move upload step to later so that comparison result is also
included in the upload
- Fix the wrong relative paths in the comparison_result.json
- Fix viewer logic to pick only the latest run for a PR.
- Modify the compare script to output more details of a
comparison. This will include the source/golden directory,
the comparison directory (the new renderings), and a file
path to difference images if the golden does not match
the rendered image.
- The image_diff script can now output a TIFF that is the
difference of two input TIFFs.
- Add a viewer for examining the differences between rendered
output and golden images.
- The viewer consists of a simple server of web API endpoints
for querying difference results (along with rendered images
in TIFF).
- And a web-based (html + lit-element) UI for looking at the
rendered images and differences.
- Move the comparison logic into its own script
- Add entry point bash script to generate the renderings
- Separate the preamble bash logic into its own file