Scarfski/filament
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1,346 Commits 164 Branches 274 Tags
e2c3dfd34174e21be3e9f3488db32fcd847dfc21
Commit Graph

60 Commits

Author SHA1 Message Date
Romain Guy
cabdc255f5 Shader code cleanup 
roughness is now called perceptualRoughness and linearRoughness
is now called roughness. It better matches papers, etc.
 2019-05-20 14:45:26 -07:00
Romain Guy
88098f99b9 Fix typo in equation 138 2019-04-16 13:39:24 -07:00
Romain Guy
4738e93b83 Replace Cloth DFG approximation with DFG LUT 
By removing the Fresnel term (often ommitted from fabric/cloth BRDFs)
we can store the DG term for the cloth BRDF in the 3rd channel of the
existing DFG LUT.
 2019-02-21 11:44:52 -08:00
Romain Guy
6f9df5bfab Update incorrect equations of importance sampling 2019-02-19 17:59:39 -08:00
Romain Guy
42acac02c0 Update documentation 
Add titles and use energy preservation vs conservation to describe
two different concepts.
 2019-02-15 09:26:52 +00:00
François Guthmann
8253006899 Typo correction 
Switched arguments in prefilteredDFG_LUT call to align with function definition in the documentation and in the code.
 2019-02-08 10:24:15 -08:00
Romain Guy
81a52411ed Clarify Fresnel term for IBL implementation of clear coat 2019-01-25 13:49:44 -08:00
François Guthmann
9915ec7841 EV100 formula typo (#543) 
Forgot the parenthesis when I corrected it, I'm sorry...
 2018-11-28 09:31:13 -08:00
François Guthmann
78804251e9 Corrected typo in formula (#519) 
It looks like there is a minus sign missing in there, see https://www.wolframalpha.com/input/?i=(((1%2Bsqrt(x))+%2F+(1+-+sqrt(x)))+-+1.5)+%2F+(((1%2Bsqrt(x))+%2F+(1+-+sqrt(x)))+%2B+1.5)

I'm not sure what the code does though https://github.com/google/filament/blob/master/shaders/src/brdf.fs#L282
 2018-11-23 10:09:54 -08:00
François Guthmann
5a402dc6a8 Corrected exposure from ev100 formula (#518) 
The new formula should be the correct one according to this document (first line p86): https://seblagarde.files.wordpress.com/2015/07/course_notes_moving_frostbite_to_pbr_v32.pdf
 2018-11-22 10:03:29 -08:00
Vallentin
81e8035cbb Fixed typos (#487) 2018-11-14 09:19:04 -08:00
Romain Guy
bb3e9a47e5 Update link to CIE colormetric tables 
Fixes #452
 2018-11-05 15:53:41 -08:00
Mathias Agopian
3bf0d6a4ab document artifacts due to giving up mipmaps (#299) 
* document artifacts due to giving up mipmaps

- also talk about lod remapping
- try to avoid to confuse alpha with roughness

* fix typos
 2018-09-24 16:14:52 -07:00
Mathias Agopian
22f7599e73 Try to clarify the sections about cubemaps (#296) 
* Try to clarify the sections about cubemaps

* fix typos and spelling

* don’t mention filament’s APIs by name
 2018-09-24 12:54:22 -07:00
Romain Guy
234dbaf00b Clarify IBL evaluation steps 2018-09-19 18:50:48 -07:00
Mathias Agopian
670d9986f3 fix typo and improve language in important sampling doc (#271) 2018-09-19 10:44:26 -07:00
Mathias Agopian
a14ceb5dca better explanation of the Jacobian used in importance sampling 2018-09-18 22:57:54 -07:00
Mathias Agopian
0f5e501dda Add images illustrating IBL prefiltering errors. (#268) 2018-09-18 19:08:21 -07:00
Mathias Agopian
df0594872e rewrite IBL prefiltering documentation 2018-09-18 14:45:47 -07:00
Mathias Agopian
cb88609015 fix @romainguy comments and improve equations 2018-09-18 14:45:47 -07:00
Mathias Agopian
d3e6fa1005 WIP: better explication of the “split-sum” 
DO NOT MERGE
 2018-09-18 14:45:47 -07:00
Romain Guy
e4c9fd2ac1 Fix documentation typos 2018-09-18 10:33:40 -07:00
Romain Guy
41d70cb30a Fix anisotropy BRDF on mobile (#245) 
mediump computations are not enough for certain roughness values.
 2018-09-13 18:31:08 -07:00
Romain Guy
cc102be69f Fix docs typo 
Closes #228
 2018-09-10 10:19:16 -07:00
A. Tombs
f78a680b9c Documentation grammar and typo fixes (#174) 
* Missing parameter in visibility function equation

The visibility function V_1 depends on l (or v) and alpha, but alpha was omitted in one equation.

* Fix typo its vs it is

* Fix typo usign -> using

* Fix typo algorightm -> algorithm

* Fix typo later -> latter

* Grammar: much less -> many fewer

* Fix missing equation label

Equation was referred to in the text, but did not have its label defined, causing the reference to show up as ???.

* Fix typo itentiy -> itentity

* Fix typo apperance -> appearance

* Fix typo participe -> participate

* Fix typo: scaterring -> scattering

* Consistency: grey -> gray

Since the document mostly uses American English, replace occurrences of "grey" (preferred spelling in UK) with "gray" (preferred spelling in US).

* Fix typo: interemdiate -> intermediate

* Fix typo: anistropic -> anisotropic

* Style: gaussian -> Gaussian

* Fix typo: particulary -> particularly

* Fix typo: subsitution -> substitution

* Fix typo: fomulate -> formulate

* Fix typo: evector -> vector

* Fix typo: tempetature -> temperature

* Fix typo: ar -> at

* Style: lambertian -> Lambertian

* Fix typo: disapears -> disappears

* Fix typo: acounting -> accounting

* Fix typo: simplificationss -> simplifications

* Fix typo: subsitute -> substitute

* Style: light saber -> lightsaber

* Fix typo: cooordinates -> coordinates

* Fix typo: probaility -> probability

* Fix typo: Hammersely -> Hammersley

* Fix typo: Mistuba -> Mitsuba
 2018-08-28 11:35:53 -07:00
Romain Guy
88fb551d30 Explains sq() in code snippet 
Closes #171
 2018-08-28 10:57:59 -07:00
Romain Guy
d74811d5e7 Fix typo in multiscatter equation 
Fixes #167
 2018-08-28 09:01:36 -07:00
Romain Guy
89743004f3 Use n instead of shading_normal 2018-08-27 13:35:21 -07:00
Romain Guy
1740f23be4 Remove unnecessary code 2018-08-27 13:34:43 -07:00
Romain Guy
4c2b538422 Explain fp16 transform of the NDF 2018-08-27 13:32:14 -07:00
Tim van Scherpenzeel
966d1e5de2 fixed three small spelling mistakes (#149) 2018-08-26 10:01:41 -07:00
Romain Guy
f8c87f8f81 Update screenshots 2018-08-22 16:29:32 -07:00
Romain Guy
d237406ccd Clean up multiscatter and single scatter specular combination 2018-08-22 15:58:04 -07:00
Romain Guy
b587ec3f43 Fix revision formatting 2018-08-21 15:55:48 -07:00
Romain Guy
b86928179b Document energy compensation for multiscattering BRDFs (#121) 
* Document better BRDFs

- Document the loss of energy in the specular BRDF
- Start documenting the gain of energy in the diffuse BRDF

* Explain energy compensation with second scaled lobe

* Add multiscattering pre-integration
 2018-08-21 15:51:54 -07:00
Romain Guy
424fd3a6e6 Add more f0 sample values 2018-08-20 14:53:35 -07:00
Romain Guy
ae1ad6f8b0 Describe F a bit more 2018-08-17 12:06:20 -07:00
Romain Guy
7a296f3d6b Add revisions section to the documentation 2018-08-17 10:09:08 -07:00
Romain Guy
f3e0137c2b Fix misguiding comments in the docs 2018-08-16 18:25:10 -07:00
Romain Guy
70f5bc4291 Add section on specular colors 
It explains how to compute f0 for conductors from measured spectral data.
 2018-08-16 16:10:13 -07:00
Romain Guy
24dc24ce86 Add explanations about the Fresnel term 2018-08-15 13:13:48 -07:00
Omar Shehata
41bbac7098 Fix typo (#85) 
Fixing a typo in the overview section.
 2018-08-13 07:44:31 -07:00
Romain Guy
6b1788fc6e Add about section 2018-08-09 16:06:50 -07:00
Romain Guy
202ce993af Document pre-exposed lights 
Fixes various mistakes
Add link to the GitHub project
Document the IBL specular in the cloth section
 2018-08-09 10:18:51 -07:00
Romain Guy
128ab657df Switch cloth model from Ashikhmin NDF to "Charlie" NDF (#53) 
* Add new Cloth NDF

Based on the work by Estevez and Kulla, also known as the "Charlie" sheen.

* Restore DFG computation to GGX

* New proposed approximation for Cloth DFG

* Add "Charlie" cloth DFG approximation to cmgen

* Switch to "Charlie" sheen for cloth shading

* Document the new cloth NDF and DFG approximation
 2018-08-08 17:22:41 -07:00
Romain Guy
86bfcf9afa Fix several typos in Filament.md.html 2018-08-07 09:35:19 -07:00
Romain Guy
55476e97f0 Fix clear coat attenuation for direct lighting 
The diffuse term was erroneously multiplied by (1-Fc)^2 after a previous refactoring. The documentation was correct.
 2018-08-05 00:10:04 -07:00
Romain Guy
c9babb32e6 Fix typo in clear coat IBL docs 2018-08-04 23:43:29 -07:00
Romain Guy
ef9eabf773 Clarify the attenuation term in the clear coat model 2018-08-04 23:30:22 -07:00
Romain Guy
680ec9c796 Fix the link to the Spherical Harmonics section 2018-08-04 23:26:02 -07:00