Merge branch 'rc/1.9.3' into release

.github/ISSUE_TEMPLATE/bug_report.md

@@ -17,10 +17,6 @@ A clear and concise description of what you expected to happen.
 **Screenshots**
 If applicable, add screenshots to help explain your problem.
 
-**Logs**
-If applicable, copy logs from your console here. Please *do not*
-use screenshots of logs, copy them as text.
-
 **Desktop (please complete the following information):**
  - OS: [e.g. iOS]
  - GPU: [e.g. NVIDIA GTX 1080]

.github/actions/verify-release-notes/Dockerfile

@@ -1,10 +0,0 @@
-FROM python:3.10.4
-
-RUN pip3 install pygithub==1.55
-
-ENV PYTHONUNBUFFERED=1
-
-COPY verify_release_notes.py /verify_release_notes.py
-
-RUN chmod +x /verify_release_notes.py
-ENTRYPOINT [ "/verify_release_notes.py" ]

.github/actions/verify-release-notes/action.yml

@@ -1,35 +0,0 @@
-name: 'Verify Release Notes'
-description: 'Verifies that a RELEASE_NOTES file has been modified'
-inputs:
-  repo-token:
-    description: 'The GitHub token'
-    required: true
-  pull-request-number:
-    description: 'The Pull Request number'
-    required: true
-  bypass-label-name:
-    description: 'The Label used to bypass this check'
-    required: false
-    default: 'internal'
-  release-notes-file:
-    description: 'The path to the RELEASE_NOTES file'
-    required: false
-    default: 'RELEASE_NOTES.md'
-  pull-request-repo-full-name:
-    description: 'The full name of the Pull Request repo'
-    required: false
-    default: ${{ github.event.pull_request.head.repo.full_name }}
-  pull-request-head-ref:
-    description: 'The HEAD ref of the Pull Request'
-    required: false
-    default: ${{ github.event.pull_request.head.ref }}
-runs:
-  using: 'docker'
-  image: 'Dockerfile'
-  args:
-    - ${{ inputs.repo-token }}
-    - ${{ inputs.pull-request-number }}
-    - ${{ inputs.bypass-label-name }}
-    - ${{ inputs.release-notes-file }}
-    - ${{ inputs.pull-request-repo-full-name }}
-    - ${{ inputs.pull-request-head-ref }}

.github/actions/verify-release-notes/verify_release_notes.py

@@ -1,100 +0,0 @@
-#!/usr/bin/env python3
-
-# Copyright (C) 2022 The Android Open Source Project
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#      http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-from github import Github
-import sys, os
-
-def print_usage():
-    print('Verify that a GitHub pull request modifies a RELEASE_NOTES file')
-    print()
-    print('Usage:')
-    print('  verify_release_notes.py [arguments]')
-    print()
-    print('Arguments:')
-    print('1. github token')
-    print('2. pull request number')
-    print('3. bypass label name')
-    print('4. release notes file path')
-    print('5. pull request repo full name')
-    print('6. pull request head ref')
-    print()
-    print('The GITHUB_REPOSITORY environment variable must be set (e.g., google/filament).')
-
-def leave_single_comment(pull_request, comment_body):
-    """ Leaves a comment on a PR once, without leaving a duplicate comment. """
-    # To avoid spamming the PR author, we'll use this comment tag (which will render invisibly on
-    # GitHub) to check if we've already left a comment on this PR.
-    COMMENT_TAG = '<!-- verify_release_notes -->\n'
-    comments = pull_request.get_issue_comments()
-    for comment in comments:
-        if comment.body.find(COMMENT_TAG) != -1:
-            return
-    # The GitHub token may not have WRITE permissions to leave a comment (for example, for 3P
-    # contributors). In that case, we simply won't leave a comment.
-    try:
-        pull_request.create_issue_comment(f'{COMMENT_TAG}{comment_body}')
-    except:
-        print("Unable to leave comment. Continuing.")
-
-# The first argument is the path to this script.
-if len(sys.argv) != 7:
-    print_usage()
-    sys.exit(1)
-
-authentication_token = sys.argv[1]
-pull_number = sys.argv[2]
-bypass_label_name = sys.argv[3]
-release_notes_file = sys.argv[4]
-pr_repo_full_name = sys.argv[5]
-pr_head_ref = sys.argv[6]
-
-g = Github(authentication_token)
-
-repo_name = os.environ.get('GITHUB_REPOSITORY')
-if repo_name is None:
-    print("The GITHUB_REPOSITORY environment variable must be set.")
-    sys.exit(1)
-
-repo = g.get_repo(repo_name)
-
-pull_request = repo.get_pull(int(pull_number))
-
-# First check if the PR has the "bypass" label. This label is used for PRs that don't need to update
-# RELEASE_NOTES. If so, we can exit immediately.
-labels = [l.name for l in pull_request.labels]
-if bypass_label_name in labels:
-    print(f"PR number {pull_number} in repo {repo_name} contains the '{bypass_label_name}' label.")
-    print("Exiting with success.")
-    sys.exit(0)
-
-# Next, check if the release notes file (RELEASE_NOTES.md or similar) has been modified.
-files = pull_request.get_files()
-for file in files:
-    if file.filename == release_notes_file:
-        print(f"PR number {pull_number} in repo {repo_name} modifies '{release_notes_file}'.")
-        print("Exiting with success.")
-        sys.exit(0)
-
-# At this point, we issue a warning to the PR author to remember to modify the release notes, and
-# exit with failure.
-edit_url = f"https://github.com/{pr_repo_full_name}/edit/{pr_head_ref}/{release_notes_file}"
-comment = (f"Please add a release note line to [{release_notes_file}]({edit_url}). "
-    f"If this PR does not warrant a release note, add the '{bypass_label_name}' label "
-    f"to this PR.")
-print(comment)
-leave_single_comment(pull_request, comment)
-
-sys.exit(1)

.github/workflows/android-continuous.yml

@@ -33,6 +33,10 @@ jobs:
         with:
           name: gltfio-android-release
           path: out/gltfio-android-release.aar
+      - uses: actions/upload-artifact@v1.0.0
+        with:
+          name: gltfio-android-lite-release
+          path: out/gltfio-android-lite-release.aar
       - uses: actions/upload-artifact@v1.0.0
         with:
           name: filament-utils-android-release

.github/workflows/linux-continuous.yml

@@ -10,7 +10,7 @@ on:
 jobs:
   build-linux:
     name: build-linux
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-latest
 
     steps:
       - uses: actions/checkout@v2.0.0

.github/workflows/mac-continuous.yml

@@ -21,6 +21,3 @@ jobs:
         with:
           name: filament-mac
           path: out/filament-release-darwin.tgz
-      - name: Check public headers
-        run: |
-          build/common/check-headers.sh out/release/filament/include

.github/workflows/presubmit.yml

@@ -1,12 +1,6 @@
 name: Presubmit
 
-on:
-  push:
-    branches:
-    - main
-  pull_request:
-    branches:
-    - main
+on: [pull_request]
 
 jobs:
   build-desktop:
@@ -15,7 +9,7 @@ jobs:
 
     strategy:
       matrix:
-        os: [macos-latest, ubuntu-18.04]
+        os: [macos-latest, ubuntu-latest]
 
     steps:
       - uses: actions/checkout@v2.0.0
@@ -29,7 +23,7 @@ jobs:
 
   build-windows:
     name: build-windows
-    runs-on: windows-2019
+    runs-on: windows-latest
 
     steps:
       - uses: actions/checkout@v2.0.0

.github/workflows/release.yml

@@ -1,25 +1,14 @@
 name: Release
 
 # This Workflow can be triggered two ways:
-# 1. A GitHub release is created (using the GitHub web UI). This triggers all of the platforms to
-# build and upload assets.
-# 2. A workflow_dispatch event is triggered from the GitHub web UI. This triggers a build for only
-# the platform specified in the dispatch event.
+# 1. A GitHub release is created (using the GitHub web UI). This triggers all of the platforms to build and upload assets.
+# 2. A repository_dispatch API event is sent. This triggers a build for only the platform specified in the dispatch event.
 
 env:
-  RELEASE_TAG: ${{ github.event.inputs.release_tag }}
+  RELEASE_TAG: ${{ github.event.client_payload.release_tag }}
 
 on:
-  workflow_dispatch:
-    inputs:
-      platform:
-        description: 'Platform to build (desktop, web, android, ios, windows)'
-        required: true
-        default: 'desktop'
-      release_tag:
-        description: 'Release tag to build (e.g., v1.13.0)'
-        required: true
-        default: 'v1.13.0'
+  repository_dispatch:
   release:
     types: [created]
 
@@ -27,11 +16,11 @@ jobs:
   build-desktop:
     name: build-desktop
     runs-on: ${{ matrix.os }}
-    if: github.event_name == 'release' || github.event.inputs.platform == 'desktop'
+    if: github.event_name == 'release' || github.event.client_payload.platform == 'desktop'
 
     strategy:
       matrix:
-        os: [macos-latest, ubuntu-18.04]
+        os: [macos-latest, ubuntu-latest]
 
     steps:
       - name: Decide Git ref
@@ -39,8 +28,8 @@ jobs:
         run: |
           REF=${RELEASE_TAG:-${GITHUB_REF}}
           TAG=${REF##*/}
-          echo "ref=${REF}" >> $GITHUB_OUTPUT
-          echo "tag=${TAG}" >> $GITHUB_OUTPUT
+          echo ::set-output name=ref::${REF}
+          echo ::set-output name=tag::${TAG}
       - uses: actions/checkout@v2.0.0
         with:
           ref: ${{ steps.git_ref.outputs.ref }}
@@ -50,7 +39,8 @@ jobs:
           cd build/$WORKFLOW_OS && printf "y" | ./build.sh release
       - name: Upload release assets
         run: |
-          xargs -L 1 sudo pip3 install < build/common/requirements.txt
+          pip3 install setuptools
+          pip3 install PyGithub
           if [ -f out/filament-release-darwin.tgz ]; then mv out/filament-release-darwin.tgz out/filament-${TAG}-mac.tgz; fi;
           if [ -f out/filament-release-linux.tgz ]; then mv out/filament-release-linux.tgz out/filament-${TAG}-linux.tgz; fi;
           python3 build/common/upload-assets.py ${TAG} out/*.tgz
@@ -61,7 +51,7 @@ jobs:
   build-web:
     name: build-web
     runs-on: macos-latest
-    if: github.event_name == 'release' || github.event.inputs.platform == 'web'
+    if: github.event_name == 'release' || github.event.client_payload.platform == 'web'
 
     steps:
       - name: Decide Git ref
@@ -69,8 +59,8 @@ jobs:
         run: |
           REF=${RELEASE_TAG:-${GITHUB_REF}}
           TAG=${REF##*/}
-          echo "ref=${REF}" >> $GITHUB_OUTPUT
-          echo "tag=${TAG}" >> $GITHUB_OUTPUT
+          echo ::set-output name=ref::${REF}
+          echo ::set-output name=tag::${TAG}
       - uses: actions/checkout@v2.0.0
         with:
           ref: ${{ steps.git_ref.outputs.ref }}
@@ -79,7 +69,8 @@ jobs:
           cd build/web && printf "y" | ./build.sh release
       - name: Upload release assets
         run: |
-          xargs -L 1 sudo pip3 install < build/common/requirements.txt
+          pip3 install setuptools
+          pip3 install PyGithub
           mv out/filament-release-web.tgz out/filament-${TAG}-web.tgz
           python3 build/common/upload-assets.py ${TAG} out/*.tgz
         env:
@@ -89,7 +80,7 @@ jobs:
   build-android:
     name: build-android
     runs-on: macos-latest
-    if: github.event_name == 'release' || github.event.inputs.platform == 'android'
+    if: github.event_name == 'release' || github.event.client_payload.platform == 'android'
 
     steps:
       - name: Decide Git ref
@@ -97,37 +88,26 @@ jobs:
         run: |
           REF=${RELEASE_TAG:-${GITHUB_REF}}
           TAG=${REF##*/}
-          echo "ref=${REF}" >> $GITHUB_OUTPUT
-          echo "tag=${TAG}" >> $GITHUB_OUTPUT
+          echo ::set-output name=ref::${REF}
+          echo ::set-output name=tag::${TAG}
       - uses: actions/checkout@v2.0.0
         with:
           ref: ${{ steps.git_ref.outputs.ref }}
       - name: Run build script
         run: |
           cd build/android && printf "y" | ./build.sh release
-      - name: Sign sample-gltf-viewer
-        run: |
-          echo "${APK_KEYSTORE_BASE64}" > filament.jks.base64
-          base64 --decode filament.jks.base64 > filament.jks
-          BUILD_TOOLS_VERSION=$(ls ${ANDROID_HOME}/build-tools | sort -V | tail -n 1)
-          APKSIGNER=${ANDROID_HOME}/build-tools/${BUILD_TOOLS_VERSION}/apksigner
-          IN_FILE="out/sample-gltf-viewer-release.apk"
-          OUT_FILE="out/filament-gltf-viewer-${TAG}-android.apk"
-          ${APKSIGNER} sign --ks filament.jks --key-pass=pass:${APK_KEYSTORE_PASS} --ks-pass=pass:${APK_KEYSTORE_PASS} --in ${IN_FILE} --out ${OUT_FILE}
-          rm "${IN_FILE}"
-        env:
-          TAG: ${{ steps.git_ref.outputs.tag }}
-          APK_KEYSTORE_BASE64: ${{ secrets.APK_KEYSTORE_BASE64 }}
-          APK_KEYSTORE_PASS: ${{ secrets.APK_KEYSTORE_PASS }}
       - name: Upload release assets
         run: |
-          xargs -L 1 sudo pip3 install < build/common/requirements.txt
+          pip3 install setuptools
+          pip3 install PyGithub
           mv out/filament-android-release.aar out/filament-${TAG}-android.aar
           mv out/filamat-android-release.aar out/filamat-${TAG}-android.aar
           mv out/filamat-android-lite-release.aar out/filamat-${TAG}-lite-android.aar
           mv out/gltfio-android-release.aar out/gltfio-${TAG}-android.aar
+          mv out/gltfio-android-lite-release.aar out/gltfio-${TAG}-lite-android.aar
           mv out/filament-utils-android-release.aar out/filament-utils-${TAG}-android.aar
-          python3 build/common/upload-assets.py ${TAG} out/*.aar out/*.apk
+          mv out/filament-utils-android-lite-release.aar out/filament-utils-${TAG}-lite-android.aar
+          python3 build/common/upload-assets.py ${TAG} out/*.aar
         env:
           TAG: ${{ steps.git_ref.outputs.tag }}
           GITHUB_API_KEY: ${{ secrets.GITHUB_API_KEY }}
@@ -135,7 +115,7 @@ jobs:
   build-ios:
     name: build-ios
     runs-on: macos-latest
-    if: github.event_name == 'release' || github.event.inputs.platform == 'ios'
+    if: github.event_name == 'release' || github.event.client_payload.platform == 'ios'
 
     steps:
       - name: Decide Git ref
@@ -143,8 +123,8 @@ jobs:
         run: |
           REF=${RELEASE_TAG:-${GITHUB_REF}}
           TAG=${REF##*/}
-          echo "ref=${REF}" >> $GITHUB_OUTPUT
-          echo "tag=${TAG}" >> $GITHUB_OUTPUT
+          echo ::set-output name=ref::${REF}
+          echo ::set-output name=tag::${TAG}
       - uses: actions/checkout@v2.0.0
         with:
           ref: ${{ steps.git_ref.outputs.ref }}
@@ -153,7 +133,8 @@ jobs:
           cd build/ios && printf "y" | ./build.sh release
       - name: Upload release assets
         run: |
-          xargs -L 1 sudo pip3 install < build/common/requirements.txt
+          pip3 install setuptools
+          pip3 install PyGithub
           mv out/filament-release-ios.tgz out/filament-${TAG}-ios.tgz
           python3 build/common/upload-assets.py ${TAG} out/*.tgz
         env:
@@ -162,8 +143,8 @@ jobs:
 
   build-windows:
     name: build-windows
-    runs-on: windows-2019
-    if: github.event_name == 'release' || github.event.inputs.platform == 'windows'
+    runs-on: windows-latest
+    if: github.event_name == 'release' || github.event.client_payload.platform == 'windows'
 
     steps:
       - name: Decide Git ref
@@ -171,8 +152,8 @@ jobs:
         run: |
           REF=${RELEASE_TAG:-${GITHUB_REF}}
           TAG=${REF##*/}
-          echo "ref=${REF}" >> $GITHUB_OUTPUT
-          echo "tag=${TAG}" >> $GITHUB_OUTPUT
+          echo ::set-output name=ref::${REF}
+          echo ::set-output name=tag::${TAG}
         shell: bash
       - uses: actions/checkout@v2.0.0
         with:

.github/workflows/verify-release-notes.yml

@@ -1,26 +0,0 @@
-name: Verify Release Notes
-
-on:
-  pull_request:
-    branches:
-      - main
-    types: [opened, synchronize, reopened, labeled]
-
-jobs:
-  verify-release-notes:
-    name: Verify Release Notes
-    runs-on: ubuntu-latest
-    steps:
-      # We *only* need to check out the .github/ directory.
-      # The verify RELEASE_NOTES script uses the GitHub API to verify that RELEASE_NOTES was
-      # modified.
-      - name: Check out action
-        uses: Bhacaz/checkout-files@73e17cfbe8d7e0c6b2672b20cb05a718e20d18d4
-        with:
-          files: .github
-          token: ${{ secrets.GITHUB_TOKEN }}
-      - name: Verify release notes
-        uses: ./.github/actions/verify-release-notes
-        with:
-          repo-token: ${{ secrets.GITHUB_TOKEN }}
-          pull-request-number: ${{ github.event.pull_request.number }}

.github/workflows/windows-continuous.yml

@@ -10,7 +10,7 @@ on:
 jobs:
   build-windows:
     name: build-windows
-    runs-on: windows-2019
+    runs-on: windows-latest
 
     steps:
       - uses: actions/checkout@v2.0.0

.gitignore

@@ -12,7 +12,3 @@ filament/docs/html/**
 *tmp*.png
 civetweb.txt
 /TAGS
-settings.json
-test*.png
-test*.json
-results

BRANCHING.md

@@ -27,3 +27,55 @@ Bugs are defined as one of the following _introduced since the prior release_:
 - unintentional public API changes
 
 For example, a long-standing crash just recently discovered would not necessitate a bug fix PR.
+
+## Creating a GitHub Release
+
+Be sure to choose the *release* branch when drafting a GitHub release.
+
+## Git Commands
+
+These commands assume a release candidate branch called *rc/1.9.0*.
+
+### Creating a Release Candidate Branch
+
+```
+$ git checkout main
+$ git pull
+$ git branch rc/1.9.0
+$ git push origin rc/1.9.0
+```
+
+### Merging the Release Candidate Branch Into Release
+
+There may be temporary hotfixes in the release branch that should be overriden by the new release
+candidate. To accomplish this, we first merge release into rc using the _ours_ strategy. Then we
+merge rc into release.
+
+```
+$ git checkout rc/1.9.0
+$ git pull
+$ git fetch origin release:release
+$ git merge -s ours release
+$ git checkout release
+$ git merge --no-ff rc/1.9.0
+$ git push origin release
+```
+
+### Deleting the Release Candidate Branch
+
+```
+$ git branch -d rc/1.9.0
+$ git push origin --delete rc/1.9.0
+```
+
+### See a History of the Release Branch
+
+```
+$ git log --oneline --first-parent
+
+442b061 (HEAD -> release) Merge branch 'rc/1.9.2' into release
+ac50d21 Hotfix
+94dc2f7 Hotfix
+b34ed5b Merge branch 'rc/1.9.1' into release
+aeef498 Merge branch 'rc/1.9.0' into release
+```

BUILDING.md

@@ -4,23 +4,29 @@
 
 To build Filament, you must first install the following tools:
 
-- CMake 3.19 (or more recent)
+- CMake 3.10 (or more recent)
 - clang 7.0 (or more recent)
-- [ninja 1.10](https://github.com/ninja-build/ninja/wiki/Pre-built-Ninja-packages) (or more recent)
+- [ninja 1.8](https://github.com/ninja-build/ninja/wiki/Pre-built-Ninja-packages) (or more recent)
+
+To build the Java based components of the project you can optionally install (recommended):
+
+- OpenJDK 1.8 (or more recent)
 
 Additional dependencies may be required for your operating system. Please refer to the appropriate
 section below.
 
 To build Filament for Android you must also install the following:
 
-- Android Studio Arctic Fox or more recent
+- Android Studio 4.0.1 or more recent
 - Android SDK
-- Android NDK 25.1 or higher
+- Android NDK "side-by-side" 21.3 or higher
 
 ### Environment variables
 
-To build Filament for Android, make sure the environment variable `ANDROID_HOME` points to the
-location of your Android SDK.
+Make sure the environment variable `ANDROID_HOME` points to the location of your Android SDK.
+
+By default our build system will attempt to compile the Java bindings. To do so, the environment
+variable `JAVA_HOME` should point to the location of your JDK.
 
 When building for WebGL, you'll also need to set `EMSDK`. See [WebAssembly](#webassembly).
 
@@ -59,13 +65,25 @@ To install the libraries and executables in `out/debug/` and `out/release/`, add
 You can force a clean build by adding the `-c` flag. The script offers more features described
 by executing `build.sh -h`.
 
+### Disabling Java builds
+
+By default our build system will attempt to compile the Java bindings. If you wish to skip this
+compilation step simply pass the `-j` flag to `build.sh`:
+
+```
+$ ./build.sh -j release
+```
+
+If you use CMake directly instead of the build script, pass `-DFILAMENT_ENABLE_JAVA=OFF`
+to CMake instead.
+
 ### Filament-specific CMake Options
 
 The following CMake options are boolean options specific to Filament:
 
+- `FILAMENT_ENABLE_JAVA`:          Compile Java projects: requires a JDK and the JAVA_HOME env var
 - `FILAMENT_ENABLE_LTO`:           Enable link-time optimizations if supported by the compiler
 - `FILAMENT_BUILD_FILAMAT`:        Build filamat and JNI buildings
-- `FILAMENT_SUPPORTS_OPENGL`:      Include the OpenGL backend
 - `FILAMENT_SUPPORTS_METAL`:       Include the Metal backend
 - `FILAMENT_SUPPORTS_VULKAN`:      Include the Vulkan backend
 - `FILAMENT_INSTALL_BACKEND_TEST`: Install the backend test library so it can be consumed on iOS
@@ -144,8 +162,13 @@ make sure the command line tools are setup by running:
 $ xcode-select --install
 ```
 
-If you wish to run the Vulkan backend instead of the default Metal backend, you must install
-the LunarG SDK, enable "System Global Components", and reboot your machine.
+After installing Java 1.8 you must also ensure that your `JAVA_HOME` environment variable is
+properly set. If it doesn't already point to the appropriate JDK, you can simply add the following
+to your `.profile`:
+
+```
+export JAVA_HOME="$(/usr/libexec/java_home)"
+```
 
 Then run `cmake` and `ninja` to trigger a build:
 
@@ -294,11 +317,11 @@ Alternatively you can build the AAR from the command line by executing the follo
 `android/` directory:
 
 ```
-$ ./gradlew -Pcom.google.android.filament.dist-dir=../../out/android-release/filament assembleRelease
+$ ./gradlew -Pfilament_dist_dir=../../out/android-release/filament assembleRelease
 ```
 
-The `-Pcom.google.android.filament.dist-dir` can be used to specify a different installation
-directory (it must match the CMake install prefix used in the previous steps).
+The `-Pfilament_dist_dir` can be used to specify a different installation directory (it must match
+the CMake install prefix used in the previous steps).
 
 #### Using Filament's AAR
 
@@ -352,7 +375,7 @@ same version that our continuous builds use.
 
 ```
 cd <your chosen parent folder for the emscripten SDK>
-curl -L https://github.com/emscripten-core/emsdk/archive/refs/tags/3.1.15.zip > emsdk.zip
+curl -L https://github.com/emscripten-core/emsdk/archive/1.39.19.zip > emsdk.zip
 unzip emsdk.zip ; mv emsdk-* emsdk ; cd emsdk
 python ./emsdk.py install latest
 python ./emsdk.py activate latest
@@ -368,11 +391,13 @@ export EMSDK=<your chosen home for the emscripten SDK>
 
 The EMSDK variable is required so that the build script can find the Emscripten SDK. The build
 creates a `samples` folder that can be used as the root of a simple static web server. Note that you
-cannot open the HTML directly from the filesystem due to CORS. We recommend using the emrun tool
-to create a quick localhost server:
+cannot open the HTML directly from the filesystem due to CORS. One way to deal with this is to
+use Python to create a quick localhost server:
 
 ```
-emrun out/cmake-webgl-release/web/samples --no_browser --port 8000
+cd out/cmake-webgl-release/web/samples
+python3 -m http.server     # Python 3
+python -m SimpleHTTPServer # Python 2.7
 ```
 
 You can then open http://localhost:8000/suzanne.html in your web browser.
@@ -397,13 +422,12 @@ filamesh ./assets/models/monkey/monkey.obj monkey.filamesh
 ```
 
 Most samples accept an IBL that must be generated using the `cmgen` tool (`./tools/filamesh/cmgen`
-in your build directory). These sample apps expect a path to a directory containing the `.rgb32f`
-files for the IBL (which are PNGs containing `R11F_G11F_B10F` data) or a path to a directory
-containing two `.ktx` files (one for the IBL itself, one for the skybox). To generate an IBL
-simply use this command:
+in your build directory). These sample apps expect a path to a directory containing the '.rgb32f'
+files for the IBL (which are PNGs containing `R11F_G11F_B10F` data). To generate an IBL simply use
+this command:
 
 ```
-cmgen -f ktx -x ./ibls/ my_ibl.exr
+cmgen -x ./ibls/ my_ibl.exr
 ```
 
 The source environment map can be a PNG (8 or 16 bit), a PSD (16 or 32 bit), an HDR or an OpenEXR
@@ -444,19 +468,3 @@ export SWIFTSHADER_LD_LIBRARY_PATH=`pwd`
 ```
 
 Next, go to your Filament repo and use the [easy build](#easy-build) script with `-t`.
-
-## SwiftShader for CI
-
-Continuous testing turnaround can be quite slow if you need to build SwiftShader from scratch, so we
-provide an Ubuntu-based Docker image that has it already built. The Docker image also includes
-everything necessary for building Filament. You can fetch and run the image as follows:
-
-```
-docker pull ghcr.io/filament-assets/swiftshader
-docker run -it ghcr.io/filament-assets/swiftshader
-```
-
-To do more with the container, see the helper script at `build/swiftshader/test.sh`.
-
-If you are a team member, you can update the public image to the latest SwiftShader by
-following the instructions at the top of `build/swiftshader/Dockerfile`.

CMakeLists.txt

@@ -1,7 +1,7 @@
 # ==================================================================================================
 # CMake
 # ==================================================================================================
-cmake_minimum_required(VERSION 3.19)
+cmake_minimum_required(VERSION 3.10)
 
 # ==================================================================================================
 # Project declaration
@@ -11,6 +11,8 @@ project(TNT)
 # ==================================================================================================
 # Options
 # ==================================================================================================
+option(FILAMENT_ENABLE_JAVA "Compile Java projects, requires a JDK and the JAVA_HOME env var" ON)
+
 option(FILAMENT_USE_EXTERNAL_GLES3 "Experimental: Compile Filament against OpenGL ES 3" OFF)
 
 option(FILAMENT_USE_SWIFTSHADER "Compile Filament against SwiftShader" OFF)
@@ -19,40 +21,20 @@ option(FILAMENT_ENABLE_LTO "Enable link-time optimizations if supported by the c
 
 option(FILAMENT_SKIP_SAMPLES "Don't build samples" OFF)
 
-option(FILAMENT_SUPPORTS_XCB "Include XCB support in Linux builds" ON)
-
-option(FILAMENT_SUPPORTS_XLIB "Include XLIB support in Linux builds" ON)
-
-option(FILAMENT_SUPPORTS_EGL_ON_LINUX "Use EGL for OpenGL in Linux builds" OFF)
-
-option(FILAMENT_SUPPORTS_WAYLAND "Include Wayland support in Linux builds" OFF)
-
-option(FILAMENT_SKIP_SDL2 "Skip dependencies of SDL2, and SDL2" OFF)
-
-option(FILAMENT_LINUX_IS_MOBILE "Treat Linux as Mobile" OFF)
-
-set(FILAMENT_NDK_VERSION "" CACHE STRING
-    "Android NDK version or version prefix to be used when building for Android."
+set(FILAMENT_PER_RENDER_PASS_ARENA_SIZE_IN_MB "2" CACHE STRING
+    "Per render pass arena size. Must be roughly 1 MB larger than FILAMENT_PER_FRAME_COMMANDS_SIZE_IN_MB, default 2."
 )
 
-set(FILAMENT_PER_RENDER_PASS_ARENA_SIZE_IN_MB "3" CACHE STRING
-    "Per render pass arena size. Must be roughly 1 MB larger than FILAMENT_PER_FRAME_COMMANDS_SIZE_IN_MB, default 3."
+set(FILAMENT_PER_FRAME_COMMANDS_SIZE_IN_MB "1" CACHE STRING
+    "Size of the high-level draw commands buffer. Rule of thumb, 1 MB less than FILAMENT_PER_RENDER_PASS_ARENA_SIZE_IN_MB, default 1."
 )
 
-set(FILAMENT_PER_FRAME_COMMANDS_SIZE_IN_MB "2" CACHE STRING
-    "Size of the high-level draw commands buffer. Rule of thumb, 1 MB less than FILAMENT_PER_RENDER_PASS_ARENA_SIZE_IN_MB, default 2."
+set(FILAMENT_MIN_COMMAND_BUFFERS_SIZE_IN_MB "1" CACHE STRING
+    "Size of the command-stream buffer. As a rule of thumb use the same value as FILAMENT_PER_FRRAME_COMMANDS_SIZE_IN_MB, default 1."
 )
 
-set(FILAMENT_MIN_COMMAND_BUFFERS_SIZE_IN_MB "2" CACHE STRING
-    "Size of the command-stream buffer. As a rule of thumb use the same value as FILAMENT_PER_FRRAME_COMMANDS_SIZE_IN_MB, default 2."
-)
-
-set(FILAMENT_OPENGL_HANDLE_ARENA_SIZE_IN_MB "4" CACHE STRING
-    "Size of the OpenGL handle arena, default 4."
-)
-
-set(FILAMENT_METAL_HANDLE_ARENA_SIZE_IN_MB "8" CACHE STRING
-    "Size of the Metal handle arena, default 8."
+set(FILAMENT_OPENGL_HANDLE_ARENA_SIZE_IN_MB "2" CACHE STRING
+    "Size of the OpenGL handle arena, default 2."
 )
 
 # ==================================================================================================
@@ -101,38 +83,11 @@ if (UNIX AND NOT APPLE AND NOT ANDROID AND NOT WEBGL)
     set(LINUX TRUE)
 endif()
 
-if (LINUX)
-    if (FILAMENT_SUPPORTS_WAYLAND)
-        add_definitions(-DFILAMENT_SUPPORTS_WAYLAND)
-        set(FILAMENT_SUPPORTS_X11 FALSE)
-    elseif (FILAMENT_SUPPORTS_EGL_ON_LINUX)
-        add_definitions(-DFILAMENT_SUPPORTS_EGL_ON_LINUX)
-        set(FILAMENT_SUPPORTS_X11 FALSE)
-    else ()
-        if (FILAMENT_SUPPORTS_XCB)
-            add_definitions(-DFILAMENT_SUPPORTS_XCB)
-        endif()
-
-        if (FILAMENT_SUPPORTS_XLIB)
-            add_definitions(-DFILAMENT_SUPPORTS_XLIB)
-        endif()
-
-        if (FILAMENT_SUPPORTS_XCB OR FILAMENT_SUPORTS_XLIB)
-            add_definitions(-DFILAMENT_SUPPORTS_X11)
-            set(FILAMENT_SUPPORTS_X11 TRUE)
-        endif()
-    endif()
-endif()
-
-if (ANDROID OR WEBGL OR IOS OR FILAMENT_LINUX_IS_MOBILE)
+if (ANDROID OR WEBGL OR IOS)
     set(IS_MOBILE_TARGET TRUE)
 endif()
 
-if (ANDROID)
-    add_definitions(-D__ANDROID_UNAVAILABLE_SYMBOLS_ARE_WEAK__)
-endif()
-
-if (NOT ANDROID AND NOT WEBGL AND NOT IOS AND NOT FILAMENT_LINUX_IS_MOBILE)
+if (NOT ANDROID AND NOT WEBGL AND NOT IOS)
     set(IS_HOST_PLATFORM TRUE)
 endif()
 
@@ -156,35 +111,27 @@ if (WIN32)
     # __declspec(dllexport) in front of each functions).
     set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ON)
 
-    # The CMAKE_CXX_FLAGS vars can be overriden by some Visual Studio generators, so we use an alternative
-    # global method here:
     if (${USE_STATIC_CRT})
-        add_compile_options(
-            $<$<CONFIG:>:/MT>
-            $<$<CONFIG:Debug>:/MTd>
-            $<$<CONFIG:Release>:/MT>
-        )
+        set(CRT_FLAGS_RELEASE "/MT")
+        set(CRT_FLAGS_DEBUG "/MTd")
     else()
-        add_compile_options(
-            $<$<CONFIG:>:/MD>
-            $<$<CONFIG:Debug>:/MDd>
-            $<$<CONFIG:Release>:/MD>
-        )
+        set(CRT_FLAGS_RELEASE "/MD")
+        set(CRT_FLAGS_DEBUG "/MDd")
     endif()
 
     # TODO: Figure out why pdb generation messes with incremental compilaton.
     # IN RELEASE_WITH_DEBUG_INFO, generate debug info in .obj, no in pdb.
-    set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "${CMAKE_CXX_FLAGS_RELWITHDEBINFO} /Z7")
-    set(CMAKE_C_FLAGS_RELWITHDEBINFO "${CMAKE_C_FLAGS_RELWITHDEBINFO} /Z7")
+    set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "${CMAKE_CXX_FLAGS_RELWITHDEBINFO} ${CRT_FLAGS_RELEASE} /Z7")
+    set(CMAKE_C_FLAGS_RELWITHDEBINFO "${CMAKE_C_FLAGS_RELWITHDEBINFO} ${CRT_FLAGS_RELEASE} /Z7")
 
     # In RELEASE, also generate PDBs.
-    set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} /Zi")
-    set(CMAKE_C_FLAGS_RELEASE "${CMAKE_C_FLAGS_RELEASE} /Zi")
+    set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} ${CRT_FLAGS_RELEASE} /Zi")
+    set(CMAKE_C_FLAGS_RELEASE "${CMAKE_C_FLAGS_RELEASE} ${CRT_FLAGS_RELEASE} /Zi")
 
     # In DEBUG, avoid generating a PDB file which seems to mess with incremental compilation.
     # Instead generate debug info directly inside obj files.
-    set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} /Z7")
-    set(CMAKE_C_FLAGS_DEBUG "${CMAKE_C_FLAGS_DEBUG} /Z7")
+    set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} ${CRT_FLAGS_DEBUG} /Z7")
+    set(CMAKE_C_FLAGS_DEBUG "${CMAKE_C_FLAGS_DEBUG} ${CRT_FLAGS_DEBUG} /Z7")
 
     # Special settings when building on CI.
     if (${FILAMENT_WINDOWS_CI_BUILD})
@@ -273,17 +220,13 @@ if (MSVC)
     set(CXX_STANDARD "/std:c++latest")
     set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${CXX_STANDARD} /W0 /Zc:__cplusplus")
 else()
-    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${CXX_STANDARD} -fstrict-aliasing -Wno-unknown-pragmas -Wno-unused-function -Wno-deprecated-declarations")
+    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${CXX_STANDARD} -fstrict-aliasing -Wno-unknown-pragmas -Wno-unused-function")
 endif()
 
 if (FILAMENT_USE_EXTERNAL_GLES3)
     set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DUSE_EXTERNAL_GLES3")
 endif()
 
-if (FILAMENT_SUPPORTS_EGL_ON_LINUX)
-  set(EGL TRUE)
-endif()
-
 if (FILAMENT_USE_SWIFTSHADER)
     set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DFILAMENT_USE_SWIFTSHADER")
 endif()
@@ -305,10 +248,7 @@ if (LINUX)
     # /usr/bin/ld: ../bluegl/libbluegl.a(BlueGL.cpp.o): relocation R_X86_64_32S
     # against `.bss' can not be used when making a shared object; recompile with -fPIC
     set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC")
-endif()
 
-if (ANDROID)
-    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC -Werror=unguarded-availability")
 endif()
 
 if (CYGWIN)
@@ -328,12 +268,6 @@ if (UNIX AND CMAKE_GENERATOR STREQUAL "Ninja")
     set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fcolor-diagnostics")
 endif()
 
-# Use hidden by default and expose what we need.
-if (NOT WIN32)
-    set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fvisibility=hidden")
-    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fvisibility=hidden")
-endif()
-
 # ==================================================================================================
 # Release compiler flags
 # ==================================================================================================
@@ -348,7 +282,7 @@ endif()
 
 # On Android RELEASE builds, we disable exceptions and RTTI to save some space (about 75 KiB
 # saved by -fno-exception and 10 KiB saved by -fno-rtti).
-if (ANDROID OR IOS OR WEBGL)
+if (ANDROID OR WEBGL)
     set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti")
 endif()
 
@@ -359,10 +293,6 @@ if (WEBGL)
     set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -fno-rtti")
 endif()
 
-if (WEBGL_PTHREADS)
-    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -pthread")
-endif()
-
 # ==================================================================================================
 # Debug compiler flags
 # ==================================================================================================
@@ -405,8 +335,8 @@ endif()
 set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ${GC_SECTIONS}")
 set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} ${GC_SECTIONS} ${B_SYMBOLIC_FUNCTIONS}")
 
-if (WEBGL_PTHREADS)
-    set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -pthread")
+if (WEBGL)
+    set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -s USE_WEBGL2=1")
 endif()
 
 # ==================================================================================================
@@ -418,12 +348,6 @@ if (CMAKE_BUILD_TYPE STREQUAL "Debug" OR CMAKE_BUILD_TYPE STREQUAL "RelWithDebIn
     set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DTNT_DEV")
 endif()
 
-# By default, build with support for OpenGL on all platforms.
-option(FILAMENT_SUPPORTS_OPENGL "Include the OpenGL backend" ON)
-if (FILAMENT_SUPPORTS_OPENGL)
-    add_definitions(-DFILAMENT_SUPPORTS_OPENGL)
-endif()
-
 # By default, build with Vulkan support on desktop platforms, although clients must request to use
 # it at run time.
 if (WIN32 OR WEBGL OR IOS)
@@ -459,20 +383,6 @@ else()
     option(FILAMENT_ENABLE_MATDBG "Enable the material debugger" OFF)
 endif()
 
-# By default, link in fgdbg for Desktop + Debug
-if (CMAKE_BUILD_TYPE STREQUAL "Debug" AND IS_HOST_PLATFORM)
-    option(FILAMENT_ENABLE_FGDBG "Enable the framegraph debugger" ON)
-else()
-    option(FILAMENT_ENABLE_FGDBG "Enable the framegraph debugger" OFF)
-endif()
-
-# Only optimize materials in Release mode (so error message lines match the source code)
-if (CMAKE_BUILD_TYPE MATCHES Release)
-    option(FILAMENT_DISABLE_MATOPT "Disable material optimizations" OFF)
-else()
-    option(FILAMENT_DISABLE_MATOPT "Disable material optimizations" ON)
-endif()
-
 # ==================================================================================================
 # Material compilation flags
 # ==================================================================================================
@@ -486,9 +396,9 @@ endif()
 
 set(MATC_API_FLAGS )
 
-if (FILAMENT_SUPPORTS_OPENGL)
-    set(MATC_API_FLAGS ${MATC_API_FLAGS} -a opengl)
-endif()
+# TODO: Add a flag to build Filament without support for OpenGL.
+set(MATC_API_FLAGS ${MATC_API_FLAGS} -a opengl)
+
 if (FILAMENT_SUPPORTS_VULKAN)
     set(MATC_API_FLAGS ${MATC_API_FLAGS} -a vulkan)
 endif()
@@ -496,9 +406,9 @@ if (FILAMENT_SUPPORTS_METAL)
     set(MATC_API_FLAGS ${MATC_API_FLAGS} -a metal)
 endif()
 
-# Disable optimizations and enable debug info (preserves names in SPIR-V)
-if (FILAMENT_DISABLE_MATOPT)
-    set(MATC_OPT_FLAGS -gd)
+# Only optimize materials in Release mode (so error message lines match the source code)
+if (NOT CMAKE_BUILD_TYPE MATCHES Release)
+    set(MATC_OPT_FLAGS -g)
 endif()
 
 set(MATC_BASE_FLAGS ${MATC_API_FLAGS} -p ${MATC_TARGET} ${MATC_OPT_FLAGS})
@@ -508,23 +418,8 @@ set(MATC_BASE_FLAGS ${MATC_API_FLAGS} -p ${MATC_TARGET} ${MATC_OPT_FLAGS})
 # ==================================================================================================
 # choose where to put the objects in the dist folder
 if (NOT DIST_ARCH)
-    # On Apple silicon, the value of CMAKE_HOST_SYSTEM_PROCESSOR varies based on the CMake process's
-    # own architecture. Because of this, running a x86_64 CMake binary on Apple silicon will cause
-    # DIST_ARCH to be set incorrectly.
-    set(DIST_ARCH "${CMAKE_HOST_SYSTEM_PROCESSOR}")
-
-    if (CMAKE_OSX_ARCHITECTURES MATCHES ".*;.*")
-        set(DIST_ARCH "universal")
-    else()
-        if (NOT "${CMAKE_OSX_ARCHITECTURES}" STREQUAL "")
-            set(DIST_ARCH "${CMAKE_OSX_ARCHITECTURES}")
-        endif()
-    endif()
-
+    set(DIST_ARCH x86_64)
 endif()
-# On Windows machines, the host processor is set to 'AMD64', which we'll interpret as x86_64.
-string(TOLOWER "${DIST_ARCH}" DIST_ARCH)
-string(REPLACE "amd64" "x86_64" DIST_ARCH "${DIST_ARCH}")
 if (NOT DIST_DIR)
     set(DIST_DIR "${DIST_ARCH}")
 endif()
@@ -542,15 +437,11 @@ function(list_licenses OUTPUT MODULES)
     foreach(module ${_MODULES})
         set(license_path "../../third_party/${module}/LICENSE")
         get_filename_component(fullname "${license_path}" ABSOLUTE)
-        if(EXISTS ${fullname})
-            string(APPEND CONTENT "${STR_OPENER}License and copyrights for ${module}:\n${STR_CLOSER},\n")
-            file(READ ${license_path} license_long)
-            string(REPLACE "\n" "${STR_CLOSER},\n${STR_OPENER}" license ${license_long})
-            string(APPEND CONTENT ${STR_OPENER}${license}\n${STR_CLOSER},)
-            string(APPEND CONTENT "\n\n")
-        else()
-            message(AUTHOR_WARNING "${license_path} not found. You can ignore this warning if you have devendored ${module}.")
-        endif()
+        string(APPEND CONTENT "${STR_OPENER}License and copyrights for ${module}:\n${STR_CLOSER},\n")
+        file(READ ${license_path} license_long)
+        string(REPLACE "\n" "${STR_CLOSER},\n${STR_OPENER}" license ${license_long})
+        string(APPEND CONTENT ${STR_OPENER}${license}\n${STR_CLOSER},)
+        string(APPEND CONTENT "\n\n")
     endforeach()
     configure_file(${FILAMENT}/build/licenses.inc.in ${OUTPUT})
 endfunction(list_licenses)
@@ -566,12 +457,7 @@ function(combine_static_libs TARGET OUTPUT DEPS)
     # Loop through the dependent libraries and query their location on disk.
     set(DEPS_FILES )
     foreach(DEPENDENCY ${DEPS})
-        if(TARGET ${DEPENDENCY})
-            get_property(dep_type TARGET ${DEPENDENCY} PROPERTY TYPE)
-            if(dep_type STREQUAL "STATIC_LIBRARY")
-                list(APPEND DEPS_FILES "$<TARGET_FILE:${DEPENDENCY}>")
-            endif()
-        endif()
+        list(APPEND DEPS_FILES "$<TARGET_FILE:${DEPENDENCY}>")
     endforeach()
 
     add_custom_command(
@@ -604,6 +490,13 @@ if (FILAMENT_USE_SWIFTSHADER)
     find_library(SWIFTSHADER_VK NAMES vk_swiftshader HINTS "$ENV{SWIFTSHADER_LD_LIBRARY_PATH}")
     message(STATUS "Found SwiftShader VK library in: ${SWIFTSHADER_VK}.")
     add_definitions(-DFILAMENT_VKLIBRARY_PATH=\"${SWIFTSHADER_VK}\")
+elseif (FILAMENT_SUPPORTS_VULKAN AND APPLE)
+    find_library(Vulkan_LIBRARY NAMES vulkan HINTS "$ENV{VULKAN_SDK}/lib" "$ENV{VULKAN_SDK}/macOS/lib")
+    if (Vulkan_LIBRARY)
+        set(Vulkan_FOUND ON)
+        message(STATUS "Found Vulkan library in SDK: ${Vulkan_LIBRARY}.")
+        add_definitions(-DFILAMENT_VKLIBRARY_PATH=\"${Vulkan_LIBRARY}\")
+    endif()
 endif()
 
 # ==================================================================================================
@@ -651,32 +544,23 @@ add_subdirectory(${EXTERNAL}/libgtest/tnt)
 add_subdirectory(${LIBRARIES}/camutils)
 add_subdirectory(${LIBRARIES}/filabridge)
 add_subdirectory(${LIBRARIES}/filaflat)
-add_subdirectory(${LIBRARIES}/filagui)
 add_subdirectory(${LIBRARIES}/filameshio)
 add_subdirectory(${LIBRARIES}/geometry)
 add_subdirectory(${LIBRARIES}/gltfio)
 add_subdirectory(${LIBRARIES}/ibl)
-add_subdirectory(${LIBRARIES}/iblprefilter)
 add_subdirectory(${LIBRARIES}/image)
-add_subdirectory(${LIBRARIES}/ktxreader)
 add_subdirectory(${LIBRARIES}/math)
 add_subdirectory(${LIBRARIES}/mathio)
-add_subdirectory(${LIBRARIES}/uberz)
 add_subdirectory(${LIBRARIES}/utils)
-add_subdirectory(${LIBRARIES}/viewer)
 add_subdirectory(${FILAMENT}/filament)
 add_subdirectory(${FILAMENT}/shaders)
-add_subdirectory(${EXTERNAL}/basisu/tnt)
-add_subdirectory(${EXTERNAL}/civetweb/tnt)
 add_subdirectory(${EXTERNAL}/hat-trie/tnt)
-add_subdirectory(${EXTERNAL}/imgui/tnt)
 add_subdirectory(${EXTERNAL}/robin-map/tnt)
 add_subdirectory(${EXTERNAL}/smol-v/tnt)
 add_subdirectory(${EXTERNAL}/benchmark/tnt)
-add_subdirectory(${EXTERNAL}/meshoptimizer/tnt)
+add_subdirectory(${EXTERNAL}/meshoptimizer)
 add_subdirectory(${EXTERNAL}/cgltf/tnt)
 add_subdirectory(${EXTERNAL}/draco/tnt)
-add_subdirectory(${EXTERNAL}/jsmn/tnt)
 add_subdirectory(${EXTERNAL}/stb/tnt)
 add_subdirectory(${EXTERNAL}/getopt)
 
@@ -690,12 +574,9 @@ if (FILAMENT_BUILD_FILAMAT OR IS_HOST_PLATFORM)
 
     # the material debugger requires filamat
     if (FILAMENT_ENABLE_MATDBG OR IS_HOST_PLATFORM)
+        add_subdirectory(${EXTERNAL}/civetweb/tnt)
         add_subdirectory(${LIBRARIES}/matdbg)
     endif()
-
-    if (FILAMENT_ENABLE_FGDBG OR IS_HOST_PLATFORM)
-        add_subdirectory(${LIBRARIES}/fgdbg)
-    endif()
 endif()
 
 if (FILAMENT_SUPPORTS_VULKAN)
@@ -703,24 +584,33 @@ if (FILAMENT_SUPPORTS_VULKAN)
     add_subdirectory(${EXTERNAL}/vkmemalloc/tnt)
 endif()
 
+if (APPLE)
+    add_subdirectory(${EXTERNAL}/moltenvk/tnt)
+endif()
+
 set(FILAMENT_SAMPLES_BINARY_DIR ${PROJECT_BINARY_DIR}/samples)
 
 if (WEBGL)
     add_subdirectory(web/filament-js)
     add_subdirectory(web/samples)
+    add_subdirectory(${EXTERNAL}/imgui/tnt)
 endif()
 
 if (IS_HOST_PLATFORM)
-    if (FILAMENT_SUPPORTS_OPENGL)
-        add_subdirectory(${LIBRARIES}/bluegl)
-    endif()
-    if (NOT FILAMENT_SKIP_SDL2)
-      add_subdirectory(${LIBRARIES}/filamentapp)
-    endif()
+    add_subdirectory(${LIBRARIES}/bluegl)
+    add_subdirectory(${LIBRARIES}/filamentapp)
+    add_subdirectory(${LIBRARIES}/filagui)
     add_subdirectory(${LIBRARIES}/imageio)
 
+    add_subdirectory(${FILAMENT}/java/filamat)
+    add_subdirectory(${FILAMENT}/java/filament)
+    add_subdirectory(${FILAMENT}/java/gltfio)
+
     add_subdirectory(${FILAMENT}/samples)
 
+    add_subdirectory(${EXTERNAL}/astcenc/tnt)
+    add_subdirectory(${EXTERNAL}/etc2comp)
+    add_subdirectory(${EXTERNAL}/imgui/tnt)
     add_subdirectory(${EXTERNAL}/libassimp/tnt)
     add_subdirectory(${EXTERNAL}/libpng/tnt)
     add_subdirectory(${EXTERNAL}/libsdl2/tnt)
@@ -736,13 +626,11 @@ if (IS_HOST_PLATFORM)
     add_subdirectory(${TOOLS}/mipgen)
     add_subdirectory(${TOOLS}/normal-blending)
     add_subdirectory(${TOOLS}/resgen)
-    add_subdirectory(${TOOLS}/rgb-to-lmsr)
     add_subdirectory(${TOOLS}/roughness-prefilter)
     add_subdirectory(${TOOLS}/specular-color)
-    add_subdirectory(${TOOLS}/uberz)
 endif()
 
 # Generate exported executables for cross-compiled builds (Android, WebGL, and iOS)
 if (NOT CMAKE_CROSSCOMPILING)
-    export(TARGETS matc cmgen filamesh mipgen resgen uberz glslminifier FILE ${IMPORT_EXECUTABLES})
+    export(TARGETS matc cmgen filamesh mipgen resgen glslminifier FILE ${IMPORT_EXECUTABLES})
 endif()

CODE_STYLE.md

@@ -164,7 +164,8 @@ private:
 
 ### Strings
 
-- Never use `std::string` in the Filament core renderer. Prefer `utils::CString` or `std::string_view`.
+- Never use `std::string` in the Filament core renderer. Prefer `utils::CString` or
+  `utils::StaticString`.
 - When using `std::string` in tools, always include the `std::` qualifier to disambiguate it
   from other string types.
 

README.md

@@ -31,27 +31,39 @@ repositories {
 }
 
 dependencies {
-    implementation 'com.google.android.filament:filament-android:1.28.0'
+    implementation 'com.google.android.filament:filament-android:1.9.3'
 }
 ```
 
 Here are all the libraries available in the group `com.google.android.filament`:
 
-| Artifact      | Description   |
-| ------------- | ------------- |
-| [![filament-android](https://maven-badges.herokuapp.com/maven-central/com.google.android.filament/filament-android/badge.svg?subject=filament-android)](https://maven-badges.herokuapp.com/maven-central/com.google.android.filament/filament-android)  | The Filament rendering engine itself. |
-| [![gltfio-android](https://maven-badges.herokuapp.com/maven-central/com.google.android.filament/gltfio-android/badge.svg?subject=gltfio-android)](https://maven-badges.herokuapp.com/maven-central/com.google.android.filament/gltfio-android) | A glTF 2.0 loader for Filament, depends on `filament-android`. |
-| [![gltfio-android-lite](https://maven-badges.herokuapp.com/maven-central/com.google.android.filament/gltfio-android-lite/badge.svg?subject=gltfio-android-lite)](https://maven-badges.herokuapp.com/maven-central/com.google.android.filament/gltfio-android-lite) | Trimmed version of `gltfio` that does not support some glTF extensions. |
-| [![filament-utils-android](https://maven-badges.herokuapp.com/maven-central/com.google.android.filament/filament-utils-android/badge.svg?subject=filament-utils-android)](https://maven-badges.herokuapp.com/maven-central/com.google.android.filament/filament-utils-android) | KTX loading, Kotlin math, and camera utilities, depends on `gltfio-android`. |
-| [![filamat-android](https://maven-badges.herokuapp.com/maven-central/com.google.android.filament/filamat-android/badge.svg?subject=filamat-android)](https://maven-badges.herokuapp.com/maven-central/com.google.android.filament/filamat-android) | A runtime material builder/compiler. This library is large but contains a full shader compiler/validator/optimizer and supports both OpenGL and Vulkan. |
-| [![filamat-android-lite](https://maven-badges.herokuapp.com/maven-central/com.google.android.filament/filamat-android-lite/badge.svg?subject=filamat-android-lite)](https://maven-badges.herokuapp.com/maven-central/com.google.android.filament/filamat-android-lite) | A much smaller alternative to `filamat-android` that can only generate OpenGL shaders. It does not provide validation or optimizations. |
+[![filament-android](https://maven-badges.herokuapp.com/maven-central/com.google.android.filament/filament-android/badge.svg?subject=filament-android)](https://maven-badges.herokuapp.com/maven-central/com.google.android.filament/filament-android)  
+The Filament rendering engine itself.
+
+[![gltfio-android](https://maven-badges.herokuapp.com/maven-central/com.google.android.filament/gltfio-android/badge.svg?subject=gltfio-android)](https://maven-badges.herokuapp.com/maven-central/com.google.android.filament/gltfio-android)  
+A glTF 2.0 loader for Filament, depends on `filament-android`  .
+
+[![gltfio-android-lite](https://maven-badges.herokuapp.com/maven-central/com.google.android.filament/gltfio-android-lite/badge.svg?subject=gltfio-android-lite)](https://maven-badges.herokuapp.com/maven-central/com.google.android.filament/gltfio-android-lite)  
+Trimmed version of `gltfio` that does not support some glTF features.
+
+[![filament-utils-android](https://maven-badges.herokuapp.com/maven-central/com.google.android.filament/filament-utils-android/badge.svg?subject=filament-utils-android)](https://maven-badges.herokuapp.com/maven-central/com.google.android.filament/filament-utils-android)  
+KTX loading, Kotlin math, and camera utilities, depends on `gltfio-android`.
+
+[![filament-utils-android-lite](https://maven-badges.herokuapp.com/maven-central/com.google.android.filament/filament-utils-android-lite/badge.svg?subject=filament-utils-lite)](https://maven-badges.herokuapp.com/maven-central/com.google.android.filament/filament-utils-android-lite)  
+Trimmed version of `filament-utils` that does not support some glTF features.
+
+[![filamat-android](https://maven-badges.herokuapp.com/maven-central/com.google.android.filament/filamat-android/badge.svg?subject=filamat-android)](https://maven-badges.herokuapp.com/maven-central/com.google.android.filament/filamat-android)  
+A runtime material builder/compiler. This library is large but contains a full shader compiler/validator/optimizer.
+
+[![filamat-android-lite](https://maven-badges.herokuapp.com/maven-central/com.google.android.filament/filamat-android-lite/badge.svg?subject=filamat-android-lite)](https://maven-badges.herokuapp.com/maven-central/com.google.android.filament/filamat-android-lite)  
+A much smaller alternative to `filamat-android` that can only generate OpenGL shaders. It does not provide validation or optimizations.
 
 ### iOS
 
 iOS projects can use CocoaPods to install the latest release:
 
 ```
-pod 'Filament', '~> 1.28.0'
+pod 'Filament', '~> 1.9.3'
 ```
 
 ### Snapshots
@@ -62,7 +74,7 @@ steps:
 1. Find the [commit](https://github.com/google/filament/commits/main) you're interested in.
 2. Click the green check mark under the commit message.
 3. Click on the _Details_ link for the platform you're interested in.
-4. On the top left click _Summary_, then in the _Artifacts_ section choose the desired artifact.
+4. On the top right, click on the _Artifacts_ dropdown and choose an artifact.
 
 ## Documentation
 
@@ -85,12 +97,25 @@ steps:
 ![Helmet](docs/images/samples/example_helmet.jpg)
 ![Screen-space refraction](docs/images/samples/example_ssr.jpg)
 
+
+### Applications
+
+Here are a few screenshots of applications that use Filament in production:
+
+#### Google Maps AR Navigation
+
+![Google Maps AR Navigation](docs/images/samples/app_gmm_ar_nav.jpg)
+
+#### Google Search 3D/AR Viewer on Android
+
+![Google Search 3D/AR Viewer on Android](docs/images/samples/app_google_3d_viewer.jpg)
+
 ## Features
 
 ### APIs
 
 - Native C++ API for Android, iOS, Linux, macOS and Windows
-- Java/JNI API for Android
+- Java/JNI API for Android, Linux, macOS and Windows
 - JavaScript API
 
 ### Backends
@@ -106,81 +131,31 @@ steps:
 - Clustered forward renderer
 - Cook-Torrance microfacet specular BRDF
 - Lambertian diffuse BRDF
-- Custom lighting/surface shading
 - HDR/linear lighting
 - Metallic workflow
 - Clear coat
 - Anisotropic lighting
 - Approximated translucent (subsurface) materials
-- Cloth/fabric/sheen shading
+- Cloth shading
 - Normal mapping & ambient occlusion mapping
 - Image-based lighting
 - Physically-based camera (shutter speed, sensitivity and aperture)
 - Physical light units
 - Point lights, spot lights and directional light
-- Specular anti-aliasing
 - Spot and directional light shadows
 - Cascaded shadows
-- EVSM, PCSS, DPCF, or PCF shadows
-- Transparent shadows
+- VSM or PCF shadows
 - Contact shadows
 - Screen-space ambient occlusion
-- Screen-space reflections
 - Screen-space refraction
 - Global fog
-- Dynamic resolution (with support for AMD FidelityFX FSR)
-
-### Post processing
-
 - HDR bloom
 - Depth of field bokeh
-- Multiple tone mappers: generic (customizable), ACES, filmic, etc.
-- Color and tone management: luminance scaling, gamut mapping
-- Color grading: exposure, night adaptation, white balance, channel mixer,
-  shadows/mid-tones/highlights, ASC CDL, contrast, saturation, etc.
-- TAA, FXAA, MSAA
-- Screen-space lens flares
-
-### glTF 2.0
-
-- Encodings
-  - [x] Embeded
-  - [x] Binary
-
-- Primitive Types
-  - [x] Points
-  - [x] Lines
-  - [ ] Line Loop
-  - [x] Line Strip
-  - [x] Triangles
-  - [x] Triangle Strip
-  - [ ] Triangle Fan
-
-- Animation
-  - [x] Transform animation
-  - [x] Linear interpolation
-  - [x] Morph animation
-    - [x] Sparse accessor
-  - [x] Skin animation
-  - [x] Joint animation
-
-- Extensions
-  - [x] KHR_draco_mesh_compression
-  - [x] KHR_lights_punctual
-  - [x] KHR_materials_clearcoat
-  - [x] KHR_materials_emissive_strength
-  - [x] KHR_materials_ior
-  - [x] KHR_materials_pbrSpecularGlossiness
-  - [x] KHR_materials_sheen
-  - [x] KHR_materials_transmission
-  - [x] KHR_materials_unlit
-  - [x] KHR_materials_variants
-  - [x] KHR_materials_volume
-  - [x] KHR_mesh_quantization
-  - [x] KHR_texture_basisu
-  - [x] KHR_texture_transform
-  - [x] EXT_meshopt_compression
-
+- Multiple tone mappers: ACES, filmic, etc.
+- Color grading: white balance, channel mixer, shadows/mid-tones/highlights, ASC CDL,
+  contrast, saturation, etc.
+- TAA, FXAA, MSAA and specular anti-aliasing
+- Dynamic resolution
 
 ## Rendering with Filament
 
@@ -245,11 +220,22 @@ if (renderer->beginFrame(swapChain)) {
 ```
 
 For complete examples of Linux, macOS and Windows Filament applications, look at the source files
-in the `samples/` directory. These samples are all based on `libs/filamentapp/` which contains the
-code that creates a native window with SDL2 and initializes the Filament engine, renderer and views.
+in the `samples/` directory. These samples are all based on `samples/app/` which contains the code
+that creates a native window with SDL2 and initializes the Filament engine, renderer and views.
 
-For more information on how to prepare environment maps for image-based lighting please refer to
-[BUILDING.md](https://github.com/google/filament/blob/main/BUILDING.md#running-the-native-samples).
+### Java on Linux, macOS and Windows
+
+After building Filament, you can use `filament-java.jar` and its companion `filament-jni` native
+library to use Filament in desktop Java applications.
+
+You must always first initialize Filament by calling `Filament.init()`.
+
+You can use Filament either with AWT or Swing, using respectively a `FilamentCanvas` or a
+`FilamentPanel`.
+
+Following the steps above (how to use Filament from native code), create an `Engine` and a
+`Renderer`, but instead of calling `beginFrame` and `endFrame` on the renderer itself, call
+these methods on `FilamentCanvas` or `FilamentPanel`.
 
 ### Android
 
@@ -280,10 +266,6 @@ To get started you can use the textures and environment maps found respectively
 `third_party/textures` and `third_party/environments`. These assets are under CC0 license. Please
 refer to their respective `URL.txt` files to know more about the original authors.
 
-Environments must be pre-processed using
-[`cmgen`](https://github.com/google/filament/blob/main/BUILDING.md#running-the-native-samples) or
-using the `libiblprefilter` library.
-
 ## How to make contributions
 
 Please read and follow the steps in [CONTRIBUTING.md](/CONTRIBUTING.md). Make sure you are
@@ -306,14 +288,13 @@ and tools.
 - `docs`:                     Documentation
   - `math`:                   Mathematica notebooks used to explore BRDFs, equations, etc.
 - `filament`:                 Filament rendering engine (minimal dependencies)
-  - `backend`:                Rendering backends/drivers (Vulkan, Metal, OpenGL/ES)
 - `ide`:                      Configuration files for IDEs (CLion, etc.)
 - `ios`:                      Sample projects for iOS
+- `java`:                     Java bindings for Filament libraries
 - `libs`:                     Libraries
   - `bluegl`:                 OpenGL bindings for macOS, Linux and Windows
   - `bluevk`:                 Vulkan bindings for macOS, Linux, Windows and Android
   - `camutils`:               Camera manipulation utilities
-  - `fgdbg`:                  Frame Graph inspector and debugger (debug builds only)
   - `filabridge`:             Library shared by the Filament engine and host tools
   - `filaflat`:               Serialization/deserialization library used for materials
   - `filagui`:                Helper library for [Dear ImGui](https://github.com/ocornut/imgui)
@@ -329,7 +310,6 @@ and tools.
   - `math`:                   Math library
   - `mathio`:                 Math types support for output streams
   - `utils`:                  Utility library (threads, memory, data structures, etc.)
-  - `viewer`:                 glTF viewer library (requires gltfio)
 - `samples`:                  Sample desktop applications
 - `shaders`:                  Shaders used by `filamat` and `matc`
 - `third_party`:              External libraries and assets

RELEASE_GUIDE.md

@@ -1,171 +0,0 @@
-# Filament Release Guide
-
-This guide makes use of some "environment variables":
-- $RELEASE = the new version of Filament we are releasing today. (e.g., 1.9.3)
-- $NEXT_RELEASE = the version we plan to release next week (e.g., 1.9.4)
-
-Before starting, ensure that each of these branches is up-to-date with origin:
-- release
-- rc/$RELEASE
-- main
-
-## 0. Make sure the rc/$RELEASE branch has the correct version.
-
-It should have the version corresponding to its name, $RELEASE.
-
-## 1. Update RELEASE_NOTES.md on the rc branch.
-
-Checkout the rc/$RELEASE branch. In RELEASE_NOTES.md, locate the header corresponding to $RELEASE
-and write release notes. To see which commits make up the release, run:
-
-```
-build/common/release.sh -c rc/$RELEASE
-```
-
-Commit the changes to rc/$RELEASE with the title:
-
-```
-Update RELEASE_NOTES for $RELEASE
-```
-
-## 2. Bump versions on main to $RELEASE.
-
-Checkout main and run the following command to bump Filament's version to $RELEASE:
-
-```
-build/common/bump-version.sh $RELEASE
-```
-
-Commit changes to main with the title:
-
-```
-Release Filament $RELEASE
-```
-
-Do not push to origin yet.
-
-## 3. Cherry-pick RELEASE_NOTES change from rc branch to main.
-
-```
-git cherry-pick rc/$RELEASE
-```
-
-Update the headers. The "main branch" header becomes a header for $NEXT_RELEASE, and a new "main
-branch" header is added.
-
-For example, this:
-
-```
-## main branch
-- foo
-- bar
-
-## v1.9.3
-- baz
-- bat
-```
-
-becomes:
-
-```
-## main branch
-
-## v1.9.4
-- foo
-- bar
-
-## v1.9.3
-- baz
-- bat
-```
-
-Ammend these changes to the cherry-picked change.
-
-```
-git add -u
-git commit --amend --no-edit
-```
-
-## 4. Run release script.
-
-```
-build/common/release.sh rc/$RELEASE rc/$NEXT_RELEASE
-```
-
-This script will merge rc/$RELEASE into release, delete the rc branch, and create a new rc
-branch called rc/$NEXT_RELEASE. Verify that everything looks okay locally.
-
-## 5. Push the release branch.
-
-```
-git push origin release
-```
-
-## 6. Create the GitHub release.
-
-Use the GitHub UI to create a GitHub release corresponding to $RELEASE version.
-Make sure the target is set to the release branch.
-
-## 7. Delete the old rc branch (optional).
-
-This step is optional. The old rc branch may be left alive for a few weeks for posterity.
-
-```
-git push origin --delete rc/$RELEASE
-```
-
-## 8. Bump the version on the new rc branch to $NEXT_RELEASE.
-
-```
-git checkout rc/$NEXT_RELEASE
-build/common/bump-version.sh $NEXT_RELEASE
-```
-
-Commit the changes to rc/$NEXT_RELEASE with the title:
-
-```
-Bump version to $NEXT_RELEASE
-```
-
-## 9. Push main.
-
-```
-git push origin main
-```
-
-## 10. Push the new rc branch.
-
-```
-git push origin -u rc/$NEXT_RELEASE
-```
-
-## 11. Rebuild the GitHub release (if failed).
-
-Sometimes the GitHub release job will fail. In this case, you can manually re-run the release job.
-
-### Remove any assets uploaded to the release (if needed).
-
-For example, if rebuilding the Mac release, ensure that the `filament-<version>-mac.tgz` artifact
-is removed from the release assets.
-
-### Update the release branch (if needed).
-
-If you need to add one or more new commits to the release, perform the following:
-
-First, push the new commit(s) to the `release` branch.
-
-Then, with the release branch checked out with the new commit(s), run
-
-```
-git tag -f -a <release tagname>
-git push origin -f <release tagname>
-```
-
-This will update and force push the tag.
-
-### Re-run the GitHub release workflow
-
-Navigate to [Filament's release
-workflow](https://github.com/google/filament/actions/workflows/release.yml). Hit the _Run workflow_
-dropdown. Modify _Platform to build_ and _Release tag to build_, then hit _Run workflow_. This will
-initiate a new release run.

RELEASE_NOTES.md

@@ -3,807 +3,7 @@
 This file contains one line summaries of commits that are worthy of mentioning in release notes.
 A new header is inserted each time a *tag* is created.
 
-## main branch
-
-- gltfio: support EXT_meshopt_compression
-- release packaging: fixed location of default IBL file
-
-## v1.28.1
-
-- gltfio: fix reloading crash in ubershader mode
-- Vulkan: improve performance in the readPixels path
-- engine: raise the spot shadows limit to 64, from 14.
-- engine: add experimental support for point light shadows.
-- gltfio: fix ubershader issues with assignment of dummy textures
-- gltfio: material instances and variants are now accessed via `FilamentInstance` [⚠️ **API Change**]
-- gltfio: the animator can now only be accessed via `FilamentInstance` [⚠️ **API Change**]
-- engine: fix "stable" shadows and make the default cascade splits logarithmic.
-- engine: Add new quality options to EVSM shadows + rendering fixes
-
-## v1.28.0
-
-- engine: LiSPSM is now a user settable option
-- engine: get the morph target buffer to the given primitive
-- Java: Fix TransformManager.getChildren()
-- Metal: newer devices are no longer limited to 16 samplers per Material.
-- gltfio: fix interpretation of occlusion strength
-- engine: minsdk is now 21 instead of 19. This allows the use of OpenGL ES 3.1
-- Vulkan: fix black screen regression
-
-## v1.27.2
-
-- gltfio: punctual lights are now duplicated when adding new asset instances
-- gltfio: FilamentInstance getAsset method now returns an immutable asset
-- gltfio: allow zero-instance assets
-- gltfio: fix regression with meshes that have no material
-- gltfio: fix regression with recomputeBoundingBoxes()
-- filamesh / matinfo: fix minor ASAN issues
-- engine: Added `Engine::resetBackendState()`, available only in WebGL builds
-
-## v1.27.1
-
-- Java: add methods for TransformManager.getChildCount(), TransformManager.getChildren() and Scene.hasEntity()
-- engine: Fix stencil buffer writes with OpenGL backend.
-- gltfio: add new virtual method to MaterialProvider that all plugins must implement
-- gltfio: add an assert for inconsistent sRGB flags among usages of a particular texture
-- engine: improve scissor documentation
-- backend: scissor is no longer clipped to the viewport (done on filament side)
-- samples: add debug overdraw visualization to gltf_viewer
-
-## v1.27.0
-
-- WebGL: reduce max instance count to work around Chrome issues [⚠️ **Recompile Materials**]
-- engine: rework material/shader sampler binding code [⚠️ **Recompile Materials**]
-- gltfio: move the API for `recomputeBoundingBoxes` [⚠️ **API Change**]
-- engine: add support for specialization constants [⚠️ **Recompile Materials**]
-- gltfio: fix spotlight regression
-- gltfio: clear the MaterialInstance cache when creating new instances
-
-## v1.26.0
-
-- engine: new feature level APIs, see `Engine::getSupportedFeatureLevel()`
-- engine: add new stencil API to `View` and stencil state APIs to `MaterialInstance` [**NEW API**].
-- engine: Fix guard bands and TAA with `vertexDomain:Device` [⚠️ **Recompile Materials**]
-- engine: `clipSpaceTransform` is now only available with `vertexDomain:Device` [⚠️ **API Change**]
-- gltfio: add unified `AssetLoader::createAsset()` method [⚠️ **API Change**]
-- gltfio: all assets are now "instanced" [⚠️ **API Change**]
-
-## v1.25.6
-
-- engine: Add `CONFIG_MINSPEC_UBO_SIZE` as a nicer way to allow exceeding the ES3.0 minspec.
-- gltfio: minor efficiency improvement for Android and WebGL builds.
-- gltfio: add support for concurrent texture downloading and decoding.
-
-## v1.25.5
-
-- WebGL: upgraded the JS bindings to work with emsdk 3.1.15
-- WebGL: added missing IBL builder to TypeScript annotations
-- engine: Fix incorrect precision restoration when computing accurate world translations
-- engine: make `MaterialInstance` public API friendly to `std::string_view` parameters
-- gltfio: add 'detach' methods to allow ownership transfer of entities and components
-
-## v1.25.4
-
-- backend: streamline texture upload APIs [⚠️ **API Change**]
-
-## v1.25.3
-
-- engine: Fix Adreno gpu crash introduced by gpu morph target change
-- engine: Add optional memory configuration parameters to Engine initialization
-
-## v1.25.2
-
-- engine: `Camera::getNear()` and `Camera::getCullingFar()` now return `doubles`
-- Metal: implement scissor support.
-- engine: `Renderer::getUserTime()` now returns seconds as documented (#5722) [⚠️ **API Fix**]
-
-## v1.25.1
-
-- engine: add support for automatic instancing. Must be enabled with `Engine::setAutomaticInstancingEnabled(bool)`
-
-## v1.25.0
-
-- Vulkan: smol-v blobs are now 8-byte aligned within the filamat archive. [⚠️ **Recompile Materials**]
-- backend: added support for EGL on linux (headless)
-- uberz tool: add --append and --template arguments.
-- matc tool: add --template argument.
-
-## v1.24.0
-
-- ImGuiHelper: add support for Y flip.
-- Metal: ignore `MTLTexture` formatting when importing external textures.
-- materials: add a new `instanced` material parameter that is now mandatory in order to call `getInstanceIndex()`
-- gltfio: UbershaderProvider now takes the ubershader archive in its constructor [⚠️ **API Change**]
-- gltfio: Fix morphing with sparse accessors.
-- gltfio: Fix models that use signed integers for morphing.
-- engine: Documentation improvements regarding SkinningBuffer and fix an off-by-one assert when setting a SkinningBuffer.
-- picking is now exposed to JavaScript
-- gltf_viewer: Exercise picking functionality.
-- OpenGL: add WebGL support for ReadPixels
-- Vulkan: add assert and error message for OOM (debug builds)
-- Vulkan: fix crash with picking and 2-component ReadPixels.
-- backend: workaround broken GLES timer query on some Mali-Gxx old drivers
-- backend: revert c049a1 & reenable b2cdf9 ("don't issue a flush systematically after framegraph's execute")
-- gltfio: namespace now lives under Filament [⚠️ **API Change**]
-- gltfio: UbershaderLoader renamed to UbershaderProvider [⚠️ **API Change**]
-- gltfio: MaterialGenerator renamed to JitShaderProvider [⚠️ **API Change**]
-
-## v1.23.2
-
-- gltfio: Fix morphing for un-packed accessors.
-- gltfio: Ubershaders are now packaged into flexible archives.
-- gltfio: Remove poorly maintained lite flavor.
-- engine: Disable user scissor while rendering the Shadow Maps.
-- engine: Merge identical backend `RenderPrimitives` together.
-- engine: Improve `ResourceAllocator` performance a bit by reserving 128 cache entries.
-- utils: Remove `std::hash<T>` definitions for `libutils` types. Use `T::Hasher` explicitly instead. [⚠️ **API Change**]
-- backend: Fix WGL context attributes.
-- Metal: Fix potential invalid shaders when using gltfio in Ubershader mode. [⚠️ **Recompile Materials to get the fix**]
-
-## v1.23.1
-
-- gltfio: support skinning with bones that do not belong to any scene.
-- gltfio: add `attachSkin` / `detachSkin` method to FilamentAsset.
-- gltfio: ubershader mode: set sheen to `OPAQUE`.
-- Metal: fix issues seen with dynamic resolution on M1 Macs.
-- engine: add a "global" mode for render primitive's `blendOrder`.
-- engine: remove `RenderManager::setGeometryAt(index, count)`. [⚠️ **API Change**]
-- engine: fix overallocation by about 17MB.
-- WebGL: Add JS bindings for Texture class methods.
-
-## v1.23.0
-
-- engine: Changed UBOs layout [⚠️ **Material breakage**].
-- engine: Normals on morphed models have been fixed (core Filament change).
-- Java: View has several minor changes due to generated code, such as field ordering.
-- gltfio: Fix crash when reloading glTF assets.
-- gltfio: introduce cross-fade animation API [**NEW API**].
-
-## v1.22.2
-
-- Java: Minor API change: rename `ssctStartTraceDistance` to `ssctShadowDistance`. [⚠️ **API Change**]
-- Java: Minor API change: rename `blendingMode` to `blendMode`. [⚠️ **API Change**]
-- engine: Fix some memory leaks.
-
-## v1.22.1
-
-- Metal: Shaders now use `half` floating-point arithmetic when possible for improved performance. [⚠️ **Recompile Materials**]
-- engine: add support for presentation time in `Renderer`
-- engine: added guard bands support for screen-space effects
-- gltfio: Add multi-scene support.
-- gltfio: Various glTF-related cleanup and enhancements.
-- gltfio: Add support for KHR_texture_basisu.
-
-## v1.22.0
-
-- engine: Changed UBOs layout [⚠️ **Material breakage**].
-- engine: Improve effects relying on mipmapping
-- engine: Fix assert seen with VSM shadows.
-- WebGL: Fix `isTextureFormatSupported` for ETC2 formats.
-
-## v1.21.3
-
-- Java: Renamed the `KTXLoader` Kotlin class to `KTX1Loader`.  [⚠️ **API Change**].
-- libs: Added `Ktx2Reader` and `BasisEncoder` to support Basis-encoded KTX2 files.
-- engine: Remove deprecated `Stream` APIs, see `Texture::import()` for an alternative [⚠️ **API Change**].
-- tools: Removed KTX1 compression support from mipgen.  [⚠️ **API Change**].
-- tools: Added support for KTX2 to mipgen.
-- gltfio: Added `resetBoneMatrices()` method.
-- gltfio: Introduced `TextureProvider` interface.  [⚠️ **API Change**].
-- gltfio: Fix progress indicator when error occurs.
-- samples: Desktop and Web Suzanne samples now use KTX2 instead of KTX1.
-- samples: Fix regression with sample-gltf-viewer and zip files.
-
-## v1.21.2
-
-- Java: Add Java binding to get skins in `FilamentAsset`.
-- libs: Add libs/ktxreader [⚠️ **API Change**].
-- mipgen: fixups / clarification regarding sRGB.
-- WebGL: fix intermittent 'detached ArrayBuffer' errors.
-
-## v1.21.1
-
-- engine: Allow both screen-space refraction and screen-space reflections on the same object [⚠️ **Material breakage**].
-- engine: Optimizations for screen-space reflections.
-- engine: Remove `Viewport::scale()` [⚠️ **API Change**].
-- engine: Fix 12x overallocation of memory in `MorphTargetBuffer`.
-- Metal: Fix validation error when reading from default `SwapChain`.
-
-## v1.21.0
-
-- engine: OpenGL performance improvements with some drivers.
-- engine: Fix incorrect shadows with some custom projection matrices.
-- engine: Fix low frame rates seen with a lot of morph targets.
-- gltfio: Add support for KHR_materials_variants.
-- gltfio: Add support for KHR_materials_emissive_strength.
-- gltfio: Java now exposes morph target names as an array for consistency [⚠️ **API Change**].
-
-## v1.20.5
-
-- engine: New behavior for MASKED to work with translucent views. [⚠️ **Recompile Materials** to get the fix]
-- engine: Fix screen-space reflections when post-processing and MSAA are off.
-- engine: Update MAX_MORPH_TARGETS constant to 256.
-- engine: Fix point light lighting with ortho projection.
-- libs: BlueGL symbols are now prefixed with `bluegl` on all platforms.
-- gltfio: Add skinning getters to `FilamentAsset`.
-
-## v1.20.4
-
-- gltfio: Java clients must now destroy the MaterialProvider [⚠️ **API Change**].
-- gltfio: Fix, bone pose not applied if glTF model doesn't have animations.
-- libs: Added `math::quat::fromDirectedRotation` [**NEW API**].
-- WebGL: Restore GL state when frame ends.
-
-## v1.20.3
-
-- Java: Fix URI bug in Android Viewer sample when dropping some zips.
-- Vulkan: Fix "uninitialized texture" warnings from the Vulkan backend.
-
-## v1.20.2
-
-- engine: Binary size optimizations.
-- engine: Fix, Mat4 from Quaternion was transposed.
-- Vulkan: Internal bug fixes and robustness improvements.
-- Vulkan: Reduced log spam.
-
-## v1.20.1
-
-- engine: Binary size improvements.
-- engine: Add basic support for instanced renderables [**NEW API**].
-- engine: Fix, first imaged passsed to `Stream::SetAcquiredImage` is ignored and leaked.
-- Vulkan: Robustness improvements.
-- Java: Fix, lookAt z axis negated.
-- gltfio: Be graceful when model has > 4 weights per vert.
-
-## v1.20.0
-
-- engine: Support rough screen-space reflections [⚠️ **Material breakage**].
-- engine: Added `Scene::forEach` API to iterate through a scene's entities.
-- engine: Fix incorrect normals with skinned models.
-- Vulkan: Fix segfault during shutdown.
-- WebGL: Support web apps that have multiple `FilamentViewer`s.
-- gltfio: Performance enhancements when loading models.
-
-## v1.19.0
-
-- engine: Support 256 morph targets.
-- engine: Screen-space reflection improvements.
-- engine: Morphing improvements and bug fixes.
-- gltfio: Generate morphing normals when they are missing.
-- gltfio: Support material extras.
-- Java: Add bindings for new morphing API.
-- Vulkan: Fix segfault on macOS.
-
-## v1.18.0
-
-- engine: Add support separate samplers in fragment and vertex shaders [⚠️ **Material breakage**].
-- engine: Support legacy morphing mode with vertex attributes.
-- engine: Allow more flexible quality settings for the ColorGrading LUT.
-- engine: Improve screen-space reflections quality and allow reflections and refractions together.
-- Vulkan: Bug fixes and improvements.
-
-## v1.17.0
-
-- engine: Add experimental glossy screen-space reflections.
-- engine: Add support for GPU morphing and 128 morph targets.
-- engine: Fix crash with non-shadow receiving renderables and VSM.
-- engine: Bring back the 3x3 filter for PCF shadows.
-- engine: Correct AABB calculation for skinned glTF models.
-
-## v1.16.1
-
-- engine: Added line/triangle strip support.
-
-## v1.16.0
-
-- engine: Fixes skinning calculations (#4887) [⚠️ **Material breakage**].
-- engine: Add support for the glTF extension KHR_materials_emissive_strength.
-- engine: Improvements and fixes to skinning calculations.
-- engine: Fix debug checks for compressed textures.
-- Metal: Fix `readPixels` when dimensions are greater than the render target's.
-
-## v1.15.2
-
-- engine: Add support for PCSS (Percentage Closer Soft Shadows).
-- engine: Fix spotlight shadow bias.
-- samples: Avoid leaking IBLs in Android sample-gltf-viewer.
-- libs: Fix `libibl` on mobile.
-
-## v1.15.1
-
-- engine: add support for DPCF (PCF shadows with contact hardening).
-- engine: add support for Wayland and Vulkan.
-- engine: Fade lights out when close to light far plane.
-- Java: Add missing `Engine#destroySkinningBuffer` method.
-
-## v1.15.0
-
-- engine: Fix spotlights normal bias calculation [⚠️ **Material breakage**].
-- libimage: Fix loading spherical harmonics on certain locals.
-
-## v1.14.2
-
-- Metal: Fix validation error when rendering to `RenderTarget` without depth attachment.
-- engine: Fix rendering glitch with zero-scale bone transforms.
-
-## v1.14.1
-
-- engine: Improvements to shadowing.
-
-## v1.14.0
-
-- engine: Internal materials can use structures as parameters [⚠️ **Material breakage**].
-- engine: `readPixels` on a `SwapChain` must be called within `beginFrame` / `endFrame` [⚠️ **API
-  Change**].
-- engine: Fix normal bias and improve spotlight quality.
-- Java: Fix shadow biases.
-
-## v1.13.0
-
-- Android: Gradle configuration caching is now enabled.
-- Android: Filament's Gradle properties have all been renamed to `com.google.android.filament.xxx`
-  where `xxx` is the property name. See `android/build.gradle` for a complete list [⚠️]
-- Android: The Gradle property `filament_tools_dir` (now called
-  `com.google.android.filament.tools-dir`) does not have a default value anymore. Please specify one
-  in your `gradle.properties` if you reuse the Gradle plugin in your projects [⚠️]
-- engine: Fix spotlights direction and falloff [⚠️ **Material breakage**].
-- engine: Improvements to VSM and spotlight shadows.
-
-## v1.12.11
-
-- Metal: Color grading performance improvement on M1 devices.
-- samples: Fix glitchy animation seen in gltf-viewer iOS sample.
-
-## v1.12.10
-
-- engine: rewrite dynamic resolution scaling controller for better accuracy and less jittering.
-- Java: fix missing ASTC texture enum.
-- tools: Fix normal map issues in mipgen.
-- WebGL: expose some `SurfaceOrientation` functions.
-
-## v1.12.9
-
-- engine: New API: `MultiSampleAntiAliasingOptions` and HDR-aware MSAA resolve. When `customResolve`
-  is enabled, improves anti-aliasing quality [**NEW API**].
-- engine: Fixes and improvements for FSR.
-- engine: All APIs that take a callback as argument now also take a `CallbackHandler*`, a new
-  interface that provides more flexibility around callback dispatch [**NEW API**].
-- Android: Fix JNI bindings for `DepthOfFieldOptions`.
-- Android: workarounds for Adreno-specific fraembuffer issue.
-- JavaScript: updates to JS bindings.
-
-## v1.12.8
-
-- engine: Added picking API to `View`  [⚠️ **Materials need to be rebuilt to access this new feature**].
-- engine: A new `Engine::pumpMessageQueues()` method can be used to trigger all pending user
-  callbacks right away [**NEW API**].
-- engine: new inline helpers to more easily use lambdas, functors and method callbacks with
-  `{Pixel}BufferDescriptor`.
-- Vulkan: fix vertical offset for `readPixels`.
-- Vulkan: various internal improvements.
-- Metal: support integer formats with `readPixels`.
-
-## v1.12.7
-
-- engine: Fix, apply emissive after shadowing.
-
-## v1.12.6
-
-- engine: Added concept of lod bias to materials.
-  [⚠️ **Materials need to be rebuilt to access this new feature**].
-- engine: Fix, BGRA ordering respected for external images with OpenGL on iOS.
-- engine: Use more sensible defaults for spot light inner outer cone angles.
-- engine: Fix potential race condition that caused stalls in `endFrame`.
-- gltfio: Improved handling of transparent materials.
-- Metal: Fix potential crash on earlier versions of iOS (<= 13.0).
-- Android: Fix `filament-utils-android` 'lite' flavor.
-- Java: Fix potential crash with `IBLPrefilter`.
-
-## v1.12.5
-
-- engine: work around a job scheduling issue in `endFrame` that caused stuttering on some Android
-devices.
-
-## v1.12.4
-
-- engine: New night adaptation API on `ColorGrading`. This API can be used to create an effect that
-  that simulates color and brightness shifts in human vision in low-light conditions.
-- engine: improved performance of AMD FidelityFX FSR1 by 4.6x, it now runs in about 2ms in 4K.
-- engine: Dynamic resolution quality `MEDIUM`, `HIGH` and `ULTRA` now all use AMD FidelityFX FSR1.
-- engine: Fix crash when duplicating material instances.
-- gltfio: generate tangents if requested by the material.
-
-## v1.12.3
-
-- engine: Support AMD FidelityFX Super Resolution for dynamic resolution scaling
-
-## v1.12.2
-
-- engine: New API on `ColorGrading` to enable or disable gamut mapping at will [**New API**].
-- engine: Fix typo causing ShadowOptions::shadowFar to not work properly.
-- engine: Fix, CSM glitch when using shadowMultiplier materials.
-- engine: Improve precision when computing camera projection.
-- engine: Increase the number of supported spot shadows to 14 (from 6).
-- Metal: Add texture swizzling support for external textures.
-
-## v1.12.1
-
-- engine: `double` precision translation support in TransformManager. Disabled by default.
-  Augment model (and view) matrix on `Camera` to accept double precision matrices. When enabled,
-  double precision translations allow filament to handle a very large world space [**New API**].
-- engine: Fix, Views with custom render targets are now blendable.
-
-## v1.12.0
-
-- engine: Option to automatically compute bent normals from SSAO & apply to specular AO
-  [⚠️ **Material breakage**].
-- engine: New APIs: Light channels. Geometry and lights now have a channel associated to them, at
-  least one channel must match for lighting to occur [⚠️ **Material breakage**].
-- engine: Fix potential GPU crash with punctual lights near the far clipping plane.
-- materials: The `inverseTonemap` API is now an exact inverse of the Filmic tonemapper.
-- Metal: Better support for texture formats on M1 Macs.
-
-## v1.11.2
-
-- engine: New API: `ColorGrading::Builder::toneMapper(const ToneMapper*)`.
-- engine: New tone mapper: `GenericToneMapper`, a configurable tone mapper.
-- engine: `ColorGrading::Builder::toneMapping(ColorGrading::ToneMapping)` is now deprecated.
-- engine: Removed `REINHARD` tonemap operator[⚠️ **API Change**].
-- engine: Improve s3tc_srgb detection on desktop.
-- engine: Add bilateral threshold in SSAO options.
-- gltfio: Fix AssetLoader leak, remove unwanted destructor.
-- Metal/Vulkan: Fix uploading texture data with padding or offset.
-- Metal: fix GPU crash seen with large amounts of geometry.
-
-## v1.11.1
-
-- engine: Luminance scaling can now be used with any tone mapping operator. It was previously tied
-  to the "EVILS" tone mapping operator.
-- engine: Removed the "EVILS" tone mapping operator [⚠️ **API Change**].
-- engine: Improvements to Skinning. A new `SkinningBuffer` API allows bone sharing between
-  renderables.
-- engine: Improvements to internal memory allocation for Metal and Vulkan backends.
-- engine: Default to OpenGL backend when Windows does not support Vulkan.
-- samples: Add new sample app: image_viewer.
-
-## v1.11.0
-
-- engine: Added support for transparent shadows. Add `transparentShadow : true` in the material file.
-- engine: honor user-defined precision in material files for non-samplers, rename `SamplerPrecision`
-  to `ParameterPrecicion`. [⚠️ **API Change**]
-- engine: Work around Qualcomm issue with point lights.
-- engine: Allow MSAA when post-processing is disabled.
-- engine: enable up to 6 spot-light shadows.
-- gltfio: Added support for `KHR_materials_volume`.
-- gltfio: fix precision in KHR_texture_transform.
-- java: Removed support for Java desktop targets (macOS, Linux, and Windows) [⚠️ **API Change**].
-
-## v1.10.7
-
-- engine: Spot-light position calculation moved to fragment shader.
-- engine: Small shadow mapping fixes and improvements.
-- gltfio: Add fast path for native material providers.
-- gltfio: Allow Java / Kotlin clients to customize MaterialProvider.
-- engine: Fix out of bounds access with `RenderTarget` java bindings.
-- Metal: `TextureFormat::DEPTH24_STENCIL8` now maps to a 32 bit depth format on iOS.
-
-## v1.10.6
-
-- engine: Use exponential VSM and improve VSM user settings [⚠️ **Recompile Materials for VSM**].
-- engine: Optional blurring of VSM shadowmaps.
-- engine: Fix a crash when using lens flares.
-- engine: Fix backend crashes when using an unsupported sample count.
-- gltfio: Add new `getAsset`API to `FilamentInstance`.
-- gltfio: Introduce support for extras strings.
-- OpenGL: Increase OpenGL backend handle arena from 2 to 4 MiB.
-- Vulkan: Fix Texture swizzle support.
-
-## v1.10.5
-
-- android: AAR libraries now properly include their ProGuard rules.
-- engine: User materials can now provide custom lighting/surface shading, please consult
-  the [materials documentation](https://google.github.io/filament/Materials.html) for details.
-- engine: `Backend::DEFAULT` now selects the most appropriate backend for the platform, rather than
-  always `OPENGL`. On Android the default is `OPENGL`, on Apple platforms the default is `METAL` and
-  on all other platforms that default is `VULKAN`.
-- engine: Fix a potential memory corruption when using more than 4 render targets.
-- engine: Fix a possible crash when bloom is enabled.
-- engine: Fix and refactor support for S3TC + SRGB with OpenGL.
-- engine: Fix automatic clearing of rendertargets.
-- engine: Fix imported render target discard and clear flags.
-- engine: Fix opaque blit with imported render targets.
-
-## v1.10.4
-
-- engine: improvements to internal job system.
-- Vulkan: performance improvements on Mali.
-- gltfio: improvements to load time for large models.
-- WebGL: remove bogus stride argument, fix `BindingType` TypeScript definition.
-
-## v1.10.3
-
-- android: use `debug.filament.backend` system property to select the desired backend.
-- engine: fix `LightManager::getFalloff`.
-- gltfio: fix crash with non-triangles.
-- macOS: fix main thread checker warnings with OpenGL.
-- vulkan: fix crash on Windows machines with NVIDIA GPUs.
-
-## v1.10.2
-
-- Vulkan: validation and diagnostic improvements
-- engine: improvements for scenes with many renderables.
-- gltfio: added support for `KHR_materials_ior`.
-- java: Add bindings for `IBLPrefilterContext`.
-- java: add `KTXLoader.getSphericalHarmonics` JNI binding
-- libimage: fix, respect sRGB option for compressed formats.
-- sample-gltf-viewer: fix lifetime cycle for RemoteServer.
-
-## v1.10.1
-
-- engine: Add `getPlatform` API to Engine.
-- engine: Add a new cone angles API to `LightManager`.
-- engine: Attachments of custom RendereTargets are not systematically discarded.
-- engine: Fix a crash when using custom rendertargets.
-- engine: New API to duplicate a `MaterialInstance`.
-- filagui: fix support for custom images in ImGuiHelper.
-- java: Add bindings for HDRLoader.
-
-## v1.10.0
-
-- engine: User materials can now use 9 samplers instead of 8 [⚠️ **Material breakage**].
-- engine: Remove `populateTangentQuaternions`  [⚠️ **API change**].
-- engine: Deprecate `Stream::Builder::stream(intptr_t)` [⚠️ **API Change**].
-- engine: Remove deprecated APIs: `Camera::setScaling`, `Engine::destroy(Camera*)`,
-  `Engine::createCamera`, `Renderer::beginFrame(SwapChain*, uint64_t,
-  backend::FrameScheduledCallback, void*)`, and `View::setShadowsEnabled` [⚠️ **API Change**].
-- engine: Remove `focusDistance` from `View::BloomOptions` [⚠️ **API Change**].
-- engine: Add a `FILAMENT_SUPPORTS_OPENGL` CMake option to enable/disable OpenGL support.
-- Vulkan: fixes and improvements for large scenes.
-- gltfio: fix morphing bugs uncovered by MorphStressTest.
-- Java: add API for `Texture::Builder::import()`.
-- WebGL: Fix a potential INVALID_OPERATION.
-
-## v1.9.25
-
-- NEW API: Screen-space lens flare effect.
-- engine: Fix several memory leaks in the GL backend.
-- Vulkan: General bug fixes and improvements.
-- Vulkan: Fix some problems seen on Mali devices.
-- ios: Fix VSM shadows not working.
-- webgl: Fix black screen seen with some samples.
-
-## v1.9.24
-
-- engine: Fix memory leaks in OpenGL driver.
-- engine: new experimental tone mapper, `EVILS` (name will most likely change).
-- engine: Improvements to Vulkan backend.
-- engine: Fix incorrect units documented for `LightManager.getIntensity`.
-- engine: fix high quality upsampling for SSAO.
-- engine: implement accurate normal reconstruction for SSAO.
-- engine: improve LOW and HIGH quality levels for SSAO.
-- libs: improvements to `libiblprefilter`.
-- materials: New `quality` property.
-- samples: Add new gltf-viewer iOS sample.
-- samples: clear the background in lightbulb sample.
-
-## v1.9.23
-
-- Vulkan: various fixes.
-- android: fix crash seen using VSM with MSAA on Adreno devices.
-- engine: Add `Engine::getEntityManager()`.
-- engine: Fix desktop crash seen with some GPU drivers.
-- engine: improve importance sampling.
-- gltfio: robustness improvements for Draco meshes.
-- libs: Add new Transcoder API for C++ clients (part of `libgeometry`).
-- libs: New `iblprefilter` library to compute IBL pre-integration on the GPU using filament.
-- materials: Fix documentation for `getNormalizedViewportCoord`.
-- samples: fix rendertarget sample crash on launch.
-
-## v1.9.22
-
-- NEW API: `Renderer::renderStandaloneView()` is a new method that can be used outside of
-  beginFrame/endFrame on Views that have a RenderTarget associated. This can be used as a
-  pseudo-compute API.
-- Vulkan: bug fixes and improvements.
-- engine: RenderTarget API can now use MRT.
-- sample-gltf-viewer: improvements for reading zip files.
-- sample-gltf-viewer: enable contact-shadows functionality in mobile gltf-viewer.
-- windows: fix build error in filament_framegraph_test.
-
-## v1.9.21
-
-- JavaScript: add missing TextureSampler bindings.
-- Metal: Fix texture swizzling crash with older Nvidia GPUs.
-- Vulkan: fix image layout validation error on Android.
-- android: fix MSAA w/ multisampled_render_to_texture on Mali.
-- engine: better anisotropic filtering with various drivers.
-- gltfio: Use BufferObject API, simplify MorphHelper.
-- gltfio: honor stride in normalizeSkinningWeights.
-- samples: Add web component demo.
-
-## v1.9.20
-
-- Android: Fix VSM.
-- engine: Introduce BufferObject API.
-- engine: Add new isTextureSwizzleSupported API on Texture.
-- engine: Add support to Metal and Vulkan backends for texture swizzling.
-- engine: Add new DoF settings (native/half res, gather kernel ring counts, CoC radius clamp).
-- engine: DoF quality and performance improvements.
-- engine: Fix high-quality upsampling issue with SSAO.
-- Java: Expose `TransformManager.getParent(int)`.
-- samples: Add Metal and Vulkan backend support to Suzanne sample.
-- WebGL: expose fitIntoUnitCube to JS.
-- WebGL: support for multiple `<canvas>` elements.
-
-## v1.9.19
-
-- engine: Fix Metal bug when setGeometryAt is called multiple times.
-- engine: Improvements to DoF.
-- engine: Fix RenderTarget NPE when depth is not present.
-- engine: Improvements to Camera APIs. Move focus distance from DofOptions to Camera.
-- engine: VSM shadows now support `shadowMultiplier`.
-- java: Expose several MaterialInstance APIs (setColorWrite, setDepthWrite, setDepthCulling) that
-  should have been public.
-- java: fix bug with Texture::setImage buffer size calculation.
-
-## v1.9.18
-
-- engine: Fix a DoF bug that caused black dots around the fast tiles.
-- engine: Minor DoF optimizations.
-- engine: Fix blanking windows not being drawn into on macOS.
-- gltfio: Add support for data:// in image URI's.
-- gltfio: Add internal MorphHelper, enable up to 255 targets.
-- engine: Fix a hang in JobSystem.
-- samples: Fix rendertarget sample app.
-
-## v1.9.17
-
-- engine: New shift parameter on `Camera` to translate the viewport and emulate a tilt/shift lens.
-- engine: `Camera::setCustomProjection()` now allows to set a different projection for culling and rendering.
-- engine: Fixed depth of field rendering with custom projection matrices.
-- engine: Fix a rare indefinite hang.
-- gltfio: `SimpleViewer` now exposes more rendering parameters, including `ColorGrading`.
-- gltfio: Fix tangents when morphing is enabled.
-- Metal/Vulkan: fix incorrect dominant light shadows rendering.
-- Fixe some issues with imported rendertargets.
-
-## v1.9.16
-
-gltfio: Add ResourceLoader evict API.
-gltfio: Fix ResourceLoader cache bug.
-iOS: Disable exceptions to reduce binary size.
-
-## v1.9.15
-
-- filamat/matc: fix sporadic crash.
-
-## v1.9.14
-
-- Improve bloom/emissive with glTF files.
-- Publicly expose Exposure API for gltfio.
-
-## v1.9.13
-
-- Android: fix "No implementation found" error.
-- Android: fix compilation error in UbershaderLoader.
-- engine: computeDataSize now returns correct value for USHORT_565.
-- Vulkan: various internal improvements.
-
-## v1.9.12
-
-- engine: Fixed GL errors seen with MSAA on WebGL.
-  Warning: this can affect multisampling behavior on devices that do not support OpenGL ES 3.1
-- materials: Added new `getVertexIndex()` API for vertex shaders.
-- samples: RenderTarget demo now disables post-processing in offscreen view and creates depth attachment.
-- gltfio: Fix, animation jolt when time delta is very small.
-
-## v1.9.11
-
-- Added support for Apple silicon Macs. build.sh can now be used to build on either Apple silicon or
-  Intel-based Macs. Pass the `-l` flag to build universal binaries.
-- Added `sheenColor` and `sheenRoughness` properties to materials to create cloth/fabric.
-- Materials generation using `libfilamat` is now multi-threaded.
-- `MaterialBuilder::build()` now expects a reference to a `JobSystem` to multi-thread shaders
-  generation. A `JobSystem` can be obtained with `Engine::getJobSystem()` when using Filament,
-  or created directly otherwise. (⚠️ **API change**)
-- Add planar reflection RenderTarget demo.
-- Metal: honor inverseFrontFaces RasterState.
-- Metal: Fix crash when switching between views with shadowing enabled.
-- Metal: Fix crash when calling Texture::setImage() on SAMPLER_2D_ARRAY texture.
-- gltfio: added support for `KHR_materials_sheen`.
-- gltfio: shader optimizations are now disabled by default, unless opting in or using ubershaders.
-- gltfio: Fix "_maskThreshold not found" error.
-- gltfio on Java: fix potential memory leak in AssetLoader#destroy.
-- gltfio: fix crash during async texture decode.
-- gltfio: support animation in dynamically-added instances.
-- gltfio: Improve robustness when decoding textures.
-- gltfio: Fix animator crash for orphaned nodes.
-- gltfio: fix tangents with morphing.
-- gltf_viewer: fix very sporadic crash when exiting.
-- gltf_viewer: fix crash when rapidly switching between glTF models.
-- WebGL: Fix samples erroring on Windows with Chrome.
-- WebGL: Support `highlight` for setBloomOptions in JavaScript.
-- WebGL: Include TypeScript bindings in releases.
-- engine: Fix, punctual lights get clipped at certain angles.
-- engine: Fix memory leak when calling `View::setViewport` frequently.
-- engine: Fix, materials not working on some Qualcomm devices.
-- engine: Modulate emissive by alpha on blended objects.
-- engine: Fix, RenderTarget cleared multiple times.
-- Java: Fix JNI bindings for color grading.
-- Android: reduced binary size.
-
-## v1.9.10
-
-- Introduce `libibl_lite` library.
-- engine: Fix `EXC_BAD_INSTRUCTION` seen when using headless SwapChains on macOS with OpenGL.
-- engine: Add new callback API to `SwapChain`.
-- engine: Fix SwiftShader crash when using an IBL without a reflections texture.
-- filamat: Shrink internal `Skybox` material size.
-- filamat: improvements to generated material size.
-- filamat: silence spirv-opt warnings in release builds.
-- matc: Add fog variant filter.
-- matc: Fix crash when building mobile materials.
-- math: reduce template bloat for matrices.
-
-## v1.9.9
-
-- Vulkan: internal robustness improvements.
-- Metal: Support CVPixelBuffer SwapChains.
-- Metal: Support copyFrame.
-- Fix clear behavior with RenderTarget API.
-- Fix GetRefractionMode JNI binding.
-- Additional fixes for Fence bug.
-
-## v1.9.8
-
-- Fix a few Fence-related bugs
-- gltfio: add createInstance() to AssetLoader.
-- gltfio: fix ASAN issue when consuming invalid animation.
-- gltfio: do not segfault on invalid primitives.
-- gltfio: add safety checks to getAnimator.
-- gltfio: fix segfault when consuming invalid file.
-- Vulkan: various internal refactoring and improvements
-- mathio: add ostream operator for quaternions.
-- Fix color grading not applied when dithering is off.
-
-## v1.9.7
-
-- Vulkan: improvements to the ReadPixels implementation.
-- Vulkan: warn instead of panic for sampler overflow.
-- Vulkan: fix leak with headless swap chain.
-- PlatformVkLinux now supports all combos of XLIB and XCB.
-- Fix TypeScript binding for TextureUsage.
-
-## v1.9.6
-
-- Added View::setVsmShadowOptions (experimental)
-- Add anisotropic shadow map sampling with VSM (experimental)
-- matc: fixed bug where some compilation failures still exited with code 0
-- Vulkan + Android: fix build break
-- Add optional XCB support to PlatformVkLinux
-- Fix Vulkan black screen on Windows with NVIDIA hardware
-
-## v1.9.5
-
-- Added a new Live Wallpaper Android sample
-- `UiHelper` now supports managing a `SurfaceHolder`
-- Fix: an internal texture resource was never destroyed
-- Fix: hang on 2-CPU machines
-- Fix: Vulkan crash when using shadow cascades
-- Linux fixes for headless SwiftShader
-- Fix null pointer dereference in `FIndirectLight`
-- Fix Windows build by avoiding nested initializers
-- Vulkan: support readPixels and headless swap chains
-- VSM improvements
-
-## v1.9.4
-
-- Add screen space cone tracing (SSCT)
-- Improvements to VSM shadow quality
-- New `ShadowOptions` control to render Variance Shadow Maps (VSM) with MSAA (experimental)
-- Improvements and fixes to screen-space ambient occlusion
-- gltf_viewer: add --headless option
-- gltf_viewer: Add new automation UI and functionality
+## Next release (v1.9.4)
 
 ## v1.9.3
 

android/Windows.md

@@ -6,29 +6,11 @@ In addition to the requirements for [building Filament on Windows](../BUILDING.m
 need the Android SDK and NDK. See [Getting Started with the
 NDK](https://developer.android.com/ndk/guides/) for detailed installation instructions.
 
-You'll also need [Ninja 1.8](https://github.com/ninja-build/ninja/wiki/Pre-built-Ninja-packages) (or
-more recent) and [Git for Windows](https://git-scm.com/download/win) to clone the repository and run
-Bash scripts.
-
 Ensure the `%ANDROID_HOME%` environment variable is set to your Android SDK installation location.
 
 On Windows, we require VS2019 for building the host tools. All of the following commands should be
 executed in a *Visual Studio x64 Native Tools Command Prompt for VS 2019*.
 
-### A Note About Python 3
-
-Python 3 is required. If CMake errors because it cannot find Python 3:
-
-```
-Could NOT find PythonInterp: Found unsuitable version "1.4", but required is at least "3"
-```
-
-then add the following flag to the CMake invocations:
-
-```
--DPYTHON_EXECUTABLE:FILEPATH=\path\to\python3
-```
-
 ## Desktop Tools
 
 First, a few Filament tools need to be compiled for desktop.
@@ -122,20 +104,20 @@ The Gradle project used to generate the AAR is located at `<filament>\android`.
 
 ```
 cd android
-gradlew -Pcom.google.android.filament.dist-dir=..\out\android-release\filament assembleRelease
+gradlew -Pfilament_dist_dir=..\out\android-release\filament assembleRelease
 copy filament-android\build\outputs\aar\filament-android-release.aar ..\..\out\
 ```
 
-If you're only interested in building for a single ABI, you'll need to pass a `com.google.android.filament.abis` parameter:
+If you're only interested in building for a single ABI, you'll need to pass a `filament_abis` parameter:
 
 ```
-gradlew -Pcom.google.android.filament.dist-dir=..\out\android-release\filament assembleRelease -Pcom.google.android.filament.abis=x86
+gradlew -Pfilament_dist_dir=..\out\android-release\filament assembleRelease -Pfilament_abis=x86
 ```
 
-If you're only interested in building SDK, you may skip samples build by passing a `com.google.android.filament.skip-samples` flag:
+If you're only interested in building SDK, you may skip samples build by passing a `filament_skip_samples` flag:
 
 ```
-gradlew -Pcom.google.android.filament.dist-dir=..\out\android-release\filament assembleRelease -Pfilament_skip_samples
+gradlew -Pfilament_dist_dir=..\out\android-release\filament assembleRelease -Pfilament_skip_samples
 ```
 
 

android/build.gradle

@@ -1,40 +1,38 @@
 // This script accepts the following parameters:
 //
-// com.google.android.filament.dist-dir
+// filament_dist_dir
 //     Path to the Filament distribution/install directory for Android
 //     (produced by make/ninja install). This directory must contain lib/arm64-v8a/ etc.
 //
-// com.google.android.filament.tools-dir
+// filament_tools_dir
 //     Path to the Filament distribution/install directory for desktop.
 //     This directory must contain bin/matc.
 //
-// com.google.android.filament.exclude-vulkan
+// filament_exclude_vulkan
 //     When set, support for Vulkan will be excluded.
 //
-// com.google.android.filament.matdbg
-//     When set, enables matdbg, disables shader optimizations
-//
-// com.google.android.filament.skip-samples
+// filament_skip_samples
 //     Exclude samples from the project. Useful to speed up compilation.
 //
-// com.google.android.filament.abis
+// filament_abis
 //     List of supported ABIs to build as a comma separated list. Available options are:
 //         arm64-v8a, armeabi-v7a, x86_64, x86, all
 //     Defaults to all.
 //
 // Example:
-//     ./gradlew -Pcom.google.android.filament.dist-dir=../dist-android-release \
-//               -Pcom.google.android.filament.abis=x86 \
-//               assembleRelease
+//     ./gradlew -Pfilament_dist_dir=../dist-android-release assembleRelease -Pfilament_abis=x86
 
 // Publishing to Maven Central:
 //   - Build and upload artifacts with ./gradlew publish
-//   - Close and release staging repo on Nexus with ./gradlew closeAndReleaseStagingRepository
+//   - Close and release staging repo on Nexus with ./gradlew closeAndReleaseRepository
 //
 // The following is needed in ~/gradle/gradle.properties:
 //
-//     sonatypeUsername=nexus_user
-//     sonatypePassword=nexus_password
+//     SONATYPE_NEXUS_USERNAME=nexus_user
+//     SONATYPE_NEXUS_PASSWORD=nexus_password
+//
+//     nexusUsername=nexus_user
+//     nexusPassword=nexus_password
 //
 //     signing.keyId=pgp_key_id
 //     signing.password=pgp_key_password
@@ -42,78 +40,61 @@
 //
 
 buildscript {
-    def path = providers
-            .gradleProperty("com.google.android.filament.dist-dir")
-            .get()
-
-    def directory = objects.fileProperty().fileValue(new File(path)).getAsFile().get()
-    def filamentPath = directory.absolutePath
-
+    def filamentPath = file("../out/android-release/filament").absolutePath
+    if (project.hasProperty("filament_dist_dir")) {
+        filamentPath = file(project.property("filament_dist_dir")).absolutePath
+    }
     // Our CMake scripts require a forward-slash path for the FILAMENT_DIST_DIR
     // variable, so here we convert the native path to a forward-slash path.
     filamentPath = filamentPath.replace(File.separator, '/')
 
     // Warning: changing this property does not work well with incremental builds.
-    def excludeVulkan = providers
-            .gradleProperty("com.google.android.filament.exclude-vulkan")
-            .isPresent()
-
-    def matdbg = providers
-            .gradleProperty("com.google.android.filament.matdbg")
-            .isPresent()
+    def excludeVulkan = project.hasProperty("filament_exclude_vulkan")
 
     def abis = ["arm64-v8a", "armeabi-v7a", "x86_64", "x86"]
-    def newAbis = providers
-            .gradleProperty("com.google.android.filament.abis")
-            .get()
-            .split(',')
-    if (!newAbis.contains("all")) {
-        abis = newAbis
+    if (project.hasProperty("filament_abis")) {
+        def newAbis = project.property("filament_abis").split(',')
+        if (!newAbis.contains("all")) {
+            abis = newAbis
+        }
     }
 
+    // Our minSdkVersion is 19.
     ext.versions = [
         'minSdk': 19,
-        'targetSdk': 33,
-        'compileSdk': 33,
-        'kotlin': '1.7.10',
-        'kotlin_coroutines': '1.6.1',
-        'buildTools': '33.0.0',
-        'ndk': '25.1.8937393',
-        'androidx_core': '1.9.0',
-        'androidx_annotations': '1.3.0'
+        'targetSdk': 29,
+        'compileSdk': 29,
+        'kotlin': '1.4.10',
+        'buildTools': '30.0.1',
+        'ndk': '21.3.6528147'
     ]
 
     ext.deps = [
         'androidx': [
-            'annotations': "androidx.annotation:annotation:${versions.androidx_annotations}",
-            'core': "androidx.core:core:${versions.androidx_core}",
+            'annotations': "androidx.annotation:annotation:1.1.0",
+            'core': "androidx.core:core:1.3.0",
         ],
-        'kotlin': "org.jetbrains.kotlin:kotlin-stdlib-jdk8:${versions.kotlin}",
-        'coroutines': [
-            'core': "org.jetbrains.kotlinx:kotlinx-coroutines-core:${versions.kotlin_coroutines}",
-            'android': "org.jetbrains.kotlinx:kotlinx-coroutines-android:${versions.kotlin_coroutines}",
-        ]
+        'kotlin': "org.jetbrains.kotlin:kotlin-stdlib-jdk8:${versions.kotlin}"
     ]
 
     dependencies {
-        // NOTE: See TODO in gradle.properties once we move to Gradle 7.4
-        classpath 'com.android.tools.build:gradle:7.3.0'
+        classpath 'com.android.tools.build:gradle:4.0.1'
         classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:${versions.kotlin}"
     }
 
     ext.cmakeArgs = [
-        "--no-warn-unused-cli",
         "-DANDROID_PIE=ON",
         "-DANDROID_PLATFORM=21",
         "-DANDROID_STL=c++_static",
         "-DFILAMENT_DIST_DIR=${filamentPath}".toString(),
-        "-DFILAMENT_SUPPORTS_VULKAN=${excludeVulkan ? 'OFF' : 'ON'}".toString(),
-        "-DFILAMENT_ENABLE_MATDBG=${matdbg ? 'ON' : 'OFF'}".toString(),
-        "-DFILAMENT_DISABLE_MATOPT=${matdbg ? 'ON' : 'OFF'}".toString()
+        "-DFILAMENT_SUPPORTS_VULKAN=${excludeVulkan ? 'OFF' : 'ON'}".toString()
     ]
 
     ext.cppFlags = [
         "-std=c++17",
+        "-Wno-unused-command-line-argument",
+        // Required to support API levels below 23
+        "-Wl,--hash-style=both",
         "-fno-stack-protector",
         "-fno-exceptions",
         "-fno-unwind-tables",
@@ -126,13 +107,8 @@ buildscript {
         "-fomit-frame-pointer",
         "-ffunction-sections",
         "-fdata-sections",
-        "-no-canonical-prefixes",
-        "-Wformat",
-        "-Werror=format-security",
-        "-Wno-unused-command-line-argument",
         "-Wl,--gc-sections",
         "-Wl,-Bsymbolic-functions",
-        "-Wl,--hash-style=both", // Required to support API levels below 23
     ]
 
     ext.abis = abis
@@ -140,22 +116,19 @@ buildscript {
     repositories {
         mavenCentral()
         google()
+        jcenter()
     }
 }
 
 plugins {
-    id "io.github.gradle-nexus.publish-plugin" version "1.1.0"
+    id 'io.codearte.nexus-staging' version '0.22.0'
 }
 
-// See https://github.com/gradle-nexus/publish-plugin
-// Publish to https://oss.sonatype.org/ (not s01)
-nexusPublishing {
+// Nexus Staging configuration
+// See https://github.com/Codearte/gradle-nexus-staging-plugin/
+nexusStaging {
     packageGroup = 'com.google.android'
-    repositories {
-        sonatype {
-            stagingProfileId = '9a75a224a4f17b'
-        }
-    }
+    stagingProfileId = '9a75a224a4f17b'
 }
 
 subprojects {
@@ -165,6 +138,7 @@ subprojects {
     repositories {
         mavenCentral()
         google()
+        jcenter()
     }
 
     if (!name.startsWith("sample")) {
@@ -189,13 +163,11 @@ subprojects {
                 ndk {
                     abiFilters(*rootProject.ext.abis)
                 }
-
-                consumerProguardFiles '../proguard-rules.pro'
             }
 
+
             externalNativeBuild {
                 cmake {
-                    version "3.19.0+"
                     path "CMakeLists.txt"
                 }
             }
@@ -217,8 +189,7 @@ subprojects {
 gradle.taskGraph.whenReady {
     gradle.taskGraph.allTasks.each {
         it.onlyIf {
-            !it.project.ext.has('isSample') ||
-                    !project.hasProperty('com.google.android.filament.skip-samples')
+            !it.project.ext.has('isSample') || !project.hasProperty('filament_skip_samples')
          }
     }
 }

android/buildSrc/build.gradle

@@ -1,16 +1,3 @@
-plugins {
-    id 'groovy-gradle-plugin'
-}
-
-gradlePlugin {
-    plugins {
-        create("filament-tools-plugin") {
-            id = "filament-tools-plugin"
-            implementationClass = "FilamentToolsPlugin"
-        }
-    }
-}
-
 repositories {
     mavenCentral()
 }

android/buildSrc/src/main/groovy/FilamentPlugin.groovy

@@ -1,72 +1,56 @@
 // This plugin accepts the following parameters:
 //
-// com.google.android.filament.tools-dir
+// filament_tools_dir
 //     Path to the Filament distribution/install directory for desktop.
 //     This directory must contain bin/matc.
 //
-// com.google.android.filament.exclude-vulkan
+// filament_exclude_vulkan
 //     When set, support for Vulkan will be excluded.
 //
 // Example:
-//     ./gradlew -Pcom.google.android.filament.tools-dir=../../dist-release assembleDebug
+//     ./gradlew -Pfilament_tools_dir=../../dist-release assembleDebug
 
 import org.gradle.api.DefaultTask
 import org.gradle.api.GradleException
 import org.gradle.api.Plugin
 import org.gradle.api.Project
-import org.gradle.api.provider.ProviderFactory
 import org.gradle.api.file.DirectoryProperty
-import org.gradle.api.file.FileSystemOperations
 import org.gradle.api.file.FileType
 import org.gradle.api.file.RegularFileProperty
 import org.gradle.api.logging.LogLevel
 import org.gradle.api.logging.Logger
-import org.gradle.api.provider.Property
-import org.gradle.api.tasks.Input
 import org.gradle.api.tasks.InputDirectory
 import org.gradle.api.tasks.InputFile
-import org.gradle.api.tasks.Optional
 import org.gradle.api.tasks.OutputDirectory
 import org.gradle.api.tasks.TaskAction
 import org.gradle.api.tasks.incremental.InputFileDetails
-import org.gradle.api.model.ObjectFactory
 import org.gradle.internal.os.OperatingSystem
-import org.gradle.process.ExecOperations
 import org.gradle.work.ChangeType
 import org.gradle.work.Incremental
 import org.gradle.work.InputChanges
 
 import java.nio.file.Paths
 
-import javax.inject.Inject
-
-abstract class TaskWithBinary extends DefaultTask {
+class TaskWithBinary extends DefaultTask {
     private final String binaryName
-    private Property<String> binaryPath = null
+    private File binaryPath = null
 
     TaskWithBinary(String name) {
         binaryName = name
     }
 
-    @Inject abstract ObjectFactory getObjects()
-    @Inject abstract ProviderFactory getProviders()
+    String getBinaryName() {
+        return binaryName
+    }
 
-    @Input
-    Property<String> getBinary() {
+    File getBinary() {
         if (binaryPath == null) {
             def tool = ["/bin/${binaryName}.exe", "/bin/${binaryName}"]
             def fullPath = tool.collect { path ->
-                def filamentToolsPath = providers
-                        .gradleProperty("com.google.android.filament.tools-dir")
-                        .forUseAtConfigurationTime().get()
-                def directory = objects.fileProperty()
-                        .fileValue(new File(filamentToolsPath)).getAsFile().get()
-                Paths.get(directory.absolutePath, path).toFile()
+                Paths.get(project.ext.filamentToolsPath.absolutePath, path).toFile()
             }
 
-            binaryPath = objects.property(String.class)
-            binaryPath.set(
-                    (OperatingSystem.current().isWindows() ? fullPath[0] : fullPath[1]).toString())
+            binaryPath = OperatingSystem.current().isWindows() ? fullPath[0] : fullPath[1]
         }
         return binaryPath
     }
@@ -81,6 +65,14 @@ class LogOutputStream extends ByteArrayOutputStream {
         this.level = level
     }
 
+    Logger getLogger() {
+        return logger
+    }
+
+    LogLevel getLevel() {
+        return level
+    }
+
     @Override
     void flush() {
         logger.log(level, toString())
@@ -93,15 +85,10 @@ class LogOutputStream extends ByteArrayOutputStream {
 abstract class MaterialCompiler extends TaskWithBinary {
     @Incremental
     @InputDirectory
-    abstract DirectoryProperty getInputDir()
+    final DirectoryProperty inputDir = project.objects.directoryProperty()
 
     @OutputDirectory
-    abstract DirectoryProperty getOutputDir()
-
-    @Inject abstract FileSystemOperations getFs()
-    @Inject abstract ExecOperations getExec()
-    @Inject abstract ObjectFactory getObjects()
-    @Inject abstract ProviderFactory getProviders()
+    final DirectoryProperty outputDir = project.objects.directoryProperty()
 
     MaterialCompiler() {
         super("matc")
@@ -110,9 +97,7 @@ abstract class MaterialCompiler extends TaskWithBinary {
     @TaskAction
     void execute(InputChanges inputs) {
         if (!inputs.incremental) {
-            fs.delete({
-                delete(objects.fileTree().from(outputDir).matching { include '*.filamat' })
-            })
+            project.delete(project.fileTree(outputDir.asFile.get()).matching { include '*.filamat' })
         }
 
         inputs.getFileChanges(inputDir).each { InputFileDetails change ->
@@ -130,24 +115,21 @@ abstract class MaterialCompiler extends TaskWithBinary {
                 out.write(header)
                 out.flush()
 
-                if (!new File(binary.get()).exists()) {
-                    throw new GradleException("Could not find ${binary.get()}." +
+                if (!getBinary().exists()) {
+                    throw new GradleException("Could not find ${getBinary()}." +
                             " Ensure Filament has been built/installed before building this app.")
                 }
 
                 def matcArgs = []
-                def exclude_vulkan = providers
-                        .gradleProperty("com.google.android.filament.exclude-vulkan")
-                        .forUseAtConfigurationTime().present
-                if (!exclude_vulkan) {
+                if (!project.hasProperty("filament_exclude_vulkan")) {
                     matcArgs += ['-a', 'vulkan']
                 }
                 matcArgs += ['-a', 'opengl', '-p', 'mobile', '-o', getOutputFile(file), file]
 
-                exec.exec {
+                project.exec {
                     standardOutput out
                     errorOutput err
-                    executable "${binary.get()}"
+                    executable "${getBinary()}"
                     args matcArgs
                 }
             }
@@ -161,21 +143,15 @@ abstract class MaterialCompiler extends TaskWithBinary {
 
 // Custom task to process IBLs using cmgen
 // This task handles incremental builds
-abstract class IblGenerator extends TaskWithBinary {
-    @Input
-    @Optional
-    abstract Property<String> getCmgenArgs()
+class IblGenerator extends TaskWithBinary {
+    String cmgenArgs = null
 
     @Incremental
     @InputFile
-    abstract RegularFileProperty getInputFile()
+    final RegularFileProperty inputFile = project.objects.fileProperty()
 
     @OutputDirectory
-    abstract DirectoryProperty getOutputDir()
-
-    @Inject abstract FileSystemOperations getFs()
-    @Inject abstract ExecOperations getExec()
-    @Inject abstract ObjectFactory getObjects()
+    final DirectoryProperty outputDir = project.objects.directoryProperty()
 
     IblGenerator() {
         super("cmgen")
@@ -184,9 +160,7 @@ abstract class IblGenerator extends TaskWithBinary {
     @TaskAction
     void execute(InputChanges inputs) {
         if (!inputs.incremental) {
-            fs.delete({
-                delete(objects.fileTree().from(outputDir).matching { include '*' })
-            })
+            project.delete(project.fileTree(outputDir.asFile.get()).matching { include '*' })
         }
 
         inputs.getFileChanges(inputFile).each { InputFileDetails change ->
@@ -204,25 +178,23 @@ abstract class IblGenerator extends TaskWithBinary {
                 out.write(header)
                 out.flush()
 
-                if (!new File(binary.get()).exists()) {
-                    throw new GradleException("Could not find ${binary.get()}." +
+                if (!getBinary().exists()) {
+                    throw new GradleException("Could not find ${getBinary()}." +
                             " Ensure Filament has been built/installed before building this app.")
                 }
 
                 def outputPath = outputDir.get().asFile
-                def commandArgs = cmgenArgs.getOrNull()
-                if (commandArgs == null) {
-                    commandArgs =
-                            '-q -x ' + outputPath + ' --format=rgb32f ' +
-                                    '--extract-blur=0.08 --extract=' + outputPath.absolutePath
-                }
-                commandArgs = commandArgs + " " + file
-
-                exec.exec {
+                project.exec {
                     standardOutput out
+                    if (!cmgenArgs) {
+                        cmgenArgs =
+                                '-q -x ' + outputPath + ' --format=rgb32f ' +
+                                '--extract-blur=0.08 --extract=' + outputPath.absolutePath
+                    }
+                    cmgenArgs = cmgenArgs + " " + file
                     errorOutput err
-                    executable "${binary.get()}"
-                    args(commandArgs.split())
+                    executable "${getBinary()}"
+                    args(cmgenArgs.split())
                 }
             }
         }
@@ -235,16 +207,13 @@ abstract class IblGenerator extends TaskWithBinary {
 
 // Custom task to compile mesh files using filamesh
 // This task handles incremental builds
-abstract class MeshCompiler extends TaskWithBinary {
+class MeshCompiler extends TaskWithBinary {
     @Incremental
     @InputFile
-    abstract RegularFileProperty getInputFile()
+    final RegularFileProperty inputFile = project.objects.fileProperty()
 
     @OutputDirectory
-    abstract DirectoryProperty getOutputDir()
-
-    @Inject abstract FileSystemOperations getFs()
-    @Inject abstract ExecOperations getExec()
+    final DirectoryProperty outputDir = project.objects.directoryProperty()
 
     MeshCompiler() {
         super("filamesh")
@@ -253,9 +222,7 @@ abstract class MeshCompiler extends TaskWithBinary {
     @TaskAction
     void execute(InputChanges inputs) {
         if (!inputs.incremental) {
-            fs.delete({
-                delete(objects.fileTree().from(outputDir).matching { include '*.filamesh' })
-            })
+            project.delete(project.fileTree(outputDir.asFile.get()).matching { include '*.filamesh' })
         }
 
         inputs.getFileChanges(inputFile).each { InputFileDetails change ->
@@ -273,15 +240,15 @@ abstract class MeshCompiler extends TaskWithBinary {
                 out.write(header)
                 out.flush()
 
-                if (!new File(binary.get()).exists()) {
-                    throw new GradleException("Could not find ${binary.get()}." +
+                if (!getBinary().exists()) {
+                    throw new GradleException("Could not find ${getBinary()}." +
                             " Ensure Filament has been built/installed before building this app.")
                 }
 
-                exec.exec {
+                project.exec {
                     standardOutput out
                     errorOutput err
-                    executable "${binary.get()}"
+                    executable "${getBinary()}"
                     args(file, getOutputFile(file))
                 }
             }
@@ -315,12 +282,17 @@ class FilamentToolsPlugin implements Plugin<Project> {
         extension.meshInputFile = project.objects.fileProperty()
         extension.meshOutputDir = project.objects.directoryProperty()
 
+        project.ext.filamentToolsPath = project.file("../../../out/release/filament")
+        if (project.hasProperty("filament_tools_dir")) {
+            project.ext.filamentToolsPath = project.file(project.property("filament_tools_dir"))
+        }
+
         project.tasks.register("filamentCompileMaterials", MaterialCompiler) {
             enabled =
                     extension.materialInputDir.isPresent() &&
                     extension.materialOutputDir.isPresent()
-            inputDir.set(extension.materialInputDir.getOrNull())
-            outputDir.set(extension.materialOutputDir.getOrNull())
+            inputDir = extension.materialInputDir.getOrNull()
+            outputDir = extension.materialOutputDir.getOrNull()
         }
 
         project.preBuild.dependsOn "filamentCompileMaterials"

android/common/CallbackUtils.cpp

@@ -16,10 +16,8 @@
 
 #include "CallbackUtils.h"
 
-#include "private/backend/VirtualMachineEnv.h"
-
 void acquireCallbackJni(JNIEnv* env, CallbackJni& callbackUtils) {
-#ifdef __ANDROID__
+#ifdef ANDROID
     callbackUtils.handlerClass = env->FindClass("android/os/Handler");
     callbackUtils.handlerClass = (jclass) env->NewGlobalRef(callbackUtils.handlerClass);
     callbackUtils.post = env->GetMethodID(callbackUtils.handlerClass,
@@ -34,7 +32,7 @@ void acquireCallbackJni(JNIEnv* env, CallbackJni& callbackUtils) {
 
 void releaseCallbackJni(JNIEnv* env, CallbackJni callbackUtils, jobject handler, jobject callback) {
     if (handler && callback) {
-#ifdef __ANDROID__
+#ifdef ANDROID
         if (env->IsInstanceOf(handler, callbackUtils.handlerClass)) {
             env->CallBooleanMethod(handler, callbackUtils.post, callback);
         }
@@ -45,76 +43,55 @@ void releaseCallbackJni(JNIEnv* env, CallbackJni callbackUtils, jobject handler,
     }
     env->DeleteGlobalRef(handler);
     env->DeleteGlobalRef(callback);
-#ifdef __ANDROID__
+#ifdef ANDROID
     env->DeleteGlobalRef(callbackUtils.handlerClass);
 #endif
     env->DeleteGlobalRef(callbackUtils.executorClass);
 }
 
-// -----------------------------------------------------------------------------------------------
-
-JniCallback* JniCallback::make(JNIEnv* env, jobject handler, jobject callback) {
-    return new JniCallback(env, handler, callback);
-}
-
-JniCallback::JniCallback(JNIEnv* env, jobject handler, jobject callback)
-        : mHandler(env->NewGlobalRef(handler)),
-          mCallback(env->NewGlobalRef(callback)) {
-    acquireCallbackJni(env, mCallbackUtils);
-}
-
-JniCallback::~JniCallback() = default;
-
-void JniCallback::post(void* user, filament::backend::CallbackHandler::Callback callback) {
-    callback(user);
-}
-
-void JniCallback::postToJavaAndDestroy(JniCallback* callback) {
-    JNIEnv* env = filament::VirtualMachineEnv::get().getEnvironment();
-    releaseCallbackJni(env, callback->mCallbackUtils, callback->mHandler, callback->mCallback);
-    delete callback;
-}
-
-// -----------------------------------------------------------------------------------------------
-
-JniBufferCallback* JniBufferCallback::make(filament::Engine*,
+JniBufferCallback* JniBufferCallback::make(filament::Engine* engine,
         JNIEnv* env, jobject handler, jobject callback, AutoBuffer&& buffer) {
     return new JniBufferCallback(env, handler, callback, std::move(buffer));
 }
 
 JniBufferCallback::JniBufferCallback(JNIEnv* env, jobject handler, jobject callback,
         AutoBuffer&& buffer)
-        : JniCallback(env, handler, callback),
-        mBuffer(std::move(buffer)) {
+        : mEnv(env)
+        , mHandler(env->NewGlobalRef(handler))
+        , mCallback(env->NewGlobalRef(callback))
+        , mBuffer(std::move(buffer)) {
+    acquireCallbackJni(env, mCallbackUtils);
 }
 
-JniBufferCallback::~JniBufferCallback() = default;
+JniBufferCallback::~JniBufferCallback() {
+    releaseCallbackJni(mEnv, mCallbackUtils, mHandler, mCallback);
+}
 
-void JniBufferCallback::postToJavaAndDestroy(void*, size_t, void* user) {
-    JniBufferCallback* callback = (JniBufferCallback*)user;
-    JNIEnv* env = filament::VirtualMachineEnv::get().getEnvironment();
-    callback->mBuffer.attachToJniThread(env);
-    releaseCallbackJni(env, callback->mCallbackUtils, callback->mHandler, callback->mCallback);
-    delete callback;
+void JniBufferCallback::invoke(void*, size_t, void* user) {
+    JniBufferCallback* data = reinterpret_cast<JniBufferCallback*>(user);
+    delete data;
 }
 
 // -----------------------------------------------------------------------------------------------
 
-JniImageCallback* JniImageCallback::make(filament::Engine*,
+JniImageCallback* JniImageCallback::make(filament::Engine* engine,
         JNIEnv* env, jobject handler, jobject callback, long image) {
     return new JniImageCallback(env, handler, callback, image);
 }
 
 JniImageCallback::JniImageCallback(JNIEnv* env, jobject handler, jobject callback, long image)
-        : JniCallback(env, handler, callback),
-        mImage(image) {
+        : mEnv(env)
+        , mHandler(env->NewGlobalRef(handler))
+        , mCallback(env->NewGlobalRef(callback))
+        , mImage(image) {
+    acquireCallbackJni(env, mCallbackUtils);
 }
 
-JniImageCallback::~JniImageCallback() = default;
-
-void JniImageCallback::postToJavaAndDestroy(void*, void* user) {
-    JniImageCallback* callback = (JniImageCallback*)user;
-    JNIEnv* env = filament::VirtualMachineEnv::get().getEnvironment();
-    releaseCallbackJni(env, callback->mCallbackUtils, callback->mHandler, callback->mCallback);
-    delete callback;
+JniImageCallback::~JniImageCallback() {
+    releaseCallbackJni(mEnv, mCallbackUtils, mHandler, mCallback);
+}
+
+void JniImageCallback::invoke(void*, void* user) {
+    JniImageCallback* data = reinterpret_cast<JniImageCallback*>(user);
+    delete data;
 }

android/common/CallbackUtils.h

@@ -18,14 +18,13 @@
 
 #include <jni.h>
 
+#include "common/CallbackUtils.h"
 #include "common/NioUtils.h"
 
-#include <backend/CallbackHandler.h>
-
 #include <filament/Engine.h>
 
 struct CallbackJni {
-#ifdef __ANDROID__
+#ifdef ANDROID
     jclass handlerClass = nullptr;
     jmethodID post = nullptr;
 #endif
@@ -36,60 +35,40 @@ struct CallbackJni {
 void acquireCallbackJni(JNIEnv* env, CallbackJni& callbackUtils);
 void releaseCallbackJni(JNIEnv* env, CallbackJni callbackUtils, jobject handler, jobject callback);
 
-struct JniCallback : private filament::backend::CallbackHandler {
-    JniCallback(JniCallback const &) = delete;
-    JniCallback(JniCallback&&) = delete;
-    JniCallback& operator=(JniCallback const &) = delete;
-    JniCallback& operator=(JniCallback&&) = delete;
-
-    // create a JniCallback
-    static JniCallback* make(JNIEnv* env, jobject handler, jobject runnable);
-
-    // execute the callback on the java thread and destroy ourselves
-    static void postToJavaAndDestroy(JniCallback* callback);
-
-    // CallbackHandler interface.
-    void post(void* user, Callback callback) override;
-
-    // Get the CallbackHandler interface
-    filament::backend::CallbackHandler* getHandler() noexcept { return this; }
-
-    jobject getCallbackObject() { return mCallback; }
-
-protected:
-    JniCallback(JNIEnv* env, jobject handler, jobject runnable);
-    explicit JniCallback() = default; // this version does nothing
-    virtual ~JniCallback();
-    jobject mHandler{};
-    jobject mCallback{};
-    CallbackJni mCallbackUtils{};
-};
-
-
-struct JniBufferCallback : public JniCallback {
-    // create a JniBufferCallback
+struct JniBufferCallback {
     static JniBufferCallback* make(filament::Engine* engine,
             JNIEnv* env, jobject handler, jobject callback, AutoBuffer&& buffer);
 
-    // execute the callback on the java thread and destroy ourselves
-    static void postToJavaAndDestroy(void*, size_t, void* user);
+    static void invoke(void* buffer, size_t n, void* user);
 
 private:
     JniBufferCallback(JNIEnv* env, jobject handler, jobject callback, AutoBuffer&& buffer);
-    virtual ~JniBufferCallback();
+    JniBufferCallback(JniBufferCallback const &) = delete;
+    JniBufferCallback(JniBufferCallback&&) = delete;
+    ~JniBufferCallback();
+
+    JNIEnv* mEnv;
+    jobject mHandler;
+    jobject mCallback;
     AutoBuffer mBuffer;
+    CallbackJni mCallbackUtils;
 };
 
-struct JniImageCallback : public JniCallback {
-    // create a JniImageCallback
+struct JniImageCallback {
     static JniImageCallback* make(filament::Engine* engine, JNIEnv* env, jobject handler,
             jobject runnable, long image);
 
-    // execute the callback on the java thread and destroy ourselves
-    static void postToJavaAndDestroy(void*, void* user);
+    static void invoke(void* image, void* user);
 
 private:
     JniImageCallback(JNIEnv* env, jobject handler, jobject runnable, long image);
-    virtual ~JniImageCallback();
+    JniImageCallback(JniBufferCallback const &) = delete;
+    JniImageCallback(JniBufferCallback&&) = delete;
+    ~JniImageCallback();
+
+    JNIEnv* mEnv;
+    jobject mHandler;
+    jobject mCallback;
     long mImage;
+    CallbackJni mCallbackUtils;
 };

android/common/NioUtils.h

@@ -38,10 +38,6 @@ public:
     AutoBuffer(AutoBuffer&& rhs) noexcept;
     ~AutoBuffer() noexcept;
 
-    void attachToJniThread(JNIEnv* env) noexcept {
-        mEnv = env;
-    }
-
     void* getData() const noexcept {
         return mUserData;
     }

android/filamat-android/CMakeLists.txt

@@ -1,5 +1,4 @@
-cmake_minimum_required(VERSION 3.19)
-project(filamat-android)
+cmake_minimum_required(VERSION 3.6)
 
 option(FILAMENT_ENABLE_MATDBG "Enables Material debugger" OFF)
 
@@ -34,16 +33,13 @@ add_library(shaders STATIC IMPORTED)
 set_target_properties(shaders PROPERTIES IMPORTED_LOCATION
         ${FILAMENT_DIR}/lib/${ANDROID_ABI}/libshaders.a)
 
-set(FILAMAT_INCLUDE_DIRS
-        ../../libs/utils/include
-        )
-
 include_directories(${FILAMENT_DIR}/include)
 
 set(CMAKE_SHARED_LINKER_FLAGS_RELEASE "${CMAKE_SHARED_LINKER_FLAGS_RELEASE} -Wl,--version-script=${CMAKE_SOURCE_DIR}/libfilamat-jni.map")
 
-add_library(filamat-jni SHARED src/main/cpp/MaterialBuilder.cpp)
-target_include_directories(filamat-jni PRIVATE ${FILAMAT_INCLUDE_DIRS})
+add_library(filamat-jni SHARED
+        src/main/cpp/MaterialBuilder.cpp
+)
 
 target_link_libraries(filamat-jni
         ${FILAMAT_FLAVOR}

android/filamat-android/build.gradle

@@ -1,6 +1,4 @@
 android {
-    namespace 'com.google.android.filament.filamat'
-
     flavorDimensions "functionality"
     productFlavors {
         full {

android/filamat-android/src/main/cpp/MaterialBuilder.cpp

@@ -18,8 +18,6 @@
 
 #include <filamat/MaterialBuilder.h>
 
-#include <utils/JobSystem.h>
-
 using namespace filament;
 using namespace filamat;
 
@@ -47,23 +45,9 @@ Java_com_google_android_filament_filamat_MaterialBuilder_nDestroyMaterialBuilder
 
 extern "C" JNIEXPORT jlong JNICALL
 Java_com_google_android_filament_filamat_MaterialBuilder_nBuilderBuild(JNIEnv*, jclass,
-        jlong nativeBuilder, jlong nativeJobSystem) {
+        jlong nativeBuilder) {
     auto builder = (MaterialBuilder*) nativeBuilder;
-    auto jobSystem = (utils::JobSystem*) nativeJobSystem;
-
-    if (nativeJobSystem == 0) {
-        jobSystem = new utils::JobSystem;
-        jobSystem->adopt();
-    }
-
-    jlong result = (jlong) new Package(builder->build(*jobSystem));
-
-    if (nativeJobSystem == 0) {
-        jobSystem->emancipate();
-        delete jobSystem;
-    }
-
-    return result;
+    return (jlong) new Package(builder->build());
 }
 
 extern "C" JNIEXPORT jbyteArray JNICALL
@@ -123,22 +107,19 @@ Java_com_google_android_filament_filamat_MaterialBuilder_nMaterialBuilderInterpo
 
 extern "C" JNIEXPORT void JNICALL
 Java_com_google_android_filament_filamat_MaterialBuilder_nMaterialBuilderUniformParameter(
-        JNIEnv* env, jclass, jlong nativeBuilder, jint uniformType, jint precision, jstring name_) {
+        JNIEnv* env, jclass, jlong nativeBuilder, jint uniformType, jstring name_) {
     auto builder = (MaterialBuilder*) nativeBuilder;
     const char* name = env->GetStringUTFChars(name_, nullptr);
-    builder->parameter(name, (MaterialBuilder::UniformType) uniformType,
-            (MaterialBuilder::ParameterPrecision) precision);
+    builder->parameter((MaterialBuilder::UniformType) uniformType, name);
     env->ReleaseStringUTFChars(name_, name);
 }
 
 extern "C" JNIEXPORT void JNICALL
 Java_com_google_android_filament_filamat_MaterialBuilder_nMaterialBuilderUniformParameterArray(
-        JNIEnv* env, jclass, jlong nativeBuilder, jint uniformType, jint size, jint precision,
-        jstring name_) {
+        JNIEnv* env, jclass, jlong nativeBuilder, jint uniformType, jint size, jstring name_) {
     auto builder = (MaterialBuilder*) nativeBuilder;
     const char* name = env->GetStringUTFChars(name_, nullptr);
-    builder->parameter(name, (size_t) size, (MaterialBuilder::UniformType) uniformType,
-            (MaterialBuilder::ParameterPrecision) precision);
+    builder->parameter((MaterialBuilder::UniformType) uniformType, (size_t) size, name);
     env->ReleaseStringUTFChars(name_, name);
 }
 
@@ -148,8 +129,9 @@ Java_com_google_android_filament_filamat_MaterialBuilder_nMaterialBuilderSampler
         jint precision, jstring name_) {
     auto builder = (MaterialBuilder*) nativeBuilder;
     const char* name = env->GetStringUTFChars(name_, nullptr);
-    builder->parameter(name, (MaterialBuilder::SamplerType) samplerType,
-            (MaterialBuilder::SamplerFormat) format, (MaterialBuilder::ParameterPrecision) precision);
+    builder->parameter((MaterialBuilder::SamplerType) samplerType,
+            (MaterialBuilder::SamplerFormat) format, (MaterialBuilder::SamplerPrecision) precision,
+            name);
     env->ReleaseStringUTFChars(name_, name);
 }
 
@@ -257,13 +239,6 @@ Java_com_google_android_filament_filamat_MaterialBuilder_nMaterialBuilderShadowM
     builder->shadowMultiplier(shadowMultiplier);
 }
 
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_filamat_MaterialBuilder_nMaterialBuilderTransparentShadow(
-        JNIEnv*, jclass, jlong nativeBuilder, jboolean transparentShadow) {
-    auto builder = (MaterialBuilder*) nativeBuilder;
-    builder->transparentShadow(transparentShadow);
-}
-
 extern "C" JNIEXPORT void JNICALL
 Java_com_google_android_filament_filamat_MaterialBuilder_nMaterialBuilderSpecularAntiAliasing(
         JNIEnv*, jclass, jlong nativeBuilder, jboolean specularAntiAliasing) {
@@ -300,13 +275,6 @@ Java_com_google_android_filament_filamat_MaterialBuilder_nMaterialBuilderFlipUV(
     builder->flipUV(flipUV);
 }
 
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_filamat_MaterialBuilder_nMaterialBuilderCustomSurfaceShading(JNIEnv*,
-        jclass, jlong nativeBuilder, jboolean customSurfaceShading) {
-    auto builder = (MaterialBuilder*) nativeBuilder;
-    builder->customSurfaceShading(customSurfaceShading);
-}
-
 extern "C" JNIEXPORT void JNICALL
 Java_com_google_android_filament_filamat_MaterialBuilder_nMaterialBuilderMultiBounceAmbientOcclusion(
         JNIEnv*, jclass, jlong nativeBuilder, jboolean multiBounceAO) {
@@ -369,10 +337,3 @@ Java_com_google_android_filament_filamat_MaterialBuilder_nMaterialBuilderVariant
     auto builder = (MaterialBuilder*) nativeBuilder;
     builder->variantFilter((uint8_t) variantFilter);
 }
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_filamat_MaterialBuilder_nMaterialBuilderUseLegacyMorphing(JNIEnv*,
-        jclass, jlong nativeBuilder) {
-    auto builder = (MaterialBuilder*) nativeBuilder;
-    builder->useLegacyMorphing();
-}

android/filamat-android/src/main/java/com/google/android/filament/filamat/MaterialBuilder.java

@@ -17,29 +17,17 @@
 package com.google.android.filament.filamat;
 
 import androidx.annotation.NonNull;
-import androidx.annotation.Nullable;
-
-import java.lang.reflect.InvocationTargetException;
-import java.lang.reflect.Method;
 import java.nio.ByteBuffer;
 
 public class MaterialBuilder {
+
     @SuppressWarnings({"FieldCanBeLocal", "UnusedDeclaration"})
     // Keep to finalize native resources
     private final BuilderFinalizer mFinalizer;
     private final long mNativeObject;
 
-    private static Class<?> sEngineClass = null;
-    private static Method sGetNativeJobSystemMethod = null;
-
     static {
         System.loadLibrary("filamat-jni");
-        try {
-            sEngineClass = Class.forName("com.google.android.filament.Engine");
-            sGetNativeJobSystemMethod = sEngineClass.getDeclaredMethod("getNativeJobSystem");
-        } catch (ClassNotFoundException | NoSuchMethodException e) {
-            // It's okay if we don't find it, this is to avoid creating dependencies
-        }
     }
 
     public enum Shading {
@@ -91,7 +79,7 @@ public class MaterialBuilder {
         SHADOW
     }
 
-    public enum ParameterPrecision {
+    public enum SamplerPrecision {
         LOW,
         MEDIUM,
         HIGH,
@@ -133,7 +121,7 @@ public class MaterialBuilder {
         FADE,                   // material is transparent and color is alpha-pre-multiplied,
                                 // affects specular lighting
         MULTIPLY,               // material darkens what's behind it
-        SCREEN                  // material brightens what's behind it
+        SCREN                   // material brightens what's behind it
     }
 
     public enum VertexDomain {
@@ -247,36 +235,19 @@ public class MaterialBuilder {
 
     @NonNull
     public MaterialBuilder uniformParameter(@NonNull UniformType type, String name) {
-        nMaterialBuilderUniformParameter(mNativeObject, type.ordinal(),
-                ParameterPrecision.DEFAULT.ordinal(), name);
-        return this;
-    }
-
-    @NonNull
-    public MaterialBuilder uniformParameter(@NonNull UniformType type,
-            ParameterPrecision precision, String name) {
-        nMaterialBuilderUniformParameter(mNativeObject, type.ordinal(), precision.ordinal(), name);
+        nMaterialBuilderUniformParameter(mNativeObject, type.ordinal(), name);
         return this;
     }
 
     @NonNull
     public MaterialBuilder uniformParameterArray(@NonNull UniformType type, int size, String name) {
-        nMaterialBuilderUniformParameterArray(mNativeObject, type.ordinal(), size,
-                ParameterPrecision.DEFAULT.ordinal(), name);
-        return this;
-    }
-
-    @NonNull
-    public MaterialBuilder uniformParameterArray(@NonNull UniformType type, int size,
-            ParameterPrecision precision, String name) {
-        nMaterialBuilderUniformParameterArray(mNativeObject, type.ordinal(), size,
-                precision.ordinal(), name);
+        nMaterialBuilderUniformParameterArray(mNativeObject, type.ordinal(), size, name);
         return this;
     }
 
     @NonNull
     public MaterialBuilder samplerParameter(@NonNull SamplerType type, SamplerFormat format,
-            ParameterPrecision precision, String name) {
+            SamplerPrecision precision, String name) {
         nMaterialBuilderSamplerParameter(
                 mNativeObject, type.ordinal(), format.ordinal(), precision.ordinal(), name);
         return this;
@@ -366,12 +337,6 @@ public class MaterialBuilder {
         return this;
     }
 
-    @NonNull
-    public MaterialBuilder transparentShadow(boolean transparentShadow) {
-        nMaterialBuilderTransparentShadow(mNativeObject, transparentShadow);
-        return this;
-    }
-
     @NonNull
     public MaterialBuilder specularAntiAliasing(boolean specularAntiAliasing) {
         nMaterialBuilderSpecularAntiAliasing(mNativeObject, specularAntiAliasing);
@@ -414,12 +379,6 @@ public class MaterialBuilder {
         return this;
     }
 
-    @NonNull
-    public MaterialBuilder customSurfaceShading(boolean customSurfaceShading) {
-        nMaterialBuilderCustomSurfaceShading(mNativeObject, customSurfaceShading);
-        return this;
-    }
-
     @NonNull
     public MaterialBuilder multiBounceAmbientOcclusion(boolean multiBounceAO) {
         nMaterialBuilderMultiBounceAmbientOcclusion(mNativeObject, multiBounceAO);
@@ -459,71 +418,12 @@ public class MaterialBuilder {
     @NonNull
     public MaterialBuilder variantFilter(int variantFilter) {
         nMaterialBuilderVariantFilter(mNativeObject, variantFilter);
-        useLegacyMorphing();
         return this;
     }
 
-    /**
-     * Legacy morphing uses the data in the {@link VertexBuffer.VertexAttribute} slots
-     * (<code>MORPH_POSITION_0</code>, etc) and is limited to 4 morph targets.
-     *
-     * @see RenderableManager.Builder#morphing()
-     */
-    @NonNull
-    public MaterialBuilder useLegacyMorphing() {
-        nMaterialBuilderUseLegacyMorphing(mNativeObject);
-        return this;
-    }
-
-    /**
-     * Validates, builds, and returns the compiled material. While this method never
-     * returns null, the returned {@link MaterialPackage} may be invalid. Call
-     * {@link MaterialPackage#isValid()} before using it.
-     *
-     * Calling this method is equivalent to calling {@link #build(Object)} and passing
-     * <code>null</code> as the job system provider.
-     *
-     * @see #build(Object)
-     */
     @NonNull
     public MaterialPackage build() {
-        return build(null);
-    }
-
-    /**
-     * Validates, builds, and returns the compiled material. While this method never
-     * returns null, the returned {@link MaterialPackage} may be invalid. Call
-     * {@link MaterialPackage#isValid()} before using it.
-     *
-     * You can pass a job system provider to this method, or null. When passing null
-     * or an invalid job system provider, a temporary job system will be created which
-     * is less efficient than reusing an existing job system.
-     *
-     * Currently the only valid type of job system provider is an <code>Engine</code>
-     * instance from the main Filament library (<code>com.google.android.filament.Engine</code>).
-     *
-     * If you are using Filament and the filamat library together you <em>must</em> pass an
-     * <code>Engine</code> as the job system provider, <em>or</em> invoke
-     * <code>MaterialBuilder</code> from a thread other than the thread used to invoke Filament
-     * APIs.
-     *
-     * @param jobSystemProvider An <code>Engine</code> instance or null
-     */
-    @NonNull
-    public MaterialPackage build(@Nullable Object jobSystemProvider) {
-        long nativeJobSystem = 0;
-        if (jobSystemProvider != null && sEngineClass != null) {
-            if (sEngineClass.isInstance(jobSystemProvider) && sGetNativeJobSystemMethod != null) {
-                try {
-                    //noinspection ConstantConditions
-                    nativeJobSystem = (Long) sGetNativeJobSystemMethod.invoke(jobSystemProvider);
-                } catch (IllegalAccessException | InvocationTargetException e) {
-                    // Ignore
-                }
-            }
-        }
-
-        long nativePackage = nBuilderBuild(mNativeObject, nativeJobSystem);
+        long nativePackage = nBuilderBuild(mNativeObject);
         byte[] data = nGetPackageBytes(nativePackage);
         MaterialPackage result =
                 new MaterialPackage(ByteBuffer.wrap(data), nGetPackageIsValid(nativePackage));
@@ -555,7 +455,7 @@ public class MaterialBuilder {
     private static native long nCreateMaterialBuilder();
     private static native void nDestroyMaterialBuilder(long nativeBuilder);
 
-    private static native long nBuilderBuild(long nativeBuilder, long nativeJobSystem);
+    private static native long nBuilderBuild(long nativeBuilder);
     private static native byte[] nGetPackageBytes(long nativePackage);
     private static native boolean nGetPackageIsValid(long nativePackage);
     private static native void nDestroyPackage(long nativePackage);
@@ -565,9 +465,9 @@ public class MaterialBuilder {
     private static native void nMaterialBuilderShading(long nativeBuilder, int shading);
     private static native void nMaterialBuilderInterpolation(long nativeBuilder, int interpolation);
     private static native void nMaterialBuilderUniformParameter(long nativeBuilder, int type,
-            int precision, String name);
+            String name);
     private static native void nMaterialBuilderUniformParameterArray(long nativeBuilder, int type,
-            int size, int precision, String name);
+            int size, String name);
     private static native void nMaterialBuilderSamplerParameter(long nativeBuilder, int type,
             int format, int precision, String name);
     private static native void nMaterialBuilderVariable(long nativeBuilder, int variable,
@@ -587,8 +487,6 @@ public class MaterialBuilder {
 
     private static native void nMaterialBuilderShadowMultiplier(long mNativeObject,
             boolean shadowMultiplier);
-    private static native void nMaterialBuilderTransparentShadow(long mNativeObject,
-            boolean transparentShadow);
     private static native void nMaterialBuilderSpecularAntiAliasing(long mNativeObject,
             boolean specularAntiAliasing);
     private static native void nMaterialBuilderSpecularAntiAliasingVariance(long mNativeObject,
@@ -600,8 +498,6 @@ public class MaterialBuilder {
     private static native void nMaterialBuilderClearCoatIorChange(long mNativeObject,
             boolean clearCoatIorChange);
     private static native void nMaterialBuilderFlipUV(long nativeBuilder, boolean flipUV);
-    private static native void nMaterialBuilderCustomSurfaceShading(long nativeBuilder,
-            boolean customSurfaceShading);
     private static native void nMaterialBuilderMultiBounceAmbientOcclusion(long nativeBuilder,
             boolean multiBounceAO);
     private static native void nMaterialBuilderSpecularAmbientOcclusion(long nativeBuilder,
@@ -612,5 +508,4 @@ public class MaterialBuilder {
     private static native void nMaterialBuilderOptimization(long nativeBuilder, int optimization);
     private static native void nMaterialBuilderVariantFilter(long nativeBuilder,
             int variantFilter);
-    private static native void nMaterialBuilderUseLegacyMorphing(long nativeBuilder);
 }

android/filament-android/CMakeLists.txt

@@ -1,9 +1,7 @@
-cmake_minimum_required(VERSION 3.19)
-project(filament-android)
+cmake_minimum_required(VERSION 3.6)
 
 option(FILAMENT_SUPPORTS_VULKAN "Enables Vulkan on Android" OFF)
 option(FILAMENT_ENABLE_MATDBG "Enables Material debugger" OFF)
-option(FILAMENT_DISABLE_MATOPT "Disables material optimizations" OFF)
 
 set(FILAMENT_DIR ${FILAMENT_DIST_DIR})
 
@@ -19,18 +17,14 @@ add_library(utils STATIC IMPORTED)
 set_target_properties(utils PROPERTIES IMPORTED_LOCATION
         ${FILAMENT_DIR}/lib/${ANDROID_ABI}/libutils.a)
 
-add_library(ibl-lite STATIC IMPORTED)
-set_target_properties(ibl-lite PROPERTIES IMPORTED_LOCATION
-        ${FILAMENT_DIR}/lib/${ANDROID_ABI}/libibl-lite.a)
+add_library(ibl STATIC IMPORTED)
+set_target_properties(ibl PROPERTIES IMPORTED_LOCATION
+        ${FILAMENT_DIR}/lib/${ANDROID_ABI}/libibl.a)
 
 add_library(filaflat STATIC IMPORTED)
 set_target_properties(filaflat PROPERTIES IMPORTED_LOCATION
         ${FILAMENT_DIR}/lib/${ANDROID_ABI}/libfilaflat.a)
 
-add_library(filamat STATIC IMPORTED)
-set_target_properties(filamat PROPERTIES IMPORTED_LOCATION
-        ${FILAMENT_DIR}/lib/${ANDROID_ABI}/libfilamat.a)
-
 add_library(geometry STATIC IMPORTED)
 set_target_properties(geometry PROPERTIES IMPORTED_LOCATION
         ${FILAMENT_DIR}/lib/${ANDROID_ABI}/libgeometry.a)
@@ -43,10 +37,6 @@ add_library(bluevk STATIC IMPORTED)
 set_target_properties(bluevk PROPERTIES IMPORTED_LOCATION
         ${FILAMENT_DIR}/lib/${ANDROID_ABI}/libbluevk.a)
 
-add_library(vkshaders STATIC IMPORTED)
-set_target_properties(vkshaders PROPERTIES IMPORTED_LOCATION
-        ${FILAMENT_DIR}/lib/${ANDROID_ABI}/libvkshaders.a)
-
 add_library(smol-v STATIC IMPORTED)
 set_target_properties(smol-v PROPERTIES IMPORTED_LOCATION
         ${FILAMENT_DIR}/lib/${ANDROID_ABI}/libsmol-v.a)
@@ -61,7 +51,6 @@ set(VERSION_SCRIPT "${CMAKE_CURRENT_SOURCE_DIR}/libfilament-jni.map")
 set(CMAKE_SHARED_LINKER_FLAGS_RELEASE "${CMAKE_SHARED_LINKER_FLAGS_RELEASE} -Wl,--version-script=${VERSION_SCRIPT}")
 
 add_library(filament-jni SHARED
-    src/main/cpp/BufferObject.cpp
     src/main/cpp/Camera.cpp
     src/main/cpp/Colors.cpp
     src/main/cpp/ColorGrading.cpp
@@ -74,19 +63,15 @@ add_library(filament-jni SHARED
     src/main/cpp/Material.cpp
     src/main/cpp/MaterialInstance.cpp
     src/main/cpp/MathUtils.cpp
-    src/main/cpp/MorphTargetBuffer.cpp
     src/main/cpp/RenderableManager.cpp
     src/main/cpp/Renderer.cpp
     src/main/cpp/RenderTarget.cpp
     src/main/cpp/Scene.cpp
     src/main/cpp/SkyBox.cpp
-    src/main/cpp/SkinningBuffer.cpp
     src/main/cpp/Stream.cpp
     src/main/cpp/SurfaceOrientation.cpp
-    src/main/cpp/SwapChain.cpp
     src/main/cpp/Texture.cpp
     src/main/cpp/TextureSampler.cpp
-    src/main/cpp/ToneMapper.cpp
     src/main/cpp/TransformManager.cpp
     src/main/cpp/VertexBuffer.cpp
     src/main/cpp/View.cpp
@@ -105,28 +90,22 @@ target_link_libraries(filament-jni
     PRIVATE backend
     PRIVATE filaflat
     PRIVATE filabridge
-    PRIVATE ibl-lite
+    PRIVATE geometry
+    PRIVATE ibl
     PRIVATE log
     PRIVATE GLESv3
     PRIVATE EGL
     PRIVATE android
     PRIVATE jnigraphics
     PRIVATE utils
-
-    # libgeometry is PUBLIC because gltfio uses it.
-    PUBLIC geometry
-
     $<$<STREQUAL:${FILAMENT_ENABLE_MATDBG},ON>:matdbg>
-    $<$<STREQUAL:${FILAMENT_ENABLE_MATDBG},ON>:filamat>
     $<$<STREQUAL:${FILAMENT_SUPPORTS_VULKAN},ON>:bluevk>
-    $<$<STREQUAL:${FILAMENT_SUPPORTS_VULKAN},ON>:vkshaders>
     $<$<STREQUAL:${FILAMENT_SUPPORTS_VULKAN},ON>:smol-v>
 )
 
 target_include_directories(filament-jni PRIVATE
         ..
         ${FILAMENT_DIR}/include
-        ../../filament/backend/include
         ../../third_party/robin-map
         ../../libs/utils/include)
 

android/filament-android/build.gradle

@@ -1,7 +1,3 @@
-android {
-    namespace 'com.google.android.filament'
-}
-
 dependencies {
     implementation deps.androidx.annotations
 }

android/filament-android/libfilament-jni.map

@@ -1,28 +1,4 @@
 LIBFILAMENT {
-  global:
-    Java_com_google_android_filament_*;
-    JNI*;
-    *filament*BufferObject*;
-    *filament*Camera*;
-    *filament*Color*;
-    *filament*Exposure*;
-    *filament*Skybox*;
-    *filament*Engine*;
-    *filament*RenderableManager*;
-    *filament*Aabb*;
-    *filament*IndirectLight*;
-    *filament*LightManager*;
-    *filament*Renderer*;
-    *filament*RenderTarget*;
-    *filament*Scene*;
-    *filament*ToneMapper*;
-    *filament*Transform*;
-    *filament*Material*;
-    *filament*IndexBuffer*;
-    *filament*VertexBuffer*;
-    *filament*View*;
-    *filament*Texture*;
-    *filament*geometry*;
-
+  global: *filament*; JNI*;
   local: *;
 };

android/filament-android/src/main/cpp/BufferObject.cpp

@@ -1,100 +0,0 @@
-/*
- * Copyright (C) 2021 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#include <jni.h>
-
-#include <functional>
-#include <stdlib.h>
-#include <string.h>
-
-#include <filament/BufferObject.h>
-
-#include <backend/BufferDescriptor.h>
-
-#include "common/CallbackUtils.h"
-#include "common/NioUtils.h"
-
-using namespace filament;
-using namespace backend;
-
-extern "C" JNIEXPORT jlong JNICALL
-Java_com_google_android_filament_BufferObject_nCreateBuilder(JNIEnv *env, jclass type) {
-    return (jlong) new BufferObject::Builder();
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_BufferObject_nDestroyBuilder(JNIEnv *env, jclass type,
-        jlong nativeBuilder) {
-    BufferObject::Builder* builder = (BufferObject::Builder *) nativeBuilder;
-    delete builder;
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_BufferObject_nBuilderSize(JNIEnv *env, jclass type,
-        jlong nativeBuilder, jint byteCount) {
-    BufferObject::Builder* builder = (BufferObject::Builder *) nativeBuilder;
-    builder->size((uint32_t) byteCount);
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_BufferObject_nBuilderBindingType(JNIEnv *env, jclass type,
-        jlong nativeBuilder, jint bindingType) {
-    using BindingType = BufferObject::BindingType;
-    BufferObject::Builder* builder = (BufferObject::Builder *) nativeBuilder;
-    BindingType types[] = {BindingType::VERTEX};
-    builder->bindingType(types[bindingType]);
-}
-
-extern "C" JNIEXPORT jlong JNICALL
-Java_com_google_android_filament_BufferObject_nBuilderBuild(JNIEnv *env, jclass type,
-        jlong nativeBuilder, jlong nativeEngine) {
-    BufferObject::Builder* builder = (BufferObject::Builder *) nativeBuilder;
-    Engine *engine = (Engine *) nativeEngine;
-    return (jlong) builder->build(*engine);
-}
-
-extern "C" JNIEXPORT jint JNICALL
-Java_com_google_android_filament_BufferObject_nGetByteCount(JNIEnv *env, jclass type,
-        jlong nativeBufferObject) {
-    BufferObject *bufferObject = (BufferObject *) nativeBufferObject;
-    return (jint) bufferObject->getByteCount();
-}
-
-extern "C" JNIEXPORT int JNICALL
-Java_com_google_android_filament_BufferObject_nSetBuffer(JNIEnv *env, jclass type,
-        jlong nativeBufferObject, jlong nativeEngine, jobject buffer, int remaining,
-        jint destOffsetInBytes, jint count,
-        jobject handler, jobject runnable) {
-    BufferObject *bufferObject = (BufferObject *) nativeBufferObject;
-    Engine *engine = (Engine *) nativeEngine;
-
-    AutoBuffer nioBuffer(env, buffer, count);
-    void* data = nioBuffer.getData();
-    size_t sizeInBytes = nioBuffer.getSize();
-    if (sizeInBytes > (remaining << nioBuffer.getShift())) {
-        // BufferOverflowException
-        return -1;
-    }
-
-    auto* callback = JniBufferCallback::make(engine, env, handler, runnable, std::move(nioBuffer));
-
-    BufferDescriptor desc(data, sizeInBytes,
-            callback->getHandler(), &JniBufferCallback::postToJavaAndDestroy, callback);
-
-    bufferObject->setBuffer(*engine, std::move(desc), (uint32_t) destOffsetInBytes);
-
-    return 0;
-}

android/filament-android/src/main/cpp/Camera.cpp

@@ -18,8 +18,6 @@
 
 #include <filament/Camera.h>
 
-#include <utils/Entity.h>
-
 #include <math/mat4.h>
 
 using namespace filament;
@@ -49,31 +47,20 @@ Java_com_google_android_filament_Camera_nSetLensProjection(JNIEnv*, jclass,
 
 extern "C" JNIEXPORT void JNICALL
 Java_com_google_android_filament_Camera_nSetCustomProjection(JNIEnv *env, jclass,
-        jlong nativeCamera, jdoubleArray inProjection_, jdoubleArray inProjectionForCulling_,
-        jdouble near, jdouble far) {
+        jlong nativeCamera, jdoubleArray inMatrix_, jdouble near, jdouble far) {
     Camera *camera = (Camera *) nativeCamera;
-    jdouble *inProjection = env->GetDoubleArrayElements(inProjection_, NULL);
-    jdouble *inProjectionForCulling = env->GetDoubleArrayElements(inProjectionForCulling_, NULL);
-    camera->setCustomProjection(
-            *reinterpret_cast<const filament::math::mat4 *>(inProjection),
-            *reinterpret_cast<const filament::math::mat4 *>(inProjectionForCulling),
-            near, far);
-    env->ReleaseDoubleArrayElements(inProjection_, inProjection, JNI_ABORT);
-    env->ReleaseDoubleArrayElements(inProjectionForCulling_, inProjectionForCulling, JNI_ABORT);
+    jdouble *inMatrix = env->GetDoubleArrayElements(inMatrix_, NULL);
+    camera->setCustomProjection(*reinterpret_cast<const filament::math::mat4 *>(inMatrix), near, far);
+    env->ReleaseDoubleArrayElements(inMatrix_, inMatrix, JNI_ABORT);
 }
 
 extern "C" JNIEXPORT void JNICALL
 Java_com_google_android_filament_Camera_nSetScaling(JNIEnv* env, jclass,
-        jlong nativeCamera, jdouble x, jdouble y) {
+        jlong nativeCamera, jdoubleArray inScaling_) {
     Camera *camera = (Camera *) nativeCamera;
-    camera->setScaling({(double)x, (double)y});
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_Camera_nSetShift(JNIEnv* env, jclass,
-        jlong nativeCamera, jdouble x, jdouble y) {
-    Camera *camera = (Camera *) nativeCamera;
-    camera->setShift({(double)x, (double)y});
+    jdouble *inScaling = env->GetDoubleArrayElements(inScaling_, NULL);
+    camera->setScaling(*reinterpret_cast<const filament::math::double4*>(inScaling));
+    env->ReleaseDoubleArrayElements(inScaling_, inScaling, JNI_ABORT);
 }
 
 extern "C" JNIEXPORT void JNICALL
@@ -84,13 +71,13 @@ Java_com_google_android_filament_Camera_nLookAt(JNIEnv*, jclass, jlong nativeCam
     camera->lookAt({eye_x, eye_y, eye_z}, {center_x, center_y, center_z}, {up_x, up_y, up_z});
 }
 
-extern "C" JNIEXPORT jdouble JNICALL
+extern "C" JNIEXPORT jfloat JNICALL
 Java_com_google_android_filament_Camera_nGetNear(JNIEnv*, jclass, jlong nativeCamera) {
     Camera *camera = (Camera *) nativeCamera;
     return camera->getNear();
 }
 
-extern "C" JNIEXPORT jdouble JNICALL
+extern "C" JNIEXPORT jfloat JNICALL
 Java_com_google_android_filament_Camera_nGetCullingFar(JNIEnv*, jclass,
         jlong nativeCamera) {
     Camera *camera = (Camera *) nativeCamera;
@@ -102,19 +89,10 @@ Java_com_google_android_filament_Camera_nSetModelMatrix(JNIEnv *env, jclass,
         jlong nativeCamera, jfloatArray in_) {
     Camera* camera = (Camera *) nativeCamera;
     jfloat *in = env->GetFloatArrayElements(in_, NULL);
-    camera->setModelMatrix((math::mat4)*reinterpret_cast<const filament::math::mat4f*>(in));
+    camera->setModelMatrix(*reinterpret_cast<const filament::math::mat4f*>(in));
     env->ReleaseFloatArrayElements(in_, in, JNI_ABORT);
 }
 
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_Camera_nSetModelMatrixFp64(JNIEnv *env, jclass,
-        jlong nativeCamera, jdoubleArray in_) {
-    Camera* camera = (Camera *) nativeCamera;
-    jdouble *in = env->GetDoubleArrayElements(in_, NULL);
-    camera->setModelMatrix(*reinterpret_cast<const filament::math::mat4*>(in));
-    env->ReleaseDoubleArrayElements(in_, in, JNI_ABORT);
-}
-
 extern "C" JNIEXPORT void JNICALL
 Java_com_google_android_filament_Camera_nGetProjectionMatrix(JNIEnv *env, jclass,
         jlong nativeCamera, jdoubleArray out_) {
@@ -150,41 +128,21 @@ Java_com_google_android_filament_Camera_nGetModelMatrix(JNIEnv *env, jclass,
         jlong nativeCamera, jfloatArray out_) {
     Camera *camera = (Camera *) nativeCamera;
     jfloat *out = env->GetFloatArrayElements(out_, NULL);
-    const filament::math::mat4f& m = (math::mat4f)camera->getModelMatrix();
+    const filament::math::mat4f& m = camera->getModelMatrix();
     std::copy_n(&m[0][0], 16, out);
     env->ReleaseFloatArrayElements(out_, out, 0);
 }
 
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_Camera_nGetModelMatrixFp64(JNIEnv *env, jclass,
-        jlong nativeCamera, jdoubleArray out_) {
-    Camera *camera = (Camera *) nativeCamera;
-    jdouble *out = env->GetDoubleArrayElements(out_, NULL);
-    const filament::math::mat4& m = camera->getModelMatrix();
-    std::copy_n(&m[0][0], 16, out);
-    env->ReleaseDoubleArrayElements(out_, out, 0);
-}
-
 extern "C" JNIEXPORT void JNICALL
 Java_com_google_android_filament_Camera_nGetViewMatrix(JNIEnv *env, jclass, jlong nativeCamera,
         jfloatArray out_) {
     Camera *camera = (Camera *) nativeCamera;
     jfloat *out = env->GetFloatArrayElements(out_, NULL);
-    const filament::math::mat4f& m = (math::mat4f)camera->getViewMatrix();
+    const filament::math::mat4f& m = camera->getViewMatrix();
     std::copy_n(&m[0][0], 16, out);
     env->ReleaseFloatArrayElements(out_, out, 0);
 }
 
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_Camera_nGetViewMatrixFp64(JNIEnv *env, jclass, jlong nativeCamera,
-        jdoubleArray out_) {
-    Camera *camera = (Camera *) nativeCamera;
-    jdouble *out = env->GetDoubleArrayElements(out_, NULL);
-    const filament::math::mat4& m = camera->getViewMatrix();
-    std::copy_n(&m[0][0], 16, out);
-    env->ReleaseDoubleArrayElements(out_, out, 0);
-}
-
 extern "C" JNIEXPORT void JNICALL
 Java_com_google_android_filament_Camera_nGetPosition(JNIEnv *env, jclass, jlong nativeCamera,
         jfloatArray out_) {
@@ -247,36 +205,3 @@ Java_com_google_android_filament_Camera_nGetSensitivity(JNIEnv*, jclass,
     Camera *camera = (Camera *) nativeCamera;
     return camera->getSensitivity();
 }
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_Camera_nSetFocusDistance(JNIEnv*, jclass,
-        jlong nativeCamera, jfloat focusDistance) {
-    Camera *camera = (Camera *) nativeCamera;
-    camera->setFocusDistance(focusDistance);
-}
-
-extern "C" JNIEXPORT jfloat JNICALL
-Java_com_google_android_filament_Camera_nGetFocusDistance(JNIEnv*, jclass,
-        jlong nativeCamera) {
-    Camera *camera = (Camera *) nativeCamera;
-    return camera->getFocusDistance();
-}
-
-extern "C" JNIEXPORT jdouble JNICALL
-Java_com_google_android_filament_Camera_nGetFocalLength(JNIEnv*, jclass,
-        jlong nativeCamera) {
-    Camera *camera = (Camera *) nativeCamera;
-    return camera->getFocalLength();
-}
-
-extern "C" JNIEXPORT jdouble JNICALL
-Java_com_google_android_filament_Camera_nComputeEffectiveFocalLength(JNIEnv*, jclass,
-        jdouble focalLength, jdouble focusDistance) {
-    return Camera::computeEffectiveFocalLength(focalLength, focusDistance);
-}
-
-extern "C" JNIEXPORT jdouble JNICALL
-Java_com_google_android_filament_Camera_nComputeEffectiveFov(JNIEnv*, jclass,
-        jdouble fovInDegrees, jdouble focusDistance) {
-    return Camera::computeEffectiveFov(fovInDegrees, focusDistance);
-}

android/filament-android/src/main/cpp/ColorGrading.cpp

@@ -17,7 +17,6 @@
 #include <jni.h>
 
 #include <filament/ColorGrading.h>
-#include <filament/ToneMapper.h>
 
 #include <math/vec3.h>
 #include <math/vec4.h>
@@ -31,48 +30,28 @@ Java_com_google_android_filament_ColorGrading_nCreateBuilder(JNIEnv*, jclass) {
 }
 
 extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_ColorGrading_nDestroyBuilder(JNIEnv*, jclass, jlong nativeBuilder) {
+Java_com_google_android_filament_ColorGrading_nDestroyBuilder(JNIEnv*, jclass,
+        jlong nativeBuilder) {
     ColorGrading::Builder* builder = (ColorGrading::Builder*) nativeBuilder;
     delete builder;
 }
 
 extern "C" JNIEXPORT jlong JNICALL
-Java_com_google_android_filament_ColorGrading_nBuilderBuild(JNIEnv*, jclass, jlong nativeBuilder, jlong nativeEngine) {
+Java_com_google_android_filament_ColorGrading_nBuilderBuild(JNIEnv*, jclass,
+        jlong nativeBuilder, jlong nativeEngine) {
     ColorGrading::Builder* builder = (ColorGrading::Builder*) nativeBuilder;
     Engine *engine = (Engine *) nativeEngine;
     return (jlong) builder->build(*engine);
 }
 
 extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_ColorGrading_nBuilderQuality(JNIEnv*, jclass, jlong nativeBuilder, jint quality_) {
+Java_com_google_android_filament_ColorGrading_nBuilderQuality(JNIEnv*, jclass,
+        jlong nativeBuilder, jint quality_) {
     ColorGrading::Builder* builder = (ColorGrading::Builder*) nativeBuilder;
     ColorGrading::QualityLevel quality = (ColorGrading::QualityLevel) quality_;
     builder->quality(quality);
 }
 
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_ColorGrading_nBuilderFormat(JNIEnv*, jclass, jlong nativeBuilder, jint format_) {
-    ColorGrading::Builder* builder = (ColorGrading::Builder*) nativeBuilder;
-    ColorGrading::LutFormat format = (ColorGrading::LutFormat) format_;
-    builder->format(format);
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_ColorGrading_nBuilderDimensions(JNIEnv*, jclass, jlong nativeBuilder, jint dim_) {
-    ColorGrading::Builder* builder = (ColorGrading::Builder*) nativeBuilder;
-    builder->dimensions((uint8_t)dim_);
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_ColorGrading_nBuilderToneMapper(JNIEnv*, jclass,
-        jlong nativeBuilder, jlong toneMapper_) {
-    ColorGrading::Builder* builder = (ColorGrading::Builder*) nativeBuilder;
-    const ToneMapper* toneMapper = (const ToneMapper*) toneMapper_;
-    builder->toneMapper(toneMapper);
-}
-
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wdeprecated-declarations"
 extern "C" JNIEXPORT void JNICALL
 Java_com_google_android_filament_ColorGrading_nBuilderToneMapping(JNIEnv*, jclass,
         jlong nativeBuilder, jint toneMapping_) {
@@ -80,35 +59,6 @@ Java_com_google_android_filament_ColorGrading_nBuilderToneMapping(JNIEnv*, jclas
     ColorGrading::ToneMapping toneMapping = (ColorGrading::ToneMapping) toneMapping_;
     builder->toneMapping(toneMapping);
 }
-#pragma clang diagnostic pop
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_ColorGrading_nBuilderLuminanceScaling(JNIEnv*, jclass,
-        jlong nativeBuilder, jboolean luminanceScaling) {
-    ColorGrading::Builder* builder = (ColorGrading::Builder*) nativeBuilder;
-    builder->luminanceScaling(luminanceScaling);
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_ColorGrading_nBuilderGamutMapping(JNIEnv*, jclass,
-        jlong nativeBuilder, jboolean gamutMapping) {
-    ColorGrading::Builder* builder = (ColorGrading::Builder*) nativeBuilder;
-    builder->gamutMapping(gamutMapping);
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_ColorGrading_nBuilderExposure(JNIEnv*, jclass,
-        jlong nativeBuilder, jfloat exposure) {
-    ColorGrading::Builder* builder = (ColorGrading::Builder*) nativeBuilder;
-    builder->exposure(exposure);
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_ColorGrading_nBuilderNightAdaptation(JNIEnv*, jclass,
-        jlong nativeBuilder, jfloat adaptation) {
-    ColorGrading::Builder* builder = (ColorGrading::Builder*) nativeBuilder;
-    builder->nightAdaptation(adaptation);
-}
 
 extern "C" JNIEXPORT void JNICALL
 Java_com_google_android_filament_ColorGrading_nBuilderWhiteBalance(JNIEnv*, jclass,

android/filament-android/src/main/cpp/Engine.cpp

@@ -16,7 +16,6 @@
 
 #include <jni.h>
 
-#include <filament/Camera.h>
 #include <filament/Engine.h>
 
 #include <utils/Entity.h>
@@ -45,11 +44,12 @@ extern "C" {
 // handle. Whatever object is returned from this method must match what is in
 // folder filament/src/driver/opengl/Context* in particular pay attention to
 // the object type in makeCurrent method.
-extern void* getNativeWindow(JNIEnv* env, jclass, jobject surface);
+extern void *getNativeWindow(JNIEnv *env, jclass, jobject surface);
 }
 
 extern "C" JNIEXPORT jlong JNICALL
-Java_com_google_android_filament_Engine_nGetBackend(JNIEnv*, jclass, jlong nativeEngine) {
+Java_com_google_android_filament_Engine_nGetBackend(JNIEnv* env,
+        jclass klass, jlong nativeEngine) {
     Engine* engine = (Engine*) nativeEngine;
     return (jlong) engine->getBackend();
 }
@@ -63,8 +63,8 @@ Java_com_google_android_filament_Engine_nCreateSwapChain(JNIEnv* env,
 }
 
 extern "C" JNIEXPORT jlong JNICALL
-Java_com_google_android_filament_Engine_nCreateSwapChainHeadless(JNIEnv*,
-        jclass, jlong nativeEngine, jint width, jint height, jlong flags) {
+Java_com_google_android_filament_Engine_nCreateSwapChainHeadless(JNIEnv* env,
+        jclass klass, jlong nativeEngine, jint width, jint height, jlong flags) {
     Engine* engine = (Engine*) nativeEngine;
     return (jlong) engine->createSwapChain(width, height, (uint64_t) flags);
 }
@@ -80,7 +80,7 @@ extern "C" JNIEXPORT jboolean JNICALL
 Java_com_google_android_filament_Engine_nDestroySwapChain(JNIEnv*, jclass,
         jlong nativeEngine, jlong nativeSwapChain) {
     Engine* engine = (Engine*) nativeEngine;
-    SwapChain* swapChain = (SwapChain*) nativeSwapChain;
+    SwapChain *swapChain = (SwapChain *) nativeSwapChain;
     return engine->destroy(swapChain);
 }
 
@@ -97,7 +97,7 @@ extern "C" JNIEXPORT jboolean JNICALL
 Java_com_google_android_filament_Engine_nDestroyView(JNIEnv*, jclass,
         jlong nativeEngine, jlong nativeView) {
     Engine* engine = (Engine*) nativeEngine;
-    View* view = (View*) nativeView;
+    View *view = (View *) nativeView;
     return engine->destroy(view);
 }
 
@@ -114,14 +114,21 @@ extern "C" JNIEXPORT jboolean JNICALL
 Java_com_google_android_filament_Engine_nDestroyRenderer(JNIEnv*, jclass,
         jlong nativeEngine, jlong nativeRenderer) {
     Engine* engine = (Engine*) nativeEngine;
-    Renderer* renderer = (Renderer*) nativeRenderer;
+    Renderer *renderer = (Renderer *) nativeRenderer;
     return engine->destroy(renderer);
 }
 
 // Camera
 
-extern "C" JNIEXPORT jlong JNICALL
+extern "C" [[deprecated]] JNIEXPORT jlong JNICALL
 Java_com_google_android_filament_Engine_nCreateCamera(JNIEnv*, jclass,
+        jlong nativeEngine) {
+    Engine* engine = (Engine*) nativeEngine;
+    return (jlong) engine->createCamera();
+}
+
+extern "C" JNIEXPORT jlong JNICALL
+Java_com_google_android_filament_Engine_nCreateCameraWithEntity(JNIEnv*, jclass,
         jlong nativeEngine, jint entity_) {
     Engine* engine = (Engine*) nativeEngine;
     Entity& entity = *reinterpret_cast<Entity*>(&entity_);
@@ -136,12 +143,12 @@ Java_com_google_android_filament_Engine_nGetCameraComponent(JNIEnv*, jclass,
     return (jlong) engine->getCameraComponent(entity);
 }
 
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_Engine_nDestroyCameraComponent(JNIEnv*, jclass,
-        jlong nativeEngine, jint entity_) {
+extern "C" [[deprecated]] JNIEXPORT void JNICALL
+Java_com_google_android_filament_Engine_nDestroyCamera(JNIEnv*, jclass,
+        jlong nativeEngine, jlong nativeCamera) {
     Engine* engine = (Engine*) nativeEngine;
-    Entity& entity = *reinterpret_cast<Entity*>(&entity_);
-    engine->destroyCameraComponent(entity);
+    Camera *camera = (Camera *) nativeCamera;
+    engine->destroy(camera);
 }
 
 // Scene
@@ -157,7 +164,7 @@ extern "C" JNIEXPORT jboolean JNICALL
 Java_com_google_android_filament_Engine_nDestroyScene(JNIEnv*, jclass,
         jlong nativeEngine, jlong nativeScene) {
     Engine* engine = (Engine*) nativeEngine;
-    Scene* scene = (Scene*) nativeScene;
+    Scene *scene = (Scene *) nativeScene;
     return engine->destroy(scene);
 }
 
@@ -174,7 +181,7 @@ extern "C" JNIEXPORT jboolean JNICALL
 Java_com_google_android_filament_Engine_nDestroyFence(JNIEnv*, jclass,
         jlong nativeEngine, jlong nativeFence) {
     Engine* engine = (Engine*) nativeEngine;
-    Fence* fence = (Fence*) nativeFence;
+    Fence *fence = (Fence *) nativeFence;
     return engine->destroy(fence);
 }
 
@@ -184,7 +191,7 @@ extern "C" JNIEXPORT jboolean JNICALL
 Java_com_google_android_filament_Engine_nDestroyStream(JNIEnv*, jclass,
         jlong nativeEngine, jlong nativeStream) {
     Engine* engine = (Engine*) nativeEngine;
-    Stream* stream = (Stream*) nativeStream;
+    Stream *stream = (Stream *) nativeStream;
     return engine->destroy(stream);
 }
 
@@ -194,7 +201,7 @@ extern "C" JNIEXPORT jboolean JNICALL
 Java_com_google_android_filament_Engine_nDestroyIndexBuffer(JNIEnv*, jclass,
         jlong nativeEngine, jlong nativeIndexBuffer) {
     Engine* engine = (Engine*) nativeEngine;
-    IndexBuffer* indexBuffer = (IndexBuffer*) nativeIndexBuffer;
+    IndexBuffer *indexBuffer = (IndexBuffer *) nativeIndexBuffer;
     return engine->destroy(indexBuffer);
 }
 
@@ -202,23 +209,15 @@ extern "C" JNIEXPORT jboolean JNICALL
 Java_com_google_android_filament_Engine_nDestroyVertexBuffer(JNIEnv*, jclass,
         jlong nativeEngine, jlong nativeVertexBuffer) {
     Engine* engine = (Engine*) nativeEngine;
-    VertexBuffer* vertexBuffer = (VertexBuffer*) nativeVertexBuffer;
+    VertexBuffer *vertexBuffer = (VertexBuffer *) nativeVertexBuffer;
     return engine->destroy(vertexBuffer);
 }
 
-extern "C" JNIEXPORT jboolean JNICALL
-Java_com_google_android_filament_Engine_nDestroySkinningBuffer(JNIEnv*, jclass,
-        jlong nativeEngine, jlong nativeSkinningBuffer) {
-    Engine* engine = (Engine*) nativeEngine;
-    SkinningBuffer* skinningBuffer = (SkinningBuffer*) nativeSkinningBuffer;
-    return engine->destroy(skinningBuffer);
-}
-
 extern "C" JNIEXPORT jboolean JNICALL
 Java_com_google_android_filament_Engine_nDestroyIndirectLight(JNIEnv*, jclass,
         jlong nativeEngine, jlong nativeIndirectLight) {
     Engine* engine = (Engine*) nativeEngine;
-    IndirectLight* indirectLight = (IndirectLight*) nativeIndirectLight;
+    IndirectLight *indirectLight = (IndirectLight *) nativeIndirectLight;
     return engine->destroy(indirectLight);
 }
 
@@ -226,7 +225,7 @@ extern "C" JNIEXPORT jboolean JNICALL
 Java_com_google_android_filament_Engine_nDestroyMaterial(JNIEnv*, jclass,
         jlong nativeEngine, jlong nativeMaterial) {
     Engine* engine = (Engine*) nativeEngine;
-    Material* material = (Material*) nativeMaterial;
+    Material *material = (Material *) nativeMaterial;
     return engine->destroy(material);
 }
 
@@ -242,7 +241,7 @@ extern "C" JNIEXPORT jboolean JNICALL
 Java_com_google_android_filament_Engine_nDestroySkybox(JNIEnv*, jclass,
         jlong nativeEngine, jlong nativeSkybox) {
     Engine* engine = (Engine*) nativeEngine;
-    Skybox* skybox = (Skybox*) nativeSkybox;
+    Skybox *skybox = (Skybox *) nativeSkybox;
     return engine->destroy(skybox);
 }
 
@@ -258,7 +257,7 @@ extern "C" JNIEXPORT jboolean JNICALL
 Java_com_google_android_filament_Engine_nDestroyTexture(JNIEnv*, jclass,
         jlong nativeEngine, jlong nativeTexture) {
     Engine* engine = (Engine*) nativeEngine;
-    Texture* texture = (Texture*) nativeTexture;
+    Texture *texture = (Texture *) nativeTexture;
     return engine->destroy(texture);
 }
 
@@ -279,7 +278,7 @@ Java_com_google_android_filament_Engine_nDestroyEntity(JNIEnv*, jclass,
 }
 
 extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_Engine_nFlushAndWait(JNIEnv*, jclass,
+Java_com_google_android_filament_Engine_nFlushAndWait(JNIEnv *env, jclass clazz,
         jlong nativeEngine) {
     Engine* engine = (Engine*) nativeEngine;
     engine->flushAndWait();
@@ -288,64 +287,22 @@ Java_com_google_android_filament_Engine_nFlushAndWait(JNIEnv*, jclass,
 // Managers...
 
 extern "C" JNIEXPORT jlong JNICALL
-Java_com_google_android_filament_Engine_nGetTransformManager(JNIEnv*, jclass, jlong nativeEngine) {
+Java_com_google_android_filament_Engine_nGetTransformManager(JNIEnv*, jclass,
+        jlong nativeEngine) {
     Engine* engine = (Engine*) nativeEngine;
     return (jlong) &engine->getTransformManager();
 }
 
 extern "C" JNIEXPORT jlong JNICALL
-Java_com_google_android_filament_Engine_nGetLightManager(JNIEnv*, jclass, jlong nativeEngine) {
+Java_com_google_android_filament_Engine_nGetLightManager(JNIEnv*, jclass,
+        jlong nativeEngine) {
     Engine* engine = (Engine*) nativeEngine;
     return (jlong) &engine->getLightManager();
 }
 
 extern "C" JNIEXPORT jlong JNICALL
-Java_com_google_android_filament_Engine_nGetRenderableManager(JNIEnv*, jclass, jlong nativeEngine) {
+Java_com_google_android_filament_Engine_nGetRenderableManager(JNIEnv*, jclass,
+        jlong nativeEngine) {
     Engine* engine = (Engine*) nativeEngine;
     return (jlong) &engine->getRenderableManager();
 }
-
-extern "C" JNIEXPORT jlong JNICALL
-Java_com_google_android_filament_Engine_nGetJobSystem(JNIEnv*, jclass, jlong nativeEngine) {
-    Engine* engine = (Engine*) nativeEngine;
-    return (jlong) &engine->getJobSystem();
-}
-
-extern "C" JNIEXPORT jlong JNICALL
-Java_com_google_android_filament_Engine_nGetEntityManager(JNIEnv*, jclass, jlong nativeEngine) {
-    Engine* engine = (Engine*) nativeEngine;
-    return (jlong) &engine->getEntityManager();
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_Engine_nSetAutomaticInstancingEnabled(JNIEnv*, jclass, jlong nativeEngine, jboolean enable) {
-    Engine* engine = (Engine*) nativeEngine;
-    engine->setAutomaticInstancingEnabled(enable);
-}
-
-extern "C" JNIEXPORT jboolean JNICALL
-Java_com_google_android_filament_Engine_nIsAutomaticInstancingEnabled(JNIEnv*, jclass, jlong nativeEngine) {
-    Engine* engine = (Engine*) nativeEngine;
-    return (jboolean)engine->isAutomaticInstancingEnabled();
-}
-
-extern "C" JNIEXPORT jint JNICALL
-Java_com_google_android_filament_Engine_nGetSupportedFeatureLevel(JNIEnv *, jclass,
-        jlong nativeEngine) {
-    Engine* engine = (Engine*) nativeEngine;
-    return (jint)engine->getSupportedFeatureLevel();
-}
-
-extern "C" JNIEXPORT jint JNICALL
-Java_com_google_android_filament_Engine_nSetActiveFeatureLevel(JNIEnv *, jclass,
-        jlong nativeEngine, jint ordinal) {
-    Engine* engine = (Engine*) nativeEngine;
-    return (jint)engine->setActiveFeatureLevel((Engine::FeatureLevel)ordinal);
-}
-
-extern "C" JNIEXPORT jint JNICALL
-Java_com_google_android_filament_Engine_nGetActiveFeatureLevel(JNIEnv *, jclass,
-        jlong nativeEngine) {
-    Engine* engine = (Engine*) nativeEngine;
-    return (jint)engine->getActiveFeatureLevel();
-}

android/filament-android/src/main/cpp/Filament.cpp

@@ -16,7 +16,9 @@
 
 #include <jni.h>
 
-#include "private/backend/VirtualMachineEnv.h"
+namespace filament {
+    extern jint JNI_OnLoad(JavaVM* vm, void* reserved);
+};
 
 JNIEXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) {
     JNIEnv* env;
@@ -24,9 +26,9 @@ JNIEXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) {
         return -1;
     }
 
-    // This must be called when the library is loaded. We need this to get a reference to the
-    // global VM
-    ::filament::VirtualMachineEnv::JNI_OnLoad(vm);
+#if ANDROID
+    ::filament::JNI_OnLoad(vm, reserved);
+#endif
 
     return JNI_VERSION_1_6;
 }

android/filament-android/src/main/cpp/IndexBuffer.cpp

@@ -91,8 +91,7 @@ Java_com_google_android_filament_IndexBuffer_nSetBuffer(JNIEnv *env, jclass type
 
     auto* callback = JniBufferCallback::make(engine, env, handler, runnable, std::move(nioBuffer));
 
-    BufferDescriptor desc(data, sizeInBytes,
-            callback->getHandler(), &JniBufferCallback::postToJavaAndDestroy, callback);
+    BufferDescriptor desc(data, sizeInBytes, &JniBufferCallback::invoke, callback);
 
     indexBuffer->setBuffer(*engine, std::move(desc), (uint32_t) destOffsetInBytes);
 

android/filament-android/src/main/cpp/LightManager.cpp

@@ -76,10 +76,8 @@ extern "C" JNIEXPORT void JNICALL
 Java_com_google_android_filament_LightManager_nBuilderShadowOptions(JNIEnv* env, jclass,
         jlong nativeBuilder, jint mapSize, jint cascades, jfloatArray splitPositions,
         jfloat constantBias, jfloat normalBias, jfloat shadowFar, jfloat shadowNearHint,
-        jfloat shadowFarHint, jboolean stable, jboolean lispsm,
-        jfloat polygonOffsetConstant, jfloat polygonOffsetSlope,
-        jboolean screenSpaceContactShadows, jint stepCount,
-        jfloat maxShadowDistance, jint vsmMsaaSamples, jboolean elvsm, jfloat blurWidth, jfloat shadowBulbRadius) {
+        jfloat shadowFarHint, jboolean stable, jboolean screenSpaceContactShadows, jint stepCount,
+        jfloat maxShadowDistance) {
     LightManager::Builder *builder = (LightManager::Builder *) nativeBuilder;
     LightManager::ShadowOptions shadowOptions {
             .mapSize = (uint32_t)mapSize,
@@ -90,18 +88,9 @@ Java_com_google_android_filament_LightManager_nBuilderShadowOptions(JNIEnv* env,
             .shadowNearHint = shadowNearHint,
             .shadowFarHint = shadowFarHint,
             .stable = (bool)stable,
-            .lispsm = (bool)lispsm,
-            .polygonOffsetConstant = polygonOffsetConstant,
-            .polygonOffsetSlope = polygonOffsetConstant,
             .screenSpaceContactShadows = (bool)screenSpaceContactShadows,
             .stepCount = uint8_t(stepCount),
-            .maxShadowDistance = maxShadowDistance,
-            .vsm = {
-                    .msaaSamples = (uint8_t) vsmMsaaSamples,
-                    .elvsm = (bool)elvsm,
-                    .blurWidth = blurWidth
-            },
-            .shadowBulbRadius = shadowBulbRadius
+            .maxShadowDistance = maxShadowDistance
     };
     jfloat *nativeSplits = env->GetFloatArrayElements(splitPositions, NULL);
     const jsize splitCount = std::min((jsize) 3, env->GetArrayLength(splitPositions));
@@ -196,23 +185,6 @@ Java_com_google_android_filament_LightManager_nBuilderHaloFalloff(JNIEnv*, jclas
     builder->sunHaloFalloff(haloFalloff);
 }
 
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_LightManager_nBuilderLightChannel(JNIEnv*, jclass,
-        jlong nativeBuilder, jint channel, jboolean enable) {
-    LightManager::Builder *builder = (LightManager::Builder *) nativeBuilder;
-    builder->lightChannel(channel, (bool)enable);
-}
-
-extern "C" JNIEXPORT jboolean JNICALL
-Java_com_google_android_filament_LightManager_nBuilderBuild(JNIEnv*, jclass,
-        jlong nativeBuilder, jlong nativeEngine, jint entity) {
-    LightManager::Builder *builder = (LightManager::Builder *) nativeBuilder;
-    Engine *engine = (Engine *) nativeEngine;
-    return jboolean(builder->build(*engine, (Entity &) entity) == LightManager::Builder::Success);
-}
-
-// ------------------------------------------------------------------------------------------------
-
 extern "C" JNIEXPORT void JNICALL
 Java_com_google_android_filament_LightManager_nComputeUniformSplits(JNIEnv* env, jclass,
         jfloatArray splitPositions, jint cascades) {
@@ -237,7 +209,13 @@ Java_com_google_android_filament_LightManager_nComputePracticalSplits(JNIEnv* en
     env->ReleaseFloatArrayElements(splitPositions, nativeSplits, 0);
 }
 
-// ------------------------------------------------------------------------------------------------
+extern "C" JNIEXPORT jboolean JNICALL
+Java_com_google_android_filament_LightManager_nBuilderBuild(JNIEnv*, jclass,
+        jlong nativeBuilder, jlong nativeEngine, jint entity) {
+    LightManager::Builder *builder = (LightManager::Builder *) nativeBuilder;
+    Engine *engine = (Engine *) nativeEngine;
+    return jboolean(builder->build(*engine, (Entity &) entity) == LightManager::Builder::Success);
+}
 
 extern "C" JNIEXPORT jint JNICALL
 Java_com_google_android_filament_LightManager_nGetType(JNIEnv* env,
@@ -398,31 +376,3 @@ Java_com_google_android_filament_LightManager_nIsShadowCaster(JNIEnv*, jclass,
     LightManager *lm = (LightManager *) nativeLightManager;
     return (jboolean)lm->isShadowCaster((LightManager::Instance) i);
 }
-
-extern "C" JNIEXPORT jfloat JNICALL
-Java_com_google_android_filament_LightManager_nGetOuterConeAngle(JNIEnv*, jclass,
-        jlong nativeLightManager, jint i) {
-    LightManager *lm = (LightManager *) nativeLightManager;
-    return (jfloat)lm->getSpotLightOuterCone((LightManager::Instance) i);
-}
-
-extern "C" JNIEXPORT jfloat JNICALL
-Java_com_google_android_filament_LightManager_nGetInnerConeAngle(JNIEnv*, jclass,
-        jlong nativeLightManager, jint i) {
-    LightManager *lm = (LightManager *) nativeLightManager;
-    return (jfloat)lm->getSpotLightInnerCone((LightManager::Instance) i);
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_LightManager_nSetLightChannel(JNIEnv*, jclass,
-        jlong nativeLightManager, jint i, jint channel, jboolean enable) {
-    LightManager *lm = (LightManager *) nativeLightManager;
-    lm->setLightChannel((LightManager::Instance) i, channel, (bool)enable);
-}
-
-extern "C" JNIEXPORT jboolean JNICALL
-Java_com_google_android_filament_LightManager_nGetLightChannel(JNIEnv*, jclass,
-        jlong nativeLightManager, jint i, jint channel) {
-    LightManager const *lm = (LightManager const *) nativeLightManager;
-    return lm->getLightChannel((LightManager::Instance) i, channel);
-}

android/filament-android/src/main/cpp/Material.cpp

@@ -91,7 +91,7 @@ Java_com_google_android_filament_Material_nGetBlendingMode(JNIEnv*, jclass,
 
 extern "C"
 JNIEXPORT jint JNICALL
-Java_com_google_android_filament_Material_nGetRefractionMode(JNIEnv*, jclass,
+Java_com_google_android_filament_Material_nGetRefraction(JNIEnv*, jclass,
         jlong nativeMaterial) {
     Material* material = (Material*) nativeMaterial;
     return (jint)material->getRefractionMode();
@@ -204,20 +204,9 @@ Java_com_google_android_filament_Material_nGetParameters(JNIEnv* env, jclass,
     jfieldID parameterSamplerOffset = env->GetStaticFieldID(parameterClass,
             "SAMPLER_OFFSET", "I");
 
-    jfieldID parameterSubpassOffset = env->GetStaticFieldID(parameterClass,
-            "SUBPASS_OFFSET", "I");
-
     jint offset = env->GetStaticIntField(parameterClass, parameterSamplerOffset);
-    jint subpassOffset = env->GetStaticIntField(parameterClass, parameterSubpassOffset);
     for (size_t i = 0; i < received; i++) {
-        jint type;
-        if (info[i].isSampler) {
-            type = (jint) info[i].samplerType + offset;
-        } else if (info[i].isSubpass) {
-            type = subpassOffset;
-        } else {
-            type = (jint) info[i].type;
-        }
+        jint type = info[i].isSampler ? (jint) info[i].samplerType + offset : (jint) info[i].type;
 
         env->CallStaticVoidMethod(
                 parameterClass, parameterAdd,

android/filament-android/src/main/cpp/MaterialInstance.cpp

@@ -341,14 +341,6 @@ Java_com_google_android_filament_MaterialInstance_nSetDepthWrite(JNIEnv*,
     instance->setDepthWrite(enable);
 }
 
-extern "C"
-JNIEXPORT void JNICALL
-Java_com_google_android_filament_MaterialInstance_nSetStencilWrite(JNIEnv*, jclass,
-        jlong nativeMaterialInstance, jboolean enable) {
-    MaterialInstance* instance = (MaterialInstance*) nativeMaterialInstance;
-    instance->setStencilWrite(enable);
-}
-
 extern "C"
 JNIEXPORT void JNICALL
 Java_com_google_android_filament_MaterialInstance_nSetDepthCulling(JNIEnv*,
@@ -357,70 +349,6 @@ Java_com_google_android_filament_MaterialInstance_nSetDepthCulling(JNIEnv*,
     instance->setDepthCulling(enable);
 }
 
-extern "C"
-JNIEXPORT void JNICALL
-Java_com_google_android_filament_MaterialInstance_nSetStencilCompareFunction(JNIEnv*, jclass,
-        jlong nativeMaterialInstance, jlong function, jlong face) {
-    MaterialInstance* instance = (MaterialInstance*) nativeMaterialInstance;
-    instance->setStencilCompareFunction(
-            static_cast<MaterialInstance::StencilCompareFunc>(function),
-            static_cast<MaterialInstance::StencilFace>(face));
-}
-
-extern "C"
-JNIEXPORT void JNICALL
-Java_com_google_android_filament_MaterialInstance_nSetStencilOpStencilFail(JNIEnv*, jclass,
-        jlong nativeMaterialInstance, jlong op, jlong face) {
-    MaterialInstance* instance = (MaterialInstance*) nativeMaterialInstance;
-    instance->setStencilOpStencilFail(
-            static_cast<MaterialInstance::StencilOperation>(op),
-            static_cast<MaterialInstance::StencilFace>(face));
-}
-
-extern "C"
-JNIEXPORT void JNICALL
-Java_com_google_android_filament_MaterialInstance_nSetStencilOpDepthFail(JNIEnv*, jclass,
-        jlong nativeMaterialInstance, jlong op, jlong face) {
-    MaterialInstance* instance = (MaterialInstance*) nativeMaterialInstance;
-    instance->setStencilOpDepthFail(
-            static_cast<MaterialInstance::StencilOperation>(op),
-            static_cast<MaterialInstance::StencilFace>(face));
-}
-
-extern "C"
-JNIEXPORT void JNICALL
-Java_com_google_android_filament_MaterialInstance_nSetStencilOpDepthStencilPass(JNIEnv*, jclass,
-        jlong nativeMaterialInstance, jlong op, jlong face) {
-    MaterialInstance* instance = (MaterialInstance*) nativeMaterialInstance;
-    instance->setStencilOpDepthStencilPass(
-            static_cast<MaterialInstance::StencilOperation>(op),
-            static_cast<MaterialInstance::StencilFace>(face));
-}
-
-extern "C"
-JNIEXPORT void JNICALL
-Java_com_google_android_filament_MaterialInstance_nSetStencilReferenceValue(JNIEnv*, jclass,
-        jlong nativeMaterialInstance, jint value, jlong face) {
-    MaterialInstance* instance = (MaterialInstance*) nativeMaterialInstance;
-    instance->setStencilReferenceValue(value, static_cast<MaterialInstance::StencilFace>(face));
-}
-
-extern "C"
-JNIEXPORT void JNICALL
-Java_com_google_android_filament_MaterialInstance_nSetStencilReadMask(JNIEnv*, jclass,
-        jlong nativeMaterialInstance, jint readMask, jlong face) {
-    MaterialInstance* instance = (MaterialInstance*) nativeMaterialInstance;
-    instance->setStencilReadMask(readMask, static_cast<MaterialInstance::StencilFace>(face));
-}
-
-extern "C"
-JNIEXPORT void JNICALL
-Java_com_google_android_filament_MaterialInstance_nSetStencilWriteMask(JNIEnv*, jclass,
-        jlong nativeMaterialInstance, jint writeMask, jlong face) {
-    MaterialInstance* instance = (MaterialInstance*) nativeMaterialInstance;
-    instance->setStencilWriteMask(writeMask, static_cast<MaterialInstance::StencilFace>(face));
-}
-
 extern "C"
 JNIEXPORT jstring JNICALL
 Java_com_google_android_filament_MaterialInstance_nGetName(JNIEnv* env, jclass,
@@ -436,19 +364,3 @@ Java_com_google_android_filament_MaterialInstance_nGetMaterial(JNIEnv* env, jcla
     MaterialInstance* instance = (MaterialInstance*) nativeMaterialInstance;
     return (jlong) instance->getMaterial();
 }
-
-extern "C"
-JNIEXPORT jlong JNICALL
-Java_com_google_android_filament_MaterialInstance_nDuplicate(JNIEnv* env, jclass clazz,
-        jlong otherNativeMaterialInstance, jstring name) {
-    MaterialInstance* other = (MaterialInstance*) otherNativeMaterialInstance;
-    const char *cstr = nullptr;
-    if (name != nullptr) {
-        cstr = env->GetStringUTFChars(name, nullptr);
-    }
-    MaterialInstance* mi = MaterialInstance::duplicate(other, cstr);
-    if (name != nullptr) {
-        env->ReleaseStringUTFChars(name, cstr);
-    }
-    return (jlong)mi;
-}

android/filament-android/src/main/cpp/MorphTargetBuffer.cpp

@@ -1,114 +0,0 @@
-/*
- * Copyright (C) 2021 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#include <jni.h>
-
-#include <functional>
-#include <stdlib.h>
-#include <string.h>
-
-#include <filament/MorphTargetBuffer.h>
-
-#include "common/CallbackUtils.h"
-#include "common/NioUtils.h"
-
-using namespace filament;
-using namespace backend;
-
-extern "C"
-JNIEXPORT jlong JNICALL
-Java_com_google_android_filament_MorphTargetBuffer_nCreateBuilder(JNIEnv*, jclass) {
-    return (jlong) new MorphTargetBuffer::Builder();
-}
-
-extern "C"
-JNIEXPORT void JNICALL
-Java_com_google_android_filament_MorphTargetBuffer_nDestroyBuilder(JNIEnv*, jclass,
-        jlong nativeBuilder) {
-    MorphTargetBuffer::Builder* builder = (MorphTargetBuffer::Builder *) nativeBuilder;
-    delete builder;
-}
-
-extern "C"
-JNIEXPORT void JNICALL
-Java_com_google_android_filament_MorphTargetBuffer_nBuilderVertexCount(JNIEnv*, jclass,
-        jlong nativeBuilder, jint vertexCount) {
-    MorphTargetBuffer::Builder* builder = (MorphTargetBuffer::Builder *) nativeBuilder;
-    builder->vertexCount((size_t) vertexCount);
-}
-
-extern "C"
-JNIEXPORT void JNICALL
-Java_com_google_android_filament_MorphTargetBuffer_nBuilderCount(JNIEnv*, jclass,
-        jlong nativeBuilder, jint count) {
-    MorphTargetBuffer::Builder* builder = (MorphTargetBuffer::Builder *) nativeBuilder;
-    builder->count((size_t) count);
-}
-
-extern "C"
-JNIEXPORT jlong JNICALL
-Java_com_google_android_filament_MorphTargetBuffer_nBuilderBuild(JNIEnv*, jclass,
-        jlong nativeBuilder, jlong nativeEngine) {
-    MorphTargetBuffer::Builder* builder = (MorphTargetBuffer::Builder *) nativeBuilder;
-    Engine *engine = (Engine *) nativeEngine;
-    return (jlong) builder->build(*engine);
-}
-
-// ------------------------------------------------------------------------------------------------
-
-extern "C"
-JNIEXPORT jint JNICALL
-Java_com_google_android_filament_MorphTargetBuffer_nSetPositionsAt(JNIEnv* env, jclass,
-        jlong nativeObject, jlong nativeEngine,
-        jint targetIndex, jfloatArray positions, jint count) {
-    MorphTargetBuffer *morphTargetBuffer = (MorphTargetBuffer *) nativeObject;
-    Engine *engine = (Engine *) nativeEngine;
-    jfloat* data = env->GetFloatArrayElements(positions, NULL);
-    morphTargetBuffer->setPositionsAt(*engine, targetIndex,
-            (math::float4*) data, size_t(count));
-    env->ReleaseFloatArrayElements(positions, data, JNI_ABORT);
-    return 0;
-}
-
-extern "C"
-JNIEXPORT jint JNICALL
-Java_com_google_android_filament_MorphTargetBuffer_nSetTangentsAt(JNIEnv* env, jclass,
-        jlong nativeObject, jlong nativeEngine,
-        jint targetIndex, jshortArray tangents, jint count) {
-    MorphTargetBuffer *morphTargetBuffer = (MorphTargetBuffer *) nativeObject;
-    Engine *engine = (Engine *) nativeEngine;
-    jshort* data = env->GetShortArrayElements(tangents, NULL);
-    morphTargetBuffer->setTangentsAt(*engine, targetIndex,
-            (math::short4*) data, size_t(count));
-    env->ReleaseShortArrayElements(tangents, data, JNI_ABORT);
-    return 0;
-}
-
-extern "C"
-JNIEXPORT jint JNICALL
-Java_com_google_android_filament_MorphTargetBuffer_nGetVertexCount(JNIEnv*, jclass,
-        jlong nativeObject) {
-    MorphTargetBuffer *morphTargetBuffer = (MorphTargetBuffer *) nativeObject;
-    return (jint)morphTargetBuffer->getVertexCount();
-}
-
-extern "C"
-JNIEXPORT jint JNICALL
-Java_com_google_android_filament_MorphTargetBuffer_nGetCount(JNIEnv*, jclass,
-        jlong nativeObject) {
-    MorphTargetBuffer *morphTargetBuffer = (MorphTargetBuffer *) nativeObject;
-    return (jint)morphTargetBuffer->getCount();
-}

android/filament-android/src/main/cpp/RenderableManager.cpp

@@ -120,14 +120,6 @@ Java_com_google_android_filament_RenderableManager_nBuilderBlendOrder(JNIEnv*, j
     builder->blendOrder((size_t) index, (uint16_t) blendOrder);
 }
 
-extern "C"
-JNIEXPORT void JNICALL
-Java_com_google_android_filament_RenderableManager_nBuilderGlobalBlendOrderEnabled(JNIEnv*, jclass,
-        jlong nativeBuilder, jint index, jboolean enabled) {
-    RenderableManager::Builder *builder = (RenderableManager::Builder *) nativeBuilder;
-    builder->globalBlendOrderEnabled((size_t) index, (bool) enabled);
-}
-
 extern "C" JNIEXPORT void JNICALL
 Java_com_google_android_filament_RenderableManager_nBuilderBoundingBox(JNIEnv*, jclass,
         jlong nativeBuilder, jfloat cx, jfloat cy, jfloat cz, jfloat ex, jfloat ey, jfloat ez) {
@@ -178,14 +170,6 @@ Java_com_google_android_filament_RenderableManager_nBuilderScreenSpaceContactSha
     builder->screenSpaceContactShadows(enabled);
 }
 
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_RenderableManager_nBuilderSkinningBuffer(JNIEnv*, jclass,
-        jlong nativeBuilder, jlong nativeSkinningBuffer, jint boneCount, jint offset) {
-    RenderableManager::Builder *builder = (RenderableManager::Builder *) nativeBuilder;
-    SkinningBuffer *skinningBuffer = (SkinningBuffer *) nativeSkinningBuffer;
-    builder->skinning(skinningBuffer, boneCount, offset);
-}
-
 extern "C" JNIEXPORT void JNICALL
 Java_com_google_android_filament_RenderableManager_nBuilderSkinning(JNIEnv*, jclass,
         jlong nativeBuilder, jint boneCount) {
@@ -193,13 +177,6 @@ Java_com_google_android_filament_RenderableManager_nBuilderSkinning(JNIEnv*, jcl
     builder->skinning((size_t)boneCount);
 }
 
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_RenderableManager_nEnableSkinningBuffers(JNIEnv*, jclass,
-        jlong nativeBuilder, jboolean enabled) {
-    RenderableManager::Builder *builder = (RenderableManager::Builder *) nativeBuilder;
-    builder->enableSkinningBuffers(enabled);
-}
-
 extern "C" JNIEXPORT jint JNICALL
 Java_com_google_android_filament_RenderableManager_nBuilderSkinningBones(JNIEnv* env, jclass,
         jlong nativeBuilder, jint boneCount, jobject bones, jint remaining) {
@@ -217,43 +194,11 @@ Java_com_google_android_filament_RenderableManager_nBuilderSkinningBones(JNIEnv*
 
 extern "C" JNIEXPORT void JNICALL
 Java_com_google_android_filament_RenderableManager_nBuilderMorphing(JNIEnv*, jclass,
-        jlong nativeBuilder, jint targetCount) {
+        jlong nativeBuilder, jboolean enabled) {
     RenderableManager::Builder *builder = (RenderableManager::Builder *) nativeBuilder;
-    builder->morphing(targetCount);
+    builder->morphing(enabled);
 }
 
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_RenderableManager_nBuilderSetMorphTargetBufferAt(JNIEnv*, jclass,
-        jlong nativeBuilder, int level, int primitiveIndex, jlong nativeMorphTargetBuffer,
-        int offset, int count) {
-    RenderableManager::Builder *builder = (RenderableManager::Builder *) nativeBuilder;
-    MorphTargetBuffer *morphTargetBuffer = (MorphTargetBuffer *) nativeMorphTargetBuffer;
-    builder->morphing(level, primitiveIndex, morphTargetBuffer, offset, count);
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_RenderableManager_nBuilderLightChannel(JNIEnv*, jclass,
-        jlong nativeBuilder, jint channel, jboolean enable) {
-    RenderableManager::Builder *builder = (RenderableManager::Builder *) nativeBuilder;
-    builder->lightChannel(channel, (bool)enable);
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_RenderableManager_nBuilderInstances(JNIEnv*, jclass,
-        jlong nativeBuilder, jint instanceCount) {
-    RenderableManager::Builder *builder = (RenderableManager::Builder *) nativeBuilder;
-    builder->instances(instanceCount);
-}
-
-// ------------------------------------------------------------------------------------------------
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_RenderableManager_nSetSkinningBuffer(JNIEnv*, jclass,
-        jlong nativeRenderableManager, jint i, jlong nativeSkinningBuffer, jint count, jint offset) {
-    RenderableManager *rm = (RenderableManager *) nativeRenderableManager;
-    SkinningBuffer *sb = (SkinningBuffer *) nativeSkinningBuffer;
-    rm->setSkinningBuffer(i, sb, count, offset);
-}
 
 extern "C" JNIEXPORT jint JNICALL
 Java_com_google_android_filament_RenderableManager_nSetBonesAsMatrices(JNIEnv* env, jclass,
@@ -291,29 +236,12 @@ Java_com_google_android_filament_RenderableManager_nSetBonesAsQuaternions(JNIEnv
 
 extern "C" JNIEXPORT void JNICALL
 Java_com_google_android_filament_RenderableManager_nSetMorphWeights(JNIEnv* env, jclass,
-        jlong nativeRenderableManager, jint instance, jfloatArray weights, jint offset) {
+        jlong nativeRenderableManager, jint instance, jfloatArray weights) {
     RenderableManager *rm = (RenderableManager *) nativeRenderableManager;
     jfloat* vec = env->GetFloatArrayElements(weights, NULL);
-    jsize count = env->GetArrayLength(weights);
-    rm->setMorphWeights((RenderableManager::Instance)instance, vec, count, offset);
+    math::float4 floatvec(vec[0], vec[1], vec[2], vec[3]);
     env->ReleaseFloatArrayElements(weights, vec, JNI_ABORT);
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_RenderableManager_nSetMorphTargetBufferAt(JNIEnv*,
-        jclass, jlong nativeRenderableManager, jint i, int level, jint primitiveIndex,
-        jlong nativeMorphTargetBuffer, jint offset, jint count) {
-    RenderableManager *rm = (RenderableManager *) nativeRenderableManager;
-    MorphTargetBuffer *morphTargetBuffer = (MorphTargetBuffer *) nativeMorphTargetBuffer;
-    rm->setMorphTargetBufferAt((RenderableManager::Instance) i, (uint8_t) level,
-            (size_t) primitiveIndex, morphTargetBuffer, (size_t) offset, (size_t) count);
-}
-
-extern "C" JNIEXPORT jint JNICALL
-Java_com_google_android_filament_RenderableManager_nGetMorphTargetCount(JNIEnv* env, jclass,
-        jlong nativeRenderableManager, jint instance) {
-    RenderableManager *rm = (RenderableManager *) nativeRenderableManager;
-    return rm->getMorphTargetCount((RenderableManager::Instance)instance);
+    rm->setMorphWeights((RenderableManager::Instance)instance, floatvec);
 }
 
 extern "C" JNIEXPORT void JNICALL
@@ -411,13 +339,21 @@ Java_com_google_android_filament_RenderableManager_nSetMaterialInstanceAt(JNIEnv
             materialInstance);
 }
 
-extern "C" JNIEXPORT jlong JNICALL
+extern "C" JNIEXPORT long JNICALL
 Java_com_google_android_filament_RenderableManager_nGetMaterialInstanceAt(JNIEnv*, jclass,
         jlong nativeRenderableManager, jint i, jint primitiveIndex) {
     RenderableManager *rm = (RenderableManager *) nativeRenderableManager;
     return (long) rm->getMaterialInstanceAt((RenderableManager::Instance) i, (size_t) primitiveIndex);
 }
 
+extern "C" JNIEXPORT long JNICALL
+Java_com_google_android_filament_RenderableManager_nGetMaterialAt(JNIEnv*, jclass,
+        jlong nativeRenderableManager, jint i, jint primitiveIndex) {
+    RenderableManager *rm = (RenderableManager *) nativeRenderableManager;
+    MaterialInstance *mi = rm->getMaterialInstanceAt((RenderableManager::Instance) i, (size_t) primitiveIndex);
+    return (long) mi->getMaterial();
+}
+
 extern "C" JNIEXPORT void JNICALL
 Java_com_google_android_filament_RenderableManager_nSetGeometryAt__JIIIJJII(JNIEnv*,
         jclass, jlong nativeRenderableManager, jint i, jint primitiveIndex, jint primitiveType,
@@ -430,6 +366,15 @@ Java_com_google_android_filament_RenderableManager_nSetGeometryAt__JIIIJJII(JNIE
             (size_t) offset, (size_t) count);
 }
 
+extern "C" JNIEXPORT void JNICALL
+Java_com_google_android_filament_RenderableManager_nSetGeometryAt__JIIIII(JNIEnv*, jclass,
+        jlong nativeRenderableManager, jint i, jint primitiveIndex, jint primitiveType, jint offset,
+        jint count) {
+    RenderableManager *rm = (RenderableManager *) nativeRenderableManager;
+    rm->setGeometryAt((RenderableManager::Instance) i, (size_t) primitiveIndex,
+            (RenderableManager::PrimitiveType) primitiveType, (size_t) offset, (size_t) count);
+}
+
 extern "C" JNIEXPORT void JNICALL
 Java_com_google_android_filament_RenderableManager_nSetBlendOrderAt(JNIEnv*, jclass,
         jlong nativeRenderableManager, jint i, jint primitiveIndex, jint blendOrder) {
@@ -438,14 +383,6 @@ Java_com_google_android_filament_RenderableManager_nSetBlendOrderAt(JNIEnv*, jcl
             (uint16_t) blendOrder);
 }
 
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_RenderableManager_nSetGlobalBlendOrderEnabledAt(JNIEnv*, jclass,
-        jlong nativeRenderableManager, jint i, jint primitiveIndex, jboolean enabled) {
-    RenderableManager *rm = (RenderableManager *) nativeRenderableManager;
-    rm->setGlobalBlendOrderEnabledAt((RenderableManager::Instance) i, (size_t) primitiveIndex,
-            (bool) enabled);
-}
-
 extern "C" JNIEXPORT jint JNICALL
 Java_com_google_android_filament_RenderableManager_nGetEnabledAttributesAt(JNIEnv*, jclass,
         jlong nativeRenderableManager, jint i, jint primitiveIndex) {
@@ -453,17 +390,3 @@ Java_com_google_android_filament_RenderableManager_nGetEnabledAttributesAt(JNIEn
     AttributeBitset enabled = rm->getEnabledAttributesAt((RenderableManager::Instance) i, (size_t) primitiveIndex);
     return enabled.getValue();
 }
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_RenderableManager_nSetLightChannel(JNIEnv*, jclass,
-        jlong nativeRenderableManager, jint i, jint channel, jboolean enable) {
-    RenderableManager *rm = (RenderableManager *) nativeRenderableManager;
-    rm->setLightChannel((RenderableManager::Instance) i, channel, (bool)enable);
-}
-
-extern "C" JNIEXPORT jboolean JNICALL
-Java_com_google_android_filament_RenderableManager_nGetLightChannel(JNIEnv*, jclass,
-        jlong nativeRenderableManager, jint i, jint channel) {
-    RenderableManager const *rm = (RenderableManager const *) nativeRenderableManager;
-    return rm->getLightChannel((RenderableManager::Instance) i, channel);
-}

android/filament-android/src/main/cpp/Renderer.cpp

@@ -50,14 +50,6 @@ Java_com_google_android_filament_Renderer_nRender(JNIEnv *, jclass, jlong native
     renderer->render(view);
 }
 
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_Renderer_nRenderStandaloneView(JNIEnv *, jclass, jlong nativeRenderer,
-        jlong nativeView) {
-    Renderer *renderer = (Renderer *) nativeRenderer;
-    View *view = (View *) nativeView;
-    renderer->renderStandaloneView(view);
-}
-
 extern "C" JNIEXPORT void JNICALL
 Java_com_google_android_filament_Renderer_nCopyFrame(JNIEnv *, jclass, jlong nativeRenderer,
         jlong nativeDstSwapChain,
@@ -97,8 +89,7 @@ Java_com_google_android_filament_Renderer_nReadPixels(JNIEnv *env, jclass,
 
     PixelBufferDescriptor desc(buffer, sizeInBytes, (backend::PixelDataFormat) format,
             (backend::PixelDataType) type, (uint8_t) alignment, (uint32_t) left, (uint32_t) top,
-            (uint32_t) stride,
-            callback->getHandler(), &JniBufferCallback::postToJavaAndDestroy, callback);
+            (uint32_t) stride, &JniBufferCallback::invoke, callback);
 
     renderer->readPixels(uint32_t(xoffset), uint32_t(yoffset), uint32_t(width), uint32_t(height),
             std::move(desc));
@@ -133,8 +124,7 @@ Java_com_google_android_filament_Renderer_nReadPixelsEx(JNIEnv *env, jclass,
 
     PixelBufferDescriptor desc(buffer, sizeInBytes, (backend::PixelDataFormat) format,
             (backend::PixelDataType) type, (uint8_t) alignment, (uint32_t) left, (uint32_t) top,
-            (uint32_t) stride,
-            callback->getHandler(), &JniBufferCallback::postToJavaAndDestroy, callback);
+            (uint32_t) stride, &JniBufferCallback::invoke, callback);
 
     renderer->readPixels(renderTarget,
             uint32_t(xoffset), uint32_t(yoffset), uint32_t(width), uint32_t(height),
@@ -156,9 +146,12 @@ Java_com_google_android_filament_Renderer_nResetUserTime(JNIEnv*, jclass, jlong
 }
 
 extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_Renderer_nSetDisplayInfo(JNIEnv*, jclass, jlong nativeRenderer, jfloat refreshRate) {
+Java_com_google_android_filament_Renderer_nSetDisplayInfo(JNIEnv*, jclass, jlong nativeRenderer,
+        jfloat refreshRate, jlong presentationDeadlineNanos, jlong vsyncOffsetNanos) {
     Renderer *renderer = (Renderer *) nativeRenderer;
-    renderer->setDisplayInfo({ .refreshRate = refreshRate });
+    renderer->setDisplayInfo({ .refreshRate = refreshRate,
+                               .presentationDeadlineNanos = (uint64_t)presentationDeadlineNanos,
+                               .vsyncOffsetNanos = (uint64_t)vsyncOffsetNanos });
 }
 
 extern "C" JNIEXPORT void JNICALL
@@ -180,10 +173,3 @@ Java_com_google_android_filament_Renderer_nSetClearOptions(JNIEnv *, jclass ,
                                 .clear = (bool) clear,
                                 .discard = (bool) discard});
 }
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_Renderer_nSetPresentationTime(JNIEnv *, jclass ,
-    jlong nativeRenderer, jlong monotonicClockNanos) {
-    Renderer *renderer = (Renderer *) nativeRenderer;
-    renderer->setPresentationTime(monotonicClockNanos);
-}

android/filament-android/src/main/cpp/Scene.cpp

@@ -83,11 +83,3 @@ Java_com_google_android_filament_Scene_nGetLightCount(JNIEnv *env, jclass type,
     Scene* scene = (Scene*) nativeScene;
     return (jint) scene->getLightCount();
 }
-
-extern "C" JNIEXPORT jboolean JNICALL
-Java_com_google_android_filament_Scene_nHasEntity(JNIEnv *env, jclass type, jlong nativeScene,
-        jint entityId) {
-    Scene* scene = (Scene*) nativeScene;
-    Entity entity = Entity::import(entityId);
-    return (jboolean) scene->hasEntity(entity);
-}

android/filament-android/src/main/cpp/SkinningBuffer.cpp

@@ -1,116 +0,0 @@
-/*
- * Copyright (C) 2021 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#include <jni.h>
-
-#include <functional>
-#include <stdlib.h>
-#include <string.h>
-
-#include <filament/SkinningBuffer.h>
-
-#include "common/CallbackUtils.h"
-#include "common/NioUtils.h"
-
-using namespace filament;
-using namespace backend;
-
-extern "C"
-JNIEXPORT jlong JNICALL
-Java_com_google_android_filament_SkinningBuffer_nCreateBuilder(JNIEnv*, jclass) {
-    return (jlong) new SkinningBuffer::Builder();
-}
-
-extern "C"
-JNIEXPORT void JNICALL
-Java_com_google_android_filament_SkinningBuffer_nDestroyBuilder(JNIEnv*, jclass,
-        jlong nativeBuilder) {
-    SkinningBuffer::Builder* builder = (SkinningBuffer::Builder *) nativeBuilder;
-    delete builder;
-}
-
-extern "C"
-JNIEXPORT void JNICALL
-Java_com_google_android_filament_SkinningBuffer_nBuilderBoneCount(JNIEnv*, jclass,
-        jlong nativeBuilder, jint boneCount) {
-    SkinningBuffer::Builder* builder = (SkinningBuffer::Builder *) nativeBuilder;
-    builder->boneCount((uint32_t)boneCount);
-}
-
-extern "C"
-JNIEXPORT void JNICALL
-Java_com_google_android_filament_SkinningBuffer_nBuilderInitialize(JNIEnv*, jclass,
-        jlong nativeBuilder, jboolean initialize) {
-    SkinningBuffer::Builder* builder = (SkinningBuffer::Builder *) nativeBuilder;
-    builder->initialize((bool)initialize);
-}
-
-extern "C"
-JNIEXPORT jlong JNICALL
-Java_com_google_android_filament_SkinningBuffer_nBuilderBuild(JNIEnv*, jclass,
-        jlong nativeBuilder, jlong nativeEngine) {
-    SkinningBuffer::Builder* builder = (SkinningBuffer::Builder *) nativeBuilder;
-    Engine *engine = (Engine *) nativeEngine;
-    return (jlong) builder->build(*engine);
-}
-
-// ------------------------------------------------------------------------------------------------
-
-extern "C"
-JNIEXPORT jint JNICALL
-Java_com_google_android_filament_SkinningBuffer_nSetBonesAsMatrices(JNIEnv* env, jclass,
-        jlong nativeSkinningBuffer, jlong nativeEngine, jobject matrices, jint remaining, jint boneCount,
-        jint offset) {
-    SkinningBuffer *skinningBuffer = (SkinningBuffer *) nativeSkinningBuffer;
-    Engine *engine = (Engine *) nativeEngine;
-    AutoBuffer nioBuffer(env, matrices, boneCount * 16);
-    void* data = nioBuffer.getData();
-    size_t sizeInBytes = nioBuffer.getSize();
-    if (sizeInBytes > (remaining << nioBuffer.getShift())) {
-        // BufferOverflowException
-        return -1;
-    }
-    skinningBuffer->setBones(*engine,
-            static_cast<filament::math::mat4f const *>(data), (size_t)boneCount, (size_t)offset);
-    return 0;
-}
-
-extern "C"
-JNIEXPORT jint JNICALL
-Java_com_google_android_filament_SkinningBuffer_nSetBonesAsQuaternions(JNIEnv* env, jclass,
-        jlong nativeSkinningBuffer, jlong nativeEngine, jobject quaternions, jint remaining,
-        jint boneCount, jint offset) {
-    SkinningBuffer *skinningBuffer = (SkinningBuffer *) nativeSkinningBuffer;
-    Engine *engine = (Engine *) nativeEngine;
-    AutoBuffer nioBuffer(env, quaternions, boneCount * 8);
-    void* data = nioBuffer.getData();
-    size_t sizeInBytes = nioBuffer.getSize();
-    if (sizeInBytes > (remaining << nioBuffer.getShift())) {
-        // BufferOverflowException
-        return -1;
-    }
-    skinningBuffer->setBones(*engine,
-            static_cast<RenderableManager::Bone const *>(data), (size_t)boneCount, (size_t)offset);
-    return 0;
-}
-
-extern "C"
-JNIEXPORT jint JNICALL
-Java_com_google_android_filament_SkinningBuffer_nGetBoneCount(JNIEnv*, jclass,
-        jlong nativeSkinningBuffer) {
-    SkinningBuffer *skinningBuffer = (SkinningBuffer *) nativeSkinningBuffer;
-    return (jint)skinningBuffer->getBoneCount();
-}

android/filament-android/src/main/cpp/SkyBox.cpp

@@ -100,7 +100,7 @@ Java_com_google_android_filament_Skybox_nSetColor(JNIEnv *, jclass,
 }
 
 extern "C" JNIEXPORT jlong JNICALL
-Java_com_google_android_filament_Skybox_nGetTexture(JNIEnv* env, jclass,
+Java_com_google_android_filament_Skybix_nGetTexture(JNIEnv* env, jclass,
         jlong nativeSkybox) {
     Skybox *skybox = (Skybox *) nativeSkybox;
     Texture const *tex = skybox->getTexture();

android/filament-android/src/main/cpp/Stream.cpp

@@ -24,7 +24,7 @@
 #include "common/NioUtils.h"
 #include "common/CallbackUtils.h"
 
-#ifdef __ANDROID__
+#ifdef ANDROID
 
 #if __has_include(<android/hardware_buffer_jni.h>)
 #include <android/hardware_buffer_jni.h>
@@ -98,6 +98,13 @@ Java_com_google_android_filament_Stream_nBuilderStreamSource(JNIEnv* env,
     builder->setStreamSource(env, streamSource);
 }
 
+extern "C" JNIEXPORT void JNICALL
+Java_com_google_android_filament_Stream_nBuilderStream(JNIEnv*, jclass,
+        jlong nativeStreamBuilder, jlong externalTextureId) {
+    StreamBuilder* builder = (StreamBuilder*) nativeStreamBuilder;
+    builder->builder()->stream(externalTextureId);
+}
+
 extern "C" JNIEXPORT void JNICALL
 Java_com_google_android_filament_Stream_nBuilderWidth(JNIEnv*, jclass,
         jlong nativeStreamBuilder, jint width) {
@@ -133,6 +140,40 @@ Java_com_google_android_filament_Stream_nSetDimensions(JNIEnv*, jclass, jlong na
     stream->setDimensions((uint32_t) width, (uint32_t) height);
 }
 
+extern "C" JNIEXPORT jint JNICALL
+Java_com_google_android_filament_Stream_nReadPixels(JNIEnv *env, jclass,
+        jlong nativeStream, jlong nativeEngine,
+        jint xoffset, jint yoffset, jint width, jint height,
+        jobject storage, jint remaining,
+        jint left, jint top, jint type, jint alignment, jint stride, jint format,
+        jobject handler, jobject runnable) {
+    Stream *stream = (Stream *) nativeStream;
+    Engine *engine = (Engine *) nativeEngine;
+
+    stride = stride ? stride : width;
+    size_t sizeInBytes = PixelBufferDescriptor::computeDataSize(
+            (PixelDataFormat) format, (PixelDataType) type,
+            (size_t) stride, (size_t) (height + top), (size_t) alignment);
+
+    AutoBuffer nioBuffer(env, storage, 0);
+    if (sizeInBytes > (remaining << nioBuffer.getShift())) {
+        // BufferOverflowException
+        return -1;
+    }
+
+    void *buffer = nioBuffer.getData();
+    auto *callback = JniBufferCallback::make(engine, env, handler, runnable, std::move(nioBuffer));
+
+    PixelBufferDescriptor desc(buffer, sizeInBytes, (backend::PixelDataFormat) format,
+            (backend::PixelDataType) type, (uint8_t) alignment, (uint32_t) left, (uint32_t) top,
+            (uint32_t) stride, &JniBufferCallback::invoke, callback);
+
+    stream->readPixels(uint32_t(xoffset), uint32_t(yoffset), uint32_t(width), uint32_t(height),
+            std::move(desc));
+
+    return 0;
+}
+
 extern "C" JNIEXPORT jlong JNICALL
 Java_com_google_android_filament_Stream_nGetTimestamp(JNIEnv*, jclass, jlong nativeStream) {
     Stream *stream = (Stream *) nativeStream;
@@ -145,7 +186,7 @@ Java_com_google_android_filament_Stream_nSetAcquiredImage(JNIEnv* env, jclass, j
     Engine* engine = (Engine*) nativeEngine;
     Stream* stream = (Stream*) nativeStream;
 
-#ifdef __ANDROID__
+#ifdef ANDROID
 
     // This function is not available before NDK 15 or before Android 8.
     if (UTILS_UNLIKELY(!AHardwareBuffer_fromHardwareBuffer_fn)) {
@@ -156,8 +197,8 @@ Java_com_google_android_filament_Stream_nSetAcquiredImage(JNIEnv* env, jclass, j
          if (!AHardwareBuffer_fromHardwareBuffer_fn) {
             __android_log_print(ANDROID_LOG_WARN, "Filament", "AHardwareBuffer_fromHardwareBuffer is not available.");
             sHardwareBufferSupported = false;
-            return;
         }
+        return;
     }
 
     AHardwareBuffer* nativeBuffer = AHardwareBuffer_fromHardwareBuffer_fn(env, hwbuffer);
@@ -177,6 +218,5 @@ Java_com_google_android_filament_Stream_nSetAcquiredImage(JNIEnv* env, jclass, j
 
 #endif
 
-    stream->setAcquiredImage((void*) nativeBuffer,
-            callback->getHandler(), &JniImageCallback::postToJavaAndDestroy, callback);
+    stream->setAcquiredImage((void*) nativeBuffer, &JniImageCallback::invoke, callback);
 }

android/filament-android/src/main/cpp/SwapChain.cpp

@@ -1,34 +0,0 @@
-/*
- * Copyright (C) 2020 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#include <jni.h>
-
-#include <filament/SwapChain.h>
-
-#include "common/CallbackUtils.h"
-
-using namespace filament;
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_SwapChain_nSetFrameCompletedCallback(JNIEnv* env, jclass,
-        jlong nativeSwapChain, jobject handler, jobject runnable) {
-    SwapChain* swapChain = (SwapChain*) nativeSwapChain;
-    auto *callback = JniCallback::make(env, handler, runnable);
-    swapChain->setFrameCompletedCallback([](void* user) {
-        JniCallback* callback = (JniCallback*)user;
-        JniCallback::postToJavaAndDestroy(callback);
-    }, callback);
-}

android/filament-android/src/main/cpp/Texture.cpp

@@ -19,7 +19,7 @@
 #include <algorithm>
 #include <functional>
 
-#ifdef __ANDROID__
+#ifdef ANDROID
 #include <android/bitmap.h>
 #endif
 
@@ -31,18 +31,15 @@
 #include "common/CallbackUtils.h"
 #include "common/NioUtils.h"
 
-#include "private/backend/VirtualMachineEnv.h"
-
 using namespace filament;
 using namespace backend;
 
-static size_t getTextureDataSize(const Texture *texture,
-        size_t level, Texture::Format format, Texture::Type type,
-        size_t stride, size_t height, size_t alignment) {
+static size_t getTextureDataSize(const Texture *texture, size_t level,
+        Texture::Format format, Texture::Type type, size_t stride, size_t alignment) {
     // Zero stride implies tight row-to-row packing.
-    stride = stride == 0 ? texture->getWidth(level)  : std::max(size_t(1), stride >> level);
-    height = height == 0 ? texture->getHeight(level) : std::max(size_t(1), height >> level);
-    return Texture::computeTextureDataSize(format, type, stride, height, alignment);
+    stride = stride == 0 ? texture->getWidth(level) : std::max(size_t(1), stride >> level);
+    return Texture::computeTextureDataSize(format, type,
+            stride, texture->getHeight(level), alignment);
 }
 
 extern "C" JNIEXPORT jboolean JNICALL
@@ -53,13 +50,6 @@ Java_com_google_android_filament_Texture_nIsTextureFormatSupported(JNIEnv*, jcla
             (Texture::InternalFormat) internalFormat);
 }
 
-extern "C" JNIEXPORT jboolean JNICALL
-Java_com_google_android_filament_Texture_nIsTextureSwizzleSupported(JNIEnv*, jclass,
-        jlong nativeEngine) {
-    Engine *engine = (Engine *) nativeEngine;
-    return (jboolean) Texture::isTextureSwizzleSupported(*engine);
-}
-
 // Texture::Builder...
 
 extern "C" JNIEXPORT jlong JNICALL
@@ -131,13 +121,6 @@ Java_com_google_android_filament_Texture_nBuilderSwizzle(JNIEnv *, jclass ,
             (Texture::Swizzle)r, (Texture::Swizzle)g, (Texture::Swizzle)b, (Texture::Swizzle)a);
 }
 
-extern "C"
-JNIEXPORT void JNICALL
-Java_com_google_android_filament_Texture_nBuilderImportTexture(JNIEnv*, jclass, jlong nativeBuilder, jlong id) {
-    Texture::Builder *builder = (Texture::Builder *) nativeBuilder;
-    builder->import((intptr_t)id);
-}
-
 extern "C" JNIEXPORT jlong JNICALL
 Java_com_google_android_filament_Texture_nBuilderBuild(JNIEnv*, jclass,
         jlong nativeBuilder, jlong nativeEngine) {
@@ -189,19 +172,17 @@ Java_com_google_android_filament_Texture_nGetInternalFormat(JNIEnv*, jclass,
 }
 
 extern "C" JNIEXPORT jint JNICALL
-Java_com_google_android_filament_Texture_nSetImage3D(JNIEnv* env, jclass, jlong nativeTexture,
-        jlong nativeEngine, jint level,
-        jint xoffset, jint yoffset, jint zoffset,
-        jint width, jint height, jint depth,
+Java_com_google_android_filament_Texture_nSetImage(JNIEnv* env, jclass, jlong nativeTexture,
+        jlong nativeEngine, jint level, jint xoffset, jint yoffset, jint width, jint height,
         jobject storage,  jint remaining,
-        jint left, jint top, jint type, jint alignment,
+        jint left, jint bottom, jint type, jint alignment,
         jint stride, jint format,
         jobject handler, jobject runnable) {
     Texture* texture = (Texture*) nativeTexture;
     Engine* engine = (Engine*) nativeEngine;
 
     size_t sizeInBytes = getTextureDataSize(texture, (size_t) level, (Texture::Format) format,
-            (Texture::Type) type, (size_t) stride, (size_t) height, (size_t) alignment) * depth;
+            (Texture::Type) type, (size_t) stride, (size_t) alignment);
 
     AutoBuffer nioBuffer(env, storage, 0);
     if (sizeInBytes > (size_t(remaining) << nioBuffer.getShift())) {
@@ -213,9 +194,72 @@ Java_com_google_android_filament_Texture_nSetImage3D(JNIEnv* env, jclass, jlong
     auto *callback = JniBufferCallback::make(engine, env, handler, runnable, std::move(nioBuffer));
 
     Texture::PixelBufferDescriptor desc(buffer, sizeInBytes, (backend::PixelDataFormat) format,
-            (backend::PixelDataType) type, (uint8_t) alignment, (uint32_t) left, (uint32_t) top,
-            (uint32_t) stride,
-            callback->getHandler(), &JniBufferCallback::postToJavaAndDestroy, callback);
+            (backend::PixelDataType) type, (uint8_t) alignment, (uint32_t) left, (uint32_t) bottom,
+            (uint32_t) stride, &JniBufferCallback::invoke, callback);
+
+    texture->setImage(*engine, (size_t) level, (uint32_t) xoffset, (uint32_t) yoffset,
+            (uint32_t) width, (uint32_t) height, std::move(desc));
+
+    return 0;
+}
+
+extern "C" JNIEXPORT jint JNICALL
+Java_com_google_android_filament_Texture_nSetImageCompressed(JNIEnv *env, jclass,
+        jlong nativeTexture, jlong nativeEngine, jint level, jint xoffset, jint yoffset,
+        jint width, jint height, jobject storage,  jint remaining,
+        jint, jint, jint, jint, jint compressedSizeInBytes, jint compressedFormat,
+        jobject handler, jobject runnable) {
+    Texture *texture = (Texture *) nativeTexture;
+    Engine *engine = (Engine *) nativeEngine;
+
+    size_t sizeInBytes = (size_t) compressedSizeInBytes;
+
+    AutoBuffer nioBuffer(env, storage, 0);
+    if (sizeInBytes > (size_t(remaining) << nioBuffer.getShift())) {
+        // BufferOverflowException
+        return -1;
+    }
+
+    void *buffer = nioBuffer.getData();
+    auto *callback = JniBufferCallback::make(engine, env, handler, runnable, std::move(nioBuffer));
+
+    Texture::PixelBufferDescriptor desc(buffer, sizeInBytes,
+            (backend::CompressedPixelDataType) compressedFormat, (uint32_t) compressedSizeInBytes,
+            &JniBufferCallback::invoke, callback);
+
+    texture->setImage(*engine, (size_t) level, (uint32_t) xoffset, (uint32_t) yoffset,
+            (uint32_t) width, (uint32_t) height, std::move(desc));
+
+    return 0;
+}
+
+extern "C" JNIEXPORT jint JNICALL
+Java_com_google_android_filament_Texture_nSetImage3D(JNIEnv* env, jclass, jlong nativeTexture,
+        jlong nativeEngine, jint level,
+        jint xoffset, jint yoffset, jint zoffset,
+        jint width, jint height, jint depth,
+        jobject storage,  jint remaining,
+        jint left, jint bottom, jint type, jint alignment,
+        jint stride, jint format,
+        jobject handler, jobject runnable) {
+    Texture* texture = (Texture*) nativeTexture;
+    Engine* engine = (Engine*) nativeEngine;
+
+    size_t sizeInBytes = getTextureDataSize(texture, (size_t) level, (Texture::Format) format,
+            (Texture::Type) type, (size_t) stride, (size_t) alignment);
+
+    AutoBuffer nioBuffer(env, storage, 0);
+    if (sizeInBytes > (size_t(remaining) << nioBuffer.getShift())) {
+        // BufferOverflowException
+        return -1;
+    }
+
+    void *buffer = nioBuffer.getData();
+    auto *callback = JniBufferCallback::make(engine, env, handler, runnable, std::move(nioBuffer));
+
+    Texture::PixelBufferDescriptor desc(buffer, sizeInBytes, (backend::PixelDataFormat) format,
+            (backend::PixelDataType) type, (uint8_t) alignment, (uint32_t) left, (uint32_t) bottom,
+            (uint32_t) stride, &JniBufferCallback::invoke, callback);
 
     texture->setImage(*engine, (size_t) level,
             (uint32_t) xoffset, (uint32_t) yoffset, (uint32_t) zoffset,
@@ -249,7 +293,7 @@ Java_com_google_android_filament_Texture_nSetImage3DCompressed(JNIEnv *env, jcla
 
     Texture::PixelBufferDescriptor desc(buffer, sizeInBytes,
             (backend::CompressedPixelDataType) compressedFormat, (uint32_t) compressedSizeInBytes,
-            callback->getHandler(), &JniBufferCallback::postToJavaAndDestroy, callback);
+            &JniBufferCallback::invoke, callback);
 
     texture->setImage(*engine, (size_t) level,
             (uint32_t) xoffset, (uint32_t) yoffset, (uint32_t) zoffset,
@@ -262,7 +306,7 @@ Java_com_google_android_filament_Texture_nSetImage3DCompressed(JNIEnv *env, jcla
 extern "C" JNIEXPORT jint JNICALL
 Java_com_google_android_filament_Texture_nSetImageCubemap(JNIEnv *env, jclass,
         jlong nativeTexture, jlong nativeEngine, jint level, jobject storage, jint remaining,
-        jint left, jint top, jint type, jint alignment, jint stride, jint format,
+        jint left, jint bottom, jint type, jint alignment, jint stride, jint format,
         jintArray faceOffsetsInBytes_,
         jobject handler, jobject runnable) {
     Texture *texture = (Texture *) nativeTexture;
@@ -274,7 +318,7 @@ Java_com_google_android_filament_Texture_nSetImageCubemap(JNIEnv *env, jclass,
     env->ReleaseIntArrayElements(faceOffsetsInBytes_, faceOffsetsInBytes, JNI_ABORT);
 
     size_t sizeInBytes = 6 * getTextureDataSize(texture, (size_t) level, (Texture::Format) format,
-            (Texture::Type) type, (size_t) stride, 0, (size_t) alignment);
+            (Texture::Type) type, (size_t) stride, (size_t) alignment);
 
     AutoBuffer nioBuffer(env, storage, 0);
     if (sizeInBytes > (size_t(remaining) << nioBuffer.getShift())) {
@@ -286,14 +330,10 @@ Java_com_google_android_filament_Texture_nSetImageCubemap(JNIEnv *env, jclass,
     auto *callback = JniBufferCallback::make(engine, env, handler, runnable, std::move(nioBuffer));
 
     Texture::PixelBufferDescriptor desc(buffer, sizeInBytes, (backend::PixelDataFormat) format,
-            (backend::PixelDataType) type, (uint8_t) alignment, (uint32_t) left, (uint32_t) top,
-            (uint32_t) stride,
-            callback->getHandler(), &JniBufferCallback::postToJavaAndDestroy, callback);
+            (backend::PixelDataType) type, (uint8_t) alignment, (uint32_t) left, (uint32_t) bottom,
+            (uint32_t) stride, &JniBufferCallback::invoke, callback);
 
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wdeprecated-declarations"
     texture->setImage(*engine, (size_t) level, std::move(desc), faceOffsets);
-#pragma clang diagnostic pop
 
     return 0;
 }
@@ -301,7 +341,7 @@ Java_com_google_android_filament_Texture_nSetImageCubemap(JNIEnv *env, jclass,
 extern "C" JNIEXPORT jint JNICALL
 Java_com_google_android_filament_Texture_nSetImageCubemapCompressed(JNIEnv *env, jclass,
         jlong nativeTexture, jlong nativeEngine, jint level, jobject storage, jint remaining,
-        jint left, jint top, jint type, jint alignment,
+        jint left, jint bottom, jint type, jint alignment,
         jint compressedSizeInBytes, jint compressedFormat, jintArray faceOffsetsInBytes_,
         jobject handler, jobject runnable) {
 
@@ -326,12 +366,9 @@ Java_com_google_android_filament_Texture_nSetImageCubemapCompressed(JNIEnv *env,
 
     Texture::PixelBufferDescriptor desc(buffer, sizeInBytes,
             (backend::CompressedPixelDataType) compressedFormat, (uint32_t) compressedSizeInBytes,
-            callback->getHandler(), &JniBufferCallback::postToJavaAndDestroy, callback);
+            &JniBufferCallback::invoke, callback);
 
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wdeprecated-declarations"
     texture->setImage(*engine, (size_t) level, std::move(desc), faceOffsets);
-#pragma clang diagnostic pop
 
     return 0;
 }
@@ -402,7 +439,7 @@ Java_com_google_android_filament_Texture_nGeneratePrefilterMipmap(JNIEnv *env, j
     Texture::PixelBufferDescriptor desc(buffer, sizeInBytes, (backend::PixelDataFormat) format,
             (backend::PixelDataType) type, (uint8_t) alignment,
             (uint32_t) left, (uint32_t) top, (uint32_t) stride,
-            callback->getHandler(), &JniBufferCallback::postToJavaAndDestroy, callback);
+            &JniBufferCallback::invoke, callback);
 
     Texture::PrefilterOptions options;
     options.sampleCount = sampleCount;
@@ -416,7 +453,7 @@ Java_com_google_android_filament_Texture_nGeneratePrefilterMipmap(JNIEnv *env, j
 // ANDROID SPECIFIC BITS
 ////////////////////////////////////////////////////////////////////////////////////////////////////
 
-#ifdef __ANDROID__
+#ifdef ANDROID
 
 #define BITMAP_CONFIG_ALPHA_8   0
 #define BITMAP_CONFIG_RGB_565   1
@@ -425,37 +462,46 @@ Java_com_google_android_filament_Texture_nGeneratePrefilterMipmap(JNIEnv *env, j
 #define BITMAP_CONFIG_RGBA_F16  4
 #define BITMAP_CONFIG_HARDWARE  5
 
-class AutoBitmap : public JniCallback {
-private:
-
+class AutoBitmap {
+public:
     AutoBitmap(JNIEnv* env, jobject bitmap) noexcept
-            : JniCallback(),
-              mBitmap(env->NewGlobalRef(bitmap)) {
+            : mEnv(env)
+            , mBitmap(env->NewGlobalRef(bitmap))
+    {
         if (mBitmap) {
-            AndroidBitmap_getInfo(env, mBitmap, &mInfo);
-            AndroidBitmap_lockPixels(env, mBitmap, &mData);
+            AndroidBitmap_getInfo(mEnv, mBitmap, &mInfo);
+            AndroidBitmap_lockPixels(mEnv, mBitmap, &mData);
         }
     }
 
     AutoBitmap(JNIEnv* env, jobject bitmap, jobject handler, jobject runnable) noexcept
-            : JniCallback(env, handler, runnable),
-              mBitmap(env->NewGlobalRef(bitmap)) {
+            : mEnv(env)
+            , mBitmap(env->NewGlobalRef(bitmap))
+            , mHandler(env->NewGlobalRef(handler))
+            , mCallback(env->NewGlobalRef(runnable))
+    {
+        acquireCallbackJni(env, mCallbackUtils);
         if (mBitmap) {
-            AndroidBitmap_getInfo(env, mBitmap, &mInfo);
-            AndroidBitmap_lockPixels(env, mBitmap, &mData);
+            AndroidBitmap_getInfo(mEnv, mBitmap, &mInfo);
+            AndroidBitmap_lockPixels(mEnv, mBitmap, &mData);
         }
     }
 
-    void release(JNIEnv* env) {
+    ~AutoBitmap() noexcept {
+        releaseCallbackJni(mEnv, mCallbackUtils, mHandler, mCallback);
         if (mBitmap) {
-            AndroidBitmap_unlockPixels(env, mBitmap);
-            env->DeleteGlobalRef(mBitmap);
+            AndroidBitmap_unlockPixels(mEnv, mBitmap);
+            mEnv->DeleteGlobalRef(mBitmap);
         }
     }
 
-    ~AutoBitmap() override = default;
+    AutoBitmap(AutoBitmap &&rhs) noexcept {
+        mEnv = rhs.mEnv;
+        std::swap(mData, rhs.mData);
+        std::swap(mBitmap, rhs.mBitmap);
+        std::swap(mInfo, rhs.mInfo);
+    }
 
-public:
     void* getData() const noexcept {
         return mData;
     }
@@ -482,39 +528,28 @@ public:
         }
     }
 
-    // create a AutoBitmap
-    static AutoBitmap* make(JNIEnv* env, jobject bitmap, jobject handler, jobject runnable) {
-        return new AutoBitmap(env, bitmap, handler, runnable);
+    static void invoke(void* buffer, size_t n, void* user) {
+        AutoBitmap* data = reinterpret_cast<AutoBitmap*>(user);
+        delete data;
     }
 
-    // execute the callback on the java thread and destroy ourselves
-    static void invoke(void*, size_t, void* user) {
-        auto* autoBitmap = reinterpret_cast<AutoBitmap*>(user);
-        JNIEnv* env = filament::VirtualMachineEnv::get().getEnvironment();
-        releaseCallbackJni(env, autoBitmap->mCallbackUtils, autoBitmap->mHandler, autoBitmap->mCallback);
-        autoBitmap->release(env);
-        delete autoBitmap;
-    }
-
-    // create a AutoBitmap without a handler
-    static AutoBitmap* make(JNIEnv* env, jobject bitmap) {
+    static AutoBitmap* make(Engine* engine, JNIEnv* env, jobject bitmap) {
         return new AutoBitmap(env, bitmap);
     }
 
-    // just destroy ourselves
-    static void invokeNoCallback(void*, size_t, void* user) {
-        auto* autoBitmap = reinterpret_cast<AutoBitmap*>(user);
-        JNIEnv* env = filament::VirtualMachineEnv::get().getEnvironment();
-        autoBitmap->release(env);
-        delete autoBitmap;
+    static AutoBitmap* make(Engine* engine, JNIEnv* env, jobject bitmap,
+            jobject handler, jobject runnable) {
+        return new AutoBitmap(env, bitmap, handler, runnable);
     }
 
 private:
+    JNIEnv* mEnv;
     void* mData = nullptr;
     jobject mBitmap = nullptr;
     jobject mHandler = nullptr;
     jobject mCallback = nullptr;
-    AndroidBitmapInfo mInfo{};
+    AndroidBitmapInfo mInfo;
+    CallbackJni mCallbackUtils;
 };
 
 extern "C"
@@ -525,14 +560,14 @@ Java_com_google_android_filament_android_TextureHelper_nSetBitmap(JNIEnv* env, j
     Texture* texture = (Texture*) nativeTexture;
     Engine *engine = (Engine *) nativeEngine;
 
-    auto* autoBitmap = AutoBitmap::make(env, bitmap);
+    auto* autoBitmap = AutoBitmap::make(engine, env, bitmap);
 
     Texture::PixelBufferDescriptor desc(
             autoBitmap->getData(),
             autoBitmap->getSizeInBytes(),
             autoBitmap->getFormat(format),
             autoBitmap->getType(format),
-            &AutoBitmap::invokeNoCallback, autoBitmap);
+            &AutoBitmap::invoke, autoBitmap);
 
     texture->setImage(*engine, (size_t) level,
             (uint32_t) xoffset, (uint32_t) yoffset,
@@ -548,14 +583,14 @@ Java_com_google_android_filament_android_TextureHelper_nSetBitmapWithCallback(JN
     Texture* texture = (Texture*) nativeTexture;
     Engine *engine = (Engine *) nativeEngine;
 
-    auto* autoBitmap = AutoBitmap::make(env, bitmap, handler, runnable);
+    auto* autoBitmap = AutoBitmap::make(engine, env, bitmap, handler, runnable);
 
     Texture::PixelBufferDescriptor desc(
             autoBitmap->getData(),
             autoBitmap->getSizeInBytes(),
             autoBitmap->getFormat(format),
             autoBitmap->getType(format),
-            autoBitmap->getHandler(), &AutoBitmap::invoke, autoBitmap);
+            &AutoBitmap::invoke, autoBitmap);
 
     texture->setImage(*engine, (size_t) level,
             (uint32_t) xoffset, (uint32_t) yoffset,

android/filament-android/src/main/cpp/ToneMapper.cpp

@@ -1,98 +0,0 @@
-/*
- * Copyright (C) 2021 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#include <jni.h>
-
-#include <filament/ToneMapper.h>
-
-using namespace filament;
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_ToneMapper_nDestroyToneMapper(JNIEnv *env, jclass clazz,
-        jlong toneMapper_) {
-    ToneMapper* toneMapper = (ToneMapper*) toneMapper_;
-    delete toneMapper;
-}
-
-extern "C" JNIEXPORT jlong JNICALL
-Java_com_google_android_filament_ToneMapper_nCreateLinearToneMapper(JNIEnv*, jclass) {
-    return (jlong) new LinearToneMapper();
-}
-
-extern "C" JNIEXPORT jlong JNICALL
-Java_com_google_android_filament_ToneMapper_nCreateACESToneMapper(JNIEnv*, jclass) {
-    return (jlong) new ACESToneMapper();
-}
-
-extern "C" JNIEXPORT jlong JNICALL
-Java_com_google_android_filament_ToneMapper_nCreateACESLegacyToneMapper(JNIEnv*, jclass) {
-    return (jlong) new ACESLegacyToneMapper();
-}
-
-extern "C" JNIEXPORT jlong JNICALL
-Java_com_google_android_filament_ToneMapper_nCreateFilmicToneMapper(JNIEnv*, jclass) {
-    return (jlong) new FilmicToneMapper();
-}
-
-extern "C" JNIEXPORT jlong JNICALL
-Java_com_google_android_filament_ToneMapper_nCreateGenericToneMapper(JNIEnv*, jclass,
-        jfloat contrast, jfloat midGrayIn, jfloat midGrayOut, jfloat hdrMax) {
-    return (jlong) new GenericToneMapper(contrast, midGrayIn, midGrayOut, hdrMax);
-}
-
-extern "C" JNIEXPORT jfloat JNICALL
-Java_com_google_android_filament_ToneMapper_nGenericGetContrast(JNIEnv*, jclass, jlong nativeObject) {
-    return ((GenericToneMapper*) nativeObject)->getContrast();
-}
-
-extern "C" JNIEXPORT jfloat JNICALL
-Java_com_google_android_filament_ToneMapper_nGenericGetMidGrayIn(JNIEnv*, jclass, jlong nativeObject) {
-    return ((GenericToneMapper*) nativeObject)->getMidGrayIn();
-}
-
-extern "C" JNIEXPORT jfloat JNICALL
-Java_com_google_android_filament_ToneMapper_nGenericGetMidGrayOut(JNIEnv*, jclass, jlong nativeObject) {
-    return ((GenericToneMapper*) nativeObject)->getMidGrayOut();
-}
-
-extern "C" JNIEXPORT jfloat JNICALL
-Java_com_google_android_filament_ToneMapper_nGenericGetHdrMax(JNIEnv*, jclass, jlong nativeObject) {
-    return ((GenericToneMapper*) nativeObject)->getHdrMax();
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_ToneMapper_nGenericSetContrast(JNIEnv*, jclass,
-        jlong nativeObject, jfloat contrast) {
-    ((GenericToneMapper*) nativeObject)->setContrast(contrast);
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_ToneMapper_nGenericSetMidGrayIn(JNIEnv*, jclass,
-        jlong nativeObject, jfloat midGrayIn) {
-    ((GenericToneMapper*) nativeObject)->setMidGrayIn(midGrayIn);
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_ToneMapper_nGenericSetMidGrayOut(JNIEnv*, jclass,
-        jlong nativeObject, jfloat midGrayOut) {
-    ((GenericToneMapper*) nativeObject)->setMidGrayOut(midGrayOut);
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_ToneMapper_nGenericSetHdrMax(JNIEnv*, jclass,
-        jlong nativeObject, jfloat hdrMax) {
-    ((GenericToneMapper*) nativeObject)->setHdrMax(hdrMax);
-}

android/filament-android/src/main/cpp/TransformManager.cpp

@@ -70,23 +70,6 @@ Java_com_google_android_filament_TransformManager_nCreateArray(JNIEnv* env,
     return tm->getInstance(entity);
 }
 
-extern "C" JNIEXPORT jint JNICALL
-Java_com_google_android_filament_TransformManager_nCreateArrayFp64(JNIEnv* env,
-        jclass, jlong nativeTransformManager, jint entity_, jint parent,
-        jdoubleArray localTransform_) {
-    TransformManager* tm = (TransformManager*) nativeTransformManager;
-    Entity& entity = *reinterpret_cast<Entity*>(&entity_);
-    if (localTransform_) {
-        jdouble *localTransform = env->GetDoubleArrayElements(localTransform_, NULL);
-        tm->create(entity, (TransformManager::Instance) parent,
-                *reinterpret_cast<const filament::math::mat4 *>(localTransform));
-        env->ReleaseDoubleArrayElements(localTransform_, localTransform, JNI_ABORT);
-    } else {
-        tm->create(entity, (TransformManager::Instance) parent);
-    }
-    return tm->getInstance(entity);
-}
-
 extern "C" JNIEXPORT void JNICALL
 Java_com_google_android_filament_TransformManager_nDestroy(JNIEnv*, jclass,
         jlong nativeTransformManager, jint entity_) {
@@ -103,33 +86,6 @@ Java_com_google_android_filament_TransformManager_nSetParent(JNIEnv*, jclass,
             (TransformManager::Instance) newParent);
 }
 
-extern "C" JNIEXPORT jint JNICALL
-Java_com_google_android_filament_TransformManager_nGetParent(JNIEnv*, jclass,
-        jlong nativeTransformManager, jint i) {
-    TransformManager* tm = (TransformManager*) nativeTransformManager;
-    return tm->getParent((TransformManager::Instance) i).getId();
-}
-
-extern "C" JNIEXPORT jint JNICALL
-Java_com_google_android_filament_TransformManager_nGetChildCount(JNIEnv*, jclass,
-        jlong nativeTransformManager, jint i) {
-    TransformManager* tm = (TransformManager*) nativeTransformManager;
-    return tm->getChildCount((TransformManager::Instance) i);
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_TransformManager_nGetChildren(JNIEnv* env,
-        jclass, jlong nativeTransformManager, jint i,
-        jintArray outEntities_, jint count) {
-    TransformManager* tm = (TransformManager*) nativeTransformManager;
-    jint* entities = env->GetIntArrayElements(outEntities_, nullptr);
-    // This is very very gross, we just pretend Entity is just like an jint
-    // (which it is), but still.
-    tm->getChildren((TransformManager::Instance) i,
-            reinterpret_cast<Entity *>(entities), (size_t) count);
-    env->ReleaseIntArrayElements(outEntities_, entities, 0);
-}
-
 extern "C" JNIEXPORT void JNICALL
 Java_com_google_android_filament_TransformManager_nSetTransform(JNIEnv* env,
         jclass, jlong nativeTransformManager, jint i,
@@ -141,17 +97,6 @@ Java_com_google_android_filament_TransformManager_nSetTransform(JNIEnv* env,
     env->ReleaseFloatArrayElements(localTransform_, localTransform, JNI_ABORT);
 }
 
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_TransformManager_nSetTransformFp64(JNIEnv* env,
-        jclass, jlong nativeTransformManager, jint i,
-        jdoubleArray localTransform_) {
-    TransformManager* tm = (TransformManager*) nativeTransformManager;
-    jdouble *localTransform = env->GetDoubleArrayElements(localTransform_, NULL);
-    tm->setTransform((TransformManager::Instance) i,
-            *reinterpret_cast<const filament::math::mat4 *>(localTransform));
-    env->ReleaseDoubleArrayElements(localTransform_, localTransform, JNI_ABORT);
-}
-
 extern "C" JNIEXPORT void JNICALL
 Java_com_google_android_filament_TransformManager_nGetTransform(JNIEnv* env,
         jclass, jlong nativeTransformManager, jint i,
@@ -163,17 +108,6 @@ Java_com_google_android_filament_TransformManager_nGetTransform(JNIEnv* env,
     env->ReleaseFloatArrayElements(outLocalTransform_, outLocalTransform, 0);
 }
 
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_TransformManager_nGetTransformFp64(JNIEnv* env,
-        jclass, jlong nativeTransformManager, jint i,
-        jdoubleArray outLocalTransform_) {
-    TransformManager* tm = (TransformManager*) nativeTransformManager;
-    jdouble *outLocalTransform = env->GetDoubleArrayElements(outLocalTransform_, NULL);
-    *reinterpret_cast<filament::math::mat4 *>(outLocalTransform) = tm->getTransformAccurate(
-            (TransformManager::Instance) i);
-    env->ReleaseDoubleArrayElements(outLocalTransform_, outLocalTransform, 0);
-}
-
 extern "C" JNIEXPORT void JNICALL
 Java_com_google_android_filament_TransformManager_nGetWorldTransform(JNIEnv* env,
         jclass, jlong nativeTransformManager, jint i,
@@ -185,17 +119,6 @@ Java_com_google_android_filament_TransformManager_nGetWorldTransform(JNIEnv* env
     env->ReleaseFloatArrayElements(outWorldTransform_, outWorldTransform, 0);
 }
 
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_TransformManager_nGetWorldTransformFp64(JNIEnv* env,
-        jclass, jlong nativeTransformManager, jint i,
-        jdoubleArray outWorldTransform_) {
-    TransformManager* tm = (TransformManager*) nativeTransformManager;
-    jdouble *outWorldTransform = env->GetDoubleArrayElements(outWorldTransform_, NULL);
-    *reinterpret_cast<filament::math::mat4 *>(outWorldTransform) = tm->getWorldTransformAccurate(
-            (TransformManager::Instance) i);
-    env->ReleaseDoubleArrayElements(outWorldTransform_, outWorldTransform, 0);
-}
-
 extern "C" JNIEXPORT void JNICALL
 Java_com_google_android_filament_TransformManager_nOpenLocalTransformTransaction(
         JNIEnv*, jclass, jlong nativeTransformManager) {
@@ -209,19 +132,3 @@ Java_com_google_android_filament_TransformManager_nCommitLocalTransformTransacti
     TransformManager* tm = (TransformManager*) nativeTransformManager;
     tm->commitLocalTransformTransaction();
 }
-
-extern "C"
-JNIEXPORT void JNICALL
-Java_com_google_android_filament_TransformManager_nSetAccurateTranslationsEnabled(JNIEnv*,
-        jclass, jlong nativeTransformManager, jboolean enable) {
-    TransformManager* tm = (TransformManager*) nativeTransformManager;
-    tm->setAccurateTranslationsEnabled((bool)enable);
-}
-
-extern "C"
-JNIEXPORT jboolean JNICALL
-Java_com_google_android_filament_TransformManager_nIsAccurateTranslationsEnabled(JNIEnv*,
-        jclass, jlong nativeTransformManager) {
-    TransformManager* tm = (TransformManager*) nativeTransformManager;
-    return (jboolean)tm->isAccurateTranslationsEnabled();
-}

android/filament-android/src/main/cpp/VertexBuffer.cpp

@@ -32,40 +32,33 @@ using namespace filament::math;
 using namespace backend;
 
 extern "C" JNIEXPORT jlong JNICALL
-Java_com_google_android_filament_VertexBuffer_nCreateBuilder(JNIEnv*, jclass) {
+Java_com_google_android_filament_VertexBuffer_nCreateBuilder(JNIEnv *env, jclass type) {
     return (jlong) new VertexBuffer::Builder();
 }
 
 extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_VertexBuffer_nDestroyBuilder(JNIEnv*, jclass,
+Java_com_google_android_filament_VertexBuffer_nDestroyBuilder(JNIEnv *env, jclass type,
         jlong nativeBuilder) {
     VertexBuffer::Builder* builder = (VertexBuffer::Builder *) nativeBuilder;
     delete builder;
 }
 
 extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_VertexBuffer_nBuilderVertexCount(JNIEnv*, jclass,
+Java_com_google_android_filament_VertexBuffer_nBuilderVertexCount(JNIEnv *env, jclass type,
         jlong nativeBuilder, jint vertexCount) {
     VertexBuffer::Builder* builder = (VertexBuffer::Builder *) nativeBuilder;
     builder->vertexCount((uint32_t) vertexCount);
 }
 
 extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_VertexBuffer_nBuilderEnableBufferObjects(JNIEnv*, jclass,
-        jlong nativeBuilder, jboolean enabled) {
-    VertexBuffer::Builder* builder = (VertexBuffer::Builder *) nativeBuilder;
-    builder->enableBufferObjects(enabled);
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_VertexBuffer_nBuilderBufferCount(JNIEnv*, jclass,
+Java_com_google_android_filament_VertexBuffer_nBuilderBufferCount(JNIEnv *env, jclass type,
         jlong nativeBuilder, jint bufferCount) {
     VertexBuffer::Builder* builder = (VertexBuffer::Builder *) nativeBuilder;
     builder->bufferCount((uint8_t) bufferCount);
 }
 
 extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_VertexBuffer_nBuilderAttribute(JNIEnv*, jclass,
+Java_com_google_android_filament_VertexBuffer_nBuilderAttribute(JNIEnv *env, jclass type,
         jlong nativeBuilder, jint attribute, jint bufferIndex, jint attributeType, jint byteOffset,
         jint byteStride) {
     VertexBuffer::Builder* builder = (VertexBuffer::Builder *) nativeBuilder;
@@ -75,14 +68,14 @@ Java_com_google_android_filament_VertexBuffer_nBuilderAttribute(JNIEnv*, jclass,
 }
 
 extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_VertexBuffer_nBuilderNormalized(JNIEnv*, jclass,
+Java_com_google_android_filament_VertexBuffer_nBuilderNormalized(JNIEnv *env, jclass type,
         jlong nativeBuilder, jint attribute, jboolean normalized) {
     VertexBuffer::Builder* builder = (VertexBuffer::Builder *) nativeBuilder;
     builder->normalized((VertexAttribute) attribute, normalized);
 }
 
 extern "C" JNIEXPORT jlong JNICALL
-Java_com_google_android_filament_VertexBuffer_nBuilderBuild(JNIEnv*, jclass,
+Java_com_google_android_filament_VertexBuffer_nBuilderBuild(JNIEnv *env, jclass type,
         jlong nativeBuilder, jlong nativeEngine) {
     VertexBuffer::Builder* builder = (VertexBuffer::Builder *) nativeBuilder;
     Engine *engine = (Engine *) nativeEngine;
@@ -90,14 +83,14 @@ Java_com_google_android_filament_VertexBuffer_nBuilderBuild(JNIEnv*, jclass,
 }
 
 extern "C" JNIEXPORT jint JNICALL
-Java_com_google_android_filament_VertexBuffer_nGetVertexCount(JNIEnv*, jclass,
+Java_com_google_android_filament_VertexBuffer_nGetVertexCount(JNIEnv *env, jclass type,
         jlong nativeVertexBuffer) {
     VertexBuffer *vertexBuffer = (VertexBuffer *) nativeVertexBuffer;
     return (jint) vertexBuffer->getVertexCount();
 }
 
 extern "C" JNIEXPORT jint JNICALL
-Java_com_google_android_filament_VertexBuffer_nSetBufferAt(JNIEnv *env, jclass,
+Java_com_google_android_filament_VertexBuffer_nSetBufferAt(JNIEnv *env, jclass type,
         jlong nativeVertexBuffer, jlong nativeEngine, jint bufferIndex,
         jobject buffer, jint remaining,
         jint destOffsetInBytes, jint count, jobject handler, jobject runnable) {
@@ -114,8 +107,7 @@ Java_com_google_android_filament_VertexBuffer_nSetBufferAt(JNIEnv *env, jclass,
 
     auto* callback = JniBufferCallback::make(engine, env, handler, runnable, std::move(nioBuffer));
 
-    BufferDescriptor desc(data, sizeInBytes,
-            callback->getHandler(), &JniBufferCallback::postToJavaAndDestroy, callback);
+    BufferDescriptor desc(data, sizeInBytes, &JniBufferCallback::invoke, callback);
 
     vertexBuffer->setBufferAt(*engine, (uint8_t) bufferIndex, std::move(desc),
             (uint32_t) destOffsetInBytes);
@@ -123,11 +115,42 @@ Java_com_google_android_filament_VertexBuffer_nSetBufferAt(JNIEnv *env, jclass,
     return 0;
 }
 
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_VertexBuffer_nSetBufferObjectAt(JNIEnv*, jclass,
-        jlong nativeVertexBuffer, jlong nativeEngine, jint bufferIndex, jlong nativeBufferObject) {
-    VertexBuffer *vertexBuffer = (VertexBuffer *) nativeVertexBuffer;
-    Engine *engine = (Engine *) nativeEngine;
-    BufferObject *bufferObject = (BufferObject *) nativeBufferObject;
-    vertexBuffer->setBufferObjectAt(*engine, (uint8_t) bufferIndex, bufferObject);
+extern "C" [[deprecated]] JNIEXPORT void JNICALL
+Java_com_google_android_filament_VertexBuffer_nPopulateTangentQuaternions(JNIEnv *env,
+        jclass type, jint quatType, jint quatCount, jobject outBuffer, jint outRemaining,
+        jint outStride, jobject normals, jint normalsRemaining, jint normalsStride,
+        jobject tangents, jint tangentsRemaining, jint tangentsStride) {
+
+    AutoBuffer outNioBuffer(env, outBuffer, outRemaining, true);
+    void* outData = outNioBuffer.getData();
+
+    AutoBuffer normalsNioBuffer(env, normals, normalsRemaining);
+    auto normalsData = (const float3*) normalsNioBuffer.getData();
+
+    if (tangents) {
+        AutoBuffer tangentsNioBuffer(env, tangents, tangentsRemaining);
+        auto tangentsData = (const float4*) tangentsNioBuffer.getData();
+        VertexBuffer::populateTangentQuaternions({
+            .quatType = (VertexBuffer::QuatType) quatType,
+            .quatCount = (size_t) quatCount,
+            .outBuffer = outData,
+            .outStride = (size_t) outStride,
+            .normals = normalsData,
+            .normalsStride = (size_t) normalsStride,
+            .tangents = tangentsData,
+            .tangentsStride = (size_t) tangentsStride
+        });
+        return;
+    }
+
+    VertexBuffer::populateTangentQuaternions({
+        .quatType = (VertexBuffer::QuatType) quatType,
+        .quatCount = (size_t) quatCount,
+        .outBuffer = outData,
+        .outStride = (size_t) outStride,
+        .normals = normalsData,
+        .normalsStride = (size_t) normalsStride,
+        .tangents = nullptr,
+        .tangentsStride = 0
+    });
 }

android/filament-android/src/main/cpp/View.cpp

@@ -20,10 +20,6 @@
 #include <filament/View.h>
 #include <filament/Viewport.h>
 
-#include "common/CallbackUtils.h"
-
-#include "private/backend/VirtualMachineEnv.h"
-
 using namespace filament;
 
 extern "C" JNIEXPORT void JNICALL
@@ -86,19 +82,13 @@ Java_com_google_android_filament_View_nSetRenderTarget(JNIEnv*, jclass,
 extern "C" JNIEXPORT void JNICALL
 Java_com_google_android_filament_View_nSetSampleCount(JNIEnv*, jclass, jlong nativeView, jint count) {
     View* view = (View*) nativeView;
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wdeprecated-declarations"
     view->setSampleCount((uint8_t) count);
-#pragma clang diagnostic pop
 }
 
 extern "C" JNIEXPORT jint JNICALL
 Java_com_google_android_filament_View_nGetSampleCount(JNIEnv*, jclass, jlong nativeView) {
     View* view = (View*) nativeView;
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wdeprecated-declarations"
     return view->getSampleCount();
-#pragma clang diagnostic pop
 }
 
 extern "C" JNIEXPORT void JNICALL
@@ -129,48 +119,17 @@ Java_com_google_android_filament_View_nGetDithering(JNIEnv*, jclass,
 extern "C" JNIEXPORT void JNICALL
 Java_com_google_android_filament_View_nSetDynamicResolutionOptions(JNIEnv*, jclass, jlong nativeView,
         jboolean enabled, jboolean homogeneousScaling,
-        jfloat minScale, jfloat maxScale, jfloat sharpness, jint quality) {
+        jfloat minScale, jfloat maxScale, jint quality) {
     View* view = (View*)nativeView;
     View::DynamicResolutionOptions options;
     options.enabled = enabled;
     options.homogeneousScaling = homogeneousScaling;
     options.minScale = filament::math::float2{ minScale };
     options.maxScale = filament::math::float2{ maxScale };
-    options.sharpness = sharpness;
     options.quality = (View::QualityLevel)quality;
     view->setDynamicResolutionOptions(options);
 }
 
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_View_nSetShadowType(JNIEnv*, jclass, jlong nativeView, jint type) {
-    View* view = (View*) nativeView;
-    view->setShadowType((View::ShadowType) type);
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_View_nSetVsmShadowOptions(JNIEnv*, jclass, jlong nativeView,
-        jint anisotropy, jboolean mipmapping, jboolean highPrecision, jfloat minVarianceScale,
-        jfloat lightBleedReduction) {
-    View* view = (View*) nativeView;
-    View::VsmShadowOptions options;
-    options.anisotropy = (uint8_t)anisotropy;
-    options.mipmapping = (bool)mipmapping;
-    options.highPrecision = (bool)highPrecision;
-    options.minVarianceScale = minVarianceScale;
-    options.lightBleedReduction = lightBleedReduction;
-    view->setVsmShadowOptions(options);
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_View_nSetSoftShadowOptions(JNIEnv*, jclass, jlong nativeView,
-        jfloat penumbraScale, jfloat penumbraRatioScale) {
-    View* view = (View*) nativeView;
-    View::SoftShadowOptions options;
-    options.penumbraScale = penumbraScale;
-    options.penumbraRatioScale = penumbraRatioScale;
-    view->setSoftShadowOptions(options);
-}
-
 extern "C"
 JNIEXPORT void JNICALL
 Java_com_google_android_filament_View_nSetRenderQuality(JNIEnv*, jclass,
@@ -237,45 +196,19 @@ Java_com_google_android_filament_View_nGetAmbientOcclusion(JNIEnv*, jclass, jlon
 extern "C" JNIEXPORT void JNICALL
 Java_com_google_android_filament_View_nSetAmbientOcclusionOptions(JNIEnv*, jclass,
     jlong nativeView, jfloat radius, jfloat bias, jfloat power, jfloat resolution, jfloat intensity,
-    jfloat bilateralThreshold,
-    jint quality, jint lowPassFilter, jint upsampling, jboolean enabled, jboolean bentNormals,
-    jfloat minHorizonAngleRad) {
+    jint quality, jint upsampling, jboolean enabled, jfloat minHorizonAngleRad) {
     View* view = (View*) nativeView;
-    View::AmbientOcclusionOptions options = view->getAmbientOcclusionOptions();
-    options.radius = radius;
-    options.power = power;
-    options.bias = bias;
-    options.resolution = resolution;
-    options.intensity = intensity;
-    options.bilateralThreshold = bilateralThreshold;
-    options.quality = (View::QualityLevel)quality;
-    options.lowPassFilter = (View::QualityLevel)lowPassFilter;
-    options.upsampling = (View::QualityLevel)upsampling;
-    options.enabled = (bool)enabled;
-    options.bentNormals = (bool)bentNormals;
-    options.minHorizonAngleRad = minHorizonAngleRad;
-    view->setAmbientOcclusionOptions(options);
-}
-
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_View_nSetSSCTOptions(JNIEnv *, jclass, jlong nativeView,
-        jfloat ssctLightConeRad, jfloat ssctShadowDistance, jfloat ssctContactDistanceMax,
-        jfloat ssctIntensity, jfloat ssctLightDirX, jfloat ssctLightDirY, jfloat ssctLightDirZ,
-        jfloat ssctDepthBias, jfloat ssctDepthSlopeBias, jint ssctSampleCount,
-        jint ssctRayCount, jboolean ssctEnabled) {
-    View* view = (View*) nativeView;
-    View::AmbientOcclusionOptions options = view->getAmbientOcclusionOptions();
-    options.ssct.lightConeRad = ssctLightConeRad;
-    options.ssct.shadowDistance = ssctShadowDistance;
-    options.ssct.contactDistanceMax = ssctContactDistanceMax;
-    options.ssct.intensity = ssctIntensity;
-    options.ssct.lightDirection = math::float3{ ssctLightDirX, ssctLightDirY, ssctLightDirZ };
-    options.ssct.depthBias = ssctDepthBias;
-    options.ssct.depthSlopeBias = ssctDepthSlopeBias;
-    options.ssct.sampleCount = (uint8_t)ssctSampleCount;
-    options.ssct.rayCount = (uint8_t)ssctRayCount;
-    options.ssct.enabled = (bool)ssctEnabled;
+    View::AmbientOcclusionOptions options = {
+            .radius = radius,
+            .power = power,
+            .bias = bias,
+            .resolution = resolution,
+            .intensity = intensity,
+            .quality = (View::QualityLevel)quality,
+            .upsampling = (View::QualityLevel)upsampling,
+            .enabled = (bool)enabled,
+            .minHorizonAngleRad = minHorizonAngleRad
+    };
     view->setAmbientOcclusionOptions(options);
 }
 
@@ -283,10 +216,7 @@ extern "C" JNIEXPORT void JNICALL
 Java_com_google_android_filament_View_nSetBloomOptions(JNIEnv*, jclass,
         jlong nativeView, jlong nativeTexture,
         jfloat dirtStrength, jfloat strength, jint resolution, jfloat anamorphism, jint levels,
-        jint blendMode, jboolean threshold, jboolean enabled, jfloat highlight,
-        jboolean lensFlare, jboolean starburst, jfloat chromaticAberration, jint ghostCount,
-        jfloat ghostSpacing, jfloat ghostThreshold, jfloat haloThickness, jfloat haloRadius,
-        jfloat haloThreshold) {
+        jint blendMode, jboolean threshold, jboolean enabled, jfloat highlight) {
     View* view = (View*) nativeView;
     Texture* dirt = (Texture*) nativeTexture;
     View::BloomOptions options = {
@@ -299,16 +229,7 @@ Java_com_google_android_filament_View_nSetBloomOptions(JNIEnv*, jclass,
             .blendMode = (View::BloomOptions::BlendMode)blendMode,
             .threshold = (bool)threshold,
             .enabled = (bool)enabled,
-            .highlight = highlight,
-            .lensFlare = (bool)lensFlare,
-            .starburst = (bool)starburst,
-            .chromaticAberration = chromaticAberration,
-            .ghostCount = (uint8_t)ghostCount,
-            .ghostSpacing = ghostSpacing,
-            .ghostThreshold = ghostThreshold,
-            .haloThickness = haloThickness,
-            .haloRadius = haloRadius,
-            .haloThreshold = haloThreshold
+            .highlight = highlight
     };
     view->setBloomOptions(options);
 }
@@ -341,25 +262,11 @@ Java_com_google_android_filament_View_nSetBlendMode(JNIEnv *, jclass , jlong nat
 }
 
 extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_View_nSetDepthOfFieldOptions(JNIEnv *, jclass,
-        jlong nativeView, jfloat cocScale, jfloat maxApertureDiameter, jboolean enabled, jint filter,
-        jboolean nativeResolution, jint foregroundRingCount, jint backgroundRingCount, jint fastGatherRingCount,
-        jint maxForegroundCOC, jint maxBackgroundCOC) {
+Java_com_google_android_filament_View_nSetDepthOfFieldOptions(JNIEnv *, jclass ,
+        jlong nativeView, jfloat focusDistance, jfloat cocScale, jfloat maxApertureDiameter, jboolean enabled) {
     View* view = (View*) nativeView;
-    View::DepthOfFieldOptions::Filter eFilter{};
-    if (filter == 1) {
-        // View::DepthOfFieldOptions::Filter::MEDIAN value is actually 2
-        eFilter = View::DepthOfFieldOptions::Filter::MEDIAN;
-    }
-    view->setDepthOfFieldOptions({.cocScale = cocScale,
-            .maxApertureDiameter = maxApertureDiameter, .enabled = (bool)enabled, .filter = eFilter,
-            .nativeResolution = (bool)nativeResolution,
-            .foregroundRingCount = (uint8_t)foregroundRingCount,
-            .backgroundRingCount = (uint8_t)backgroundRingCount,
-            .fastGatherRingCount = (uint8_t)fastGatherRingCount,
-            .maxForegroundCOC = (uint8_t)maxForegroundCOC,
-            .maxBackgroundCOC = (uint8_t)maxBackgroundCOC,
-    });
+    view->setDepthOfFieldOptions({.focusDistance = focusDistance, .cocScale = cocScale,
+            .maxApertureDiameter = maxApertureDiameter, .enabled = (bool)enabled});
 }
 
 extern "C"
@@ -371,17 +278,6 @@ Java_com_google_android_filament_View_nSetVignetteOptions(JNIEnv*, jclass, jlong
             .color = LinearColorA{r, g, b, a}, .enabled = (bool)enabled});
 }
 
-extern "C"
-JNIEXPORT void JNICALL
-Java_com_google_android_filament_View_nSetMultiSampleAntiAliasingOptions(JNIEnv* env, jclass clazz,
-        jlong nativeView, jboolean enabled, jint sampleCount, jboolean customResolve) {
-    View* view = (View*) nativeView;
-    view->setMultiSampleAntiAliasingOptions({
-            .enabled = (bool)enabled,
-            .sampleCount = (uint8_t)sampleCount,
-            .customResolve = (bool)customResolve});
-}
-
 extern "C"
 JNIEXPORT void JNICALL
 Java_com_google_android_filament_View_nSetTemporalAntiAliasingOptions(JNIEnv *, jclass,
@@ -391,16 +287,6 @@ Java_com_google_android_filament_View_nSetTemporalAntiAliasingOptions(JNIEnv *,
             .filterWidth = filterWidth, .feedback = feedback, .enabled = (bool) enabled});
 }
 
-extern "C"
-JNIEXPORT void JNICALL
-Java_com_google_android_filament_View_nSetScreenSpaceReflectionsOptions(JNIEnv*, jclass,
-        jlong nativeView, jfloat thickness, jfloat bias, jfloat maxDistance, jfloat stride, jboolean enabled) {
-    View* view = (View*) nativeView;
-    view->setScreenSpaceReflectionsOptions({.thickness = thickness, .bias = bias,
-            .maxDistance = maxDistance, .stride = stride, .enabled = (bool) enabled
-    });
-}
-
 extern "C"
 JNIEXPORT jboolean JNICALL
 Java_com_google_android_filament_View_nIsShadowingEnabled(JNIEnv *, jclass, jlong nativeView) {
@@ -423,65 +309,3 @@ Java_com_google_android_filament_View_nIsScreenSpaceRefractionEnabled(JNIEnv *,
     View* view = (View*) nativeView;
     return (jboolean)view->isScreenSpaceRefractionEnabled();
 }
-
-extern "C"
-JNIEXPORT void JNICALL
-Java_com_google_android_filament_View_nPick(JNIEnv* env, jclass,
-        jlong nativeView,
-        jint x, jint y, jobject handler, jobject internalCallback) {
-
-    // jniState will be initialized the first time this method is called
-    static const struct JniState {
-        jclass internalOnPickCallbackClass;
-        jfieldID renderableFieldId;
-        jfieldID depthFieldId;
-        jfieldID fragCoordXFieldId;
-        jfieldID fragCoordYFieldId;
-        jfieldID fragCoordZFieldId;
-        explicit JniState(JNIEnv* env) noexcept {
-            internalOnPickCallbackClass = env->FindClass("com/google/android/filament/View$InternalOnPickCallback");
-            renderableFieldId = env->GetFieldID(internalOnPickCallbackClass, "mRenderable", "I");
-            depthFieldId = env->GetFieldID(internalOnPickCallbackClass, "mDepth", "F");
-            fragCoordXFieldId = env->GetFieldID(internalOnPickCallbackClass, "mFragCoordsX", "F");
-            fragCoordYFieldId = env->GetFieldID(internalOnPickCallbackClass, "mFragCoordsY", "F");
-            fragCoordZFieldId = env->GetFieldID(internalOnPickCallbackClass, "mFragCoordsZ", "F");
-        }
-    } jniState(env);
-
-    View* view = (View*) nativeView;
-    JniCallback *callback = JniCallback::make(env, handler, internalCallback);
-    view->pick(x, y, [callback](View::PickingQueryResult const& result) {
-        // this is executed on the backend/service thread
-        jobject obj = callback->getCallbackObject();
-        JNIEnv* env = filament::VirtualMachineEnv::get().getEnvironment();
-        env->SetIntField(obj, jniState.renderableFieldId, (jint)result.renderable.getId());
-        env->SetFloatField(obj, jniState.depthFieldId, result.depth);
-        env->SetFloatField(obj, jniState.fragCoordXFieldId, result.fragCoords.x);
-        env->SetFloatField(obj, jniState.fragCoordYFieldId, result.fragCoords.y);
-        env->SetFloatField(obj, jniState.fragCoordZFieldId, result.fragCoords.z);
-        JniCallback::postToJavaAndDestroy(callback);
-    }, callback->getHandler());
-}
-
-extern "C"
-JNIEXPORT void JNICALL
-Java_com_google_android_filament_View_nSetStencilBufferEnabled(JNIEnv *, jclass, jlong nativeView,
-        jboolean enabled) {
-    View* view = (View*) nativeView;
-    view->setStencilBufferEnabled(enabled);
-}
-
-extern "C"
-JNIEXPORT jboolean JNICALL
-Java_com_google_android_filament_View_nIsStencilBufferEnabled(JNIEnv *, jclass, jlong nativeView) {
-    View* view = (View*) nativeView;
-    return view->isStencilBufferEnabled();
-}
-
-extern "C"
-JNIEXPORT void JNICALL
-Java_com_google_android_filament_View_nSetGuardBandOptions(JNIEnv *, jclass,
-        jlong nativeView, jboolean enabled) {
-    View* view = (View*) nativeView;
-    view->setGuardBandOptions({ .enabled = (bool)enabled });
-}

android/filament-android/src/main/cpp/nativewindow/Darwin.mm

@@ -0,0 +1,71 @@
+/*
+ * Copyright (C) 2018 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include <stdio.h>
+
+#include <jawt.h>
+
+#if defined(__has_include)
+#if __has_include(<darwin/jawt_md.h>)
+#include <darwin/jawt_md.h>
+#else
+#include <jawt_md.h>
+#endif
+#else
+#include <darwin/jawt_md.h>
+#endif
+
+#include <filament/Engine.h>
+#include "JAWTUtils.h"
+
+#import <Cocoa/Cocoa.h>
+
+#pragma clang diagnostic push
+#pragma ide diagnostic ignored "NotReleasedValue"
+extern "C" {
+void *getNativeWindow(JNIEnv *env, jclass klass, jobject surface) {
+    void *win = nullptr;
+    JAWT_DrawingSurface *ds = nullptr;
+    JAWT_DrawingSurfaceInfo *dsi = nullptr;
+
+    if (!acquireDrawingSurface(env, surface, &ds, &dsi)) {
+        return win;
+    }
+    NSObject<JAWT_SurfaceLayers>* jawldsip = (NSObject<JAWT_SurfaceLayers>*)dsi->platformInfo;
+    // Use jawt_DrawingSurfaceInfo.bounds for frame dimension.
+    NSView *view = [[NSView alloc] initWithFrame:
+            NSMakeRect(dsi->bounds.x, dsi->bounds.y, dsi->bounds.width, dsi->bounds.height)];
+    view.wantsLayer = true;
+    [jawldsip setLayer:view.layer];
+
+    win = (void*) view;
+    releaseDrawingSurface(ds, dsi);
+    return win;
+}
+
+jlong createNativeSurface(jint width, jint height) {
+    NSView *view = [[NSView alloc] initWithFrame:NSMakeRect(0, 0, width, height)];
+    view.wantsLayer = true;
+    return (jlong) view;
+}
+
+void destroyNativeSurface(jlong surface) {
+    NSView *view = reinterpret_cast<NSView*>(surface);
+    [view release];
+}
+
+}
+#pragma clang diagnostic pop

android/filament-android/src/main/cpp/nativewindow/JAWTUtils.cpp

@@ -0,0 +1,109 @@
+/*
+ * Copyright (C) 2018 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "JAWTUtils.h"
+
+#include <vector>
+
+static std::vector<int> jawtVersions = {
+        0x00010003,
+        0x00010004,
+        0x00010007,
+        0x00010009,
+};
+
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wuninitialized"
+bool acquireDrawingSurface(JNIEnv* env, jobject surface,
+        JAWT_DrawingSurface** ods, JAWT_DrawingSurfaceInfo** odsi) {
+
+    JAWT awt;
+    JAWT_DrawingSurface* ds = nullptr;
+    JAWT_DrawingSurfaceInfo* dsi = nullptr;
+
+    // Search for a valid AWT
+    jboolean foundJawt = JNI_FALSE;
+    for (int jawtVersion : jawtVersions) {
+        awt.version = jawtVersion;
+        foundJawt = JAWT_GetAWT(env, &awt);
+        if (foundJawt == JNI_TRUE) {
+#ifndef NDEBUG
+            printf("Found valid AWT v%08x.\n", jawtVersion);
+#endif
+            break;
+        } else {
+#ifndef NDEBUG
+            printf("AWT v%08x not present.\n", jawtVersion);
+#endif
+        }
+    }
+#ifndef NDEBUG
+    fflush(stdout);
+#endif
+
+    if (foundJawt == JNI_FALSE) {
+        printf("AWT Not found\n");
+        fflush(stdout);
+        return false;
+    }
+
+    // Get the drawing surface
+    ds = awt.GetDrawingSurface(env, surface);
+    if (ds == nullptr) {
+#ifndef NDEBUG
+        printf("NULL drawing surface\n");
+        fflush(stdout);
+#endif
+        return false;
+    }
+
+    // Lock the drawing
+    jint lock = ds->Lock(ds);
+    if ((lock & JAWT_LOCK_ERROR) != 0) {
+#ifndef NDEBUG
+        printf("Error locking surface\n");
+        fflush(stdout);
+#endif
+        awt.FreeDrawingSurface(ds);
+        return false;
+    }
+
+    // Get the drawing surface info
+    dsi = ds->GetDrawingSurfaceInfo(ds);
+    if (dsi == nullptr) {
+#ifndef NDEBUG
+        printf("Error getting surface info\n");
+        fflush(stdout);
+#endif
+
+        ds->Unlock(ds);
+        awt.FreeDrawingSurface(ds);
+        return false;
+    }
+
+    *odsi = dsi;
+    *ods = ds;
+
+    return true;
+}
+#pragma clang diagnostic pop
+
+void releaseDrawingSurface(JAWT_DrawingSurface* ds, JAWT_DrawingSurfaceInfo* dsi) {
+    // Free the drawing surface info
+    ds->FreeDrawingSurfaceInfo(dsi);
+    // Unlock the drawing surface
+    ds->Unlock(ds);
+}

android/filament-android/src/main/cpp/nativewindow/JAWTUtils.h

@@ -0,0 +1,23 @@
+/*
+ * Copyright (C) 2018 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include <jawt.h>
+
+extern "C" {
+bool acquireDrawingSurface(JNIEnv* env, jobject surface, JAWT_DrawingSurface** ods,
+        JAWT_DrawingSurfaceInfo** odsi);
+void releaseDrawingSurface(JAWT_DrawingSurface* ds, JAWT_DrawingSurfaceInfo* dsi);
+}

android/filament-android/src/main/cpp/nativewindow/Linux.cpp

@@ -0,0 +1,90 @@
+/*
+ * Copyright (C) 2018 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include <stdio.h>
+
+#include <jawt.h>
+#include <linux/jawt_md.h>
+
+#include "JAWTUtils.h"
+#include<GL/glx.h>
+
+extern "C" {
+void *getNativeWindow(JNIEnv* env, jclass, jobject surface) {
+    void* win = nullptr;
+    JAWT_DrawingSurface* ds = nullptr;
+    JAWT_DrawingSurfaceInfo* dsi = nullptr;
+
+    if (!acquireDrawingSurface(env, surface, &ds, &dsi)) {
+        return win;
+    }
+    JAWT_X11DrawingSurfaceInfo* dsi_x11 = (JAWT_X11DrawingSurfaceInfo*) dsi->platformInfo;
+
+    win = (void*) dsi_x11->drawable;
+    releaseDrawingSurface(ds, dsi);
+    return win;
+}
+
+jlong createNativeSurface(jint width, jint height) {
+    Display* display = XOpenDisplay(nullptr);
+    int screen = DefaultScreen(display);
+    Window window = 0;
+
+    #ifndef NDEBUG
+        int major, minor;
+        glXQueryVersion(display, &major, &minor);
+        printf("Using GLX v%d.%d\n", major, minor); fflush(stdout);
+    #endif
+
+    static int visualAttributess[] = {
+        GLX_DRAWABLE_TYPE, GLX_WINDOW_BIT,
+        GLX_RENDER_TYPE,   GLX_RGBA_BIT,
+        GLX_DOUBLEBUFFER,  True,
+        GLX_RED_SIZE,      8,
+        GLX_GREEN_SIZE,    8,
+        GLX_BLUE_SIZE,     8,
+        GLX_DEPTH_SIZE,   24,
+        None
+    };
+    int numConfigs = 0;
+    GLXFBConfig* configs = glXChooseFBConfig( display, screen, visualAttributess, &numConfigs);
+    if (numConfigs == 0) {
+        printf("Unable to find a suitable Framebuffer Configuration.\n"); fflush(stdout);
+        return 0;
+    }
+
+    int pbufferAttributes[] = {
+        GLX_PBUFFER_WIDTH, width,
+        GLX_PBUFFER_HEIGHT, height,
+        None
+    };
+    window = glXCreatePbuffer( display, configs[0], pbufferAttributes );
+    XFree(configs);
+    // Make sure pbuffer creation has not been buffered in the event queue (we need it NOW).
+    XFlush(display);
+
+    // Camouflage the pbuffer as a window which are both XID anyway.
+    return (jlong) window;
+}
+
+void destroyNativeSurface(jlong surface) {
+    const char* displayName = nullptr;
+    Display* display = XOpenDisplay(displayName);
+    GLXPbuffer pBuffer = (GLXPbuffer)surface;
+    glXDestroyPbuffer(display, pBuffer);
+}
+
+}

android/filament-android/src/main/cpp/nativewindow/Win32.cpp

@@ -0,0 +1,67 @@
+/*
+ * Copyright (C) 2018 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include <stdio.h>
+
+#include <jawt.h>
+#include <win32/jawt_md.h>
+#include <windows.h>
+
+#include <utils/unwindows.h>
+
+#include "JAWTUtils.h"
+#include <filament/Engine.h>
+
+extern "C" {
+
+void* getNativeWindow(JNIEnv* env, jclass, jobject surface) {
+    JAWT_DrawingSurface* ds = nullptr;
+    JAWT_DrawingSurfaceInfo* dsi = nullptr;
+
+    if (!acquireDrawingSurface(env, surface, &ds, &dsi)) {
+        return nullptr;
+    }
+
+    JAWT_Win32DrawingSurfaceInfo* dsi_win32 = (JAWT_Win32DrawingSurfaceInfo*) dsi->platformInfo;
+    HWND hWnd = dsi_win32->hwnd;
+
+    releaseDrawingSurface(ds, dsi);
+
+    return (void*) hWnd;
+}
+
+
+jlong createNativeSurface(jint width, jint height) {
+    // We need to adjust the window size so the "client area" matches width and height requested.
+    // Otherwise, the window itself will be of dimension width-height but the "client area" and the
+    // resulting surface will be smaller than requested.
+    RECT dimension = {0, 0, width, height};
+    AdjustWindowRect(&dimension, WS_OVERLAPPEDWINDOW, FALSE);
+    width = dimension.right - dimension.left;
+    height = dimension.bottom - dimension.top;
+
+    HWND window = CreateWindowA("STATIC", "dummy", 0, 0, 0, width, height, NULL, NULL, NULL, NULL);
+    SetWindowLong(window, GWL_STYLE, 0); //remove all window styles
+
+    return (jlong) window;
+}
+
+void destroyNativeSurface(jlong surface) {
+    HWND window = (HWND) surface;
+    DestroyWindow(window);
+}
+
+}

android/filament-android/src/main/java/com/google/android/filament/Asserts.java

@@ -63,27 +63,12 @@ final class Asserts {
         return out;
     }
 
-    @NonNull @Size(min = 16)
-    static double[] assertMat4(@Nullable double[] out) {
-        if (out == null) out = new double[16];
-        else if (out.length < 16) {
-            throw new ArrayIndexOutOfBoundsException("Array length must be at least 16");
-        }
-        return out;
-    }
-
     static void assertMat4fIn(@NonNull @Size(min = 16) float[] in) {
         if (in.length < 16) {
             throw new ArrayIndexOutOfBoundsException("Array length must be at least 16");
         }
     }
 
-    static void assertMat4In(@NonNull @Size(min = 16) double[] in) {
-        if (in.length < 16) {
-            throw new ArrayIndexOutOfBoundsException("Array length must be at least 16");
-        }
-    }
-
     @NonNull @Size(min = 3)
     static float[] assertFloat3(@Nullable float[] out) {
         if (out == null) out = new float[3];

android/filament-android/src/main/java/com/google/android/filament/BufferObject.java

@@ -1,210 +0,0 @@
-/*
- * Copyright (C) 2021 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package com.google.android.filament;
-
-import androidx.annotation.IntRange;
-import androidx.annotation.NonNull;
-import androidx.annotation.Nullable;
-
-import java.nio.Buffer;
-import java.nio.BufferOverflowException;
-
-/**
- * A generic GPU buffer containing data.
- *
- * Usage of this BufferObject is optional. For simple use cases it is not necessary. It is useful
- * only when you need to share data between multiple VertexBuffer instances. It also allows you to
- * efficiently swap-out the buffers in VertexBuffer.
- *
- * NOTE: For now this is only used for vertex data, but in the future we may use it for other things
- * (e.g. compute).
- *
- * @see VertexBuffer
- */
-public class BufferObject {
-    private long mNativeObject;
-
-    private BufferObject(long nativeBufferObject) {
-        mNativeObject = nativeBufferObject;
-    }
-
-    public static class Builder {
-        @SuppressWarnings({"FieldCanBeLocal", "UnusedDeclaration"})
-        // Keep to finalize native resources
-        private final BuilderFinalizer mFinalizer;
-        private final long mNativeBuilder;
-
-        public enum BindingType {
-            VERTEX,
-        }
-
-        public Builder() {
-            mNativeBuilder = nCreateBuilder();
-            mFinalizer = new BuilderFinalizer(mNativeBuilder);
-        }
-
-        /**
-         * Size of the buffer in bytes.
-         *
-         * @param byteCount Maximum number of bytes the BufferObject can hold.
-         * @return A reference to this Builder for chaining calls.
-         */
-        @NonNull
-        public Builder size(@IntRange(from = 1) int byteCount) {
-            nBuilderSize(mNativeBuilder, byteCount);
-            return this;
-        }
-
-        /**
-         * The binding type for this buffer object. (defaults to VERTEX)
-         *
-         * @param bindingType Distinguishes between SSBO, VBO, etc. For now this must be VERTEX.
-         * @return A reference to this Builder for chaining calls.
-         */
-        @NonNull
-        public Builder bindingType(@NonNull BindingType bindingType) {
-            nBuilderBindingType(mNativeBuilder, bindingType.ordinal());
-            return this;
-        }
-
-        /**
-         * Creates and returns the <code>BufferObject</code> object. After creation, the buffer
-         * is uninitialized. Use {@link #setBuffer} to initialize the <code>BufferObject</code>.
-         *
-         * @param engine reference to the {@link Engine} to associate this <code>BufferObject</code>
-         *               with
-         *
-         * @return the newly created <code>BufferObject</code> object
-         *
-         * @exception IllegalStateException if the BufferObject could not be created
-         *
-         * @see #setBuffer
-         */
-        @NonNull
-        public BufferObject build(@NonNull Engine engine) {
-            long nativeBufferObject = nBuilderBuild(mNativeBuilder, engine.getNativeObject());
-            if (nativeBufferObject == 0)
-                throw new IllegalStateException("Couldn't create BufferObject");
-            return new BufferObject(nativeBufferObject);
-        }
-
-        private static class BuilderFinalizer {
-            private final long mNativeObject;
-
-            BuilderFinalizer(long nativeObject) {
-                mNativeObject = nativeObject;
-            }
-
-            @Override
-            public void finalize() {
-                try {
-                    super.finalize();
-                } catch (Throwable t) { // Ignore
-                } finally {
-                    nDestroyBuilder(mNativeObject);
-                }
-            }
-        }
-    }
-
-    /**
-     * Returns the size of this <code>BufferObject</code> in elements.
-     *
-     * @return the number of bytes the <code>BufferObject</code> holds
-     */
-    @IntRange(from = 0)
-    public int getByteCount() {
-        return nGetByteCount(getNativeObject());
-    }
-
-    /**
-     * Asynchronously copy-initializes this <code>BufferObject</code> from the data provided.
-     *
-     * @param engine            reference to the {@link Engine} to associate this
-     *                          <code>BufferObject</code> with
-     * @param buffer            a CPU-side {@link Buffer} with the data used to initialize the
-     *                          <code>BufferObject</code>.
-     */
-    public void setBuffer(@NonNull Engine engine, @NonNull Buffer buffer) {
-        setBuffer(engine, buffer, 0, 0, null, null);
-    }
-
-    /**
-     * Asynchronously copy-initializes a region of this <code>BufferObject</code> from the data
-     * provided.
-     *
-     * @param engine            reference to the {@link Engine} to associate this
-     *                          <code>BufferObject</code> with
-     * @param buffer            a CPU-side {@link Buffer} with the data used to initialize the
-     *                          <code>BufferObject</code>.
-     * @param destOffsetInBytes offset in <i>bytes</i> into the <code>BufferObject</code>
-     * @param count             number of bytes to consume, defaults to
-     *                          <code>buffer.remaining()</code>
-     */
-    public void setBuffer(@NonNull Engine engine, @NonNull Buffer buffer,
-            @IntRange(from = 0) int destOffsetInBytes, @IntRange(from = 0) int count) {
-        setBuffer(engine, buffer, destOffsetInBytes, count, null, null);
-    }
-
-    /**
-     * Asynchronously copy-initializes a region of this <code>BufferObject</code> from the data
-     * provided.
-     *
-     * @param engine            reference to the {@link Engine} to associate this
-     *                          <code>BufferObject</code> with
-     * @param buffer            a CPU-side {@link Buffer} with the data used to initialize the
-     *                          <code>BufferObject</code>.
-     * @param destOffsetInBytes offset in <i>bytes</i> into the <code>BufferObject</code>
-     * @param count             number of bytes to consume, defaults to
-     *                          <code>buffer.remaining()</code>
-     * @param handler           an {@link java.util.concurrent.Executor Executor}. On Android this
-     *                          can also be a {@link android.os.Handler Handler}.
-     * @param callback          a callback executed by <code>handler</code> when <code>buffer</code>
-     *                          is no longer needed.
-     */
-    public void setBuffer(@NonNull Engine engine, @NonNull Buffer buffer,
-            @IntRange(from = 0) int destOffsetInBytes, @IntRange(from = 0) int count,
-            @Nullable Object handler, @Nullable Runnable callback) {
-        int result = nSetBuffer(getNativeObject(), engine.getNativeObject(), buffer, buffer.remaining(),
-                destOffsetInBytes, count == 0 ? buffer.remaining() : count, handler, callback);
-        if (result < 0) {
-            throw new BufferOverflowException();
-        }
-    }
-
-    public long getNativeObject() {
-        if (mNativeObject == 0) {
-            throw new IllegalStateException("Calling method on destroyed BufferObject");
-        }
-        return mNativeObject;
-    }
-
-    void clearNativeObject() {
-        mNativeObject = 0;
-    }
-
-    private static native long nCreateBuilder();
-    private static native void nDestroyBuilder(long nativeBuilder);
-    private static native void nBuilderSize(long nativeBuilder, int byteCount);
-    private static native void nBuilderBindingType(long nativeBuilder, int bindingType);
-    private static native long nBuilderBuild(long nativeBuilder, long nativeEngine);
-
-    private static native int nGetByteCount(long nativeBufferObject);
-    private static native int nSetBuffer(long nativeBufferObject, long nativeEngine,
-            Buffer buffer, int remaining,
-            int destOffsetInBytes, int count, Object handler, Runnable callback);
-}

android/filament-android/src/main/java/com/google/android/filament/Camera.java

@@ -27,17 +27,21 @@ import androidx.annotation.Size;
  *
  * <h1><u>Creation and destruction</u></h1>
  *
- * In Filament, Camera is a component that must be associated with an entity. To do so,
- * use {@link Engine#createCamera(int)}. A Camera component is destroyed using
- * {@link Engine#destroyCameraComponent(int Entity)} ()}.
+ * Unlike most Filament objects, Camera doesn't require a builder and can be constructed directly
+ * using {@link Engine#createCamera}. At the very least, a projection must be defined
+ * using {@link #setProjection}. In most case, the camera position also needs to be set.
+ * <p>
+ * A Camera object is destroyed using {@link Engine#destroyCamera}.
  *
  * <pre>
- *  Camera myCamera = engine.createCamera(myCameraEntity);
+ *  Engine engine = Engine.create();
+ *
+ *  Camera myCamera = engine.createCamera();
  *  myCamera.setProjection(45, 16.0/9.0, 0.1, 1.0);
  *  myCamera.lookAt(0, 1.60, 1,
  *                  0, 0, 0,
  *                  0, 1, 0);
- *  engine.destroyCameraComponent(myCameraEntity);
+ *  engine.destroyCamera(myCamera);
  * </pre>
  *
  *
@@ -121,9 +125,6 @@ import androidx.annotation.Size;
 public class Camera {
     private long mNativeObject;
 
-    @Entity
-    private final int mEntity;
-
     /**
      * Denotes the projection type used by this camera.
      * @see #setProjection
@@ -146,9 +147,8 @@ public class Camera {
         HORIZONTAL
     }
 
-    Camera(long nativeCamera, @Entity int entity) {
+    Camera(long nativeCamera) {
         mNativeObject = nativeCamera;
-        mEntity = entity;
     }
 
     /**
@@ -252,12 +252,9 @@ public class Camera {
     }
 
     /**
-     * Sets a custom projection matrix.
+     * Sets the projection matrix.
      *
-     * <p>The projection matrix must define an NDC system that must match the OpenGL convention,
-     * that is all 3 axis are mapped to [-1, 1].</p>
-     *
-     * @param inProjection  custom projection matrix for rendering and culling
+     * @param inMatrix      custom projection matrix.
      *
      * @param near          distance in world units from the camera to the near plane.
      *                      The near plane's position in view space is z = -<code>near</code>.
@@ -273,74 +270,10 @@ public class Camera {
      *                      <code>far</code> != <code>near</code>
      *                              for {@link Projection#ORTHO}.
      */
-    public void setCustomProjection(@NonNull @Size(min = 16) double[] inProjection,
+    public void setCustomProjection(@NonNull @Size(min = 16) double[] inMatrix,
             double near, double far) {
-        Asserts.assertMat4dIn(inProjection);
-        nSetCustomProjection(getNativeObject(), inProjection, inProjection, near, far);
-    }
-
-    /**
-     * Sets a custom projection matrix.
-     *
-     * <p>The projection matrices must define an NDC system that must match the OpenGL convention,
-     * that is all 3 axis are mapped to [-1, 1].</p>
-     *
-     * @param inProjection              custom projection matrix for rendering.
-     *
-     * @param inProjectionForCulling    custom projection matrix for culling.
-     *
-     * @param near          distance in world units from the camera to the near plane.
-     *                      The near plane's position in view space is z = -<code>near</code>.
-     *                      Precondition:
-     *                      <code>near</code> > 0 for {@link Projection#PERSPECTIVE} or
-     *                      <code>near</code> != <code>far</code> for {@link Projection#ORTHO}.
-     *
-     * @param far           distance in world units from the camera to the far plane.
-     *                      The far plane's position in view space is z = -<code>far</code>.
-     *                      Precondition:
-     *                      <code>far</code> > <code>near</code>
-     *                              for {@link Projection#PERSPECTIVE} or
-     *                      <code>far</code> != <code>near</code>
-     *                              for {@link Projection#ORTHO}.
-     */
-    public void setCustomProjection(
-            @NonNull @Size(min = 16) double[] inProjection,
-            @NonNull @Size(min = 16) double[] inProjectionForCulling,
-            double near, double far) {
-        Asserts.assertMat4dIn(inProjection);
-        Asserts.assertMat4dIn(inProjectionForCulling);
-        nSetCustomProjection(getNativeObject(), inProjection, inProjectionForCulling, near, far);
-    }
-
-    /**
-     * Sets an additional matrix that scales the projection matrix.
-     *
-     * <p>This is useful to adjust the aspect ratio of the camera independent from its projection.
-     * First, pass an aspect of 1.0 to setProjection. Then set the scaling with the desired aspect
-     * ratio:<br>
-     *
-     * <code>
-     *     double aspect = width / height;
-     *
-     *     // with Fov.HORIZONTAL passed to setProjection:
-     *     camera.setScaling(1.0, aspect);
-     *
-     *     // with Fov.VERTICAL passed to setProjection:
-     *     camera.setScaling(1.0 / aspect, 1.0);
-     * </code>
-     *
-     * By default, this is an identity matrix.
-     * </p>
-     *
-     * @param xscaling  horizontal scaling to be applied after the projection matrix.
-     * @param yscaling  vertical scaling to be applied after the projection matrix.
-     *
-     * @see Camera#setProjection
-     * @see Camera#setLensProjection
-     * @see Camera#setCustomProjection
-     */
-    public void setScaling(double xscaling, double yscaling) {
-        nSetScaling(getNativeObject(), xscaling, yscaling);
+        Asserts.assertMat4dIn(inMatrix);
+        nSetCustomProjection(getNativeObject(), inMatrix, near, far);
     }
 
     /**
@@ -370,37 +303,14 @@ public class Camera {
      * @see Camera#setProjection
      * @see Camera#setLensProjection
      * @see Camera#setCustomProjection
-     *
-     * @deprecated use {@link #setScaling(double, double)}
-     *
      */
-    @Deprecated
     public void setScaling(@NonNull @Size(min = 4) double[] inScaling) {
         Asserts.assertDouble4In(inScaling);
-        setScaling(inScaling[0], inScaling[1]);
+        nSetScaling(getNativeObject(), inScaling);
     }
 
     /**
-     * Sets an additional matrix that shifts (translates) the projection matrix.
-     * <p>
-     * The shift parameters are specified in NDC coordinates, that is, if the translation must
-     * be specified in pixels, the xshift and yshift parameters be scaled by 1.0 / viewport.width
-     * and 1.0 / viewport.height respectively.
-     * </p>
-     *
-     * @param xshift    horizontal shift in NDC coordinates applied after the projection
-     * @param yshift    vertical shift in NDC coordinates applied after the projection
-     *
-     * @see Camera#setProjection
-     * @see Camera#setLensProjection
-     * @see Camera#setCustomProjection
-     */
-    public void setShift(double xshift, double yshift) {
-        nSetShift(getNativeObject(), xshift, yshift);
-    }
-
-    /**
-     * Sets the camera's model matrix.
+     * Sets the camera's view matrix.
      * <p>
      * Helper method to set the camera's entity transform component.
      * Remember that the Camera "looks" towards its -z axis.
@@ -412,29 +322,15 @@ public class Camera {
      *          engine.getTransformManager().getInstance(camera->getEntity()), viewMatrix);
      * </pre>
      *
-     * @param modelMatrix The camera position and orientation provided as a <b>rigid transform</b> matrix.
+     * @param viewMatrix The camera position and orientation provided as a <b>rigid transform</b> matrix.
      */
-    public void setModelMatrix(@NonNull @Size(min = 16) float[] modelMatrix) {
-        Asserts.assertMat4fIn(modelMatrix);
-        nSetModelMatrix(getNativeObject(), modelMatrix);
+    public void setModelMatrix(@NonNull @Size(min = 16) float[] viewMatrix) {
+        Asserts.assertMat4fIn(viewMatrix);
+        nSetModelMatrix(getNativeObject(), viewMatrix);
     }
 
     /**
-     * Sets the camera's model matrix.
-     * <p>
-     * Helper method to set the camera's entity transform component.
-     * Remember that the Camera "looks" towards its -z axis.
-     * <p>
-     *
-     * @param modelMatrix The camera position and orientation provided as a <b>rigid transform</b> matrix.
-     */
-    public void setModelMatrix(@NonNull @Size(min = 16) double[] modelMatrix) {
-        Asserts.assertMat4In(modelMatrix);
-        nSetModelMatrixFp64(getNativeObject(), modelMatrix);
-    }
-
-    /**
-     * Sets the camera's model matrix.
+     * Sets the camera's view matrix.
      *
      * @param eyeX      x-axis position of the camera in world space
      * @param eyeY      y-axis position of the camera in world space
@@ -452,19 +348,17 @@ public class Camera {
     }
 
     /**
-     * Gets the distance to the near plane
      * @return Distance to the near plane
      */
     public float getNear() {
-        return (float)nGetNear(getNativeObject());
+        return nGetNear(getNativeObject());
     }
 
     /**
-     * Gets the distance to the far plane
      * @return Distance to the far plane
      */
     public float getCullingFar() {
-        return (float)nGetCullingFar(getNativeObject());
+        return nGetCullingFar(getNativeObject());
     }
 
     /**
@@ -530,29 +424,13 @@ public class Camera {
         return out;
     }
 
-    /**
-     * Retrieves the camera's model matrix. The model matrix encodes the camera position and
-     * orientation, or pose.
-     *
-     * @param out A 16-double array where the model matrix will be stored, or null in which
-     *            case a new array is allocated.
-     *
-     * @return A 16-double array containing the camera's pose as a column-major matrix.
-     */
-    @NonNull @Size(min = 16)
-    public double[] getModelMatrix(@Nullable @Size(min = 16) double[] out) {
-        out = Asserts.assertMat4(out);
-        nGetModelMatrixFp64(getNativeObject(), out);
-        return out;
-    }
-
     /**
      * Retrieves the camera's view matrix. The view matrix is the inverse of the model matrix.
      *
-     * @param out A 16-float array where the view matrix will be stored, or null in which
+     * @param out A 16-float array where the model view will be stored, or null in which
      *            case a new array is allocated.
      *
-     * @return A 16-float array containing the camera's column-major view matrix.
+     * @return A 16-float array containing the camera's view as a column-major matrix.
      */
     @NonNull @Size(min = 16)
     public float[] getViewMatrix(@Nullable @Size(min = 16) float[] out) {
@@ -561,21 +439,6 @@ public class Camera {
         return out;
     }
 
-    /**
-     * Retrieves the camera's view matrix. The view matrix is the inverse of the model matrix.
-     *
-     * @param out A 16-double array where the model view will be stored, or null in which
-     *            case a new array is allocated.
-     *
-     * @return A 16-double array containing the camera's column-major view matrix.
-     */
-    @NonNull @Size(min = 16)
-    public double[] getViewMatrix(@Nullable @Size(min = 16) double[] out) {
-        out = Asserts.assertMat4(out);
-        nGetViewMatrixFp64(getNativeObject(), out);
-        return out;
-    }
-
     /**
      * Retrieves the camera position in world space.
      *
@@ -688,7 +551,6 @@ public class Camera {
     }
 
     /**
-     * Gets the aperture in f-stops
      * @return Aperture in f-stops
      */
     public float getAperture() {
@@ -696,7 +558,6 @@ public class Camera {
     }
 
     /**
-     * Gets the shutter speed in seconds
      * @return Shutter speed in seconds
      */
     public float getShutterSpeed() {
@@ -704,69 +565,12 @@ public class Camera {
     }
 
     /**
-     * Gets the focal length in meters
-     * @return focal length in meters [m]
-     */
-    public double getFocalLength() {
-        return nGetFocalLength(getNativeObject());
-    }
-
-    /**
-     * Set the camera focus distance in world units
-     * @param distance Distance from the camera to the focus plane in world units. Must be
-     *                 positive and larger than the camera's near clipping plane.
-     */
-    public void setFocusDistance(float distance) {
-        nSetFocusDistance(getNativeObject(), distance);
-    }
-
-    /**
-     * Gets the distance from the camera to the focus plane in world units
-     * @return Distance from the camera to the focus plane in world units
-     */
-    public float getFocusDistance() {
-        return nGetFocusDistance(getNativeObject());
-    }
-
-    /**
-     * Gets the sensitivity in ISO
      * @return Sensitivity in ISO
      */
     public float getSensitivity() {
         return nGetSensitivity(getNativeObject());
     }
 
-    /**
-     * Gets the entity representing this Camera
-     * @return the entity this Camera component is attached to
-     */
-    @Entity
-    public int getEntity() {
-        return mEntity;
-    }
-
-    /**
-     * Helper to compute the effective focal length taking into account the focus distance
-     *
-     * @param focalLength       focal length in any unit (e.g. [m] or [mm])
-     * @param focusDistance     focus distance in same unit as focalLength
-     * @return                  the effective focal length in same unit as focalLength
-     */
-    static double computeEffectiveFocalLength(double focalLength, double focusDistance) {
-        return nComputeEffectiveFocalLength(focalLength, focusDistance);
-    }
-
-    /**
-     * Helper to compute the effective field-of-view taking into account the focus distance
-     *
-     * @param fovInDegrees      full field of view in degrees
-     * @param focusDistance     focus distance in meters [m]
-     * @return                  effective full field of view in degrees
-     */
-    static double computeEffectiveFov(double fovInDegrees, double focusDistance) {
-        return nComputeEffectiveFov(fovInDegrees, focusDistance);
-    }
-
     public long getNativeObject() {
         if (mNativeObject == 0) {
             throw new IllegalStateException("Calling method on destroyed Camera");
@@ -781,21 +585,17 @@ public class Camera {
     private static native void nSetProjection(long nativeCamera, int projection, double left, double right, double bottom, double top, double near, double far);
     private static native void nSetProjectionFov(long nativeCamera, double fovInDegrees, double aspect, double near, double far, int fov);
     private static native void nSetLensProjection(long nativeCamera, double focalLength, double aspect, double near, double far);
-    private static native void nSetCustomProjection(long nativeCamera, double[] inProjection, double[] inProjectionForCulling, double near, double far);
-    private static native void nSetScaling(long nativeCamera, double x, double y);
-    private static native void nSetShift(long nativeCamera, double x, double y);
+    private static native void nSetCustomProjection(long nativeCamera, double[] inMatrix, double near, double far);
+    private static native void nSetScaling(long nativeCamera, double[] inScaling);
     private static native void nSetModelMatrix(long nativeCamera, float[] in);
-    private static native void nSetModelMatrixFp64(long nativeCamera, double[] in);
     private static native void nLookAt(long nativeCamera, double eyeX, double eyeY, double eyeZ, double centerX, double centerY, double centerZ, double upX, double upY, double upZ);
-    private static native double nGetNear(long nativeCamera);
-    private static native double nGetCullingFar(long nativeCamera);
+    private static native float nGetNear(long nativeCamera);
+    private static native float nGetCullingFar(long nativeCamera);
     private static native void nGetProjectionMatrix(long nativeCamera, double[] out);
     private static native void nGetCullingProjectionMatrix(long nativeCamera, double[] out);
     private static native void nGetScaling(long nativeCamera, double[] out);
     private static native void nGetModelMatrix(long nativeCamera, float[] out);
-    private static native void nGetModelMatrixFp64(long nativeCamera, double[] out);
     private static native void nGetViewMatrix(long nativeCamera, float[] out);
-    private static native void nGetViewMatrixFp64(long nativeCamera, double[] out);
     private static native void nGetPosition(long nativeCamera, float[] out);
     private static native void nGetLeftVector(long nativeCamera, float[] out);
     private static native void nGetUpVector(long nativeCamera, float[] out);
@@ -804,9 +604,4 @@ public class Camera {
     private static native float nGetAperture(long nativeCamera);
     private static native float nGetShutterSpeed(long nativeCamera);
     private static native float nGetSensitivity(long nativeCamera);
-    private static native void nSetFocusDistance(long nativeCamera, float distance);
-    private static native float nGetFocusDistance(long nativeCamera);
-    private static native double nGetFocalLength(long nativeCamera);
-    private static native double nComputeEffectiveFocalLength(double focalLength, double focusDistance);
-    private static native double nComputeEffectiveFov(double fovInDegrees, double focusDistance);
 }

android/filament-android/src/main/java/com/google/android/filament/ColorGrading.java

@@ -54,8 +54,6 @@ import static com.google.android.filament.Asserts.assertFloat4In;
  *
  * The various transforms held by ColorGrading are applied in the following order:
  * <ul>
- * <li>Exposure</li>
- * <li>Night adaptation</li>
  * <li>White balance</li>
  * <li>Channel mixer</li>
  * <li>Shadows/mid-tones/highlights</li>
@@ -65,16 +63,12 @@ import static com.google.android.filament.Asserts.assertFloat4In;
  * <li>Saturation</li>
  * <li>Curves</li>
  * <li>Tone mapping</li>
- * <li>Luminance scaling</li>
- * <li>Gamut mapping</li>
  * </ul>
  *
  * <h1>Defaults</h1>
  *
  * Here are the default color grading options:
  * <ul>
- * <li>Exposure: 0.0</li>
- * <li>Night adaptation: 0.0</li>
  * <li>White balance: temperature <code>0.0</code>, and tint <code>0.0</code></li>
  * <li>Channel mixer: red <code>{1,0,0}</code>, green <code>{0,1,0}</code>, blue <code>{0,0,1}</code></li>
  * <li>Shadows/mid-tones/highlights: shadows <code>{1,1,1,0}</code>, mid-tones <code>{1,1,1,0}</code>,
@@ -84,13 +78,11 @@ import static com.google.android.filament.Asserts.assertFloat4In;
  * <li>Vibrance: <code>1.0</code></li>
  * <li>Saturation: <code>1.0</code></li>
  * <li>Curves: gamma <code>{1,1,1}</code>, midPoint <code>{1,1,1}</code>, and scale <code>{1,1,1}</code></li>
- * <li>Tone mapping: {@link ToneMapper.ACESLegacy}</li>
- * <li>Luminance scaling: false</li>
- * <li>Gamut mapping: false</li>
+ * <li>Tone mapping: {@link ToneMapping#ACES_LEGACY}</li>
  * </ul>
  *
  * @see View
- * @see ToneMapper
+ * @see ToneMapping
  */
 public class ColorGrading {
     long mNativeObject;
@@ -105,18 +97,8 @@ public class ColorGrading {
         ULTRA
     }
 
-    /**
-     * Color grading LUT format.
-     */
-    public enum LutFormat {
-        INTEGER,
-        FLOAT
-    }
-
     /**
      * List of available tone-mapping operators.
-     *
-     * @deprecated Use {@link ColorGrading.Builder#toneMapper(ToneMapper)}
      */
     public enum ToneMapping {
         /** Linear tone mapping (i.e. no tone mapping). */
@@ -127,12 +109,15 @@ public class ColorGrading {
         ACES,
         /** Filmic tone mapping, modelled after ACES but applied in sRGB space. */
         FILMIC,
+        /** Filmic tone mapping, with more contrast and saturation. */
+        UCHIMURA,
+        /** Reinhard luma-based tone mapping. */
+        REINHARD,
         /** Tone mapping used to validate/debug scene exposure. */
         DISPLAY_RANGE,
     }
 
-    // NOTE: This constructor is public only so that filament-utils can use it.
-    public ColorGrading(long colorGrading) {
+    ColorGrading(long colorGrading) {
         mNativeObject = colorGrading;
     }
 
@@ -170,55 +155,6 @@ public class ColorGrading {
             return this;
         }
 
-        /**
-         * When color grading is implemented using a 3D LUT, this sets the texture format of
-         * of the LUT. This overrides the value set by quality().
-         *
-         * The default is INTEGER
-         *
-         * @param format The desired format of the 3D LUT.
-         *
-         * @return This Builder, for chaining calls
-         */
-        public Builder format(LutFormat format) {
-            nBuilderFormat(mNativeBuilder, format.ordinal());
-            return this;
-        }
-
-        /**
-         * When color grading is implemented using a 3D LUT, this sets the dimension of the LUT.
-         * This overrides the value set by quality().
-         *
-         * The default is 32
-         *
-         * @param dim The desired dimension of the LUT. Between 16 and 64.
-         *
-         * @return This Builder, for chaining calls
-         */
-        public Builder dimensions(int dim) {
-            nBuilderDimensions(mNativeBuilder, dim);
-            return this;
-        }
-
-        /**
-         * Selects the tone mapping operator to apply to the HDR color buffer as the last
-         * operation of the color grading post-processing step.
-         *
-         * The default tone mapping operator is {@link ToneMapper.ACESLegacy}.
-         *
-         * The specified tone mapper must have a lifecycle that exceeds the lifetime of
-         * this builder. Since the build(Engine&) method is synchronous, it is safe to
-         * delete the tone mapper object after that finishes executing.
-         *
-         * @param toneMapper The tone mapping operator to apply to the HDR color buffer
-         *
-         * @return This Builder, for chaining calls
-         */
-        public Builder toneMapper(ToneMapper toneMapper) {
-            nBuilderToneMapper(mNativeBuilder, toneMapper.getNativeObject());
-            return this;
-        }
-
         /**
          * Selects the tone mapping operator to apply to the HDR color buffer as the last
          * operation of the color grading post-processing step.
@@ -228,81 +164,12 @@ public class ColorGrading {
          * @param toneMapping The tone mapping operator to apply to the HDR color buffer
          *
          * @return This Builder, for chaining calls
-         *
-         * @deprecated Use {@link #toneMapper(ToneMapper)}
          */
         public Builder toneMapping(ToneMapping toneMapping) {
             nBuilderToneMapping(mNativeBuilder, toneMapping.ordinal());
             return this;
         }
 
-        /**
-         * Enables or disables the luminance scaling component (LICH) from the exposure value
-         * invariant luminance system (EVILS). When this setting is enabled, pixels with high
-         * chromatic values will roll-off to white to offer a more natural rendering. This step
-         * also helps avoid undesirable hue skews caused by out of gamut colors clipped
-         * to the destination color gamut.
-         *
-         * When luminance scaling is enabled, tone mapping is performed on the luminance of each
-         * pixel instead of per-channel.
-         *
-         * @param luminanceScaling Enables or disables EVILS post-tone mapping
-         *
-         * @return This Builder, for chaining calls
-         */
-        public Builder luminanceScaling(boolean luminanceScaling) {
-            nBuilderLuminanceScaling(mNativeBuilder, luminanceScaling);
-            return this;
-        }
-
-        /**
-         * Enables or disables gamut mapping to the destination color space's gamut. When gamut
-         * mapping is turned off, out-of-gamut colors are clipped to the destination's gamut,
-         * which may produce hue skews (blue skewing to purple, green to yellow, etc.). When
-         * gamut mapping is enabled, out-of-gamut colors are brought back in gamut by trying to
-         * preserve the perceived chroma and lightness of the original values.
-         *
-         * @param gamutMapping Enables or disables gamut mapping
-         *
-         * @return This Builder, for chaining calls
-         */
-        public Builder gamutMapping(boolean gamutMapping) {
-            nBuilderGamutMapping(mNativeBuilder, gamutMapping);
-            return this;
-        }
-
-        /**
-         * Adjusts the exposure of this image. The exposure is specified in stops:
-         * each stop brightens (positive values) or darkens (negative values) the image by
-         * a factor of 2. This means that an exposure of 3 will brighten the image 8 times
-         * more than an exposure of 0 (2^3 = 8 and 2^0 = 1). Contrary to the camera's exposure,
-         * this setting is applied after all post-processing (bloom, etc.) are applied.
-         *
-         * @param exposure Value in EV stops. Can be negative, 0, or positive.
-         *
-         * @return This Builder, for chaining calls
-         */
-        public Builder exposure(float exposure) {
-            nBuilderExposure(mNativeBuilder, exposure);
-            return this;
-        }
-
-        /**
-         * Controls the amount of night adaptation to replicate a more natural representation of
-         * low-light conditions as perceived by the human vision system. In low-light conditions,
-         * peak luminance sensitivity of the eye shifts toward the blue end of the color spectrum:
-         * darker tones appear brighter, reducing contrast, and colors are blue shifted (the darker
-         * the more intense the effect).
-         *
-         * @param adaptation Amount of adaptation, between 0 (no adaptation) and 1 (full adaptation).
-         *
-         * @return This Builder, for chaining calls
-         */
-        public Builder nightAdaptation(float adaptation) {
-            nBuilderNightAdaptation(mNativeBuilder, adaptation);
-            return this;
-        }
-
         /**
          * Adjusts the while balance of the image. This can be used to remove color casts
          * and correct the appearance of the white point in the scene, or to alter the
@@ -403,7 +270,7 @@ public class ColorGrading {
          *
          * @return This Builder, for chaining calls
          */
-        public Builder shadowsMidtonesHighlights(
+        Builder shadowsMidtonesHighlights(
                 @NonNull @Size(min = 4) float[] shadows,
                 @NonNull @Size(min = 4) float[] midtones,
                 @NonNull @Size(min = 4) float[] highlights,
@@ -442,7 +309,7 @@ public class ColorGrading {
          *
          * @return This Builder, for chaining calls
          */
-        public Builder slopeOffsetPower(
+        Builder slopeOffsetPower(
                 @NonNull @Size(min = 3) float[] slope,
                 @NonNull @Size(min = 3) float[] offset,
                 @NonNull @Size(min = 3) float[] power) {
@@ -493,7 +360,7 @@ public class ColorGrading {
          *
          * @return This Builder, for chaining calls
          */
-        public Builder vibrance(float vibrance) {
+        Builder vibrance(float vibrance) {
             nBuilderVibrance(mNativeBuilder, vibrance);
             return this;
         }
@@ -595,14 +462,7 @@ public class ColorGrading {
     private static native void nDestroyBuilder(long nativeBuilder);
 
     private static native void nBuilderQuality(long nativeBuilder, int quality);
-    private static native void nBuilderFormat(long nativeBuilder, int format);
-    private static native void nBuilderDimensions(long nativeBuilder, int dim);
-    private static native void nBuilderToneMapper(long nativeBuilder, long toneMapper);
-    private static native void nBuilderToneMapping(long nativeBuilder, int toneMapping);
-    private static native void nBuilderLuminanceScaling(long nativeBuilder, boolean luminanceScaling);
-    private static native void nBuilderGamutMapping(long nativeBuilder, boolean gamutMapping);
-    private static native void nBuilderExposure(long nativeBuilder, float exposure);
-    private static native void nBuilderNightAdaptation(long nativeBuilder, float adaptation);
+    private static native void nBuilderToneMapping(long nativeBuilder, int toneMapper);
     private static native void nBuilderWhiteBalance(long nativeBuilder, float temperature, float tint);
     private static native void nBuilderChannelMixer(long nativeBuilder, float[] outRed, float[] outGreen, float[] outBlue);
     private static native void nBuilderShadowsMidtonesHighlights(long nativeBuilder, float[] shadows, float[] midtones, float[] highlights, float[] ranges);

android/filament-android/src/main/java/com/google/android/filament/Engine.java

@@ -47,7 +47,7 @@ import com.google.android.filament.proguard.UsedByReflection;
  * <pre>
  * import com.google.android.filament.*
  *
- * Engine engine        = Engine.create();
+ * Engin engine         = Engine.create();
  * SwapChain swapChain  = engine.createSwapChain(nativeWindow);
  * Renderer renderer    = engine.createRenderer();
  * Scene scene          = engine.createScene();
@@ -106,15 +106,10 @@ import com.google.android.filament.proguard.UsedByReflection;
  * @see Renderer
  */
 public class Engine {
-    private static final Backend[] sBackendValues = Backend.values();
-    private static final FeatureLevel[] sFeatureLevelValues = FeatureLevel.values();
-
     private long mNativeObject;
-
     @NonNull private final TransformManager mTransformManager;
     @NonNull private final LightManager mLightManager;
     @NonNull private final RenderableManager mRenderableManager;
-    @NonNull private final EntityManager mEntityManager;
 
     /**
      * Denotes a backend
@@ -142,24 +137,11 @@ public class Engine {
         NOOP,
     }
 
-    /**
-     * Defines the backend's feature levels.
-     */
-    public enum FeatureLevel {
-        /** Reserved, don't use */
-        FEATURE_LEVEL_0,
-        /** OpenGL ES 3.0 features (default) */
-        FEATURE_LEVEL_1,
-        /** OpenGL ES 3.1 features + 31 textures units + cubemap arrays */
-        FEATURE_LEVEL_2
-    };
-
     private Engine(long nativeEngine) {
         mNativeObject = nativeEngine;
         mTransformManager = new TransformManager(nGetTransformManager(nativeEngine));
         mLightManager = new LightManager(nGetLightManager(nativeEngine));
         mRenderableManager = new RenderableManager(nGetRenderableManager(nativeEngine));
-        mEntityManager = new EntityManager(nGetEntityManager(nativeEngine));
     }
 
     /**
@@ -268,91 +250,9 @@ public class Engine {
      */
     @NonNull
     public Backend getBackend() {
-        return sBackendValues[(int) nGetBackend(getNativeObject())];
+        return Backend.values()[(int) nGetBackend(getNativeObject())];
     }
 
-    /**
-     * Helper to enable accurate translations.
-     * If you need this Engine to handle a very large world space, one way to achieve this
-     * automatically is to enable accurate translations in the TransformManager. This helper
-     * provides a convenient way of doing that.
-     * This is typically called once just after creating the Engine.
-     */
-    public void enableAccurateTranslations() {
-        getTransformManager().setAccurateTranslationsEnabled(true);
-    }
-
-    /**
-     * Query the feature level supported by the selected backend.
-     *
-     * A specific feature level needs to be set before the corresponding features can be used.
-     *
-     * @return FeatureLevel supported the selected backend.
-     * @see #setActiveFeatureLevel
-     */
-    @NonNull
-    public FeatureLevel getSupportedFeatureLevel() {
-        return sFeatureLevelValues[(int) nGetSupportedFeatureLevel(getNativeObject())];
-    }
-
-    /**
-     * Activate all features of a given feature level. By default FeatureLevel::FEATURE_LEVEL_1 is
-     * active. The selected feature level must not be higher than the value returned by
-     * getActiveFeatureLevel() and it's not possible lower the active feature level.
-     *
-     * @param featureLevel the feature level to activate. If featureLevel is lower than
-     *                     getActiveFeatureLevel(), the current (higher) feature level is kept.
-     *                     If featureLevel is higher than getSupportedFeatureLevel(), an exception
-     *                     is thrown, or the program is terminated if exceptions are disabled.
-     *
-     * @return the active feature level.
-     *
-     * @see #getSupportedFeatureLevel
-     * @see #getActiveFeatureLevel
-     */
-    @NonNull
-    public FeatureLevel setActiveFeatureLevel(@NonNull FeatureLevel featureLevel) {
-        return sFeatureLevelValues[(int) nSetActiveFeatureLevel(getNativeObject(), featureLevel.ordinal())];
-    }
-
-    /**
-     * Returns the currently active feature level.
-     * @return currently active feature level
-     * @see #getSupportedFeatureLevel
-     * @see #setActiveFeatureLevel
-     */
-    @NonNull
-    public FeatureLevel getActiveFeatureLevel() {
-        return sFeatureLevelValues[(int) nGetActiveFeatureLevel(getNativeObject())];
-    }
-
-    /**
-     * Enables or disables automatic instancing of render primitives. Instancing of render primitive
-     * can greatly reduce CPU overhead but requires the instanced primitives to be identical
-     * (i.e. use the same geometry) and use the same MaterialInstance. If it is known that the
-     * scene doesn't contain any identical primitives, automatic instancing can have some
-     * overhead and it is then best to disable it.
-     *
-     * Disabled by default.
-     *
-     * @param enable true to enable, false to disable automatic instancing.
-     *
-     * @see RenderableManager
-     * @see MaterialInstance
-     */
-    public void setAutomaticInstancingEnabled(boolean enable) {
-        nSetAutomaticInstancingEnabled(getNativeObject(), enable);
-    }
-
-    /**
-     * @return true if automatic instancing is enabled, false otherwise.
-     * @see #setAutomaticInstancingEnabled
-     */
-    public boolean isAutomaticInstancingEnabled() {
-        return nIsAutomaticInstancingEnabled(getNativeObject());
-    }
-
-
     // SwapChain
 
     /**
@@ -497,6 +397,19 @@ public class Engine {
 
     // Camera
 
+    /**
+     * Creates a new <code>entity</code> and adds a {@link Camera} component to it.
+     *
+     * @return A newly created {@link Camera}
+     * @exception IllegalStateException can be thrown if the {@link Camera} couldn't be created
+     */
+    @NonNull
+    public Camera createCamera() {
+        long nativeCamera = nCreateCamera(getNativeObject());
+        if (nativeCamera == 0) throw new IllegalStateException("Couldn't create Camera");
+        return new Camera(nativeCamera);
+    }
+
     /**
      * Creates and adds a {@link Camera} component to a given <code>entity</code>.
      *
@@ -506,9 +419,9 @@ public class Engine {
      */
     @NonNull
     public Camera createCamera(@Entity int entity) {
-        long nativeCamera = nCreateCamera(getNativeObject(), entity);
+        long nativeCamera = nCreateCameraWithEntity(getNativeObject(), entity);
         if (nativeCamera == 0) throw new IllegalStateException("Couldn't create Camera");
-        return new Camera(nativeCamera, entity);
+        return new Camera(nativeCamera);
     }
 
     /**
@@ -522,16 +435,16 @@ public class Engine {
     public Camera getCameraComponent(@Entity int entity) {
         long nativeCamera = nGetCameraComponent(getNativeObject(), entity);
         if (nativeCamera == 0) return null;
-        return new Camera(nativeCamera, entity);
+        return new Camera(nativeCamera);
     }
 
     /**
-     * Destroys the {@link Camera} component associated with the given entity.
-     *
-     * @param entity an entity
+     * Destroys a {@link Camera} component and frees all its associated resources.
+     * @param camera the {@link Camera} to destroy
      */
-    public void destroyCameraComponent(@Entity int entity) {
-        nDestroyCameraComponent(getNativeObject(), entity);
+    public void destroyCamera(@NonNull Camera camera) {
+        nDestroyCamera(getNativeObject(), camera.getNativeObject());
+        camera.clearNativeObject();
     }
 
     // Scene
@@ -611,15 +524,6 @@ public class Engine {
         vertexBuffer.clearNativeObject();
     }
 
-    /**
-     * Destroys a {@link SkinningBuffer} and frees all its associated resources.
-     * @param skinningBuffer the {@link SkinningBuffer} to destroy
-     */
-    public void destroySkinningBuffer(@NonNull SkinningBuffer skinningBuffer) {
-        assertDestroy(nDestroySkinningBuffer(getNativeObject(), skinningBuffer.getNativeObject()));
-        skinningBuffer.clearNativeObject();
-    }
-
     /**
      * Destroys a {@link IndirectLight} and frees all its associated resources.
      * @param ibl the {@link IndirectLight} to destroy
@@ -664,7 +568,7 @@ public class Engine {
      * Destroys a {@link ColorGrading} and frees all its associated resources.
      * @param colorGrading the {@link ColorGrading} to destroy
      */
-    public void destroyColorGrading(@NonNull ColorGrading colorGrading) {
+    public void destroySkybox(@NonNull ColorGrading colorGrading) {
         assertDestroy(nDestroyColorGrading(getNativeObject(), colorGrading.getNativeObject()));
         colorGrading.clearNativeObject();
     }
@@ -688,11 +592,8 @@ public class Engine {
     }
 
     /**
-     * Destroys all Filament-known components from this <code>entity</code>.
+     * Destroys an <code>entity</code> and all its components.
      * <p>
-     * This method destroys Filament components only, not the <code>entity</code> itself. To destroy
-     * the <code>entity</code> use <code>EntityManager#destroy</code>.
-     *
      * It is recommended to destroy components individually before destroying their
      * <code>entity</code>, this gives more control as to when the destruction really happens.
      * Otherwise, orphaned components are garbage collected, which can happen at a later time.
@@ -731,17 +632,9 @@ public class Engine {
         return mRenderableManager;
     }
 
-    /**
-     * @return the {@link EntityManager} used by this {@link Engine}
-     */
-    @NonNull
-    public EntityManager getEntityManager() {
-        return mEntityManager;
-    }
-
     /**
      * Kicks the hardware thread (e.g.: the OpenGL, Vulkan or Metal thread) and blocks until
-     * all commands to this point are executed. Note that this does guarantee that the
+     * all commands to this point are executed. Note that this doesn't guarantee that the
      * hardware is actually finished.
      *
      * <p>This is typically used right after destroying the <code>SwapChain</code>,
@@ -761,21 +654,13 @@ public class Engine {
         return mNativeObject;
     }
 
-    @UsedByReflection("MaterialBuilder.java")
-    public long getNativeJobSystem() {
-        if (mNativeObject == 0) {
-            throw new IllegalStateException("Calling method on destroyed Engine");
-        }
-        return nGetJobSystem(getNativeObject());
-    }
-
     private void clearNativeObject() {
         mNativeObject = 0;
     }
 
     private static void assertDestroy(boolean success) {
         if (!success) {
-            throw new IllegalStateException("Object couldn't be destroyed (double destroy()?)");
+            throw new IllegalStateException("Object couldn't be destoyed (double destroy()?)");
         }
     }
 
@@ -790,9 +675,10 @@ public class Engine {
     private static native boolean nDestroyView(long nativeEngine, long nativeView);
     private static native long nCreateRenderer(long nativeEngine);
     private static native boolean nDestroyRenderer(long nativeEngine, long nativeRenderer);
-    private static native long nCreateCamera(long nativeEngine, int entity);
+    private static native long nCreateCamera(long nativeEngine);
+    private static native long nCreateCameraWithEntity(long nativeEngine, int entity);
     private static native long nGetCameraComponent(long nativeEngine, int entity);
-    private static native void nDestroyCameraComponent(long nativeEngine, int entity);
+    private static native void nDestroyCamera(long nativeEngine, long nativeCamera);
     private static native long nCreateScene(long nativeEngine);
     private static native boolean nDestroyScene(long nativeEngine, long nativeScene);
     private static native long nCreateFence(long nativeEngine);
@@ -800,7 +686,6 @@ public class Engine {
     private static native boolean nDestroyStream(long nativeEngine, long nativeStream);
     private static native boolean nDestroyIndexBuffer(long nativeEngine, long nativeIndexBuffer);
     private static native boolean nDestroyVertexBuffer(long nativeEngine, long nativeVertexBuffer);
-    private static native boolean nDestroySkinningBuffer(long nativeEngine, long nativeSkinningBuffer);
     private static native boolean nDestroyIndirectLight(long nativeEngine, long nativeIndirectLight);
     private static native boolean nDestroyMaterial(long nativeEngine, long nativeMaterial);
     private static native boolean nDestroyMaterialInstance(long nativeEngine, long nativeMaterialInstance);
@@ -813,11 +698,4 @@ public class Engine {
     private static native long nGetTransformManager(long nativeEngine);
     private static native long nGetLightManager(long nativeEngine);
     private static native long nGetRenderableManager(long nativeEngine);
-    private static native long nGetJobSystem(long nativeEngine);
-    private static native long nGetEntityManager(long nativeEngine);
-    private static native void nSetAutomaticInstancingEnabled(long nativeEngine, boolean enable);
-    private static native boolean nIsAutomaticInstancingEnabled(long nativeEngine);
-    private static native int nGetSupportedFeatureLevel(long nativeEngine);
-    private static native int nSetActiveFeatureLevel(long nativeEngine, int ordinal);
-    private static native int nGetActiveFeatureLevel(long nativeEngine);
 }

android/filament-android/src/main/java/com/google/android/filament/EntityManager.java

@@ -31,10 +31,6 @@ public class EntityManager {
     private EntityManager() {
     }
 
-    EntityManager(long nativeEntityManager) {
-        mNativeObject = nativeEntityManager;
-    }
-
     @NonNull
     public static EntityManager get() {
         return Holder.INSTANCE;

android/filament-android/src/main/java/com/google/android/filament/IndirectLight.java

@@ -21,6 +21,8 @@ import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 import androidx.annotation.Size;
 
+import com.google.android.filament.proguard.UsedByReflection;
+
 /**
  * <code>IndirectLight</code> is used to simulate environment lighting, a form of global illumination.
  *
@@ -84,7 +86,11 @@ import androidx.annotation.Size;
 public class IndirectLight {
     long mNativeObject;
 
-    public IndirectLight(long indirectLight) {
+    public IndirectLight(Engine engine, long indirectLight) {
+        mNativeObject = indirectLight;
+    }
+
+    IndirectLight(long indirectLight) {
         mNativeObject = indirectLight;
     }
 
@@ -282,7 +288,7 @@ public class IndirectLight {
          * range can be adjusted with this method.</p>
          *
          * @param envIntensity  Scale factor applied to the environment and irradiance such that
-         *                      the result is in <i>lux</i>, or <i>lumen/m^2</i> (default = 30000)
+         *                      the result is in cd/m^2 (lux) units (default = 30000)
          *
          * @return This Builder, for chaining calls.
          */
@@ -348,14 +354,14 @@ public class IndirectLight {
      * range can be adjusted with this method.</p>
      *
      * @param intensity  Scale factor applied to the environment and irradiance such that
-     *                   the result is in <i>lux</i>, or <i>lumen/m^2</i> (default = 30000)
+     *                   the result is in cd/m^2 units (default = 30000)
      */
     public void setIntensity(float intensity) {
         nSetIntensity(getNativeObject(), intensity);
     }
 
     /**
-     * Returns the environment's intensity in <i>lux</i>, or <i>lumen/m^2</i>.
+     * Returns the environment's intensity in cd/m<sup>2</sup>.
      */
     public float getIntensity() {
         return nGetIntensity(getNativeObject());
@@ -424,7 +430,6 @@ public class IndirectLight {
     }
 
     /** @deprecated */
-    @Deprecated
     @NonNull @Size(min = 3)
     public float[] getDirectionEstimate(@Nullable @Size(min = 3) float[] direction) {
         direction = Asserts.assertFloat3(direction);
@@ -467,7 +472,6 @@ public class IndirectLight {
 
 
     /** @deprecated */
-    @Deprecated
     @NonNull @Size(min = 4)
     public float[] getColorEstimate(@Nullable @Size(min = 4) float[] colorIntensity, float x, float y, float z) {
         colorIntensity = Asserts.assertFloat4(colorIntensity);

android/filament-android/src/main/java/com/google/android/filament/LightManager.java

@@ -117,8 +117,6 @@ import androidx.annotation.Size;
  * </ul>
  */
 public class LightManager {
-    private static final Type[] sTypeValues = Type.values();
-
     private long mNativeObject;
 
     LightManager(long nativeLightManager) {
@@ -190,7 +188,7 @@ public class LightManager {
      * Control the quality / performance of the shadow map associated to this light
      */
     public static class ShadowOptions {
-        /** Size of the shadow map in texels. Must be a power-of-two and larger or equal to 8. */
+        /** Size of the shadow map in texels. Must be a power-of-two. */
         public int mapSize = 1024;
 
         /**
@@ -240,21 +238,19 @@ public class LightManager {
          */
         @NonNull
         @Size(min = 3)
-        public float[] cascadeSplitPositions = { 0.125f, 0.25f, 0.50f };
+        public float[] cascadeSplitPositions = { 0.25f, 0.50f, 0.75f };
 
         /** Constant bias in world units (e.g. meters) by which shadows are moved away from the
          * light. 1mm by default.
-         * This is ignored when the View's ShadowType is set to VSM.
          */
-        public float constantBias = 0.001f;
+        public float constantBias = 0.05f;
 
         /** Amount by which the maximum sampling error is scaled. The resulting value is used
          * to move the shadow away from the fragment normal. Should be 1.0.
-         * This is ignored when the View's ShadowType is set to VSM.
          */
-        public float normalBias = 1.0f;
+        public float normalBias = 0.4f;
 
-        /** Distance from the camera after which shadows are clipped. This is used to clip
+        /** Distance from the camera after which shadows are clipped. this is used to clip
          * shadows that are too far and wouldn't contribute to the scene much, improving
          * performance and quality. This value is always positive.
          * Use 0.0f to use the camera far distance.
@@ -280,41 +276,8 @@ public class LightManager {
          * Controls whether the shadow map should be optimized for resolution or stability.
          * When set to true, all resolution enhancing features that can affect stability are
          * disabling, resulting in significantly lower resolution shadows, albeit stable ones.
-         *
-         * Setting this flag to true always disables LiSPSM (see below).
          */
-        public boolean stable = false;
-
-        /**
-         * LiSPSM, or light-space perspective shadow-mapping is a technique allowing to better
-         * optimize the use of the shadow-map texture. When enabled the effective resolution of
-         * shadows is greatly improved and yields result similar to using cascades without the
-         * extra cost. LiSPSM comes with some drawbacks however, in particular it is incompatible
-         * with blurring because it effectively affects the blur kernel size.
-         *
-         * Blurring is only an issue when using ShadowType.VSM with a large blur or with
-         * ShadowType.PCSS however.
-         *
-         * If these blurring artifacts become problematic, this flag can be used to disable LiSPSM.
-         */
-        public boolean lispsm = false;
-
-        /**
-         * Constant bias in depth-resolution units by which shadows are moved away from the
-         * light. The default value of 0.5 is used to round depth values up.
-         * Generally this value shouldn't be changed or at least be small and positive.
-         * This is ignored when the View's ShadowType is set to VSM.
-         */
-        float polygonOffsetConstant = 0.5f;
-
-        /**
-         * Bias based on the change in depth in depth-resolution units by which shadows are moved
-         * away from the light. The default value of 2.0 works well with SHADOW_SAMPLING_PCF_LOW.
-         * Generally this value is between 0.5 and the size in texel of the PCF filter.
-         * Setting this value correctly is essential for LISPSM shadow-maps.
-         * This is ignored when the View's ShadowType is set to VSM.
-         */
-        float polygonOffsetSlope = 2.0f;
+        public boolean stable = true;
 
         /**
          * Whether screen-space contact shadows are used. This applies regardless of whether a
@@ -342,46 +305,6 @@ public class LightManager {
          *</p>
          */
         public float maxShadowDistance = 0.3f;
-
-        /*
-         * Options prefixed with 'vsm' are available when the View's ShadowType is set to VSM.
-         *
-         * @see View#setShadowType
-         */
-
-        /**
-         * The number of MSAA samples to use when rendering VSM shadow maps.
-         * Must be a power-of-two and greater than or equal to 1. A value of 1 effectively turns
-         * off MSAA.
-         * Higher values may not be available depending on the underlying hardware.
-         *
-         * <p>
-         * <strong>Warning: This API is still experimental and subject to change.</strong>
-         * </p>
-         */
-        @IntRange(from = 1)
-        public int vsmMsaaSamples = 1;
-
-
-        /**
-         * When elvsm is set to true, "Exponential Layered VSM without Layers" are used. It is
-         * an improvement to the default EVSM which suffers important light leaks. Enabling
-         * ELVSM for a single shadowmap doubles the memory usage of all shadow maps.
-         * ELVSM is mostly useful when large blurs are used.
-         */
-        public boolean elvsm = false;
-
-        /**
-         * Blur width for the VSM blur. Zero do disable.
-         * The maximum value is 125.
-         */
-        public float blurWidth = 0.0f;
-
-        /**
-         * Light bulb radius used for soft shadows. Currently this is only used when DPCF is
-         * enabled. (2cm by default).
-         */
-        public float shadowBulbRadius = 0.02f;
     }
 
     public static class ShadowCascades {
@@ -480,21 +403,14 @@ public class LightManager {
             mFinalizer = new BuilderFinalizer(mNativeBuilder);
         }
 
-        /**
-         * Enables or disables a light channel. Light channel 0 is enabled by default.
-         *
-         * @param channel Light channel to enable or disable, between 0 and 7.
-         * @param enable Whether to enable or disable the light channel.
-         */
-        @NonNull
-        public Builder lightChannel(@IntRange(from = 0, to = 7) int channel, boolean enable) {
-            nBuilderLightChannel(mNativeBuilder, channel, enable);
-            return this;
-        }
-
         /**
          * Whether this Light casts shadows (disabled by default)
          *
+         * <p>
+         * <b>warning:</b>
+         *  {@link Type#POINT} lights cannot cast shadows.
+         * </p>
+         *
          * @param enable Enables or disables casting shadows from this Light.
          *
          * @return This Builder, for chaining calls.
@@ -516,11 +432,8 @@ public class LightManager {
             nBuilderShadowOptions(mNativeBuilder,
                     options.mapSize, options.shadowCascades, options.cascadeSplitPositions,
                     options.constantBias, options.normalBias, options.shadowFar, options.shadowNearHint,
-                    options.shadowFarHint, options.stable, options.lispsm,
-                    options.polygonOffsetConstant, options.polygonOffsetSlope,
-                    options.screenSpaceContactShadows,
-                    options.stepCount, options.maxShadowDistance, options.vsmMsaaSamples,
-                    options.elvsm, options.blurWidth, options.shadowBulbRadius);
+                    options.shadowFarHint, options.stable, options.screenSpaceContactShadows,
+                    options.stepCount, options.maxShadowDistance);
             return this;
         }
 
@@ -809,7 +722,7 @@ public class LightManager {
 
     @NonNull
     public Type getType(@EntityInstance int i) {
-        return sTypeValues[nGetType(mNativeObject, i)];
+        return Type.values()[nGetType(mNativeObject, i)];
     }
 
     /**
@@ -844,30 +757,6 @@ public class LightManager {
         return type == Type.SPOT || type == Type.FOCUSED_SPOT;
     }
 
-    /**
-     * Enables or disables a light channel.
-     * Light channel 0 is enabled by default.
-     *
-     * @param i        Instance of the component obtained from getInstance().
-     * @param channel  Light channel to set
-     * @param enable   true to enable, false to disable
-     *
-     * @see Builder#lightChannel
-     */
-    public void setLightChannel(@EntityInstance int i, @IntRange(from = 0, to = 7) int channel, boolean enable) {
-        nSetLightChannel(mNativeObject, i, channel, enable);
-    }
-
-    /**
-     * Returns whether a light channel is enabled on a specified renderable.
-     * @param i        Instance of the component obtained from getInstance().
-     * @param channel  Light channel to query
-     * @return         true if the light channel is enabled, false otherwise
-     */
-    public boolean getLightChannel(@EntityInstance int i, @IntRange(from = 0, to = 7) int channel) {
-        return nGetLightChannel(mNativeObject, i, channel);
-    }
-
     /**
      * Dynamically updates the light's position.
      *
@@ -1157,14 +1046,6 @@ public class LightManager {
         return nIsShadowCaster(mNativeObject, i);
     }
 
-    public float getOuterConeAngle(@EntityInstance int i) {
-        return nGetOuterConeAngle(mNativeObject, i);
-    }
-
-    public float getInnerConeAngle(@EntityInstance int i) {
-        return nGetInnerConeAngle(mNativeObject, i);
-    }
-
     public long getNativeObject() {
         return mNativeObject;
     }
@@ -1178,14 +1059,7 @@ public class LightManager {
     private static native void nDestroyBuilder(long nativeBuilder);
     private static native boolean nBuilderBuild(long nativeBuilder, long nativeEngine, int entity);
     private static native void nBuilderCastShadows(long nativeBuilder, boolean enable);
-    private static native void nBuilderShadowOptions(long nativeBuilder, int mapSize,
-            int cascades, float[] splitPositions,
-             float constantBias, float normalBias,
-             float shadowFar, float shadowNearHint, float shadowFarhint,
-             boolean stable, boolean lispsm,
-             float polygonOffsetConstant, float polygonOffsetSlope,
-             boolean screenSpaceContactShadows, int stepCount, float maxShadowDistance,
-             int vsmMsaaSamples, boolean elvsm, float blurWidth, float shadowBulbRadius);
+    private static native void nBuilderShadowOptions(long nativeBuilder, int mapSize, int cascades, float[] splitPositions, float constantBias, float normalBias, float shadowFar, float shadowNearHint, float shadowFarhint, boolean stable, boolean screenSpaceContactShadows, int stepCount, float maxShadowDistance);
     private static native void nBuilderCastLight(long nativeBuilder, boolean enabled);
     private static native void nBuilderPosition(long nativeBuilder, float x, float y, float z);
     private static native void nBuilderDirection(long nativeBuilder, float x, float y, float z);
@@ -1198,7 +1072,6 @@ public class LightManager {
     private static native void nBuilderAngularRadius(long nativeBuilder, float angularRadius);
     private static native void nBuilderHaloSize(long nativeBuilder, float haloSize);
     private static native void nBuilderHaloFalloff(long nativeBuilder, float haloFalloff);
-    private static native void nBuilderLightChannel(long nativeBuilder, int channel, boolean enable);
 
     private static native void nComputeUniformSplits(float[] splitPositions, int cascades);
     private static native void nComputeLogSplits(float[] splitPositions, int cascades, float near, float far);
@@ -1226,8 +1099,4 @@ public class LightManager {
     private static native float nGetSunHaloFalloff(long nativeLightManager, int i);
     private static native void nSetShadowCaster(long nativeLightManager, int i, boolean shadowCaster);
     private static native boolean nIsShadowCaster(long nativeLightManager, int i);
-    private static native float nGetOuterConeAngle(long nativeLightManager, int i);
-    private static native float nGetInnerConeAngle(long nativeLightManager, int i);
-    private static native void nSetLightChannel(long nativeLightManager, int i, int channel, boolean enable);
-    private static native boolean nGetLightChannel(long nativeLightManager, int i, int channel);
 }

android/filament-android/src/main/java/com/google/android/filament/Material.java

@@ -36,22 +36,7 @@ import java.util.Set;
  *
  * @see <a href="https://google.github.io/filament/Materials.html">Filament Materials Guide</a>
  */
-@UsedByNative("AssetLoader.cpp")
 public class Material {
-    static final class EnumCache {
-        private EnumCache() { }
-
-        static final Shading[] sShadingValues = Shading.values();
-        static final Interpolation[] sInterpolationValues = Interpolation.values();
-        static final BlendingMode[] sBlendingModeValues = BlendingMode.values();
-        static final RefractionMode[] sRefractionModeValues = RefractionMode.values();
-        static final RefractionType[] sRefractionTypeValues = RefractionType.values();
-        static final VertexDomain[] sVertexDomainValues = VertexDomain.values();
-        static final CullingMode[] sCullingModeValues = CullingMode.values();
-        static final VertexBuffer.VertexAttribute[] sVertexAttributeValues =
-                VertexBuffer.VertexAttribute.values();
-    }
-
     private long mNativeObject;
     private final MaterialInstance mDefaultInstance;
 
@@ -225,8 +210,6 @@ public class Material {
 
     @UsedByNative("Material.cpp")
     public static class Parameter {
-        private static final Type[] sTypeValues = Type.values();
-
         public enum Type {
             BOOL,
             BOOL2,
@@ -250,8 +233,7 @@ public class Material {
             SAMPLER_2D_ARRAY,
             SAMPLER_CUBEMAP,
             SAMPLER_EXTERNAL,
-            SAMPLER_3D,
-            SUBPASS_INPUT
+            SAMPLER_3D
         }
 
         public enum Precision {
@@ -265,10 +247,6 @@ public class Material {
         @UsedByNative("Material.cpp")
         private static final int SAMPLER_OFFSET = Type.MAT4.ordinal() + 1;
 
-        @SuppressWarnings("unused")
-        @UsedByNative("Material.cpp")
-        private static final int SUBPASS_OFFSET = Type.SAMPLER_3D.ordinal() + 1;
-
         @NonNull
         public final String name;
         @NonNull
@@ -292,11 +270,11 @@ public class Material {
                 @IntRange(from = 0) int type, @IntRange(from = 0) int precision,
                 @IntRange(from = 1) int count) {
             parameters.add(
-                    new Parameter(name, sTypeValues[type], Precision.values()[precision], count));
+                    new Parameter(name, Type.values()[type], Precision.values()[precision], count));
         }
     }
 
-    public Material(long nativeMaterial) {
+    Material(long nativeMaterial) {
         mNativeObject = nativeMaterial;
         long nativeDefaultInstance = nGetDefaultInstance(nativeMaterial);
         mDefaultInstance = new MaterialInstance(this, nativeDefaultInstance);
@@ -390,7 +368,7 @@ public class Material {
      * Material Models</a>
      */
     public Shading getShading() {
-        return EnumCache.sShadingValues[nGetShading(getNativeObject())];
+        return Shading.values()[nGetShading(getNativeObject())];
     }
 
     /**
@@ -401,7 +379,7 @@ public class Material {
      * Vertex and attributes: interpolation</a>
      */
     public Interpolation getInterpolation() {
-        return EnumCache.sInterpolationValues[nGetInterpolation(getNativeObject())];
+        return Interpolation.values()[nGetInterpolation(getNativeObject())];
     }
 
     /**
@@ -412,7 +390,7 @@ public class Material {
      * Blending and transparency: blending</a>
      */
     public BlendingMode getBlendingMode() {
-        return EnumCache.sBlendingModeValues[nGetBlendingMode(getNativeObject())];
+        return BlendingMode.values()[nGetBlendingMode(getNativeObject())];
     }
 
     /**
@@ -423,7 +401,7 @@ public class Material {
      * Blending and transparency: refraction</a>
      */
     public RefractionMode getRefractionMode() {
-        return EnumCache.sRefractionModeValues[nGetRefractionMode(getNativeObject())];
+        return RefractionMode.values()[nGetRefractionMode(getNativeObject())];
     }
 
     /**
@@ -434,9 +412,10 @@ public class Material {
      * Blending and transparency: refractionType</a>
      */
     public RefractionType getRefractionType() {
-        return EnumCache.sRefractionTypeValues[nGetRefractionType(getNativeObject())];
+        return RefractionType.values()[nGetRefractionType(getNativeObject())];
     }
 
+
     /**
      * Returns the vertex domain of this material.
      *
@@ -445,7 +424,7 @@ public class Material {
      * Vertex and attributes: vertexDomain</a>
      */
     public VertexDomain getVertexDomain() {
-        return EnumCache.sVertexDomainValues[nGetVertexDomain(getNativeObject())];
+        return VertexDomain.values()[nGetVertexDomain(getNativeObject())];
     }
 
     /**
@@ -456,7 +435,7 @@ public class Material {
      * Rasterization: culling</a>
      */
     public CullingMode getCullingMode() {
-        return EnumCache.sCullingModeValues[nGetCullingMode(getNativeObject())];
+        return CullingMode.values()[nGetCullingMode(getNativeObject())];
     }
 
     /**
@@ -547,7 +526,7 @@ public class Material {
         if (mRequiredAttributes == null) {
             int bitSet = nGetRequiredAttributes(getNativeObject());
             mRequiredAttributes = EnumSet.noneOf(VertexBuffer.VertexAttribute.class);
-            VertexBuffer.VertexAttribute[] values = EnumCache.sVertexAttributeValues;
+            VertexBuffer.VertexAttribute[] values = VertexBuffer.VertexAttribute.values();
             for (int i = 0; i < values.length; i++) {
                 if ((bitSet & (1 << i)) != 0) {
                     mRequiredAttributes.add(values[i]);
@@ -776,7 +755,7 @@ public class Material {
      * @param name   name of the parameter array as defined by this Material
      * @param type   the number of components for each individual parameter
      * @param v      array of values to set to the named parameter array
-     * @param offset the number of elements in <code>v</code> to skip
+     * @param offset the number of elements to skip
      * @param count  the number of elements in the parameter array to set
      *
      * <p>For example, to set a parameter array of 4 bool4s:
@@ -784,6 +763,11 @@ public class Material {
      *     boolean[] a = new boolean[4 * 4];
      *     material.setDefaultParameter("param", MaterialInstance.BooleanElement.BOOL4, a, 0, 4);
      * }</pre>
+     * To only set the last 3 elements, specify an offset of 1 and a count of 3:
+     * <pre>{@code
+     *     boolean[] a = new boolean[4 * 3];
+     *     material.setDefaultParameter("param", MaterialInstance.BooleanElement.BOOL4, a, 1, 3);
+     * }</pre>
      * </p>
      *
      * @see Material#getDefaultInstance()
@@ -800,7 +784,7 @@ public class Material {
      * @param name   name of the parameter array as defined by this Material
      * @param type   the number of components for each individual parameter
      * @param v      array of values to set to the named parameter array
-     * @param offset the number of elements in <code>v</code> to skip
+     * @param offset the number of elements to skip
      * @param count  the number of elements in the parameter array to set
      *
      * <p>For example, to set a parameter array of 4 int4s:
@@ -808,6 +792,11 @@ public class Material {
      *     int[] a = new int[4 * 4];
      *     material.setDefaultParameter("param", MaterialInstance.IntElement.INT4, a, 0, 4);
      * }</pre>
+     * To only set the last 3 elements, specify an offset of 1 and a count of 3:
+     * <pre>{@code
+     *     int[] a = new int[4 * 3];
+     *     material.setDefaultParameter("param", MaterialInstance.IntElement.INT4, a, 1, 3);
+     * }</pre>
      * </p>
      *
      * @see Material#getDefaultInstance()
@@ -824,7 +813,7 @@ public class Material {
      * @param name   name of the parameter array as defined by this Material
      * @param type   the number of components for each individual parameter
      * @param v      array of values to set to the named parameter array
-     * @param offset the number of elements in <code>v</code> to skip
+     * @param offset the number of elements to skip
      * @param count  the number of elements in the parameter array to set
      *
      * <p>For example, to set a parameter array of 4 float4s:
@@ -832,6 +821,11 @@ public class Material {
      *     float[] a = new float[4 * 4];
      *     material.setDefaultParameter("param", MaterialInstance.FloatElement.FLOAT4, a, 0, 4);
      * }</pre>
+     * To only set the last 3 elements, specify an offset of 1 and a count of 3:
+     * <pre>{@code
+     *     float[] a = new float[4 * 3];
+     *     material.setDefaultParameter("param", MaterialInstance.FloatElement.FLOAT4, a, 1, 3);
+     * }</pre>
      * </p>
      *
      * @see Material#getDefaultInstance()

android/filament-android/src/main/java/com/google/android/filament/MaterialInstance.java

@@ -20,9 +20,6 @@ import androidx.annotation.IntRange;
 import androidx.annotation.NonNull;
 import androidx.annotation.Size;
 
-import com.google.android.filament.proguard.UsedByNative;
-
-@UsedByNative("AssetLoader.cpp")
 public class MaterialInstance {
     private Material mMaterial;
     private String mName;
@@ -52,54 +49,6 @@ public class MaterialInstance {
         MAT4
     }
 
-    /**
-     * Operations that control how the stencil buffer is updated.
-     */
-    public enum StencilOperation {
-        /**
-         * Keeps the current value.
-         */
-        KEEP,
-        /**
-         * Sets the value to 0.
-         */
-        ZERO,
-        /**
-         * Sets the value to the stencil reference value.
-         */
-        REPLACE,
-        /**
-         * Increments the current value. Clamps to the maximum representable unsigned value.
-         */
-        INCR_CLAMP,
-        /**
-         * Increments the current value. Wraps value to zero when incrementing the maximum
-         * representable unsigned value.
-         */
-        INCR_WRAP,
-        /**
-         * Decrements the current value. Clamps to 0.
-         */
-        DECR_CLAMP,
-        /**
-         * Decrements the current value. Wraps value to the maximum representable unsigned value
-         * when decrementing a value of zero.
-         */
-        DECR_WRAP,
-        /**
-         * Bitwise inverts the current value.
-         */
-        INVERT,
-    }
-
-    public enum StencilFace {
-        FRONT,
-        BACK,
-        FRONT_AND_BACK
-    }
-    // Converts the StencilFace enum ordinal to Filament's equivalent bit field.
-    static final int[] sStencilFaceMapping = {0x1, 0x2, 0x3};
-
     public MaterialInstance(Engine engine, long nativeMaterialInstance) {
         mNativeObject = nativeMaterialInstance;
         mNativeMaterial = nGetMaterial(mNativeObject);
@@ -107,7 +56,6 @@ public class MaterialInstance {
 
     MaterialInstance(@NonNull Material material, long nativeMaterialInstance) {
         mMaterial = material;
-        mNativeMaterial = material.getNativeObject();
         mNativeObject = nativeMaterialInstance;
     }
 
@@ -116,22 +64,6 @@ public class MaterialInstance {
         mNativeMaterial = nGetMaterial(mNativeObject);
     }
 
-    /**
-     * Creates a new {@link #MaterialInstance} using another {@link #MaterialInstance} as a template for initialization.
-     * The new {@link #MaterialInstance} is an instance of the same {@link Material} of the template instance and
-     * must be destroyed just like any other {@link #MaterialInstance}.
-     *
-     * @param other A {@link #MaterialInstance} to use as a template for initializing a new instance
-     * @param name  A name for the new {@link #MaterialInstance} or nullptr to use the template's name
-     * @return      A new {@link #MaterialInstance}
-     */
-    @NonNull
-    public static MaterialInstance duplicate(@NonNull MaterialInstance other, String name) {
-        long nativeInstance = nDuplicate(other.mNativeObject, name);
-        if (nativeInstance == 0) throw new IllegalStateException("Couldn't duplicate MaterialInstance");
-        return new MaterialInstance(other.getMaterial(), nativeInstance);
-    }
-
     /** @return the {@link Material} associated with this instance */
     @NonNull
     public Material getMaterial() {
@@ -290,10 +222,6 @@ public class MaterialInstance {
 
     /**
      * Sets a texture and sampler parameter on this material's default instance.
-     * <p>
-     * Note: Depth textures can't be sampled with a linear filter unless the comparison mode is set
-     *       to COMPARE_TO_TEXTURE.
-     * </p>
      *
      * @param name The name of the material texture parameter
      * @param texture The texture to set as parameter
@@ -310,7 +238,7 @@ public class MaterialInstance {
      * @param name   name of the parameter array as defined by this Material
      * @param type   the number of components for each individual parameter
      * @param v      array of values to set to the named parameter array
-     * @param offset the number of elements in <code>v</code> to skip
+     * @param offset the number of elements to skip
      * @param count  the number of elements in the parameter array to set
      *
      * <p>For example, to set a parameter array of 4 bool4s:
@@ -318,6 +246,11 @@ public class MaterialInstance {
      *     boolean[] a = new boolean[4 * 4];
      *     instance.setParameter("param", MaterialInstance.BooleanElement.BOOL4, a, 0, 4);
      * }</pre>
+     * To only set the last 3 elements, specify an offset of 1 and a count of 3:
+     * <pre>{@code
+     *     boolean[] a = new boolean[4 * 3];
+     *     instance.setParameter("param", MaterialInstance.BooleanElement.BOOL4, a, 1, 3);
+     * }</pre>
      * </p>
      */
     public void setParameter(@NonNull String name,
@@ -332,7 +265,7 @@ public class MaterialInstance {
      * @param name   name of the parameter array as defined by this Material
      * @param type   the number of components for each individual parameter
      * @param v      array of values to set to the named parameter array
-     * @param offset the number of elements in <code>v</code> to skip
+     * @param offset the number of elements to skip
      * @param count  the number of elements in the parameter array to set
      *
      * <p>For example, to set a parameter array of 4 int4s:
@@ -340,6 +273,11 @@ public class MaterialInstance {
      *     int[] a = new int[4 * 4];
      *     instance.setParameter("param", MaterialInstance.IntElement.INT4, a, 0, 4);
      * }</pre>
+     * To only set the last 3 elements, specify an offset of 1 and a count of 3:
+     * <pre>{@code
+     *     int[] a = new int[4 * 3];
+     *     instance.setParameter("param", MaterialInstance.IntElement.INT4, a, 1, 3);
+     * }</pre>
      * </p>
      */
     public void setParameter(@NonNull String name,
@@ -354,7 +292,7 @@ public class MaterialInstance {
      * @param name   name of the parameter array as defined by this Material
      * @param type   the number of components for each individual parameter
      * @param v      array of values to set to the named parameter array
-     * @param offset the number of elements in <code>v</code> to skip
+     * @param offset the number of elements to skip
      * @param count  the number of elements in the parameter array to set
      *
      * <p>For example, to set a parameter array of 4 float4s:
@@ -362,6 +300,11 @@ public class MaterialInstance {
      *     float[] a = new float[4 * 4];
      *     material.setDefaultParameter("param", MaterialInstance.FloatElement.FLOAT4, a, 0, 4);
      * }</pre>
+     * To only set the last 3 elements, specify an offset of 1 and a count of 3:
+     * <pre>{@code
+     *     float[] a = new float[4 * 3];
+     *     material.setDefaultParameter("param", MaterialInstance.FloatElement.FLOAT4, a, 1, 3);
+     * }</pre>
      * </p>
      */
     public void setParameter(@NonNull String name,
@@ -402,40 +345,19 @@ public class MaterialInstance {
     }
 
     /**
-     * Set-up a custom scissor rectangle; by default it is disabled.
+     * Set up a custom scissor rectangle; by default this encompasses the View.
      *
-     * <p>
-     * The scissor rectangle gets clipped by the View's viewport, in other words, the scissor
-     * cannot affect fragments outside of the View's Viewport.
-     * </p>
-     *
-     * <p>
-     * Currently the scissor is not compatible with dynamic resolution and should always be
-     * disabled when dynamic resolution is used.
-     * </p>
-     *
-     * @param left      left coordinate of the scissor box relative to the viewport
-     * @param bottom    bottom coordinate of the scissor box relative to the viewport
+     * @param left      left coordinate of the scissor box
+     * @param bottom    bottom coordinate of the scissor box
      * @param width     width of the scissor box
      * @param height    height of the scissor box
-     *
-     * @see #unsetScissor
-     * @see View#setViewport
-     * @see View#setDynamicResolutionOptions
      */
     public void setScissor(@IntRange(from = 0) int left, @IntRange(from = 0) int bottom,
             @IntRange(from = 0) int width, @IntRange(from = 0) int height) {
         nSetScissor(getNativeObject(), left, bottom, width, height);
     }
 
-    /**
-     * Returns the scissor rectangle to its default disabled setting.
-     * <p>
-     * Currently the scissor is not compatible with dynamic resolution and should always be
-     * disabled when dynamic resolution is used.
-     * </p>
-     * @see View#setDynamicResolutionOptions
-     */
+    /** Returns the scissor rectangle to its default setting, which encompasses the View. */
     public void unsetScissor() {
         nUnsetScissor(getNativeObject());
     }
@@ -530,7 +452,7 @@ public class MaterialInstance {
      * <a href="https://google.github.io/filament/Materials.html#materialdefinitions/materialblock/rasterization:colorWrite">
      * Rasterization: colorWrite</a>
      */
-    public void setColorWrite(boolean enable) {
+    void setColorWrite(boolean enable) {
         nSetColorWrite(getNativeObject(), enable);
     }
 
@@ -541,14 +463,10 @@ public class MaterialInstance {
      * <a href="https://google.github.io/filament/Materials.html#materialdefinitions/materialblock/rasterization:depthWrite">
      * Rasterization: depthWrite</a>
      */
-    public void setDepthWrite(boolean enable) {
+    void setDepthWrite(boolean enable) {
         nSetDepthWrite(getNativeObject(), enable);
     }
 
-    public void setStencilWrite(boolean enable) {
-        nSetStencilWrite(getNativeObject(), enable);
-    }
-
     /**
      * Overrides the default depth testing state that was set on the material.
      *
@@ -556,212 +474,10 @@ public class MaterialInstance {
      * <a href="https://google.github.io/filament/Materials.html#materialdefinitions/materialblock/rasterization:depthCulling">
      * Rasterization: depthCulling</a>
      */
-    public void setDepthCulling(boolean enable) {
+    void setDepthCulling(boolean enable) {
         nSetDepthCulling(getNativeObject(), enable);
     }
 
-    /**
-     * Sets the stencil comparison function (default is {@link TextureSampler.CompareFunction#ALWAYS}).
-     *
-     * <p>
-     * It's possible to set separate stencil comparison functions; one for front-facing polygons,
-     * and one for back-facing polygons. The face parameter determines the comparison function(s)
-     * updated by this call.
-     * </p>
-     *
-     * @param func the stencil comparison function
-     * @param face the faces to update the comparison function for
-     */
-    public void setStencilCompareFunction(TextureSampler.CompareFunction func, StencilFace face) {
-        nSetStencilCompareFunction(getNativeObject(), func.ordinal(),
-                sStencilFaceMapping[face.ordinal()]);
-    }
-
-    /**
-     * Sets the stencil comparison function for both front and back-facing polygons.
-     * @see #setStencilCompareFunction(TextureSampler.CompareFunction, StencilFace)
-     */
-    public void setStencilCompareFunction(TextureSampler.CompareFunction func) {
-        setStencilCompareFunction(func, StencilFace.FRONT_AND_BACK);
-    }
-
-    /**
-     * Sets the stencil fail operation (default is {@link StencilOperation#KEEP}).
-     *
-     * <p>
-     * The stencil fail operation is performed to update values in the stencil buffer when the
-     * stencil test fails.
-     * </p>
-     *
-     * <p>
-     * It's possible to set separate stencil fail operations; one for front-facing polygons, and one
-     * for back-facing polygons. The face parameter determines the stencil fail operation(s) updated
-     * by this call.
-     * </p>
-     *
-     * @param op the stencil fail operation
-     * @param face the faces to update the stencil fail operation for
-     */
-    public void setStencilOpStencilFail(StencilOperation op, StencilFace face) {
-        nSetStencilOpStencilFail(getNativeObject(), op.ordinal(),
-                sStencilFaceMapping[face.ordinal()]);
-    }
-
-    /**
-     * Sets the stencil fail operation for both front and back-facing polygons.
-     * @see #setStencilOpStencilFail(StencilOperation, StencilFace)
-     */
-    public void setStencilOpStencilFail(StencilOperation op) {
-        setStencilOpStencilFail(op, StencilFace.FRONT_AND_BACK);
-    }
-
-    /**
-     * Sets the depth fail operation (default is {@link StencilOperation#KEEP}).
-     *
-     * <p>
-     * The depth fail operation is performed to update values in the stencil buffer when the depth
-     * test fails.
-     * </p>
-     *
-     * <p>
-     * It's possible to set separate depth fail operations; one for front-facing polygons, and one
-     * for back-facing polygons. The face parameter determines the depth fail operation(s) updated
-     * by this call.
-     * </p>
-     *
-     * @param op the depth fail operation
-     * @param face the faces to update the depth fail operation for
-     */
-    public void setStencilOpDepthFail(StencilOperation op, StencilFace face) {
-        nSetStencilOpDepthFail(getNativeObject(), op.ordinal(),
-                sStencilFaceMapping[face.ordinal()]);
-    }
-
-    /**
-     * Sets the depth fail operation for both front and back-facing polygons.
-     * @see #setStencilOpDepthFail(StencilOperation, StencilFace)
-     */
-    public void setStencilOpDepthFail(StencilOperation op) {
-        setStencilOpDepthFail(op, StencilFace.FRONT_AND_BACK);
-    }
-
-    /**
-     * Sets the depth-stencil pass operation (default is {@link StencilOperation#KEEP}).
-     *
-     * <p>
-     * The depth-stencil pass operation is performed to update values in the stencil buffer when
-     * both the stencil test and depth test pass.
-     * </p>
-     *
-     * <p>
-     * It's possible to set separate depth-stencil pass operations; one for front-facing polygons,
-     * and one for back-facing polygons. The face parameter determines the depth-stencil pass
-     * operation(s) updated by this call.
-     * </p>
-     *
-     * @param op the depth-stencil pass operation
-     * @param face the faces to update the depth-stencil operation for
-     */
-    public void setStencilOpDepthStencilPass(StencilOperation op, StencilFace face) {
-        nSetStencilOpDepthStencilPass(getNativeObject(), op.ordinal(),
-                sStencilFaceMapping[face.ordinal()]);
-    }
-
-    /**
-     * Sets the depth-stencil pass operation for both front and back-facing polygons.
-     * @see #setStencilOpDepthStencilPass(StencilOperation, StencilFace)
-     */
-    public void setStencilOpDepthStencilPass(StencilOperation op) {
-        setStencilOpDepthStencilPass(op, StencilFace.FRONT_AND_BACK);
-    }
-
-    /**
-     * Sets the stencil reference value (default is 0).
-     *
-     * <p>
-     * The stencil reference value is the left-hand side for stencil comparison tests. It's also
-     * used as the replacement stencil value when {@link StencilOperation} is
-     * {@link StencilOperation#REPLACE}.
-     * </p>
-     *
-     * <p>
-     * It's possible to set separate stencil reference values; one for front-facing polygons, and
-     * one for back-facing polygons. The face parameter determines the reference value(s) updated by
-     * this call.
-     * </p>
-     *
-     * @param value the stencil reference value (only the least significant 8 bits are used)
-     * @param face the faces to update the reference value for
-     */
-    public void setStencilReferenceValue(@IntRange(from = 0, to = 255) int value, StencilFace face) {
-        nSetStencilReferenceValue(getNativeObject(), value, sStencilFaceMapping[face.ordinal()]);
-    }
-
-    /**
-     * Sets the stencil reference value for both front and back-facing polygons.
-     * @see #setStencilReferenceValue(int, StencilFace)
-     */
-    public void setStencilReferenceValue(@IntRange(from = 0, to = 255) int value) {
-        setStencilReferenceValue(value, StencilFace.FRONT_AND_BACK);
-    }
-
-    /**
-     * Sets the stencil read mask (default is 0xFF).
-     *
-     * <p>
-     * The stencil read mask masks the bits of the values participating in the stencil comparison
-     * test- both the value read from the stencil buffer and the reference value.
-     * </p>
-     *
-     * <p>
-     * It's possible to set separate stencil read masks; one for front-facing polygons, and one for
-     * back-facing polygons. The face parameter determines the stencil read mask(s) updated by this
-     * call.
-     * </p>
-     *
-     * @param readMask the read mask (only the least significant 8 bits are used)
-     * @param face the faces to update the read mask for
-     */
-    public void setStencilReadMask(@IntRange(from = 0, to = 255) int readMask, StencilFace face) {
-        nSetStencilReadMask(getNativeObject(), readMask, sStencilFaceMapping[face.ordinal()]);
-    }
-
-    /**
-     * Sets the stencil read mask for both front and back-facing polygons.
-     * @see #setStencilReadMask(int, StencilFace)
-     */
-    public void setStencilReadMask(@IntRange(from = 0, to = 255) int readMask) {
-        setStencilReadMask(readMask, StencilFace.FRONT_AND_BACK);
-    }
-
-    /**
-     * Sets the stencil write mask (default is 0xFF).
-     *
-     * <p>
-     * The stencil write mask masks the bits in the stencil buffer updated by stencil operations.
-     * </p>
-     *
-     * <p>
-     * It's possible to set separate stencil write masks; one for front-facing polygons, and one for
-     * back-facing polygons. The face parameter determines the stencil write mask(s) updated by this
-     * call.
-     * </p>
-     *
-     * @param writeMask the write mask (only the least significant 8 bits are used)
-     * @param face the faces to update the read mask for
-     */
-    public void setStencilWriteMask(@IntRange(from = 0, to = 255) int writeMask, StencilFace face) {
-        nSetStencilWriteMask(getNativeObject(), writeMask, sStencilFaceMapping[face.ordinal()]);
-    }
-
-    /**
-     * Sets the stencil write mask for both front and back-facing polygons.
-     * @see #setStencilWriteMask(int, StencilFace)
-     */
-    public void setStencilWriteMask(int writeMask) {
-        setStencilWriteMask(writeMask, StencilFace.FRONT_AND_BACK);
-    }
-
     public long getNativeObject() {
         if (mNativeObject == 0) {
             throw new IllegalStateException("Calling method on destroyed MaterialInstance");
@@ -834,26 +550,8 @@ public class MaterialInstance {
     private static native void nSetCullingMode(long nativeMaterialInstance, long mode);
     private static native void nSetColorWrite(long nativeMaterialInstance, boolean enable);
     private static native void nSetDepthWrite(long nativeMaterialInstance, boolean enable);
-    private static native void nSetStencilWrite(long nativeMaterialInstance, boolean enable);
     private static native void nSetDepthCulling(long nativeMaterialInstance, boolean enable);
 
-    private static native void nSetStencilCompareFunction(long nativeMaterialInstance,
-            long function, long face);
-    private static native void nSetStencilOpStencilFail(long nativeMaterialInstance, long op,
-            long face);
-    private static native void nSetStencilOpDepthFail(long nativeMaterialInstance, long op,
-            long face);
-    private static native void nSetStencilOpDepthStencilPass(long nativeMaterialInstance, long op,
-            long face);
-    private static native void nSetStencilReferenceValue(long nativeMaterialInstance, int value,
-            long face);
-    private static native void nSetStencilReadMask(long nativeMaterialInstance, int readMask,
-            long face);
-    private static native void nSetStencilWriteMask(long nativeMaterialInstance, int writeMask,
-            long face);
-
     private static native String nGetName(long nativeMaterialInstance);
     private static native long nGetMaterial(long nativeMaterialInstance);
-
-    private static native long nDuplicate(long otherNativeMaterialInstance, String name);
 }

android/filament-android/src/main/java/com/google/android/filament/MorphTargetBuffer.java

@@ -1,180 +0,0 @@
-/*
- * Copyright (C) 2022 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package com.google.android.filament;
-
-import androidx.annotation.IntRange;
-import androidx.annotation.NonNull;
-
-import java.nio.Buffer;
-import java.nio.BufferOverflowException;
-import java.nio.FloatBuffer;
-
-public class MorphTargetBuffer {
-    private long mNativeObject;
-    private MorphTargetBuffer(long nativeMorphTargetBuffer) {
-        mNativeObject = nativeMorphTargetBuffer;
-    }
-
-    public static class Builder {
-        @SuppressWarnings({"FieldCanBeLocal", "UnusedDeclaration"})
-        // Keep to finalize native resources
-        private final MorphTargetBuffer.Builder.BuilderFinalizer mFinalizer;
-        private final long mNativeBuilder;
-
-        public Builder() {
-            mNativeBuilder = nCreateBuilder();
-            mFinalizer = new MorphTargetBuffer.Builder.BuilderFinalizer(mNativeBuilder);
-        }
-
-        /**
-         * Size of the morph targets in vertex counts.
-         *
-         * @param vertexCount Number of vertex counts the morph targets can hold.
-         * @return this <code>Builder</code> object for chaining calls
-         */
-        @NonNull
-        public Builder vertexCount(@IntRange(from = 1) int vertexCount) {
-            nBuilderVertexCount(mNativeBuilder, vertexCount);
-            return this;
-        }
-
-        /**
-         * Size of the morph targets in targets.
-         *
-         * @param count Number of targets the morph targets can hold.
-         * @return this <code>Builder</code> object for chaining calls
-         */
-        @NonNull
-        public Builder count(@IntRange(from = 1) int count) {
-            nBuilderCount(mNativeBuilder, count);
-            return this;
-        }
-
-        /**
-         * Creates and returns the <code>MorphTargetBuffer</code> object.
-         *
-         * @param engine reference to the {@link Engine} to associate this <code>MorphTargetBuffer</code>
-         *               with.
-         *
-         * @return the newly created <code>MorphTargetBuffer</code> object
-         *
-         * @exception IllegalStateException if the MorphTargetBuffer could not be created
-         *
-         * @see #setMorphTargetBufferAt
-         */
-        @NonNull
-        public MorphTargetBuffer build(@NonNull Engine engine) {
-            long nativeMorphTargetBuffer = nBuilderBuild(mNativeBuilder, engine.getNativeObject());
-            if (nativeMorphTargetBuffer == 0)
-                throw new IllegalStateException("Couldn't create MorphTargetBuffer");
-            return new MorphTargetBuffer(nativeMorphTargetBuffer);
-        }
-
-        private static class BuilderFinalizer {
-            private final long mNativeObject;
-
-            BuilderFinalizer(long nativeObject) {
-                mNativeObject = nativeObject;
-            }
-
-            @Override
-            public void finalize() {
-                try {
-                    super.finalize();
-                } catch (Throwable t) { // Ignore
-                } finally {
-                    nDestroyBuilder(mNativeObject);
-                }
-            }
-        }
-    }
-
-    /**
-     * Updates float4 positions for the given morph target.
-     *
-     * @param engine {@link Engine} instance
-     * @param targetIndex The index of morph target to be updated
-     * @param positions An array with at least count*4 floats
-     * @param count Number of float4 vectors in positions to be consumed
-     */
-    public void setPositionsAt(@NonNull Engine engine,
-            @IntRange(from = 0) int targetIndex,
-            @NonNull float[] positions, @IntRange(from = 0, to = 125) int count) {
-        int result = nSetPositionsAt(mNativeObject, engine.getNativeObject(), targetIndex,
-                positions, count);
-        if (result < 0) {
-            throw new BufferOverflowException();
-        }
-    }
-
-    /**
-     * Updates tangents for the given morph target.
-     *
-     * These quaternions must be represented as signed shorts, where real numbers in the [-1,+1]
-     * range multiplied by 32767.
-     *
-     * @param engine {@link Engine} instance
-     * @param targetIndex The index of morph target to be updated
-     * @param tangents An array with at least "count*4" shorts
-     * @param count number of short4 quaternions in tangents
-     */
-    public void setTangentsAt(@NonNull Engine engine,
-            @IntRange(from = 0) int targetIndex,
-            @NonNull short[] tangents, @IntRange(from = 0, to = 125) int count) {
-        int result = nSetTangentsAt(mNativeObject, engine.getNativeObject(), targetIndex,
-                tangents, count);
-        if (result < 0) {
-            throw new BufferOverflowException();
-        }
-    }
-
-    /**
-     * @return number of vertices in this {@link MorphTargetBuffer}
-     */
-    public int getVertexCount() {
-        return nGetVertexCount(mNativeObject);
-    }
-
-    /**
-     * @return number of morph targets in this {@link MorphTargetBuffer}
-     */
-    public int getCount() {
-        return nGetCount(mNativeObject);
-    }
-
-    public long getNativeObject() {
-        if (mNativeObject == 0) {
-            throw new IllegalStateException("Calling method on destroyed MorphTargetBuffer");
-        }
-        return mNativeObject;
-    }
-
-    void clearNativeObject() {
-        mNativeObject = 0;
-    }
-
-    private static native long nCreateBuilder();
-    private static native void nDestroyBuilder(long nativeBuilder);
-    private static native void nBuilderVertexCount(long nativeBuilder, int vertexCount);
-    private static native void nBuilderCount(long nativeBuilder, int count);
-    private static native long nBuilderBuild(long nativeBuilder, long nativeEngine);
-
-    private static native int nSetPositionsAt(long nativeObject, long nativeEngine, int targetIndex, float[] positions, int count);
-    private static native int nSetTangentsAt(long nativeObject, long nativeEngine, int targetIndex, short[] tangents, int count);
-    private static native int nGetVertexCount(long nativeObject);
-    private static native int nGetCount(long nativeObject);
-}

android/filament-android/src/main/java/com/google/android/filament/RenderTarget.java

@@ -31,15 +31,13 @@ import androidx.annotation.Nullable;
  * @see View
  */
 public class RenderTarget {
-    private static final int ATTACHMENT_COUNT = AttachmentPoint.values().length;
-    private static final Texture.CubemapFace[] sCubemapFaceValues = Texture.CubemapFace.values();
-
     private long mNativeObject;
-    private final Texture[] mTextures = new Texture[ATTACHMENT_COUNT];
+    private final Texture[] mTextures = new Texture[2];
 
     private RenderTarget(long nativeRenderTarget, Builder builder) {
         mNativeObject = nativeRenderTarget;
-        System.arraycopy(builder.mTextures, 0, mTextures, 0, ATTACHMENT_COUNT);
+        mTextures[0] = builder.mTextures[0];
+        mTextures[1] = builder.mTextures[1];
     }
 
     public long getNativeObject() {
@@ -54,14 +52,7 @@ public class RenderTarget {
      */
     public enum AttachmentPoint {
         COLOR,
-        COLOR1,
-        COLOR2,
-        COLOR3,
-        COLOR4,
-        COLOR5,
-        COLOR6,
-        COLOR7,
-        DEPTH
+        DEPTH,
     }
 
     /**
@@ -71,7 +62,7 @@ public class RenderTarget {
         @SuppressWarnings({"FieldCanBeLocal", "UnusedDeclaration"})
         private final BuilderFinalizer mFinalizer;
         private final long mNativeBuilder;
-        private final Texture[] mTextures = new Texture[ATTACHMENT_COUNT];
+        private final Texture[] mTextures = new Texture[2];
 
         public Builder() {
             mNativeBuilder = nCreateBuilder();
@@ -196,7 +187,7 @@ public class RenderTarget {
      * a cubemap.
      */
     public Texture.CubemapFace getFace(AttachmentPoint attachment) {
-        return sCubemapFaceValues[nGetFace(getNativeObject(), attachment.ordinal())];
+        return Texture.CubemapFace.values()[nGetFace(getNativeObject(), attachment.ordinal())];
     }
 
     /**

android/filament-android/src/main/java/com/google/android/filament/Renderer.java

@@ -61,17 +61,13 @@ public class Renderer {
         /**
          * How far in advance a buffer must be queued for presentation at a given time in ns
          * On Android you can use {@link android.view.Display#getPresentationDeadlineNanos()}.
-         * @deprecated this value is ignored
          */
-        @Deprecated
         public long presentationDeadlineNanos = 0;
 
         /**
          * Offset by which vsyncSteadyClockTimeNano provided in beginFrame() is offset in ns
          * On Android you can use {@link android.view.Display#getAppVsyncOffsetNanos()}.
-         * @deprecated this value is ignored
          */
-        @Deprecated
         public long vsyncOffsetNanos = 0;
     };
 
@@ -111,12 +107,12 @@ public class Renderer {
         /**
          * Rate at which the scale will change to reach the target frame rate.
          */
-        public float scaleRate = 1.0f / 15.0f;
+        public float scaleRate = 0.125f;
 
         /**
-         * History size. higher values, tend to filter more (clamped to 31).
+         * History size. higher values, tend to filter more (clamped to 30).
          */
-        public int history = 15;
+        public int history = 9;
     }
 
     /**
@@ -179,7 +175,8 @@ public class Renderer {
      */
     public void setDisplayInfo(@NonNull DisplayInfo info) {
         mDisplayInfo = info;
-        nSetDisplayInfo(getNativeObject(), info.refreshRate);
+        nSetDisplayInfo(getNativeObject(),
+                info.refreshRate, info.presentationDeadlineNanos, info.vsyncOffsetNanos);
     }
 
     /**
@@ -250,23 +247,6 @@ public class Renderer {
         return mEngine;
     }
 
-    /**
-     * Set the time at which the frame must be presented to the display.
-     * <p>
-     * This must be called between {@link #beginFrame} and {@link #endFrame}.
-     * </p>
-     *
-     * @param monotonicClockNanos  The time in nanoseconds corresponding to the system monotonic
-     *                             up-time clock. The presentation time is typically set in the
-     *                             middle of the period of interest and cannot be too far in the
-     *                             future as it is limited by how many buffers are available in
-     *                             the display sub-system. Typically it is set to 1 or 2 vsync
-     *                             periods away.
-     */
-    public void setPresentationTime(long monotonicClockNanos) {
-        nSetPresentationTime(getNativeObject(), monotonicClockNanos);
-    }
-
     /**
      * Sets up a frame for this <code>Renderer</code>.
      * <p><code>beginFrame</code> manages frame pacing, and returns whether or not a frame should be
@@ -329,13 +309,13 @@ public class Renderer {
      *
      * <p><code>render()</code> generates commands for each of the following stages:</p>
      * <ul>
-     * <li>Shadow map passes, if needed</li>
+     * <li>Shadow map pass, if needed (currently only a single shadow map is supported)</li>
      * <li>Depth pre-pass</li>
      * <li>SSAO pass, if enabled</li>
      * <li>Color pass</li>
      * <li>Post-processing pass</li>
      * </ul>
-     * <p>
+     *
      * A typical render loop looks like this:
      *
      * <pre>
@@ -351,58 +331,31 @@ public class Renderer {
      * </pre>
      *
      * <ul>
-     * <li><code>render()</code> must be called <b>after</b> {@link #beginFrame} and <b>before</b>
-     * {@link #endFrame}.</li>
+     *<li><code>render()</code> must be called <b>after</b> {@link #beginFrame} and <b>before</b>
+     *{@link #endFrame}.</li>
      *
-     * <li><code>render()</code> must be called from the {@link Engine}'s main thread
-     * (or external synchronization must be provided). In particular, calls to <code>render()</code>
-     * on different <code>Renderer</code> instances <b>must</b> be synchronized.</li>
+     *<li><code>render()</code> must be called from the {@link Engine}'s main thread
+     *(or external synchronization must be provided). In particular, calls to <code>render()</code>
+     *on different <code>Renderer</code> instances <b>must</b> be synchronized.</li>
      *
-     * <li><code>render()</code> performs potentially heavy computations and cannot be multi-threaded.
-     * However, internally, it is highly multi-threaded to both improve performance and mitigate
-     * the call's latency.</li>
+     *<li><code>render()</code> performs potentially heavy computations and cannot be multi-threaded.
+     *However, internally, it is highly multi-threaded to both improve performance and mitigate
+     *the call's latency.</li>
      *
-     * <li><code>render()</code> is typically called once per frame (but not necessarily).</li>
+     *<li><code>render()</code> is typically called once per frame (but not necessarily).</li>
      * </ul>
      *
      * @param view the {@link View} to render
+     *
      * @see #beginFrame
      * @see #endFrame
      * @see View
+     *
      */
     public void render(@NonNull View view) {
         nRender(getNativeObject(), view.getNativeObject());
     }
 
-    /**
-     * Renders a standalone {@link View} into its associated <code>RenderTarget</code>.
-     *
-     * <p>
-     * This call is mostly equivalent to calling {@link #render(View)} inside a
-     * {@link #beginFrame} / {@link #endFrame} block, but incurs less overhead. It can be used
-     * as a poor man's compute API. 
-     * </p>
-     *
-     * <ul>
-     * <li><code>renderStandaloneView()</code> must be called <b>outside</b> of
-     * {@link #beginFrame} / {@link #endFrame}.</li>
-     *
-     * <li><code>renderStandaloneView()</code> must be called from the {@link Engine}'s main thread
-     * (or external synchronization must be provided). In particular, calls to
-     * <code>renderStandaloneView()</code> on different <code>Renderer</code> instances <b>must</b>
-     * be synchronized.</li>
-     *
-     * <li><code>renderStandaloneView()</code> performs potentially heavy computations and cannot be
-     * multi-threaded. However, internally, it is highly multi-threaded to both improve performance
-     * and mitigate the call's latency.</li>
-     *
-     * @param view the {@link View} to render. This View must have an associated {@link RenderTarget}
-     * @see View
-     */
-    public void renderStandaloneView(@NonNull View view) {
-        nRenderStandaloneView(getNativeObject(), view.getNativeObject());
-    }
-
     /**
      * Copies the currently rendered {@link View} to the indicated {@link SwapChain}, using the
      * indicated source and destination rectangle.
@@ -457,9 +410,8 @@ public class Renderer {
      *</pre>
      *
      *
-     * <p><code>readPixels</code> must be called within a frame, meaning after {@link #beginFrame}
-     * and before {@link #endFrame}. Typically, <code>readPixels</code> will be called after
-     * {@link #render}.</p>
+     * <p>Typically <code>readPixels</code> will be called after {@link #render} and before
+     * {@link #endFrame}.</p>
      * <br>
      * <p>After calling this method, the callback associated with <code>buffer</code>
      * will be invoked on the main thread, indicating that the read-back has completed.
@@ -551,10 +503,6 @@ public class Renderer {
      * Typically, this will happen after multiple calls to {@link #beginFrame},
      * {@link #render}, {@link #endFrame}.</p>
      * <br>
-     * <p>OpenGL only: if issuing a <code>readPixels</code> on a {@link RenderTarget} backed by a
-     * {@link Texture} that had data uploaded to it via {@link Texture#setImage}, the data returned
-     * from <code>readPixels</code> will be y-flipped with respect to the {@link Texture#setImage}
-     * call.</p>
      * <p><code>readPixels</code> is intended for debugging and testing.
      * It will impact performance significantly.</p>
      *
@@ -684,11 +632,9 @@ public class Renderer {
         mNativeObject = 0;
     }
 
-    private static native void nSetPresentationTime(long nativeObject, long monotonicClockNanos);
     private static native boolean nBeginFrame(long nativeRenderer, long nativeSwapChain, long frameTimeNanos);
     private static native void nEndFrame(long nativeRenderer);
     private static native void nRender(long nativeRenderer, long nativeView);
-    private static native void nRenderStandaloneView(long nativeRenderer, long nativeView);
     private static native void nCopyFrame(long nativeRenderer, long nativeDstSwapChain,
             int dstLeft, int dstBottom, int dstWidth, int dstHeight,
             int srcLeft, int srcBottom, int srcWidth, int srcHeight,
@@ -706,7 +652,8 @@ public class Renderer {
             Object handler, Runnable callback);
     private static native double nGetUserTime(long nativeRenderer);
     private static native void nResetUserTime(long nativeRenderer);
-    private static native void nSetDisplayInfo(long nativeRenderer, float refreshRate);
+    private static native void nSetDisplayInfo(long nativeRenderer,
+            float refreshRate, long presentationDeadlineNanos, long vsyncOffsetNanos);
     private static native void nSetFrameRateOptions(long nativeRenderer,
             float interval, float headRoomRatio, float scaleRate, int history);
     private static native void nSetClearOptions(long nativeRenderer,

android/filament-android/src/main/java/com/google/android/filament/Scene.java

@@ -128,7 +128,6 @@ public class Scene {
     /**
      * @deprecated See {@link #removeEntity(int)}
      */
-    @Deprecated
     public void remove(@Entity int entity) {
         removeEntity(entity);
     }
@@ -163,15 +162,6 @@ public class Scene {
         return nGetLightCount(getNativeObject());
     }
 
-    /**
-     * Returns true if the given entity is in the Scene.
-     *
-     * @return Whether the given entity is in the Scene.
-     */
-    public boolean hasEntity(@Entity int entity) {
-        return nHasEntity(getNativeObject(), entity);
-    }
-
     public long getNativeObject() {
         if (mNativeObject == 0) {
             throw new IllegalStateException("Calling method on destroyed Scene");
@@ -191,5 +181,4 @@ public class Scene {
     private static native void nRemoveEntities(long nativeScene, int[] entities);
     private static native int nGetRenderableCount(long nativeScene);
     private static native int nGetLightCount(long nativeScene);
-    private static native boolean nHasEntity(long nativeScene, int entity);
 }

android/filament-android/src/main/java/com/google/android/filament/SkinningBuffer.java

@@ -1,177 +0,0 @@
-/*
- * Copyright (C) 2021 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package com.google.android.filament;
-
-import androidx.annotation.IntRange;
-import androidx.annotation.NonNull;
-
-import java.nio.Buffer;
-import java.nio.BufferOverflowException;
-import java.nio.FloatBuffer;
-
-public class SkinningBuffer {
-    private long mNativeObject;
-    private SkinningBuffer(long nativeSkinningBuffer) {
-        mNativeObject = nativeSkinningBuffer;
-    }
-
-    public static class Builder {
-        @SuppressWarnings({"FieldCanBeLocal", "UnusedDeclaration"})
-        // Keep to finalize native resources
-        private final SkinningBuffer.Builder.BuilderFinalizer mFinalizer;
-        private final long mNativeBuilder;
-
-        public Builder() {
-            mNativeBuilder = nCreateBuilder();
-            mFinalizer = new SkinningBuffer.Builder.BuilderFinalizer(mNativeBuilder);
-        }
-
-        /**
-         * Size of the skinning buffer in bones.
-         *
-         * <p>Due to limitation in the GLSL, the SkinningBuffer must always by a multiple of
-         * 256, this adjustment is done automatically, but can cause
-         * some memory overhead. This memory overhead can be mitigated by using the same
-         * {@link SkinningBuffer} to store the bone information for multiple RenderPrimitives.</p>
-         *
-         * @param boneCount Number of bones the skinning buffer can hold.
-         * @return this <code>Builder</code> object for chaining calls
-         */
-        @NonNull
-        public Builder boneCount(@IntRange(from = 1) int boneCount) {
-            nBuilderBoneCount(mNativeBuilder, boneCount);
-            return this;
-        }
-
-        /**
-         * The new buffer is created with identity bones
-         *
-         * @param initialize true to initializing the buffer, false to not.
-         * @return A reference to this Builder for chaining calls.
-         */
-        @NonNull
-        public Builder initialize(boolean initialize) {
-            nBuilderInitialize(mNativeBuilder, initialize);
-            return this;
-        }
-
-        /**
-         * Creates and returns the <code>SkinningBuffer</code> object.
-         *
-         * @param engine reference to the {@link Engine} to associate this <code>SkinningBuffer</code>
-         *               with.
-         *
-         * @return the newly created <code>SkinningBuffer</code> object
-         *
-         * @exception IllegalStateException if the SkinningBuffer could not be created
-         *
-         * @see #setBonesAsMatrices
-         * @see #setBonesAsQuaternions
-         */
-        @NonNull
-        public SkinningBuffer build(@NonNull Engine engine) {
-            long nativeSkinningBuffer = nBuilderBuild(mNativeBuilder, engine.getNativeObject());
-            if (nativeSkinningBuffer == 0)
-                throw new IllegalStateException("Couldn't create SkinningBuffer");
-            return new SkinningBuffer(nativeSkinningBuffer);
-        }
-
-        private static class BuilderFinalizer {
-            private final long mNativeObject;
-
-            BuilderFinalizer(long nativeObject) {
-                mNativeObject = nativeObject;
-            }
-
-            @Override
-            public void finalize() {
-                try {
-                    super.finalize();
-                } catch (Throwable t) { // Ignore
-                } finally {
-                    nDestroyBuilder(mNativeObject);
-                }
-            }
-        }
-    }
-
-    /**
-     * Updates the bone transforms in the range [offset, offset + boneCount).
-     *
-     * @param engine {@link Engine} instance
-     * @param matrices A {@link FloatBuffer} containing boneCount 4x4 packed matrices (i.e. 16 floats each matrix and no gap between matrices)
-     * @param boneCount Number of bones to set
-     * @param offset Index of the first bone to set
-     */
-    public void setBonesAsMatrices(@NonNull Engine engine,
-            @NonNull Buffer matrices, @IntRange(from = 0, to = 255) int boneCount,
-            @IntRange(from = 0) int offset) {
-        int result = nSetBonesAsMatrices(mNativeObject, engine.getNativeObject(),
-                matrices, matrices.remaining(), boneCount, offset);
-        if (result < 0) {
-            throw new BufferOverflowException();
-        }
-    }
-
-    /**
-     * Updates the bone transforms in the range [offset, offset + boneCount).
-     *
-     * @param engine {@link Engine} instance
-     * @param quaternions A {@link FloatBuffer} containing boneCount transforms. Each transform consists of 8 float.
-     *                    float 0 to 3 encode a unit quaternion <code>w+ix+jy+kz</code> stored as <code>x,y,z,w</code>.
-     *                    float 4 to 7 encode a translation stored as <code>x,y,z,1</code>.
-     * @param boneCount Number of bones to set
-     * @param offset Index of the first bone to set
-     */
-    public void setBonesAsQuaternions(@NonNull Engine engine,
-            @NonNull Buffer quaternions, @IntRange(from = 0, to = 255) int boneCount,
-            @IntRange(from = 0) int offset) {
-        int result = nSetBonesAsQuaternions(mNativeObject, engine.getNativeObject(),
-                quaternions, quaternions.remaining(), boneCount, offset);
-        if (result < 0) {
-            throw new BufferOverflowException();
-        }
-    }
-
-    /**
-     * @return number of bones in this {@link SkinningBuffer}
-     */
-    public int getBoneCount() {
-        return nGetBoneCount(mNativeObject);
-    }
-
-    public long getNativeObject() {
-        if (mNativeObject == 0) {
-            throw new IllegalStateException("Calling method on destroyed IndexBuffer");
-        }
-        return mNativeObject;
-    }
-
-    void clearNativeObject() {
-        mNativeObject = 0;
-    }
-
-    private static native long nCreateBuilder();
-    private static native void nDestroyBuilder(long nativeBuilder);
-    private static native void nBuilderBoneCount(long nativeBuilder, int boneCount);
-    private static native void nBuilderInitialize(long nativeBuilder, boolean initialize);
-    private static native long nBuilderBuild(long nativeBuilder, long nativeEngine);
-
-    private static native int nSetBonesAsMatrices(long nativeObject, long nativeEngine, Buffer matrices, int remaining, int boneCount, int offset);
-    private static native int nSetBonesAsQuaternions(long nativeObject, long nativeEngine, Buffer quaternions, int remaining, int boneCount, int offset);
-    private static native int nGetBoneCount(long nativeObject);
-}

android/filament-android/src/main/java/com/google/android/filament/Skybox.java

@@ -23,6 +23,8 @@ import androidx.annotation.Size;
 
 import static com.google.android.filament.Colors.LinearColor;
 
+import com.google.android.filament.proguard.UsedByReflection;
+
 /**
  * Skybox
  * <p>When added to a {@link Scene}, the <code>Skybox</code> fills all untouched pixels.</p>
@@ -51,7 +53,11 @@ import static com.google.android.filament.Colors.LinearColor;
 public class Skybox {
     private long mNativeObject;
 
-    public Skybox(long nativeSkybox) {
+    public Skybox(Engine engine, long nativeSkybox) {
+        mNativeObject = nativeSkybox;
+    }
+
+    Skybox(long nativeSkybox) {
         mNativeObject = nativeSkybox;
     }
 
@@ -109,14 +115,13 @@ public class Skybox {
         }
 
         /**
-         * Sets the <code>Skybox</code> intensity when no {@link IndirectLight} is set on the
-         * {@link Scene}.
+         * Sets the <code>Skybox</code> intensity when no {@link IndirectLight} is set
          *
-         * <p>This call is ignored when an {@link IndirectLight} is set on the {@link Scene}, and
-         * the intensity of the {@link IndirectLight} is used instead.</p>
+         * <p>This call is ignored when an  {@link IndirectLight} is set, otherwise it is used in
+         * its place.</p>
          *
          * @param envIntensity  Scale factor applied to the skybox texel values such that
-         *                      the result is in <i>lux</i>, or <i>lumen/m^2</i> (default = 30000)
+         *                      the result is in cd/m<sup>2</sup> (lux) units (default = 30000)
          *
          * @return This Builder, for chaining calls.
          *
@@ -232,7 +237,7 @@ public class Skybox {
     }
 
     /**
-     * Returns the <code>Skybox</code>'s intensity in <i>lux</i>, or <i>lumen/m^2</i>.
+     * Returns the <code>Skybox</code>'s intensity in cd/m<sup>2</sup>.
      */
     public float getIntensity() { return nGetIntensity(getNativeObject()); }
 

android/filament-android/src/main/java/com/google/android/filament/Stream.java

@@ -26,66 +26,10 @@ import java.nio.ReadOnlyBufferException;
 /**
  * <code>Stream</code> is used to attach a native video stream to a filament {@link Texture}.
  *
- * Stream supports three different configurations:
- *
- * <dl>
- * <dt>ACQUIRED</dt>     <dd>connects to an Android AHardwareBuffer</dd>
- * <dt>NATIVE</dt>       <dd>connects to an Android SurfaceTexture</dd>
- * </dl>
- *
- * <p>
- * Before explaining these different configurations, let's review the high-level structure of an
- * AR or video application that uses Filament.
- * </p>
- *
- * <pre>
- * while (true) {
- *
- *     // Misc application work occurs here, such as:
- *     // - Writing the image data for a video frame into a Stream
- *     // - Moving the Filament Camera
- *
- *     if (renderer.beginFrame(swapChain)) {
- *         renderer.render(view);
- *         renderer.endFrame();
- *     }
- * }
- * </pre>
- *
- * <p>
- * Let's say that the video image data at the time of a particular invocation of beginFrame
- * becomes visible to users at time A. The 3D scene state (including the camera) at the time of
- * that same invocation becomes apparent to users at time B.
- * </p>
- *
- * <ul>
- * <li>If time A matches time B, we say that the stream is <em>synchronized</em>.</li>
- * <li>Filament invokes low-level graphics commands on the <em>driver thread</em>.</li>
- * <li>The thread that calls beginFrame is called the <em>main thread</em>.</li>
- * </ul>
- *
- * <p>
- * For <b>ACQUIRED</b> streams, there is no need to perform the copy because Filament explictly
- * acquires the stream, then releases it later via a callback function. This configuration is
- * especially useful when the Vulkan backend is enabled.
- * </p>
- *
- * <p>
- * For <b>NATIVE</b> streams, Filament does not make any synchronization guarantee. However they are
- * simple to use and do not incur a copy. These are often appropriate in video applications.
- * </p>
- *
- * <p>
- * Please see <code>sample-stream-test</code> and <code>sample-hello-camera</code> for usage
- * examples.
- * </p>
- *
  * @see Texture#setExternalStream
  * @see Engine#destroyStream
  */
 public class Stream {
-    private static final StreamType[] sStreamTypeValues = StreamType.values();
-
     private long mNativeObject;
     private long mNativeEngine;
 
@@ -96,6 +40,9 @@ public class Stream {
         /** Not synchronized but copy-free. Good for video. */
         NATIVE,
 
+        /** Synchronized, but GL-only and incurs copies. Good for AR on devices before API 26. */
+        TEXTURE_ID,
+
         /** Synchronized, copy-free, and take a release callback. Good for AR but requires API 26+. */
         ACQUIRED,
     };
@@ -111,7 +58,8 @@ public class Stream {
      * By default, Stream objects are {@link StreamType#ACQUIRED ACQUIRED} and must have external images pushed to them via
      * {@link #setAcquiredImage}.
      *
-     * To create a {@link StreamType#NATIVE NATIVE} stream, call the <pre>stream</pre> method on the builder.
+     * To create a {@link StreamType#NATIVE NATIVE} or {@link StreamType#TEXTURE_ID TEXTURE_ID} stream, call one of the <pre>stream</pre> methods
+     * on the builder.
      */
     public static class Builder {
         @SuppressWarnings({"FieldCanBeLocal", "UnusedDeclaration"}) // Keep to finalize native resources
@@ -145,6 +93,25 @@ public class Stream {
             throw new IllegalArgumentException("Invalid stream source: " + streamSource);
         }
 
+        /**
+         * Creates a {@link StreamType#TEXTURE_ID TEXTURE_ID} stream. A copy stream will sample data from the supplied
+         * external texture and copy it into an internal private texture.
+         *
+         * <p>Currently only OpenGL external texture ids are supported.</p>
+         *
+         * @param externalTextureId An opaque texture id (typically a GLuint created with
+         *                          <code>glGenTextures()</code>) in a context shared with
+         *                          filament -- in that case this texture's target must be
+         *                          <code>GL_TEXTURE_EXTERNAL_OES.</code>
+         * @return This Builder, for chaining calls.
+         * @see Texture#setExternalStream
+         */
+        @NonNull
+        public Builder stream(long externalTextureId) {
+            nBuilderStream(mNativeBuilder, externalTextureId);
+            return this;
+        }
+
         /**
          * @param width initial width of the incoming stream. Whether this value is used is
          *              stream dependent. On Android, it must be set when using
@@ -203,26 +170,17 @@ public class Stream {
     }
 
     /**
-     * Indicates whether this <code>Stream</code> is NATIVE or ACQUIRED.
+     * Indicates whether this <code>Stream</code> is NATIVE, TEXTURE_ID, or ACQUIRED.
      */
     public StreamType getStreamType() {
-        return sStreamTypeValues[nGetStreamType(getNativeObject())];
+        return StreamType.values()[nGetStreamType(getNativeObject())];
     }
 
     /**
      * Updates an <pre>ACQUIRED</pre> stream with an image that is guaranteed to be used in the next frame.
      *
-     * This method tells Filament to immediately "acquire" the image and trigger a callback
-     * when it is done with it. This should be called by the user outside of beginFrame / endFrame,
-     * and should be called only once per frame. If the user pushes images to the same stream
-     * multiple times in a single frame, only the final image is honored, but all callbacks are
-     * invoked.
-     *
-     * This method should be called on the same thread that calls {@link Renderer#beginFrame}, which is
-     * also where the callback is invoked. This method can only be used for streams that were
-     * constructed without calling the {@link Builder.stream} method.
-     *
-     * See {@link Stream} for more information about NATIVE and ACQUIRED configurations.
+     * This method should be called on the same thread that calls {#link Renderer#beginFrame}, which is
+     * also where the callback is invoked.
      *
      * @param hwbuffer {@link android.hardware.HardwareBuffer HardwareBuffer} (requires API level 26)
      * @param handler {@link java.util.concurrent.Executor Executor} or {@link android.os.Handler Handler}.
@@ -244,6 +202,92 @@ public class Stream {
         nSetDimensions(getNativeObject(), width, height);
     }
 
+    /**
+     * Reads back the content of the last frame of a <code>Stream</code> since the last call to
+     * {@link Renderer#beginFrame}.
+     *
+     * <p>The Stream must be a copy stream, which can be checked with {@link #getStreamType()}.
+     * This function is a no-op otherwise.</p>
+     *
+     * <pre>
+     *
+     *  Stream buffer                  User buffer (PixelBufferDescriptor)
+     *  +--------------------+
+     *  |                    |                .stride         .alignment
+     *  |                    |         ----------------------->-->
+     *  |                    |         O----------------------+--+   low addresses
+     *  |                    |         |          |           |  |
+     *  |             w      |         |          | .top      |  |
+     *  |       <--------->  |         |          V           |  |
+     *  |       +---------+  |         |     +---------+      |  |
+     *  |       |     ^   |  | ======> |     |         |      |  |
+     *  |   x   |    h|   |  |         |.left|         |      |  |
+     *  +------>|     v   |  |         +---->|         |      |  |
+     *  |       +.........+  |         |     +.........+      |  |
+     *  |            ^       |         |                      |  |
+     *  |          y |       |         +----------------------+--+  high addresses
+     *  O------------+-------+
+     *
+     * </pre>
+     *
+     * <p>Typically readPixels() will be called after {@link Renderer#beginFrame}.</p>
+     *
+     * <p>After calling this method, the callback associated with <code>buffer</code>
+     * will be invoked on the main thread, indicating that the read-back has completed.
+     * Typically, this will happen after multiple calls to {@link Renderer#beginFrame},
+     * {@link Renderer#render}, {@link Renderer#endFrame}.</p>
+     *
+     * <p><code>readPixels</code> is intended for debugging and testing.
+     * It will impact performance significantly.</p>
+     *
+     * @param xoffset   left offset of the sub-region to read back
+     * @param yoffset   bottom offset of the sub-region to read back
+     * @param width     width of the sub-region to read back
+     * @param height    height of the sub-region to read back
+     * @param buffer    client-side buffer where the read-back will be written
+     *
+     *                  <p>
+     *                  The following format are always supported:
+     *                      <li>{@link Texture.Format#RGBA}</li>
+     *                      <li>{@link Texture.Format#RGBA_INTEGER}</li>
+     *                  </p>
+     *
+     *                  <p>
+     *                  The following types are always supported:
+     *                      <li>{@link Texture.Type#UBYTE}</li>
+     *                      <li>{@link Texture.Type#UINT}</li>
+     *                      <li>{@link Texture.Type#INT}</li>
+     *                      <li>{@link Texture.Type#FLOAT}</li>
+     *                  </p>
+     *
+     *                  <p>Other combination of format/type may be supported. If a combination is
+     *                  not supported, this operation may fail silently. Use a DEBUG build
+     *                  to get some logs about the failure.</p>
+     *
+     * @exception BufferOverflowException if the specified parameters would result in reading
+     * outside of <code>buffer</code>.
+     */
+    public void readPixels(
+            @IntRange(from = 0) int xoffset, @IntRange(from = 0) int yoffset,
+            @IntRange(from = 0) int width, @IntRange(from = 0) int height,
+            @NonNull Texture.PixelBufferDescriptor buffer) {
+
+        if (buffer.storage.isReadOnly()) {
+            throw new ReadOnlyBufferException();
+        }
+
+        int result = nReadPixels(getNativeObject(), mNativeEngine,
+                xoffset, yoffset, width, height,
+                buffer.storage, buffer.storage.remaining(),
+                buffer.left, buffer.top, buffer.type.ordinal(), buffer.alignment,
+                buffer.stride, buffer.format.ordinal(),
+                buffer.handler, buffer.callback);
+
+        if (result < 0) {
+            throw new BufferOverflowException();
+        }
+    }
+
     /**
      * Returns the presentation time of the currently displayed frame in nanosecond.
      *
@@ -269,6 +313,7 @@ public class Stream {
     private static native long nCreateBuilder();
     private static native void nDestroyBuilder(long nativeStreamBuilder);
     private static native void nBuilderStreamSource(long nativeStreamBuilder, Object streamSource);
+    private static native void nBuilderStream(long nativeStreamBuilder, long externalTextureId);
     private static native void nBuilderWidth(long nativeStreamBuilder, int width);
     private static native void nBuilderHeight(long nativeStreamBuilder, int height);
     private static native long nBuilderBuild(long nativeStreamBuilder, long nativeEngine);

android/filament-android/src/main/java/com/google/android/filament/SwapChain.java

@@ -85,12 +85,6 @@ public class SwapChain {
      */
     public static final long CONFIG_READABLE = 0x2;
 
-    /**
-     * Indicates that the native X11 window is an XCB window rather than an XLIB window.
-     * This is ignored on non-Linux platforms and in builds that support only one X11 API.
-     */
-    public static final long CONFIG_ENABLE_XCB = 0x4;
-
     SwapChain(long nativeSwapChain, Object surface) {
         mNativeObject = nativeSwapChain;
         mSurface = surface;
@@ -104,31 +98,6 @@ public class SwapChain {
         return mSurface;
     }
 
-    /**
-     * FrameCompletedCallback is a callback function that notifies an application when a frame's
-     * contents have completed rendering on the GPU.
-     *
-     * <p>
-     * Use setFrameCompletedCallback to set a callback on an individual SwapChain. Each time a frame
-     * completes GPU rendering, the callback will be called.
-     * </p>
-     *
-     * <p>
-     * The FrameCompletedCallback is guaranteed to be called on the main Filament thread.
-     * </p>
-     *
-     * <p>
-     * Warning: Only Filament's Metal backend supports frame callbacks. Other backends ignore the
-     * callback (which will never be called) and proceed normally.
-     * </p>
-     *
-     * @param handler     A {@link java.util.concurrent.Executor Executor}.
-     * @param callback    The Runnable callback to invoke.
-     */
-    public void setFrameCompletedCallback(@NonNull Object handler, @NonNull Runnable callback) {
-        nSetFrameCompletedCallback(getNativeObject(), handler, callback);
-    }
-
     public long getNativeObject() {
         if (mNativeObject == 0) {
             throw new IllegalStateException("Calling method on destroyed SwapChain");
@@ -139,6 +108,4 @@ public class SwapChain {
     void clearNativeObject() {
         mNativeObject = 0;
     }
-
-    private static native void nSetFrameCompletedCallback(long nativeSwapChain, Object handler, Runnable callback);
 }

android/filament-android/src/main/java/com/google/android/filament/Texture.java

@@ -71,12 +71,13 @@ import static com.google.android.filament.Texture.Type.COMPRESSED;
  * @see MaterialInstance#setParameter(String, Texture, TextureSampler)
  */
 public class Texture {
-    private static final Sampler[] sSamplerValues = Sampler.values();
-    private static final InternalFormat[] sInternalFormatValues = InternalFormat.values();
-
     private long mNativeObject;
 
-    public Texture(long nativeTexture) {
+    Texture(long nativeTexture) {
+        mNativeObject = nativeTexture;
+    }
+
+    public Texture(Engine engine, long nativeTexture) {
         mNativeObject = nativeTexture;
     }
 
@@ -219,38 +220,7 @@ public class Texture {
         ETC2_EAC_RGBA8, ETC2_EAC_SRGBA8,
 
         // Available everywhere except Android/iOS
-        DXT1_RGB, DXT1_RGBA, DXT3_RGBA, DXT5_RGBA,
-        DXT1_SRGB, DXT1_SRGBA, DXT3_SRGBA, DXT5_SRGBA,
-
-        // ASTC formats are available with a GLES extension
-        RGBA_ASTC_4x4,
-        RGBA_ASTC_5x4,
-        RGBA_ASTC_5x5,
-        RGBA_ASTC_6x5,
-        RGBA_ASTC_6x6,
-        RGBA_ASTC_8x5,
-        RGBA_ASTC_8x6,
-        RGBA_ASTC_8x8,
-        RGBA_ASTC_10x5,
-        RGBA_ASTC_10x6,
-        RGBA_ASTC_10x8,
-        RGBA_ASTC_10x10,
-        RGBA_ASTC_12x10,
-        RGBA_ASTC_12x12,
-        SRGB8_ALPHA8_ASTC_4x4,
-        SRGB8_ALPHA8_ASTC_5x4,
-        SRGB8_ALPHA8_ASTC_5x5,
-        SRGB8_ALPHA8_ASTC_6x5,
-        SRGB8_ALPHA8_ASTC_6x6,
-        SRGB8_ALPHA8_ASTC_8x5,
-        SRGB8_ALPHA8_ASTC_8x6,
-        SRGB8_ALPHA8_ASTC_8x8,
-        SRGB8_ALPHA8_ASTC_10x5,
-        SRGB8_ALPHA8_ASTC_10x6,
-        SRGB8_ALPHA8_ASTC_10x8,
-        SRGB8_ALPHA8_ASTC_10x10,
-        SRGB8_ALPHA8_ASTC_12x10,
-        SRGB8_ALPHA8_ASTC_12x12
+        DXT1_RGB, DXT1_RGBA, DXT3_RGBA, DXT5_RGBA
     }
 
     /**
@@ -265,38 +235,7 @@ public class Texture {
         ETC2_EAC_RGBA8, ETC2_EAC_SRGBA8,
 
         // Available everywhere except Android/iOS
-        DXT1_RGB, DXT1_RGBA, DXT3_RGBA, DXT5_RGBA,
-        DXT1_SRGB, DXT1_SRGBA, DXT3_SRGBA, DXT5_SRGBA,
-
-        // ASTC formats are available with a GLES extension
-        RGBA_ASTC_4x4,
-        RGBA_ASTC_5x4,
-        RGBA_ASTC_5x5,
-        RGBA_ASTC_6x5,
-        RGBA_ASTC_6x6,
-        RGBA_ASTC_8x5,
-        RGBA_ASTC_8x6,
-        RGBA_ASTC_8x8,
-        RGBA_ASTC_10x5,
-        RGBA_ASTC_10x6,
-        RGBA_ASTC_10x8,
-        RGBA_ASTC_10x10,
-        RGBA_ASTC_12x10,
-        RGBA_ASTC_12x12,
-        SRGB8_ALPHA8_ASTC_4x4,
-        SRGB8_ALPHA8_ASTC_5x4,
-        SRGB8_ALPHA8_ASTC_5x5,
-        SRGB8_ALPHA8_ASTC_6x5,
-        SRGB8_ALPHA8_ASTC_6x6,
-        SRGB8_ALPHA8_ASTC_8x5,
-        SRGB8_ALPHA8_ASTC_8x6,
-        SRGB8_ALPHA8_ASTC_8x8,
-        SRGB8_ALPHA8_ASTC_10x5,
-        SRGB8_ALPHA8_ASTC_10x6,
-        SRGB8_ALPHA8_ASTC_10x8,
-        SRGB8_ALPHA8_ASTC_10x10,
-        SRGB8_ALPHA8_ASTC_12x10,
-        SRGB8_ALPHA8_ASTC_12x12
+        DXT1_RGB, DXT1_RGBA, DXT3_RGBA, DXT5_RGBA
     }
 
     /**
@@ -542,7 +481,7 @@ public class Texture {
          * @param alignment     Alignment in bytes.
          * @return              Size of the buffer in bytes.
          */
-        public static int computeDataSize(@NonNull Format format, @NonNull Type type,
+        static int computeDataSize(@NonNull Format format, @NonNull Type type,
                 int stride, int height, @IntRange(from = 1, to = 8) int alignment) {
             if (type == Type.COMPRESSED) {
                 return 0;
@@ -570,15 +509,12 @@ public class Texture {
                 case RGBA_INTEGER:
                     n = 4;
                     break;
-
-                default: throw new IllegalStateException("unsupported format enum");
             }
 
             int bpp = n;
             switch (type) {
                 case UBYTE:
                 case BYTE:
-                case COMPRESSED:
                     // nothing to do
                     break;
                 case USHORT:
@@ -595,9 +531,6 @@ public class Texture {
                     // Special case, format must be RGB and uses 4 bytes
                     bpp = 4;
                     break;
-                case USHORT_565:
-                    bpp = 2;
-                    break;
             }
 
             int bpr = bpp * stride;
@@ -629,17 +562,6 @@ public class Texture {
         return nIsTextureFormatSupported(engine.getNativeObject(), format.ordinal());
     }
 
-    /**
-     * Checks whether texture swizzling is supported in this {@link Engine}.
-     * This depends on the selected backend.
-     *
-     * @param engine {@link Engine}
-     * @return <code>true</code> if texture swizzling.
-     */
-    public static boolean isTextureSwizzleSupported(@NonNull Engine engine) {
-        return nIsTextureSwizzleSupported(engine.getNativeObject());
-    }
-
     /**
      * Use <code>Builder</code> to construct a <code>Texture</code> object instance.
      */
@@ -756,26 +678,6 @@ public class Texture {
             return this;
         }
 
-        /**
-         * Specify a native texture to import as a Filament texture.
-         * <p>
-         * The texture id is backend-specific:
-         * <ul>
-         *   <li> OpenGL: GLuint texture ID </li>
-         * </ul>
-         * </p>
-         *
-         *
-         * @param id a backend specific texture identifier
-         *
-         * @return This Builder, for chaining calls.
-         */
-        @NonNull
-        public Builder importTexture(long id) {
-            nBuilderImportTexture(mNativeBuilder, id);
-            return this;
-        }
-
         /**
          * Creates a new <code>Texture</code> instance.
          * @param engine The {@link Engine} to associate this <code>Texture</code> with.
@@ -870,7 +772,7 @@ public class Texture {
      */
     @NonNull
     public Sampler getTarget() {
-        return sSamplerValues[nGetTarget(getNativeObject())];
+        return Sampler.values()[nGetTarget(getNativeObject())];
     }
 
     /**
@@ -878,13 +780,13 @@ public class Texture {
      */
     @NonNull
     public InternalFormat getFormat() {
-        return sInternalFormatValues[nGetInternalFormat(getNativeObject())];
+        return InternalFormat.values()[nGetInternalFormat(getNativeObject())];
     }
 
     // TODO: add a setImage() version that takes an android Bitmap
 
     /**
-     * <code>setImage</code> is used to modify the whole content of the texture from a CPU-buffer.
+     * <code>setImage</code> is used to modify the whole content of the texure from a CPU-buffer.
      *
      *  <p>This <code>Texture</code> instance must use {@link Sampler#SAMPLER_2D SAMPLER_2D} or
      *  {@link Sampler#SAMPLER_EXTERNAL SAMPLER_EXTERNAL}. If the later is specified
@@ -912,7 +814,7 @@ public class Texture {
     public void setImage(@NonNull Engine engine,
             @IntRange(from = 0) int level,
             @NonNull PixelBufferDescriptor buffer) {
-        setImage(engine, level, 0, 0, 0, getWidth(level), getHeight(level), 1, buffer);
+        setImage(engine, level, 0, 0, getWidth(level), getHeight(level), buffer);
     }
 
 
@@ -947,22 +849,40 @@ public class Texture {
             @IntRange(from = 0) int xoffset, @IntRange(from = 0) int yoffset,
             @IntRange(from = 0) int width, @IntRange(from = 0) int height,
             @NonNull PixelBufferDescriptor buffer) {
-        setImage(engine, level, xoffset, yoffset, 0, width, height, 1, buffer);
+        int result;
+        if (buffer.type == COMPRESSED) {
+            result = nSetImageCompressed(getNativeObject(), engine.getNativeObject(), level,
+                    xoffset, yoffset, width, height,
+                    buffer.storage, buffer.storage.remaining(),
+                    buffer.left, buffer.top, buffer.type.ordinal(), buffer.alignment,
+                    buffer.compressedSizeInBytes, buffer.compressedFormat.ordinal(),
+                    buffer.handler, buffer.callback);
+        } else {
+            result = nSetImage(getNativeObject(), engine.getNativeObject(), level,
+                    xoffset, yoffset, width, height,
+                    buffer.storage, buffer.storage.remaining(),
+                    buffer.left, buffer.top, buffer.type.ordinal(), buffer.alignment,
+                    buffer.stride, buffer.format.ordinal(),
+                    buffer.handler, buffer.callback);
+        }
+        if (result < 0) {
+            throw new BufferOverflowException();
+        }
     }
 
     /**
-     * <code>setImage</code> is used to modify a sub-region of a 3D texture, 2D texture array or
-     * cubemap from a CPU-buffer. Cubemaps are treated like a 2D array of six layers.
+     * <code>setImage</code> is used to modify a sub-region of the 3D texture or 2D texture array
+     * from a CPU-buffer.
      *
-     *  <p>This <code>Texture</code> instance must use {@link Sampler#SAMPLER_2D_ARRAY SAMPLER_2D_ARRAY},
-     *  {@link Sampler#SAMPLER_3D SAMPLER_3D} or {@link Sampler#SAMPLER_CUBEMAP SAMPLER_CUBEMAP}.</p>
+     *  <p>This <code>Texture</code> instance must use {@link Sampler#SAMPLER_2D_ARRAY SAMPLER_2D_ARRAY} or
+     *  {@link Sampler#SAMPLER_3D SAMPLER_3D}.</p>
      *
      * @param engine    {@link Engine} this texture is associated to. Must be the
      *                  instance passed to {@link Builder#build Builder.build()}.
      * @param level     Level to set the image for. Must be less than {@link #getLevels()}.
      * @param xoffset   x-offset in texel of the region to modify
      * @param yoffset   y-offset in texel of the region to modify
-     * @param zoffset   z-offset in texel of the region to modify
+     * @param yoffset   z-offset in texel of the region to modify
      * @param width     width in texel of the region to modify
      * @param height    height in texel of the region to modify
      * @param depth     depth in texel or index of the region to modify
@@ -1028,9 +948,7 @@ public class Texture {
      *
      * @see Builder#sampler
      * @see PixelBufferDescriptor
-     * @deprecated use {@link #setImage(Engine, int, int, int, int, int, int, int, PixelBufferDescriptor)}
      */
-     @Deprecated
     public void setImage(@NonNull Engine engine, @IntRange(from = 0) int level,
             @NonNull PixelBufferDescriptor buffer,
             @NonNull @Size(min = 6) int[] faceOffsetsInBytes) {
@@ -1219,7 +1137,6 @@ public class Texture {
     }
 
     private static native boolean nIsTextureFormatSupported(long nativeEngine, int internalFormat);
-    private static native boolean nIsTextureSwizzleSupported(long nativeEngine);
 
     private static native long nCreateBuilder();
     private static native void nDestroyBuilder(long nativeBuilder);
@@ -1232,7 +1149,6 @@ public class Texture {
     private static native void nBuilderFormat(long nativeBuilder, int format);
     private static native void nBuilderUsage(long nativeBuilder, int flags);
     private static native void nBuilderSwizzle(long nativeBuilder, int r, int g, int b, int a);
-    private static native void nBuilderImportTexture(long nativeBuilder, long id);
     private static native long nBuilderBuild(long nativeBuilder, long nativeEngine);
 
     private static native int nGetWidth(long nativeTexture, int level);
@@ -1242,25 +1158,37 @@ public class Texture {
     private static native int nGetTarget(long nativeTexture);
     private static native int nGetInternalFormat(long nativeTexture);
 
+    private static native int nSetImage(long nativeTexture, long nativeEngine,
+            int level, int xoffset, int yoffset, int width, int height,
+            Buffer storage, int remaining, int left, int bottom, int type, int alignment,
+            int stride, int format,
+            Object handler, Runnable callback);
+
+    private static native int nSetImageCompressed(long nativeTexture, long nativeEngine,
+            int level, int xoffset, int yoffset, int width, int height,
+            Buffer storage, int remaining, int left, int bottom, int type, int alignment,
+            int compressedSizeInBytes, int compressedFormat,
+            Object handler, Runnable callback);
+
     private static native int nSetImage3D(long nativeTexture, long nativeEngine,
             int level, int xoffset, int yoffset, int zoffset, int width, int height, int depth,
-            Buffer storage, int remaining, int left, int top, int type, int alignment,
+            Buffer storage, int remaining, int left, int bottom, int type, int alignment,
             int stride, int format,
             Object handler, Runnable callback);
 
     private static native int nSetImage3DCompressed(long nativeTexture, long nativeEngine,
             int level, int xoffset, int yoffset, int zoffset, int width, int height, int depth,
-            Buffer storage, int remaining, int left, int top, int type, int alignment,
+            Buffer storage, int remaining, int left, int bottom, int type, int alignment,
             int compressedSizeInBytes, int compressedFormat,
             Object handler, Runnable callback);
 
     private static native int nSetImageCubemap(long nativeTexture, long nativeEngine,
-            int level, Buffer storage, int remaining, int left, int top, int type,
+            int level, Buffer storage, int remaining, int left, int bottom, int type,
             int alignment, int stride, int format,
             int[] faceOffsetsInBytes, Object handler, Runnable callback);
 
     private static native int nSetImageCubemapCompressed(long nativeTexture, long nativeEngine,
-            int level, Buffer storage, int remaining, int left, int top, int type,
+            int level, Buffer storage, int remaining, int left, int bottom, int type,
             int alignment, int compressedSizeInBytes, int compressedFormat,
             int[] faceOffsetsInBytes, Object handler, Runnable callback);
 

android/filament-android/src/main/java/com/google/android/filament/TextureSampler.java

@@ -22,14 +22,6 @@ import androidx.annotation.NonNull;
  * <code>TextureSampler</code> defines how a texture is accessed.
  */
 public class TextureSampler {
-    static final class EnumCache {
-        static final MinFilter[] sMinFilterValues = MinFilter.values();
-        static final MagFilter[] sMagFilterValues = MagFilter.values();
-        static final WrapMode[] sWrapModeValues = WrapMode.values();
-        static final CompareMode[] sCompareModeValues = CompareMode.values();
-        static final CompareFunction[] sCompareFunctionValues = CompareFunction.values();
-    }
-
     public enum WrapMode {
         /**
          * The edge of the texture extends to infinity.
@@ -210,7 +202,7 @@ public class TextureSampler {
      * @return the minification filter
      */
     public MinFilter getMinFilter() {
-        return EnumCache.sMinFilterValues[nGetMinFilter(mSampler)];
+        return MinFilter.values()[nGetMinFilter(mSampler)];
     }
 
     /**
@@ -226,7 +218,7 @@ public class TextureSampler {
      * @return the magnification filter
      */
     public MagFilter getMagFilter() {
-        return EnumCache.sMagFilterValues[nGetMagFilter(mSampler)];
+        return MagFilter.values()[nGetMagFilter(mSampler)];
     }
 
     /**
@@ -242,7 +234,7 @@ public class TextureSampler {
      * @return the wrapping mode in the s (horizontal) direction
      */
     public WrapMode getWrapModeS() {
-        return EnumCache.sWrapModeValues[nGetWrapModeS(mSampler)];
+        return WrapMode.values()[nGetWrapModeS(mSampler)];
     }
 
     /**
@@ -257,7 +249,7 @@ public class TextureSampler {
      * @return the wrapping mode in the t (vertical) direction
      */
     public WrapMode getWrapModeT() {
-        return EnumCache.sWrapModeValues[nGetWrapModeT(mSampler)];
+        return WrapMode.values()[nGetWrapModeT(mSampler)];
     }
 
     /**
@@ -272,7 +264,7 @@ public class TextureSampler {
      * @return the wrapping mode in the r (depth) direction
      */
     public WrapMode getWrapModeR() {
-        return EnumCache.sWrapModeValues[nGetWrapModeR(mSampler)];
+        return WrapMode.values()[nGetWrapModeR(mSampler)];
     }
 
     /**
@@ -305,7 +297,7 @@ public class TextureSampler {
      * @return the comparison mode
      */
     public CompareMode getCompareMode() {
-        return EnumCache.sCompareModeValues[nGetCompareMode(mSampler)];
+        return CompareMode.values()[nGetCompareMode(mSampler)];
     }
 
     /**
@@ -321,7 +313,7 @@ public class TextureSampler {
      * @return the comparison function
      */
     public CompareFunction getCompareFunction() {
-        return EnumCache.sCompareFunctionValues[nGetCompareFunction(mSampler)];
+        return CompareFunction.values()[nGetCompareFunction(mSampler)];
     }
 
     /**

android/filament-android/src/main/java/com/google/android/filament/ToneMapper.java

@@ -1,210 +0,0 @@
-package com.google.android.filament;
-
-/**
- * Interface for tone mapping operators. A tone mapping operator, or tone mapper,
- * is responsible for compressing the dynamic range of the rendered scene to a
- * dynamic range suitable for display.
- *
- * In Filament, tone mapping is a color grading step. ToneMapper instances are
- * created and passed to the ColorGrading::Builder to produce a 3D LUT that will
- * be used during post-processing to prepare the final color buffer for display.
- *
- * Filament provides several default tone mapping operators that fall into three
- * categories:
- *
- * <ul>
- * <li>Configurable tone mapping operators</li>
- * <ul>
- *   <li>GenericToneMapper</li>
- * </ul>
- * <li>Fixed-aesthetic tone mapping operators</li>
- * <ul>
- *   <li>ACESToneMapper</li>
- *   <li>ACESLegacyToneMapper</li>
- *   <li>FilmicToneMapper</li>
- * </ul>
- * <li>Debug/validation tone mapping operators</li>
- * <ul>
- *   <li>LinearToneMapper</li>
- *   <li>DisplayRangeToneMapper</li>
- * </ul>
- * </ul>
- *
- * You can create custom tone mapping operators by subclassing ToneMapper.
- */
-public class ToneMapper {
-    private final long mNativeObject;
-
-    private ToneMapper(long nativeObject) {
-        mNativeObject = nativeObject;
-    }
-
-    public long getNativeObject() {
-        if (mNativeObject == 0) {
-            throw new IllegalStateException("Calling method on destroyed ToneMapper");
-        }
-        return mNativeObject;
-    }
-
-    @Override
-    protected void finalize() throws Throwable {
-        try {
-            super.finalize();
-        } finally {
-            nDestroyToneMapper(mNativeObject);
-        }
-    }
-
-    /**
-     * Linear tone mapping operator that returns the input color but clamped to
-     * the 0..1 range. This operator is mostly useful for debugging.
-     */
-    public static class Linear extends ToneMapper {
-        public Linear() {
-            super(nCreateLinearToneMapper());
-        }
-    }
-
-    /**
-     * ACES tone mapping operator. This operator is an implementation of the
-     * ACES Reference Rendering Transform (RRT) combined with the Output Device
-     * Transform (ODT) for sRGB monitors (dim surround, 100 nits).
-     */
-    public static class ACES extends ToneMapper {
-        public ACES() {
-            super(nCreateACESToneMapper());
-        }
-    }
-
-    /**
-     * ACES tone mapping operator, modified to match the perceived brightness
-     * of FilmicToneMapper. This operator is the same as ACESToneMapper but
-     * applies a brightness multiplier of ~1.6 to the input color value to
-     * target brighter viewing environments.
-     */
-    public static class ACESLegacy extends ToneMapper {
-        public ACESLegacy() {
-            super(nCreateACESLegacyToneMapper());
-        }
-    }
-
-    /**
-     * "Filmic" tone mapping operator. This tone mapper was designed to
-     * approximate the aesthetics of the ACES RRT + ODT for Rec.709
-     * and historically Filament's default tone mapping operator. It exists
-     * only for backward compatibility purposes and is not otherwise recommended.
-     */
-    public static class Filmic extends ToneMapper {
-        public Filmic() {
-            super(nCreateFilmicToneMapper());
-        }
-    }
-
-    /**
-     * Generic tone mapping operator that gives control over the tone mapping
-     * curve. This operator can be used to control the aesthetics of the final
-     * image. This operator also allows to control the dynamic range of the
-     * scene referred values.
-     *
-     * The tone mapping curve is defined by 5 parameters:
-     * <ul>
-     * <li>contrast: controls the contrast of the curve</li>
-     * referred values map to output white</li>
-     * <li>midGrayIn: sets the input middle gray</li>
-     * <li>midGrayOut: sets the output middle gray</li>
-     * <li>hdrMax: defines the maximum input value that will be mapped to
-     * output white</li>
-     * </ul>
-     */
-    public static class Generic extends ToneMapper {
-        /**
-         * Builds a new generic tone mapper parameterized to closely approximate
-         * the {@link ACESLegacy} tone mapper. The default values are:
-         *
-         * <ul>
-         * <li>contrast = 1.55f</li>
-         * <li>midGrayIn = 0.18f</li>
-         * <li>midGrayOut = 0.215f</li>
-         * <li>hdrMax = 10.0f</li>
-         * </ul>
-         */
-        public Generic() {
-            this(1.55f, 0.18f, 0.215f, 10.0f);
-        }
-
-        /**
-         * Builds a new generic tone mapper.
-         *
-         * @param contrast: controls the contrast of the curve, must be > 0.0, values
-         *                  in the range 0.5..2.0 are recommended.
-         * @param midGrayIn: sets the input middle gray, between 0.0 and 1.0.
-         * @param midGrayOut: sets the output middle gray, between 0.0 and 1.0.
-         * @param hdrMax: defines the maximum input value that will be mapped to
-         *                output white. Must be >= 1.0.
-         */
-        public Generic(
-                float contrast, float midGrayIn, float midGrayOut, float hdrMax) {
-            super(nCreateGenericToneMapper(contrast, midGrayIn, midGrayOut, hdrMax));
-        }
-
-        /** Returns the contrast of the curve as a strictly positive value. */
-        public float getContrast() {
-            return nGenericGetContrast(getNativeObject());
-        }
-
-        /** Sets the contrast of the curve, must be > 0.0, values in the range 0.5..2.0 are recommended. */
-        public void setContrast(float contrast) {
-            nGenericSetContrast(getNativeObject(), contrast);
-        }
-
-        /** Returns the middle gray point for input values as a value between 0.0 and 1.0. */
-        public float getMidGrayIn() {
-            return nGenericGetMidGrayIn(getNativeObject());
-        }
-
-        /** Sets the input middle gray, between 0.0 and 1.0. */
-        public void setMidGrayIn(float midGrayIn) {
-            nGenericSetMidGrayIn(getNativeObject(), midGrayIn);
-        }
-
-        /** Returns the middle gray point for output values as a value between 0.0 and 1.0. */
-        public float getMidGrayOut() {
-            return nGenericGetMidGrayOut(getNativeObject());
-        }
-
-        /** Sets the output middle gray, between 0.0 and 1.0. */
-        public void setMidGrayOut(float midGrayOut) {
-            nGenericSetMidGrayOut(getNativeObject(), midGrayOut);
-        }
-
-        /** Returns the maximum input value that will map to output white, as a value >= 1.0. */
-        public float getHdrMax() {
-            return nGenericGetHdrMax(getNativeObject());
-        }
-
-        /** Defines the maximum input value that will be mapped to output white. Must be >= 1.0. */
-        public void setHdrMax(float hdrMax) {
-            nGenericSetHdrMax(getNativeObject(), hdrMax);
-        }
-    }
-
-    private static native void nDestroyToneMapper(long nativeObject);
-
-    private static native long nCreateLinearToneMapper();
-    private static native long nCreateACESToneMapper();
-    private static native long nCreateACESLegacyToneMapper();
-    private static native long nCreateFilmicToneMapper();
-    private static native long nCreateGenericToneMapper(
-            float contrast, float midGrayIn, float midGrayOut, float hdrMax);
-
-    // Generic tone mappper
-    private static native float nGenericGetContrast(long nativeObject);
-    private static native float nGenericGetMidGrayIn(long nativeObject);
-    private static native float nGenericGetMidGrayOut(long nativeObject);
-    private static native float nGenericGetHdrMax(long nativeObject);
-
-    private static native void nGenericSetContrast(long nativeObject, float contrast);
-    private static native void nGenericSetMidGrayIn(long nativeObject, float midGrayIn);
-    private static native void nGenericSetMidGrayOut(long nativeObject, float midGrayOut);
-    private static native void nGenericSetHdrMax(long nativeObject, float hdrMax);
-}

android/filament-android/src/main/java/com/google/android/filament/TransformManager.java

@@ -16,7 +16,6 @@
 
 package com.google.android.filament;
 
-import androidx.annotation.IntRange;
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 import androidx.annotation.Size;
@@ -84,35 +83,6 @@ import androidx.annotation.Size;
         return nGetInstance(mNativeObject, entity);
     }
 
-    /**
-     * Enables or disable the accurate translation mode. Disabled by default.
-     *
-     * When accurate translation mode is active, the translation component of all transforms is
-     * maintained at double precision. This is only useful if the mat4 version of setTransform()
-     * is used, as well as getTransformAccurate().
-     *
-     * @param enable true to enable the accurate translation mode, false to disable.
-     *
-     * @see #isAccurateTranslationsEnabled
-     * @see #create(int, int, double[])
-     * @see #setTransform(int, double[])
-     * @see #getTransform(int, double[])
-     * @see #getWorldTransform(int, double[])
-     */
-    public void setAccurateTranslationsEnabled(boolean enable) {
-        nSetAccurateTranslationsEnabled(mNativeObject, enable);
-    }
-
-    /**
-     * Returns whether the high precision translation mode is active.
-     *
-     * @return true if accurate translations mode is active, false otherwise
-     * @see #setAccurateTranslationsEnabled
-     */
-    public boolean isAccurateTranslationsEnabled() {
-        return nIsAccurateTranslationsEnabled(mNativeObject);
-    }
-
     /**
      * Creates a transform component and associates it with the given entity. The component is
      * initialized with the identity transform.
@@ -144,23 +114,6 @@ import androidx.annotation.Size;
         return nCreateArray(mNativeObject, entity, parent, localTransform);
     }
 
-    /**
-     * Creates a transform component with a parent and associates it with the given entity.
-     * If this component already exists on the given entity, it is first
-     * destroyed as if {@link #destroy} was called.
-     *
-     * @param entity         an {@link Entity} to associate a transform component to.
-     * @param parent         the  {@link EntityInstance} of the parent transform
-     * @param localTransform the transform, relative to the parent, to initialize the transform
-     *                       component with.
-     * @see #destroy
-     */
-    @EntityInstance
-    public int create(@Entity int entity, @EntityInstance int parent,
-            @Nullable @Size(min = 16) double[] localTransform) {
-        return nCreateArrayFp64(mNativeObject, entity, parent, localTransform);
-    }
-
     /**
      * Destroys this component from the given entity, children are orphaned.
      *
@@ -187,49 +140,6 @@ import androidx.annotation.Size;
         nSetParent(mNativeObject, i, newParent);
     }
 
-    /**
-     * Returns the actual parent entity of an {@link EntityInstance} originally defined
-     * by {@link #setParent(int, int)}.
-     *
-     * @param i the {@link EntityInstance} of the transform component to get the parent from.
-     * @return the parent {@link Entity}.
-     * @see #getInstance
-     */
-    @Entity
-    public int getParent(@EntityInstance int i) {
-        return nGetParent(mNativeObject, i);
-    }
-
-    /**
-     * Returns the number of children of an {@link EntityInstance}.
-     *
-     * @param i the {@link EntityInstance} of the transform component to query.
-     * @return The number of children of the queried component.
-     */
-    public int getChildCount(@EntityInstance int i) {
-        return nGetChildCount(mNativeObject, i);
-    }
-
-    /**
-     * Gets a list of children for a transform component.
-     *
-     * @param i           the {@link EntityInstance} of the transform component to get the children
-     *                    from.
-     * @param outEntities array to receive the result sized to the maximum number of children to
-     *                    retrieve. If <code>null</code> is given, a new suitable array sized to
-     *                    {@link #getChildCount(int)} is allocated.
-     * @return Array of retrieved children {@link Entity}.
-     */
-    public @Entity @NonNull int[] getChildren(@EntityInstance int i, @Nullable int[] outEntities) {
-        if (outEntities == null) {
-            outEntities = new int[getChildCount(i)];
-        }
-        if (outEntities.length > 0) {
-            nGetChildren(mNativeObject, i, outEntities, outEntities.length);
-        }
-        return outEntities;
-    }
-
     /**
      * Sets a local transform of a transform component.
      * <p>This operation can be slow if the hierarchy of transform is too deep, and this
@@ -247,24 +157,6 @@ import androidx.annotation.Size;
         nSetTransform(mNativeObject, i, localTransform);
     }
 
-    /**
-     * Sets a local transform of a transform component.
-     * <p>This operation can be slow if the hierarchy of transform is too deep, and this
-     * will be particularly bad when updating a lot of transforms. In that case,
-     * consider using {@link #openLocalTransformTransaction} / {@link #commitLocalTransformTransaction}.</p>
-     *
-     * @param i              the {@link EntityInstance} of the transform component to set the local
-     *                       transform to.
-     * @param localTransform the local transform (i.e. relative to the parent).
-     * @see #getTransform(int, double[])
-     * @see #getWorldTransform(int, double[])
-     */
-    public void setTransform(@EntityInstance int i,
-            @NonNull @Size(min = 16) double[] localTransform) {
-        Asserts.assertMat4In(localTransform);
-        nSetTransformFp64(mNativeObject, i, localTransform);
-    }
-
     /**
      * Returns the local transform of a transform component.
      *
@@ -285,26 +177,6 @@ import androidx.annotation.Size;
         return outLocalTransform;
     }
 
-    /**
-     * Returns the local transform of a transform component.
-     *
-     * @param i                 the {@link EntityInstance} of the transform component to query the
-     *                          local transform from.
-     * @param outLocalTransform a 16 <code>float</code> array to receive the result.
-     *                          If <code>null</code> is given,  a new suitable array is allocated.
-     * @return the local transform of the component (i.e. relative to the parent). This always
-     * returns the value set by setTransform().
-     * @see #setTransform
-     */
-    @NonNull
-    @Size(min = 16)
-    public double[] getTransform(@EntityInstance int i,
-            @Nullable @Size(min = 16) double[] outLocalTransform) {
-        outLocalTransform = Asserts.assertMat4(outLocalTransform);
-        nGetTransformFp64(mNativeObject, i, outLocalTransform);
-        return outLocalTransform;
-    }
-
     /**
      * Returns the world transform of a transform component.
      *
@@ -325,26 +197,6 @@ import androidx.annotation.Size;
         return outWorldTransform;
     }
 
-    /**
-     * Returns the world transform of a transform component.
-     *
-     * @param i                 the {@link EntityInstance} of the transform component to query the
-     *                          world transform from.
-     * @param outWorldTransform a 16 <code>float</code> array to receive the result.
-     *                          If <code>null</code> is given,  a new suitable array is allocated
-     * @return The world transform of the component (i.e. relative to the root). This is the
-     * composition of this component's local transform with its parent's world transform.
-     * @see #setTransform
-     */
-    @NonNull
-    @Size(min = 16)
-    public double[] getWorldTransform(@EntityInstance int i,
-            @Nullable @Size(min = 16) double[] outWorldTransform) {
-        outWorldTransform = Asserts.assertMat4(outWorldTransform);
-        nGetWorldTransformFp64(mNativeObject, i, outWorldTransform);
-        return outWorldTransform;
-    }
-
     /**
      * Opens a local transform transaction. During a transaction, {@link #getWorldTransform} can
      * return an invalid transform until {@link #commitLocalTransformTransaction} is called.
@@ -387,20 +239,11 @@ import androidx.annotation.Size;
     private static native int nGetInstance(long nativeTransformManager, int entity);
     private static native int nCreate(long nativeTransformManager, int entity);
     private static native int nCreateArray(long mNativeObject, int entity, int parent, float[] localTransform);
-    private static native int nCreateArrayFp64(long mNativeObject, int entity, int parent, double[] localTransform);
     private static native void nDestroy(long nativeTransformManager, int entity);
     private static native void nSetParent(long nativeTransformManager, int i, int newParent);
-    private static native int nGetParent(long nativeTransformManager, int i);
-    private static native int nGetChildCount(long nativeTransformManager, int i);
-    private static native void nGetChildren(long nativeEntityManager, int i, int[] outEntities, int count);
     private static native void nSetTransform(long nativeTransformManager, int i, float[] localTransform);
-    private static native void nSetTransformFp64(long nativeTransformManager, int i, double[] localTransform);
     private static native void nGetTransform(long nativeTransformManager, int i, float[] outLocalTransform);
-    private static native void nGetTransformFp64(long nativeTransformManager, int i, double[] outLocalTransform);
     private static native void nGetWorldTransform(long nativeTransformManager, int i, float[] outWorldTransform);
-    private static native void nGetWorldTransformFp64(long nativeTransformManager, int i, double[] outWorldTransform);
     private static native void nOpenLocalTransformTransaction(long nativeTransformManager);
     private static native void nCommitLocalTransformTransaction(long nativeTransformManager);
-    private static native void nSetAccurateTranslationsEnabled(long nativeTransformManager, boolean enable);
-    private static native boolean nIsAccurateTranslationsEnabled(long nativeTransformManager);
 }

android/filament-android/src/main/java/com/google/android/filament/VertexBuffer.java

@@ -104,6 +104,48 @@ public class VertexBuffer {
         HALF3,
         HALF4,
     }
+    /**
+     * Specifies the quaternion type for the {@link #populateTangentQuaternions} utility.
+     */
+    public enum QuatType {
+        /** 2 bytes per component as half-floats (8 bytes per quat) */
+        HALF4,
+
+        /** 2 bytes per component as normalized integers (8 bytes per quat) */
+        SHORT4,
+
+        /** 4 bytes per component as floats (16 bytes per quat) */
+        FLOAT4,
+    }
+
+    /**
+     * Specifies the parameters for the {@link #populateTangentQuaternions} utility.
+     */
+    public static class QuatTangentContext {
+        /** desired quaternion type (required) */
+        public QuatType quatType;
+
+        /** number of quaternions (required) */
+        public int quatCount;
+
+        /** pre-allocated output buffer (required) */
+        public Buffer outBuffer;
+
+        /** desired stride in bytes (optional) */
+        public int outStride;
+
+        /** source normals (required) */
+        public Buffer normals;
+
+        /** normals stride in bytes (optional) */
+        public int normalsStride;
+
+        /** source tangents (optional) */
+        public Buffer tangents;
+
+        /** tangents stride in bytes (optional) */
+        public int tangentsStride;
+    }
 
     public static class Builder {
         @SuppressWarnings({"FieldCanBeLocal", "UnusedDeclaration"}) // Keep to finalize native resources
@@ -128,21 +170,6 @@ public class VertexBuffer {
             return this;
         }
 
-        /**
-         * Allows buffers to be swapped out and shared using BufferObject.
-         *
-         * If buffer objects mode is enabled, clients must call setBufferObjectAt rather than
-         * setBufferAt. This allows sharing of data between VertexBuffer objects, but it may
-         * slightly increase the memory footprint of Filament's internal bookkeeping.
-         *
-         * @param enabled If true, enables buffer object mode.  False by default.
-         */
-        @NonNull
-        public Builder enableBufferObjects(boolean enabled) {
-            nBuilderEnableBufferObjects(mNativeBuilder, enabled);
-            return this;
-        }
-
         /**
          * Defines how many buffers will be created in this vertex buffer set. These buffers are
          * later referenced by index from 0 to <code>bufferCount</code> - 1.
@@ -370,21 +397,36 @@ public class VertexBuffer {
             throw new BufferOverflowException();
         }
     }
-
     /**
-     * Swaps in the given buffer object.
+     * Convenience function that consumes normal vectors (and, optionally, tangent vectors) and
+     * produces quaternions that can be passed into a TANGENTS buffer.
      *
-     * To use this, you must first call enableBufferObjects() on the Builder.
+     * <p>
+     * The given output buffer must be preallocated with at least quatCount * outStride bytes.
+     * <p>
      *
-     * @param engine Reference to the filament::Engine to associate this VertexBuffer with.
-     * @param bufferIndex Index of the buffer to initialize. Must be between 0
-     *                    and Builder::bufferCount() - 1.
-     * @param bufferObject The handle to the GPU data that will be used in this buffer slot.
+     * <p>
+     * Normals are required but tangents are optional, in which case this function tries to generate
+     * reasonable tangents. The given normals should be unit length.
+     * </p>
+     *
+     * <p>
+     * If supplied, the tangent vectors should be unit length and should be orthogonal to the
+     * normals. The w component of the tangent is a sign (-1 or +1) indicating handedness of the
+     * basis.
+     * </p>
+     *
+     * @deprecated Instead please use SurfaceOrientation since it has additional capabilities and a
+     * builder-style API.
+     *
+     * @param context an initialized QuatTangentContext object
      */
-    public void setBufferObjectAt(@NonNull Engine engine, int bufferIndex,
-            @NonNull BufferObject bufferObject) {
-        nSetBufferObjectAt(getNativeObject(), engine.getNativeObject(), bufferIndex,
-                bufferObject.getNativeObject());
+    public static void populateTangentQuaternions(@NonNull QuatTangentContext context) {
+        nPopulateTangentQuaternions(context.quatType.ordinal(), context.quatCount,
+                context.outBuffer, context.outBuffer.remaining(), context.outStride,
+                context.normals, context.normals.remaining(), context.normalsStride,
+                context.tangents, context.tangents != null ? context.tangents.remaining() : 0,
+                context.tangentsStride);
     }
 
     public long getNativeObject() {
@@ -401,7 +443,6 @@ public class VertexBuffer {
     private static native long nCreateBuilder();
     private static native void nDestroyBuilder(long nativeBuilder);
     private static native void nBuilderVertexCount(long nativeBuilder, int vertexCount);
-    private static native void nBuilderEnableBufferObjects(long nativeBuilder, boolean enabled);
     private static native void nBuilderBufferCount(long nativeBuilder, int bufferCount);
     private static native void nBuilderAttribute(long nativeBuilder, int attribute,
             int bufferIndex, int attributeType, int byteOffset, int byteStride);
@@ -414,6 +455,7 @@ public class VertexBuffer {
             int bufferIndex, Buffer buffer, int remaining, int destOffsetInBytes, int count,
             Object handler, Runnable callback);
 
-    private static native void nSetBufferObjectAt(long nativeVertexBuffer, long nativeEngine,
-            int bufferIndex, long nativeBufferObject);
+    private static native void nPopulateTangentQuaternions(int quatType, int quatCount,
+            Buffer outBuffer, int outRemaining, int outStride, Buffer normals, int normalsRemaining,
+            int normalsStride, Buffer tangents, int tangentsRemaining, int tangentsStride);
 }

android/filament-android/src/main/java/com/google/android/filament/android/DisplayHelper.java

@@ -157,6 +157,8 @@ public class DisplayHelper {
             info = new Renderer.DisplayInfo();
         }
         info.refreshRate = DisplayHelper.getRefreshRate(display);
+        info.presentationDeadlineNanos = DisplayHelper.getPresentationDeadlineNanos(display);
+        info.vsyncOffsetNanos = DisplayHelper.getAppVsyncOffsetNanos(display);
         return info;
     }
 

android/filament-android/src/main/java/com/google/android/filament/android/TextureHelper.java

@@ -23,6 +23,8 @@ import androidx.annotation.NonNull;
 import com.google.android.filament.Engine;
 import com.google.android.filament.Texture;
 
+import java.lang.reflect.Method;
+
 public final class TextureHelper {
     // Keep in sync with Texture.cpp
     private static final int BITMAP_CONFIG_ALPHA_8    = 0;

android/filament-android/src/main/java/com/google/android/filament/android/UiHelper.java

@@ -30,8 +30,8 @@ import android.view.TextureView;
 import com.google.android.filament.SwapChain;
 
 /**
- * UiHelper is a simple class that can manage either a SurfaceView, TextureView, or a SurfaceHolder
- * so it can be used to render into with Filament.
+ * UiHelper is a simple class that can manage either a SurfaceView or a TextureView so it can
+ * be used to render into with Filament.
  *
  * Here is a simple example with a SurfaceView. The code would be exactly the same with a
  * TextureView:
@@ -191,23 +191,6 @@ public class UiHelper {
         }
     }
 
-    private static class SurfaceHolderHandler implements RenderSurface {
-        private SurfaceHolder mSurfaceHolder;
-
-        SurfaceHolderHandler(SurfaceHolder surface) {
-            mSurfaceHolder = surface;
-        }
-
-        @Override
-        public void resize(int width, int height) {
-            mSurfaceHolder.setFixedSize(width, height);
-        }
-
-        @Override
-        public void detach() {
-        }
-    }
-
     private class TextureViewHandler implements RenderSurface {
         private TextureView mTextureView;
         private Surface mSurface;
@@ -275,8 +258,8 @@ public class UiHelper {
     }
 
     /**
-     * Free resources associated to the native window specified in {@link #attachTo(SurfaceView)},
-     * {@link #attachTo(TextureView)}, or {@link #attachTo(SurfaceHolder)}.
+     * Free resources associated to the native window specified in {@link #attachTo(SurfaceView)}
+     * or {@link #attachTo(TextureView)}.
      */
     public void detach() {
         destroySwapChain();
@@ -332,8 +315,8 @@ public class UiHelper {
      * Controls whether the render target (SurfaceView or TextureView) is opaque or not.
      * The render target is considered opaque by default.
      *
-     * Must be called before calling {@link #attachTo(SurfaceView)}, {@link #attachTo(TextureView)},
-     * or {@link #attachTo(SurfaceHolder)}.
+     * Must be called before calling {@link #attachTo(SurfaceView)}
+     * or {@link #attachTo(TextureView)}.
      *
      * @param opaque Indicates whether the render target should be opaque. True by default.
      */
@@ -358,8 +341,6 @@ public class UiHelper {
      * Must be called before calling {@link #attachTo(SurfaceView)}
      * or {@link #attachTo(TextureView)}.
      *
-     * Has no effect when using {@link #attachTo(SurfaceHolder)}.
-     *
      * @param overlay Indicates whether the render target should be rendered below the activity's
      *                surface when transparent.
      */
@@ -422,9 +403,7 @@ public class UiHelper {
 
             SurfaceHolder holder = view.getHolder();
             holder.addCallback(callback);
-            if (mDesiredWidth > 0 && mDesiredHeight > 0) {
-                holder.setFixedSize(mDesiredWidth, mDesiredHeight);
-            }
+            holder.setFixedSize(mDesiredWidth, mDesiredHeight);
 
             // in case the SurfaceView's surface already existed
             final Surface surface = holder.getSurface();
@@ -504,55 +483,6 @@ public class UiHelper {
         }
     }
 
-    /**
-     * Associate UiHelper with a SurfaceHolder.
-     *
-     * As soon as a Surface is created, we'll create the
-     * EGL resources needed, and call user callbacks if needed.
-     */
-    public void attachTo(@NonNull SurfaceHolder holder) {
-        if (attach(holder)) {
-            int format = isOpaque() ? PixelFormat.OPAQUE : PixelFormat.TRANSLUCENT;
-            holder.setFormat(format);
-
-            mRenderSurface = new SurfaceHolderHandler(holder);
-
-            final SurfaceHolder.Callback callback = new SurfaceHolder.Callback() {
-                @Override
-                public void surfaceCreated(SurfaceHolder surfaceHolder) {
-                    if (LOGGING) Log.d(LOG_TAG, "surfaceCreated()");
-                    createSwapChain(holder.getSurface());
-                }
-
-                @Override
-                public void surfaceChanged(SurfaceHolder holder, int format, int width, int height) {
-                    // Note: this is always called at least once after surfaceCreated()
-                    if (LOGGING) Log.d(LOG_TAG, "surfaceChanged(" + width + ", " + height + ")");
-                    mRenderCallback.onResized(width, height);
-                }
-
-                @Override
-                public void surfaceDestroyed(SurfaceHolder surfaceHolder) {
-                    if (LOGGING) Log.d(LOG_TAG, "surfaceDestroyed()");
-                    destroySwapChain();
-                }
-            };
-
-            holder.addCallback(callback);
-            if (mDesiredWidth > 0 && mDesiredHeight > 0) {
-                holder.setFixedSize(mDesiredWidth, mDesiredHeight);
-            }
-
-            // in case the SurfaceHolder's surface already existed
-            final Surface surface = holder.getSurface();
-            if (surface != null && surface.isValid()) {
-                callback.surfaceCreated(holder);
-                callback.surfaceChanged(holder, format,
-                        holder.getSurfaceFrame().width(), holder.getSurfaceFrame().height());
-            }
-        }
-    }
-
     private boolean attach(@NonNull Object nativeWindow) {
         if (mNativeWindow != null) {
             // we are already attached to a native window

android/filament-utils-android/CMakeLists.txt

@@ -1,8 +1,6 @@
-cmake_minimum_required(VERSION 3.19)
-project(filament-utils-android)
+cmake_minimum_required(VERSION 3.6)
 
 set(FILAMENT_DIR ${FILAMENT_DIST_DIR})
-set(IMAGEIO_DIR ../../libs/imageio)
 
 add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/../gltfio-android ${CMAKE_CURRENT_BINARY_DIR}/gltfio-android)
 
@@ -14,60 +12,27 @@ add_library(image STATIC IMPORTED)
 set_target_properties(image PROPERTIES IMPORTED_LOCATION
         ${FILAMENT_DIR}/lib/${ANDROID_ABI}/libimage.a)
 
-add_library(ktxreader STATIC IMPORTED)
-set_target_properties(ktxreader PROPERTIES IMPORTED_LOCATION
-        ${FILAMENT_DIR}/lib/${ANDROID_ABI}/libktxreader.a)
-
-add_library(viewer STATIC IMPORTED)
-set_target_properties(viewer PROPERTIES IMPORTED_LOCATION
-        ${FILAMENT_DIR}/lib/${ANDROID_ABI}/libviewer.a)
-
-add_library(civetweb STATIC IMPORTED)
-set_target_properties(civetweb PROPERTIES IMPORTED_LOCATION
-        ${FILAMENT_DIR}/lib/${ANDROID_ABI}/libcivetweb.a)
-
-add_library(iblprefilter STATIC IMPORTED)
-set_target_properties(iblprefilter PROPERTIES IMPORTED_LOCATION
-        ${FILAMENT_DIR}/lib/${ANDROID_ABI}/libfilament-iblprefilter.a)
+include_directories(${FILAMENT_DIR}/include
+        ..
+        ../../libs/utils/include)
 
 set(CMAKE_SHARED_LINKER_FLAGS_RELEASE "${CMAKE_SHARED_LINKER_FLAGS_RELEASE} -Wl,--version-script=${CMAKE_CURRENT_SOURCE_DIR}/libfilament-utils-jni.map")
 
 add_library(filament-utils-jni SHARED
-        src/main/cpp/AutomationEngine.cpp
         src/main/cpp/Bookmark.cpp
-        src/main/cpp/HDRLoader.cpp
-        src/main/cpp/IBLPrefilterContext.cpp
         src/main/cpp/Utils.cpp
         src/main/cpp/Manipulator.cpp
-        src/main/cpp/RemoteServer.cpp
-
-        ${IMAGEIO_DIR}/include/imageio/ImageDecoder.h
-        ${IMAGEIO_DIR}/include/imageio/HDRDecoder.h
-        ${IMAGEIO_DIR}/src/HDRDecoder.cpp
 
         ../common/CallbackUtils.cpp
         ../common/NioUtils.cpp
 )
 
-target_compile_definitions(filament-utils-jni PUBLIC IMAGEIO_LITE=1)
-
-target_include_directories(filament-utils-jni PRIVATE
-        ${FILAMENT_DIR}/include
-        ..
-        ../../filament/backend/include
-        ${IMAGEIO_DIR}/include
-        ../../libs/utils/include)
-
 set_target_properties(filament-utils-jni PROPERTIES LINK_DEPENDS
         ${CMAKE_CURRENT_SOURCE_DIR}/libfilament-utils-jni.symbols)
 
 # The ordering in the following list is important because CMake does not have dependency information.
 target_link_libraries(filament-utils-jni
         gltfio-jni
-        civetweb
         camutils
-        iblprefilter
         image
-        ktxreader
-        viewer
 )

android/filament-utils-android/build.gradle

@@ -1,7 +1,17 @@
 apply plugin: 'kotlin-android'
+apply plugin: 'kotlin-android-extensions'
 
 android {
-    namespace 'com.google.android.filament.utils'
+    flavorDimensions "functionality"
+    productFlavors {
+        full {
+            dimension "functionality"
+        }
+
+        lite {
+            dimension "functionality"
+        }
+    }
 
     sourceSets {
         main {
@@ -9,17 +19,13 @@ android {
         }
     }
 
-    defaultConfig {
-        missingDimensionStrategy 'functionality', 'full'
-    }
+    // No need to package up the following shared libs, which arise as a side effect of our
+    // externalNativeBuild dependencies. When clients pick and choose from project-level gradle
+    // dependencies, these shared libs already get pulled in, so we need to avoid the error:
+    // "More than one file was found with OS independent path ..."
     packagingOptions {
-        // No need to package up the following shared libs, which arise as a side effect of our
-        // externalNativeBuild dependencies. When clients pick and choose from project-level gradle
-        // dependencies, these shared libs already get pulled in, so we need to avoid the error:
-        // "More than one file was found with OS independent path ..."
-        jniLibs {
-            excludes += ['lib/*/libfilament-jni.so', 'lib/*/libgltfio-jni.so']
-        }
+        exclude 'lib/*/libfilament-jni.so'
+        exclude 'lib/*/libgltfio-jni.so'
     }
 }
 
@@ -38,12 +44,13 @@ configurations.all { config ->
 dependencies {
     implementation deps.kotlin
     implementation deps.androidx.annotations
+    implementation project(':filament-android')
 
-    implementation deps.coroutines.core
-    implementation deps.coroutines.android
+    implementation 'org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.3'
+    implementation 'org.jetbrains.kotlinx:kotlinx-coroutines-android:1.3.3'
 
-    api project(':filament-android')
-    api module("com.google.android.filament:gltfio-android:${VERSION_NAME}")
+    fullImplementation module("com.google.android.filament:gltfio-android:${VERSION_NAME}")
+    liteImplementation module("com.google.android.filament:gltfio-android-lite:${VERSION_NAME}")
 }
 
 apply from: rootProject.file('gradle/gradle-mvn-push.gradle')
@@ -51,9 +58,14 @@ apply from: rootProject.file('gradle/gradle-mvn-push.gradle')
 afterEvaluate {
     publishing {
         publications {
-            release(MavenPublication) {
-                artifactId = POM_ARTIFACT_ID
-                from components.release
+            fullRelease(MavenPublication) {
+                artifactId = POM_ARTIFACT_ID_FULL
+                from components.fullRelease
+            }
+
+            liteRelease(MavenPublication) {
+                artifactId = POM_ARTIFACT_ID_LITE
+                from components.liteRelease
             }
         }
     }

android/filament-utils-android/gradle.properties

@@ -1,3 +1,4 @@
 POM_NAME=Filament Android Utilities
-POM_ARTIFACT_ID=filament-utils-android
+POM_ARTIFACT_ID_FULL=filament-utils-android
+POM_ARTIFACT_ID_LITE=filament-utils-android-lite
 POM_PACKAGING=aar

android/filament-utils-android/src/main/cpp/AutomationEngine.cpp

@@ -1,218 +0,0 @@
-/*
- * Copyright (C) 2021 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#include <jni.h>
-
-#include <viewer/AutomationEngine.h>
-
-using namespace filament;
-using namespace filament::viewer;
-using namespace utils;
-
-extern "C" JNIEXPORT jlong JNICALL
-Java_com_google_android_filament_utils_AutomationEngine_nCreateAutomationEngine(JNIEnv* env, jclass,
-        jstring spec_) {
-    const char* spec = env->GetStringUTFChars(spec_, 0);
-    jlong result = (jlong) AutomationEngine::createFromJSON(spec, strlen(spec));
-    env->ReleaseStringUTFChars(spec_, spec);
-    return result;
-}
-
-extern "C" JNIEXPORT jlong JNICALL
-Java_com_google_android_filament_utils_AutomationEngine_nCreateDefaultAutomationEngine(JNIEnv* env,
-        jclass klass) {
-    return (jlong) AutomationEngine::createDefault();
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_utils_AutomationEngine_nSetOptions(JNIEnv* env, jclass klass,
-        jlong nativeAutomation, jfloat sleepDuration, jint minFrameCount, jboolean verbose) {
-    AutomationEngine* automation = (AutomationEngine*) nativeAutomation;
-    AutomationEngine::Options options = {
-        .sleepDuration = sleepDuration,
-        .minFrameCount = minFrameCount,
-        .verbose = (bool) verbose,
-
-        // Since they write to the filesystem, we do not currently support exporting screenshots
-        // and JSON files on Android.
-        .exportScreenshots = false,
-        .exportSettings = false,
-    };
-    automation->setOptions(options);
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_utils_AutomationEngine_nStartRunning(JNIEnv* env, jclass klass,
-        jlong nativeAutomation) {
-    AutomationEngine* automation = (AutomationEngine*) nativeAutomation;
-    automation->startRunning();
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_utils_AutomationEngine_nStartBatchMode(JNIEnv* env, jclass klass,
-        jlong nativeAutomation) {
-    AutomationEngine* automation = (AutomationEngine*) nativeAutomation;
-    automation->startBatchMode();
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_utils_AutomationEngine_nTick(JNIEnv* env, jclass klass,
-        jlong nativeAutomation, jlong nativeEngine,
-        jlong view, jlongArray materials, jlong renderer, jfloat deltaTime) {
-    using MaterialPointer = MaterialInstance*;
-    jsize materialCount = 0;
-    jlong* longMaterials = nullptr;
-    MaterialPointer* ptrMaterials = nullptr;
-    if (materials) {
-        materialCount = env->GetArrayLength(materials);
-        ptrMaterials = new MaterialPointer[materialCount];
-        longMaterials = env->GetLongArrayElements(materials, nullptr);
-        for (jsize i = 0; i < materialCount; i++) {
-            ptrMaterials[i] = (MaterialPointer) longMaterials[i];
-        }
-    }
-    AutomationEngine* automation = (AutomationEngine*) nativeAutomation;
-    AutomationEngine::ViewerContent content = {
-        .view = (View*) view,
-        .renderer = (Renderer*) renderer,
-        .materials = ptrMaterials,
-        .materialCount = (size_t) materialCount,
-    };
-    Engine* engine = (Engine*)nativeEngine;
-    automation->tick(engine, content, deltaTime);
-    if (longMaterials) {
-        env->ReleaseLongArrayElements(materials, longMaterials, 0);
-        delete[] ptrMaterials;
-    }
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_utils_AutomationEngine_nApplySettings(JNIEnv* env, jclass klass,
-        jlong nativeAutomation, jlong nativeEngine,
-        jstring json, jlong view, jlongArray materials, jlong nativeIbl,
-        jint sunlightEntity, jintArray assetLights, jlong nativeLm, jlong scene, jlong renderer) {
-    using MaterialPointer = MaterialInstance*;
-
-    jsize materialCount = 0;
-    jlong* longMaterials = nullptr;
-    MaterialPointer* ptrMaterials = nullptr;
-    if (materials) {
-        materialCount = env->GetArrayLength(materials);
-        ptrMaterials = new MaterialPointer[materialCount];
-        longMaterials = env->GetLongArrayElements(materials, nullptr);
-        for (jsize i = 0; i < materialCount; i++) {
-            ptrMaterials[i] = (MaterialPointer) longMaterials[i];
-        }
-    }
-
-    jsize lightCount = 0;
-    jint* intLights = nullptr;
-    if (assetLights) {
-        lightCount = env->GetArrayLength(assetLights);
-        intLights = env->GetIntArrayElements(assetLights, nullptr);
-    }
-
-    static_assert(sizeof(jint) == sizeof(Entity));
-
-    AutomationEngine* automation = (AutomationEngine*) nativeAutomation;
-    const char* nativeJson = env->GetStringUTFChars(json, 0);
-    size_t jsonLength = env->GetStringUTFLength(json);
-
-    AutomationEngine::ViewerContent content = {
-        .view = (View*) view,
-        .renderer = (Renderer*) renderer,
-        .materials = ptrMaterials,
-        .materialCount = (size_t) materialCount,
-        .lightManager = (LightManager*) nativeLm,
-        .scene = (Scene*) scene,
-        .indirectLight = (IndirectLight*) nativeIbl,
-        .sunlight = (Entity&) sunlightEntity,
-        .assetLights = (Entity*) intLights,
-        .assetLightCount = (size_t) lightCount,
-    };
-    Engine* engine = (Engine*)nativeEngine;
-    automation->applySettings(engine, nativeJson, jsonLength, content);
-    env->ReleaseStringUTFChars(json, nativeJson);
-    if (longMaterials) {
-        env->ReleaseLongArrayElements(materials, longMaterials, 0);
-        delete[] ptrMaterials;
-    }
-    if (intLights) {
-        env->ReleaseIntArrayElements(assetLights, intLights, 0);
-    }
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_utils_AutomationEngine_nGetViewerOptions(JNIEnv* env, jclass,
-        jlong nativeObject, jobject result) {
-    AutomationEngine* automation = (AutomationEngine*) nativeObject;
-    auto options = automation->getViewerOptions();
-
-    const jclass klass = env->GetObjectClass(result);
-
-    const jfieldID cameraAperture = env->GetFieldID(klass, "cameraAperture", "F");
-    const jfieldID cameraSpeed = env->GetFieldID(klass, "cameraSpeed", "F");
-    const jfieldID cameraISO = env->GetFieldID(klass, "cameraISO", "F");
-    const jfieldID groundShadowStrength = env->GetFieldID(klass, "groundShadowStrength", "F");
-    const jfieldID groundPlaneEnabled = env->GetFieldID(klass, "groundPlaneEnabled", "Z");
-    const jfieldID skyboxEnabled = env->GetFieldID(klass, "skyboxEnabled", "Z");
-    const jfieldID cameraFocalLength = env->GetFieldID(klass, "cameraFocalLength", "F");
-    const jfieldID cameraFocusDistance = env->GetFieldID(klass, "cameraFocusDistance", "F");
-    const jfieldID autoScaleEnabled = env->GetFieldID(klass, "autoScaleEnabled", "Z");
-    const jfieldID autoInstancingEnabled = env->GetFieldID(klass, "autoInstancingEnabled", "Z");
-
-    env->SetFloatField(result, cameraAperture, options.cameraAperture);
-    env->SetFloatField(result, cameraSpeed, options.cameraSpeed);
-    env->SetFloatField(result, cameraISO, options.cameraISO);
-    env->SetFloatField(result, groundShadowStrength, options.groundShadowStrength);
-    env->SetBooleanField(result, groundPlaneEnabled, options.groundPlaneEnabled);
-    env->SetBooleanField(result, skyboxEnabled, options.skyboxEnabled);
-    env->SetFloatField(result, cameraFocalLength, options.cameraFocalLength);
-    env->SetFloatField(result, cameraFocusDistance, options.cameraFocusDistance);
-    env->SetBooleanField(result, autoScaleEnabled, options.autoScaleEnabled);
-    env->SetBooleanField(result, autoInstancingEnabled, options.autoInstancingEnabled);
-}
-
-extern "C" JNIEXPORT jlong JNICALL
-Java_com_google_android_filament_utils_AutomationEngine_nGetColorGrading(JNIEnv*, jclass,
-        jlong nativeObject, jlong nativeEngine) {
-    AutomationEngine* automation = (AutomationEngine*) nativeObject;
-    return (jlong) automation->getColorGrading((Engine*) nativeEngine);
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_utils_AutomationEngine_nSignalBatchMode(JNIEnv*, jclass, jlong native) {
-    AutomationEngine* automation = (AutomationEngine*) native;
-    automation->signalBatchMode();
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_utils_AutomationEngine_nStopRunning(JNIEnv*, jclass, jlong native) {
-    AutomationEngine* automation = (AutomationEngine*) native;
-    automation->stopRunning();
-}
-
-extern "C" JNIEXPORT jboolean JNICALL
-Java_com_google_android_filament_utils_AutomationEngine_nShouldClose(JNIEnv*, jclass, jlong native) {
-    AutomationEngine* automation = (AutomationEngine*) native;
-    return automation->shouldClose();
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_utils_AutomationEngine_nDestroy(JNIEnv*, jclass, jlong native) {
-    AutomationEngine* automation = (AutomationEngine*) native;
-    delete automation;
-}

android/filament-utils-android/src/main/cpp/HDRLoader.cpp

@@ -1,91 +0,0 @@
-/*
- * Copyright (C) 2021 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#include <jni.h>
-
-#include <filament/Engine.h>
-#include <filament/Texture.h>
-
-#include <imageio/HDRDecoder.h>
-
-#include <utils/Log.h>
-
-#include <sstream>
-
-#include "common/NioUtils.h"
-
-using namespace filament;
-using namespace image;
-using namespace utils;
-
-using PixelBufferDescriptor = Texture::PixelBufferDescriptor;
-
-jlong nCreateHDRTexture(JNIEnv* env, jclass,
-        jlong nativeEngine, jobject javaBuffer, jint remaining, jint internalFormat) {
-
-    Engine* engine = (Engine*) nativeEngine;
-    AutoBuffer buffer(env, javaBuffer, remaining);
-    Texture::InternalFormat textureFormat = (Texture::InternalFormat) internalFormat;
-
-    auto dataPtr = (char const*) buffer.getData();
-    const size_t byteCount = buffer.getSize();
-
-    // This creates a copy but it's the easest way to create a memory stream.
-    std::string ins(dataPtr, byteCount);
-    std::istringstream in(ins);
-
-    LinearImage* image = new LinearImage(ImageDecoder::decode(in, "memory.hdr"));
-
-    // This can happen if a decoding error occurs.
-    if (image->getChannels() != 3) {
-        delete image;
-        return 0;
-    }
-
-    Texture* texture = Texture::Builder()
-        .width(image->getWidth())
-        .height(image->getHeight())
-        .levels(0xff)
-        .sampler(Texture::Sampler::SAMPLER_2D)
-        .format(textureFormat)
-        .build(*engine);
-
-    if (texture == nullptr) {
-        slog.e << "Unable to create Filament Texture from HDR image." << io::endl;
-        delete image;
-        return 0;
-    }
-
-    PixelBufferDescriptor::Callback freeCallback = [](void* buf, size_t, void* userdata) {
-        delete (LinearImage*) userdata;
-    };
-
-    PixelBufferDescriptor pbd(
-        (void const* ) image->getPixelRef(),
-        image->getWidth() * image->getHeight() * 3 * sizeof(float),
-        PixelBufferDescriptor::PixelDataFormat::RGB,
-        PixelBufferDescriptor::PixelDataType::FLOAT,
-        freeCallback,
-        image);
-
-    // Note that the setImage call could fail (e.g. due to an invalid combination of internal format
-    // and PixelDataFormat) but there is no way of detecting such a failure.
-    texture->setImage(*engine, 0, std::move(pbd));
-
-    texture->generateMipmaps(*engine);
-
-    return (jlong) texture;
-}

android/filament-utils-android/src/main/cpp/IBLPrefilterContext.cpp

@@ -1,75 +0,0 @@
-/*
- * Copyright (C) 2021 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#include <jni.h>
-
-#include <filament-iblprefilter/IBLPrefilterContext.h>
-
-#include <filament/Engine.h>
-#include <filament/Texture.h>
-
-using namespace filament;
-
-extern "C" JNIEXPORT jlong JNICALL
-Java_com_google_android_filament_utils_IBLPrefilterContext_nCreate(JNIEnv* env, jclass,
-        jlong nativeEngine) {
-    Engine* engine = (Engine*) nativeEngine;
-    return (jlong) new IBLPrefilterContext(*engine);
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_utils_IBLPrefilterContext_nDestroy(JNIEnv*, jclass, jlong native) {
-    IBLPrefilterContext* context = (IBLPrefilterContext*) native;
-    delete context;
-}
-
-extern "C" JNIEXPORT long JNICALL
-Java_com_google_android_filament_utils_IBLPrefilterContext_nCreateEquirectHelper(JNIEnv* env, jclass, jlong nativeContext) {
-    IBLPrefilterContext* context = (IBLPrefilterContext*) nativeContext;
-    return (long) new IBLPrefilterContext::EquirectangularToCubemap(*context);
-}
-
-extern "C" JNIEXPORT long JNICALL
-Java_com_google_android_filament_utils_IBLPrefilterContext_nEquirectHelperRun(JNIEnv* env, jclass, jlong nativeHelper, long nativeEquirect) {
-    auto helper = (IBLPrefilterContext::EquirectangularToCubemap*) nativeHelper;
-    auto texture = (filament::Texture*) nativeEquirect;
-    auto result = (*helper)(texture);
-    return (long) result;
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_utils_IBLPrefilterContext_nDestroyEquirectHelper(JNIEnv* env, jclass, jlong nativeObject) {
-    delete (IBLPrefilterContext::EquirectangularToCubemap*) nativeObject;
-}
-
-extern "C" JNIEXPORT long JNICALL
-Java_com_google_android_filament_utils_IBLPrefilterContext_nCreateSpecularFilter(JNIEnv* env, jclass, jlong nativeContext) {
-    IBLPrefilterContext* context = (IBLPrefilterContext*) nativeContext;
-    return (long) new IBLPrefilterContext::SpecularFilter(*context);
-}
-
-extern "C" JNIEXPORT long JNICALL
-Java_com_google_android_filament_utils_IBLPrefilterContext_nSpecularFilterRun(JNIEnv* env, jclass, jlong nativeHelper, long nativeSkybox) {
-    auto helper = (IBLPrefilterContext::SpecularFilter*) nativeHelper;
-    auto texture = (filament::Texture*) nativeSkybox;
-    auto result = (*helper)(texture);
-    return (long) result;
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_utils_IBLPrefilterContext_nDestroySpecularFilter(JNIEnv* env, jclass, jlong nativeObject) {
-    delete (IBLPrefilterContext::SpecularFilter*) nativeObject;
-}

android/filament-utils-android/src/main/cpp/RemoteServer.cpp

@@ -1,77 +0,0 @@
-/*
- * Copyright (C) 2021 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#include <jni.h>
-
-#include <viewer/RemoteServer.h>
-
-using namespace filament::viewer;
-
-extern "C" JNIEXPORT jlong JNICALL
-Java_com_google_android_filament_utils_RemoteServer_nCreate(JNIEnv* env, jclass, jint port) {
-    RemoteServer* server = new RemoteServer(port);
-    if (!server->isValid()) {
-        delete server;
-        return 0;
-    }
-    return (jlong) server;
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_utils_RemoteServer_nDestroy(JNIEnv*, jclass, jlong native) {
-    RemoteServer* server = (RemoteServer*) native;
-    delete server;
-}
-
-extern "C" JNIEXPORT jstring JNICALL
-Java_com_google_android_filament_utils_RemoteServer_nPeekIncomingLabel(JNIEnv* env, jclass, jlong native) {
-    RemoteServer* server = (RemoteServer*) native;
-    char const* label = server->peekIncomingLabel();
-    return label ? env->NewStringUTF(label) : nullptr;
-}
-
-extern "C" JNIEXPORT jstring JNICALL
-Java_com_google_android_filament_utils_RemoteServer_nPeekReceivedLabel(JNIEnv* env, jclass, jlong native) {
-    RemoteServer* server = (RemoteServer*) native;
-    ReceivedMessage const* msg = server->peekReceivedMessage();
-    return msg ? env->NewStringUTF(msg->label) : nullptr;
-}
-
-extern "C" JNIEXPORT jint JNICALL
-Java_com_google_android_filament_utils_RemoteServer_nPeekReceivedBufferLength(JNIEnv* env, jclass, jlong native) {
-    RemoteServer* server = (RemoteServer*) native;
-    ReceivedMessage const* msg = server->peekReceivedMessage();
-    return msg ? msg->bufferByteCount : 0;
-}
-
-extern "C" JNIEXPORT void JNICALL
-Java_com_google_android_filament_utils_RemoteServer_nAcquireReceivedMessage(JNIEnv* env, jclass, jlong native, jobject buffer, jint length) {
-    RemoteServer* server = (RemoteServer*) native;
-    ReceivedMessage const* msg = server->acquireReceivedMessage();
-    if (msg == nullptr) {
-        return;
-    }
-
-    void* address = env->GetDirectBufferAddress(buffer);
-    if (address == nullptr) {
-        // This should never happen because the Java layer does allocateDirect.
-        return;
-    }
-
-    memcpy(address, msg->buffer, length);
-    server->releaseReceivedMessage(msg);
-}
-

android/filament-utils-android/src/main/cpp/Utils.cpp

@@ -20,25 +20,21 @@
 #include <filament/IndirectLight.h>
 #include <filament/Skybox.h>
 
-#include <ktxreader/Ktx1Reader.h>
+#include <image/KtxUtility.h>
 
 #include "common/NioUtils.h"
 
 using namespace filament;
 using namespace filament::math;
 using namespace image;
-using namespace ktxreader;
 
-jlong nCreateHDRTexture(JNIEnv* env, jclass,
-        jlong nativeEngine, jobject javaBuffer, jint remaining, jint internalFormat);
-
-static jlong nCreateKTXTexture(JNIEnv* env, jclass,
+static jlong nCreateTexture(JNIEnv* env, jclass,
         jlong nativeEngine, jobject javaBuffer, jint remaining, jboolean srgb) {
     Engine* engine = (Engine*) nativeEngine;
     AutoBuffer buffer(env, javaBuffer, remaining);
-    Ktx1Bundle* bundle = new Ktx1Bundle((const uint8_t*) buffer.getData(), buffer.getSize());
-    return (jlong) Ktx1Reader::createTexture(engine, *bundle, srgb, [](void* userdata) {
-        Ktx1Bundle* bundle = (Ktx1Bundle*) userdata;
+    KtxBundle* bundle = new KtxBundle((const uint8_t*) buffer.getData(), buffer.getSize());
+    return (jlong) ktx::createTexture(engine, *bundle, srgb, [](void* userdata) {
+        KtxBundle* bundle = (KtxBundle*) userdata;
         delete bundle;
     }, bundle);
 }
@@ -47,9 +43,9 @@ static jlong nCreateIndirectLight(JNIEnv* env, jclass,
         jlong nativeEngine, jobject javaBuffer, jint remaining, jboolean srgb) {
     Engine* engine = (Engine*) nativeEngine;
     AutoBuffer buffer(env, javaBuffer, remaining);
-    Ktx1Bundle* bundle = new Ktx1Bundle((const uint8_t*) buffer.getData(), buffer.getSize());
-    Texture* cubemap = Ktx1Reader::createTexture(engine, *bundle, srgb,  [](void* userdata) {
-        Ktx1Bundle* bundle = (Ktx1Bundle*) userdata;
+    KtxBundle* bundle = new KtxBundle((const uint8_t*) buffer.getData(), buffer.getSize());
+    Texture* cubemap = ktx::createTexture(engine, *bundle, srgb,  [](void* userdata) {
+        KtxBundle* bundle = (KtxBundle*) userdata;
         delete bundle;
     }, bundle);
 
@@ -69,27 +65,14 @@ static jlong nCreateSkybox(JNIEnv* env, jclass,
         jlong nativeEngine, jobject javaBuffer, jint remaining, jboolean srgb) {
     Engine* engine = (Engine*) nativeEngine;
     AutoBuffer buffer(env, javaBuffer, remaining);
-    Ktx1Bundle* bundle = new Ktx1Bundle((const uint8_t*) buffer.getData(), buffer.getSize());
-    Texture* cubemap = Ktx1Reader::createTexture(engine, *bundle, srgb,  [](void* userdata) {
-        Ktx1Bundle* bundle = (Ktx1Bundle*) userdata;
+    KtxBundle* bundle = new KtxBundle((const uint8_t*) buffer.getData(), buffer.getSize());
+    Texture* cubemap = ktx::createTexture(engine, *bundle, srgb,  [](void* userdata) {
+        KtxBundle* bundle = (KtxBundle*) userdata;
         delete bundle;
     }, bundle);
     return (jlong) Skybox::Builder().environment(cubemap).showSun(true).build(*engine);
 }
 
-static jboolean nGetSphericalHarmonics(JNIEnv* env, jclass, jobject javaBuffer, jint remaining,
-        jfloatArray outSphericalHarmonics_) {
-    AutoBuffer buffer(env, javaBuffer, remaining);
-    Ktx1Bundle bundle((const uint8_t*) buffer.getData(), buffer.getSize());
-
-    jfloat* outSphericalHarmonics = env->GetFloatArrayElements(outSphericalHarmonics_, nullptr);
-    const auto success = bundle.getSphericalHarmonics(
-        reinterpret_cast<filament::math::float3*>(outSphericalHarmonics)
-    );
-    env->ReleaseFloatArrayElements(outSphericalHarmonics_, outSphericalHarmonics, JNI_ABORT);
-
-    return success ? JNI_TRUE : JNI_FALSE;
-}
 
 JNIEXPORT jint JNI_OnLoad(JavaVM* vm, void*) {
     JNIEnv* env;
@@ -97,27 +80,15 @@ JNIEXPORT jint JNI_OnLoad(JavaVM* vm, void*) {
         return -1;
     }
 
-    int rc;
+    jclass c = env->FindClass("com/google/android/filament/utils/KtxLoader");
+    if (c == nullptr) return JNI_ERR;
 
-    // KTX1Loader
-    jclass ktxloaderClass = env->FindClass("com/google/android/filament/utils/KTX1Loader");
-    if (ktxloaderClass == nullptr) return JNI_ERR;
-    static const JNINativeMethod ktxMethods[] = {
-        {(char*)"nCreateKTXTexture", (char*)"(JLjava/nio/Buffer;IZ)J", reinterpret_cast<void*>(nCreateKTXTexture)},
-        {(char*)"nCreateIndirectLight", (char*)"(JLjava/nio/Buffer;IZ)J", reinterpret_cast<void*>(nCreateIndirectLight)},
-        {(char*)"nCreateSkybox", (char*)"(JLjava/nio/Buffer;IZ)J", reinterpret_cast<void*>(nCreateSkybox)},
-        {(char*)"nGetSphericalHarmonics", (char*)"(Ljava/nio/Buffer;I[F)Z", reinterpret_cast<void*>(nGetSphericalHarmonics)},
+    static const JNINativeMethod methods[] = {
+        {"nCreateTexture", "(JLjava/nio/Buffer;IZ)J", reinterpret_cast<void*>(nCreateTexture)},
+        {"nCreateIndirectLight", "(JLjava/nio/Buffer;IZ)J", reinterpret_cast<void*>(nCreateIndirectLight)},
+        {"nCreateSkybox", "(JLjava/nio/Buffer;IZ)J", reinterpret_cast<void*>(nCreateSkybox)},
     };
-    rc = env->RegisterNatives(ktxloaderClass, ktxMethods, sizeof(ktxMethods) / sizeof(JNINativeMethod));
-    if (rc != JNI_OK) return rc;
-
-    // HDRLoader
-    jclass hdrloaderClass = env->FindClass("com/google/android/filament/utils/HDRLoader");
-    if (hdrloaderClass == nullptr) return JNI_ERR;
-    static const JNINativeMethod hdrMethods[] = {
-        {(char*)"nCreateHDRTexture", (char*)"(JLjava/nio/Buffer;II)J", reinterpret_cast<void*>(nCreateHDRTexture)},
-    };
-    rc = env->RegisterNatives(hdrloaderClass, hdrMethods, sizeof(hdrMethods) / sizeof(JNINativeMethod));
+    int rc = env->RegisterNatives(c, methods, sizeof(methods) / sizeof(JNINativeMethod));
     if (rc != JNI_OK) return rc;
 
     return JNI_VERSION_1_6;

android/filament-utils-android/src/main/java/com/google/android/filament/utils/AutomationEngine.java

@@ -1,286 +0,0 @@
-/*
- * Copyright (C) 2021 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package com.google.android.filament.utils;
-
-import androidx.annotation.NonNull;
-import androidx.annotation.Nullable;
-
-import com.google.android.filament.ColorGrading;
-import com.google.android.filament.Engine;
-import com.google.android.filament.Entity;
-import com.google.android.filament.IndirectLight;
-import com.google.android.filament.LightManager;
-import com.google.android.filament.Scene;
-import com.google.android.filament.View;
-import com.google.android.filament.MaterialInstance;
-import com.google.android.filament.Renderer;
-
-/**
- * The AutomationEngine makes it easy to push a bag of settings values to Filament.
- * It can also be used to iterate through settings permutations for testing purposes.
- *
- * When creating an automation engine for testing purposes, clients give it a JSON string that
- * tells it how to generate permutations of settings. Automation is always in one of two states:
- * running or idle. The running state can be entered immediately (startRunning) or by requesting
- * batch mode (startBatchMode).
- *
- * When executing a test, clients should call tick() after each frame is rendered, which provides an
- * opportunity to push settings to Filament, increment the current test index (if enough time has
- * elapsed), and request an asynchronous screenshot.
- *
- * The time to sleep between tests is configurable and can be set to zero. Automation also waits a
- * specified minimum number of frames between tests.
- *
- * Batch mode is meant for non-interactive applications. In batch mode, automation defers applying
- * the first test case until the client unblocks it via signalBatchMode(). This is useful when
- * waiting for a large model file to become fully loaded. Batch mode also offers a query
- * (shouldClose) that is triggered after the last test has been invoked.
- */
-public class AutomationEngine {
-    private final long mNativeObject;
-    private ColorGrading mColorGrading;
-
-    /**
-     * Allows users to toggle screenshots, change the sleep duration between tests, etc.
-     */
-    public static class Options {
-        /**
-         * Minimum time that automation waits between applying a settings object and advancing
-         * to the next test case. Specified in seconds.
-         */
-        public float sleepDuration = 0.2f;
-
-        /**
-         * Similar to sleepDuration, but expressed as a frame count. Both the minimum sleep time
-         * and the minimum frame count must be elapsed before automation advances to the next test.
-         */
-        public int minFrameCount = 2;
-
-        /**
-         * If true, test progress is dumped to the utils Log (info priority).
-         */
-        public boolean verbose = true;
-    }
-
-    /**
-     * Collection of Filament objects that can be modified by the automation engine.
-     */
-    public static class ViewerContent {
-        public View view;
-        public Renderer renderer;
-        public MaterialInstance[] materials;
-        public LightManager lightManager;
-        public Scene scene;
-        public IndirectLight indirectLight;
-        public @Entity int sunlight;
-        public @Entity int[] assetLights;
-    }
-
-    /**
-     * Allows remote control for the viewer.
-     */
-    public static class ViewerOptions {
-        public float cameraAperture = 16.0f;
-        public float cameraSpeed = 125.0f;
-        public float cameraISO = 100.0f;
-        public float groundShadowStrength = 0.75f;
-        public boolean groundPlaneEnabled = false;
-        public boolean skyboxEnabled = true;
-        public float cameraFocalLength = 28.0f;
-        public float cameraFocusDistance = 0.0f;
-        public boolean autoScaleEnabled = true;
-        public boolean autoInstancingEnabled = false;
-    }
-
-    /**
-     * Creates an automation engine from a JSON specification.
-     *
-     * An example of a JSON spec can be found by searching the repo for DEFAULT_AUTOMATION.
-     * This is documented using a JSON schema (look for viewer/schemas/automation.json).
-     *
-     * @param jsonSpec Valid JSON string that conforms to the automation schema.
-     */
-    public AutomationEngine(@NonNull String jsonSpec) {
-        mNativeObject = nCreateAutomationEngine(jsonSpec);
-        if (mNativeObject == 0) throw new IllegalStateException("Couldn't create AutomationEngine");
-    }
-
-    /**
-     * Creates an automation engine for the sole purpose of pushing settings, or for executing
-     * the default test sequence.
-     *
-     * To see how the default test sequence is generated, search for DEFAULT_AUTOMATION.
-     */
-    public AutomationEngine() {
-        mNativeObject = nCreateDefaultAutomationEngine();
-        if (mNativeObject == 0) throw new IllegalStateException("Couldn't create AutomationEngine");
-    }
-
-    /**
-     * Configures the automation engine for users who wish to set up a custom sleep time
-     * between tests, etc.
-     */
-    public void setOptions(@NonNull Options options) {
-        nSetOptions(mNativeObject, options.sleepDuration, options.minFrameCount, options.verbose);
-    }
-
-    /**
-     * Activates the automation test. During the subsequent call to tick(), the first test is
-     * applied and automation enters the running state.
-     */
-    public void startRunning() { nStartRunning(mNativeObject); }
-
-    /**
-     * Activates the automation test, but enters a paused state until the user calls
-     * signalBatchMode().
-     */
-    public void startBatchMode() { nStartBatchMode(mNativeObject); }
-
-    /**
-     * Notifies the automation engine that time has passed and a new frame has been rendered.
-     *
-     * This is when settings get applied, screenshots are (optionally) exported, and the internal
-     * test counter is potentially incremented.
-     *
-     * @param engine        The filament Engine of interest.
-     * @param content       Contains the Filament View, Materials, and Renderer that get modified.
-     * @param deltaTime     The amount of time that has passed since the previous tick in seconds.
-     */
-    public void tick(@NonNull Engine engine, @NonNull ViewerContent content, float deltaTime) {
-        if (content.view == null || content.renderer == null) {
-            throw new IllegalStateException("Must provide a View and Renderer");
-        }
-        long[] nativeMaterialInstances = null;
-        if (content.materials != null) {
-            nativeMaterialInstances = new long[content.materials.length];
-            for (int i = 0; i < nativeMaterialInstances.length; i++) {
-                nativeMaterialInstances[i] = content.materials[i].getNativeObject();
-            }
-        }
-        long nativeView = content.view.getNativeObject();
-        long nativeRenderer = content.renderer.getNativeObject();
-        nTick(mNativeObject, engine.getNativeObject(), nativeView, nativeMaterialInstances, nativeRenderer, deltaTime);
-    }
-
-    /**
-     * Mutates a set of client-owned Filament objects according to a JSON string.
-     *
-     * This method is an alternative to tick(). It allows clients to use the automation engine as a
-     * remote control, as opposed to iterating through a predetermined test sequence.
-     *
-     * This updates the stashed Settings object, then pushes those settings to the given
-     * Filament objects. Clients can optionally call getColorGrading() after calling this method.
-     *
-     * @param engine        Filament Engine to use.
-     * @param settingsJson  Contains the JSON string with a set of changes that need to be pushed.
-     * @param content       Contains a set of Filament objects that you want to mutate.
-     */
-    public void applySettings(@NonNull Engine engine, @NonNull String settingsJson,
-        @NonNull ViewerContent content) {
-        if (content.view == null || content.renderer == null) {
-            throw new IllegalStateException("Must provide a View and Renderer");
-        }
-        long[] nativeMaterialInstances = null;
-        if (content.lightManager == null || content.scene == null) {
-            throw new IllegalStateException("Must provide a LightManager and Scene");
-        }
-        if (content.materials != null) {
-            nativeMaterialInstances = new long[content.materials.length];
-            for (int i = 0; i < nativeMaterialInstances.length; i++) {
-                nativeMaterialInstances[i] = content.materials[i].getNativeObject();
-            }
-        }
-        long nativeView = content.view.getNativeObject();
-        long nativeIbl = content.indirectLight == null ? 0 : content.indirectLight.getNativeObject();
-        long nativeLm = content.lightManager.getNativeObject();
-        long nativeScene = content.scene.getNativeObject();
-        long nativeRenderer = content.renderer.getNativeObject();
-        nApplySettings(mNativeObject, engine.getNativeObject(),
-                settingsJson, nativeView, nativeMaterialInstances,
-                nativeIbl, content.sunlight, content.assetLights, nativeLm, nativeScene,
-                nativeRenderer);
-    }
-
-    /**
-     * Gets the current viewer options.
-     *
-     * NOTE: Focal length here might be different from the user-specified value, due to DoF options.
-     */
-    @NonNull
-    public ViewerOptions getViewerOptions() {
-        ViewerOptions result = new ViewerOptions();
-        nGetViewerOptions(mNativeObject, result);
-        return result;
-    }
-
-    /**
-     * Gets a color grading object that corresponds to the latest settings.
-     *
-     * This method either returns a cached instance, or it destroys the cached instance and creates
-     * a new one.
-     */
-    @NonNull
-    public ColorGrading getColorGrading(@NonNull Engine engine) {
-        // The native layer automatically destroys the old color grading instance,
-        // so there is no need to call Engine#destroyColorGrading here.
-        long nativeCg = nGetColorGrading(mNativeObject, engine.getNativeObject());
-        if (mColorGrading == null || mColorGrading.getNativeObject() != nativeCg) {
-            mColorGrading = nativeCg == 0 ? null : new ColorGrading(nativeCg);
-        }
-        return mColorGrading;
-    }
-
-    /**
-     * Signals that batch mode can begin. Call this after all meshes and textures finish loading.
-     */
-    public void signalBatchMode() { nSignalBatchMode(mNativeObject); }
-
-    /**
-     * Cancels an in-progress automation session.
-     */
-    public void stopRunning() { nStopRunning(mNativeObject); }
-
-    /**
-     * Returns true if automation is in batch mode and all tests have finished.
-     */
-    public boolean shouldClose() { return nShouldClose(mNativeObject); }
-
-    @Override
-    protected void finalize() throws Throwable {
-        nDestroy(mNativeObject);
-        super.finalize();
-    }
-
-    private static native long nCreateAutomationEngine(String jsonSpec);
-    private static native long nCreateDefaultAutomationEngine();
-    private static native void nSetOptions(long nativeObject, float sleepDuration,
-            int minFrameCount, boolean verbose);
-    private static native void nStartRunning(long nativeObject);
-    private static native void nStartBatchMode(long nativeObject);
-    private static native void nTick(long nativeObject, long nativeEngine,
-            long view, long[] materials, long renderer, float deltaTime);
-    private static native void nApplySettings(long nativeObject, long nativeEngine,
-            String jsonSettings, long view,
-            long[] materials, long ibl, int sunlight, int[] assetLights, long lightManager,
-            long scene, long renderer);
-    private static native void nGetViewerOptions(long nativeObject, Object result);
-    private static native long nGetColorGrading(long nativeObject, long nativeEngine);
-    private static native void nSignalBatchMode(long nativeObject);
-    private static native void nStopRunning(long nativeObject);
-    private static native boolean nShouldClose(long nativeObject);
-    private static native void nDestroy(long nativeObject);
-}

android/filament-utils-android/src/main/java/com/google/android/filament/utils/HDRLoader.kt

@@ -1,50 +0,0 @@
-/*
- * Copyright (C) 2021 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package com.google.android.filament.utils
-
-import com.google.android.filament.Engine
-import com.google.android.filament.Texture
-
-import java.nio.Buffer
-
-/**
- * Utility for decoding an HDR file and producing a Filament texture.
- */
-object HDRLoader {
-    class Options {
-        var desiredFormat = Texture.InternalFormat.RGB16F
-    }
-
-    /**
-     * Consumes the content of an HDR file and produces a [Texture] object.
-     *
-     * @param engine Gets passed to the builder.
-     * @param buffer The content of the HDR File.
-     * @param options Loader options.
-     * @return The resulting Filament texture, or null on failure.
-     */
-    fun createTexture(engine: Engine, buffer: Buffer, options: Options = Options()): Texture? {
-        val nativeEngine = engine.nativeObject
-        val nativeTexture = nCreateHDRTexture(nativeEngine, buffer, buffer.remaining(), options.desiredFormat.ordinal)
-        if (nativeTexture == 0L) {
-            return null;
-        }
-        return Texture(nativeTexture)
-    }
-
-    private external fun nCreateHDRTexture(nativeEngine: Long, buffer: Buffer, remaining: Int, format: Int): Long
-}

android/filament-utils-android/src/main/java/com/google/android/filament/utils/IBLPrefilterContext.java

@@ -1,130 +0,0 @@
-/*
- * Copyright (C) 2021 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package com.google.android.filament.utils;
-
-import com.google.android.filament.Engine;
-import com.google.android.filament.Texture;
-
-/**
- * IBLPrefilterContext creates and initializes GPU state common to all environment map filters
- * supported. Typically, only one instance per filament Engine of this object needs to exist.
- *
- * Java usage example:
- * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
- *
- * context = new IBLPrefilterContext(engine);
- * equirectangularToCubemap = new IBLPrefilterContext.EquirectangularToCubemap(context);
- *
- * Texture equirect = HDRLoader.createTexture("foo.hdr");
- * Texture skyboxTexture = equirectangularToCubemap.run(equirect);
- * engine.destroy(equirect);
- * equirectangularToCubemap.destroy();
- *
- * specularFilter = new IBLPrefilterContext.SpecularFilter(context);
- * Texture reflections = specularFilter.run(skyboxTexture);
- * specularFilter.destroy();
- *
- * context.destroy();
- *
- * IndirectLight ibl = IndirectLight.Builder()
- *         .reflections(reflections)
- *         .intensity(30000.0f)
- *         .build(engine);
- * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
- */
-public class IBLPrefilterContext {
-    private long mNativeObject;
-
-    public IBLPrefilterContext(Engine engine) {
-        mNativeObject = nCreate(engine.getNativeObject());
-        if (mNativeObject == 0) throw new IllegalStateException("Couldn't create IBLPrefilterContext");
-    }
-
-    public void destroy() {
-        nDestroy(getNativeObject());
-        mNativeObject = 0;
-    }
-
-    public static class EquirectangularToCubemap {
-        private long mNativeObject;
-
-        public EquirectangularToCubemap(IBLPrefilterContext context) {
-            mNativeObject = nCreateEquirectHelper(context.getNativeObject());
-        }
-
-        public Texture run(Texture equirect) {
-            long nativeTexture = nEquirectHelperRun(getNativeObject(), equirect.getNativeObject());
-            return new Texture(nativeTexture);
-        }
-
-        public void destroy() {
-            nDestroyEquirectHelper(getNativeObject());
-            mNativeObject = 0;
-        }
-
-        protected long getNativeObject() {
-            if (mNativeObject == 0) {
-                throw new IllegalStateException("Calling method on destroyed EquirectangularToCubemap");
-            }
-            return mNativeObject;
-        }
-    }
-
-    public static class SpecularFilter {
-        private long mNativeObject;
-
-        public SpecularFilter(IBLPrefilterContext context) {
-            mNativeObject = nCreateSpecularFilter(context.getNativeObject());
-        }
-
-        public Texture run(Texture skybox) {
-            long nativeTexture = nSpecularFilterRun(getNativeObject(), skybox.getNativeObject());
-            return new Texture(nativeTexture);
-        }
-
-        public void destroy() {
-            nDestroySpecularFilter(getNativeObject());
-            mNativeObject = 0;
-        }
-
-        protected long getNativeObject() {
-            if (mNativeObject == 0) {
-                throw new IllegalStateException("Calling method on destroyed SpecularFilter");
-            }
-            return mNativeObject;
-        }
-    }
-
-
-    protected long getNativeObject() {
-        if (mNativeObject == 0) {
-            throw new IllegalStateException("Calling method on destroyed IBLPrefilterContext");
-        }
-        return mNativeObject;
-    }
-
-    private static native long nCreate(long nativeEngine);
-    private static native void nDestroy(long nativeObject);
-
-    private static native long nCreateEquirectHelper(long nativeContext);
-    private static native long nEquirectHelperRun(long nativeHelper, long nativeEquirect);
-    private static native void nDestroyEquirectHelper(long nativeObject);
-
-    private static native long nCreateSpecularFilter(long nativeContext);
-    private static native long nSpecularFilterRun(long nativeHelper, long nativeSkybox);
-    private static native void nDestroySpecularFilter(long nativeObject);
-}

android/filament-utils-android/src/main/java/com/google/android/filament/utils/KTX1Loader.kt

@@ -1,95 +0,0 @@
-/*
- * Copyright (C) 2020 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package com.google.android.filament.utils
-
-import com.google.android.filament.Engine
-import com.google.android.filament.IndirectLight
-import com.google.android.filament.Skybox
-import com.google.android.filament.Texture
-
-import java.nio.Buffer
-
-/**
- * Utilities for consuming KTX1 files and producing Filament textures, IBLs, and sky boxes.
- *
- * KTX is a simple container format that makes it easy to bundle miplevels and cubemap faces
- * into a single file.
- */
-object KTX1Loader {
-    class Options {
-        var srgb = false
-    }
-
-    /**
-     * Consumes the content of a KTX file and produces a [Texture] object.
-     *
-     * @param engine Gets passed to the builder.
-     * @param buffer The content of the KTX File.
-     * @param options Loader options.
-     * @return The resulting Filament texture, or null on failure.
-     */
-    fun createTexture(engine: Engine, buffer: Buffer, options: Options = Options()): Texture {
-        val nativeEngine = engine.nativeObject
-        val nativeTexture = nCreateKTXTexture(nativeEngine, buffer, buffer.remaining(), options.srgb)
-        return Texture(nativeTexture)
-    }
-
-    /**
-     * Consumes the content of a KTX file and produces an [IndirectLight] object.
-     *
-     * @param engine Gets passed to the builder.
-     * @param buffer The content of the KTX File.
-     * @param options Loader options.
-     * @return The resulting Filament texture, or null on failure.
-     */
-    fun createIndirectLight(engine: Engine, buffer: Buffer, options: Options = Options()): IndirectLight {
-        val nativeEngine = engine.nativeObject
-        val nativeIndirectLight = nCreateIndirectLight(nativeEngine, buffer, buffer.remaining(), options.srgb)
-        return IndirectLight(nativeIndirectLight)
-    }
-
-    /**
-     * Consumes the content of a KTX file and produces a [Skybox] object.
-     *
-     * @param engine Gets passed to the builder.
-     * @param buffer The content of the KTX File.
-     * @param options Loader options.
-     * @return The resulting Filament texture, or null on failure.
-     */
-    fun createSkybox(engine: Engine, buffer: Buffer, options: Options = Options()): Skybox {
-        val nativeEngine = engine.nativeObject
-        val nativeSkybox = nCreateSkybox(nativeEngine, buffer, buffer.remaining(), options.srgb)
-        return Skybox(nativeSkybox)
-    }
-
-    /**
-     * Retrieves spherical harmonics from the content of a KTX file.
-     *
-     * @param buffer The content of the KTX File.
-     * @return The resulting array of 9 * 3 floats, or null on failure.
-     */
-    fun getSphericalHarmonics(buffer: Buffer): FloatArray? {
-        val sphericalHarmonics = FloatArray(9 * 3)
-        val success = nGetSphericalHarmonics(buffer, buffer.remaining(), sphericalHarmonics)
-        return if (success) sphericalHarmonics else null
-    }
-
-    private external fun nCreateKTXTexture(nativeEngine: Long, buffer: Buffer, remaining: Int, srgb: Boolean): Long
-    private external fun nCreateIndirectLight(nativeEngine: Long, buffer: Buffer, remaining: Int, srgb: Boolean): Long
-    private external fun nGetSphericalHarmonics(buffer: Buffer, remaining: Int, outSphericalHarmonics: FloatArray): Boolean
-    private external fun nCreateSkybox(nativeEngine: Long, buffer: Buffer, remaining: Int, srgb: Boolean): Long
-}