f4a079f663
* Filament Error Handling Remediation and noexcept Cleanup - Replaced assert_invariant with FILAMENT_CHECK_PRECONDITION in Renderer::beginFrame for caller bugs. - Removed noexcept from Camera::setCustomProjection to allow precondition checks to throw. - Removed noexcept from Texture and InstanceBuffer methods using precondition checks. - Documented silent clamping in View::setBloomOptions. - Clarified comment in FrameGraphResources regarding preconditions. - Refined MaterialInstance::commit to split texture loop into check and update passes, preventing partial state changes on precondition failure. * backend: Propagate backend thread exceptions to the main thread. Introduce a mechanism to catch exceptions thrown on the backend thread and rethrow them on the main thread. This prevents deadlocks and allows the application to handle fatal backend failures gracefully. - Consolidate synchronization primitives in DriverBase. - Add mHasUnrecoverableError flag to interrupt blocked fence waits. - Optimize waitForFence to avoid extra atomic reads in common paths. - Propagate FenceStatus::ERROR across all backends. - CommandBufferQueue now stores a std::exception_ptr when the backend fails. - The backend enters a "zombie" state on failure, skipping further command execution but allowing clean shutdown. - Public APIs in Renderer and Engine now check for stored exceptions and rethrow them, documented with @throws. - Guarded by __EXCEPTIONS to ensure no overhead when exceptions are disabled. - Add unit test for fence interruption and document new APIs. BUGS=[407545700] * feat: harden backend exceptions and add hasUnrecoverableFailure API - Update Renderer::beginFrame() and Renderer::shouldRenderFrame() to return false early if an unrecoverable backend exception has been delivered to the main thread. - Document the new return behavior for beginFrame() and shouldRenderFrame() in Renderer.h. - Add Engine::hasUnrecoverableFailure() to the public API to allow apps to check for fatal errors without relying on exceptions. - Implement hasUnrecoverableFailure() in FEngine by delegating to CommandBufferQueue. - Expose Engine::hasUnrecoverableFailure() to Java bindings (Engine.java and JNI). - Expose Engine::hasUnrecoverableFailure() to JavaScript bindings (jsbindings.cpp). * java: propagate C++ Panics & exceptions to JAVA
99 lines
3.2 KiB
C++
99 lines
3.2 KiB
C++
/*
|
|
* Copyright (C) 2017 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <jni.h>
|
|
|
|
#include "common/NioUtils.h"
|
|
|
|
#include <backend/CallbackHandler.h>
|
|
|
|
#include <filament/Engine.h>
|
|
|
|
struct CallbackJni {
|
|
#ifdef __ANDROID__
|
|
jclass handlerClass = nullptr;
|
|
jmethodID post = nullptr;
|
|
#endif
|
|
jclass executorClass = nullptr;
|
|
jmethodID execute = nullptr;
|
|
};
|
|
|
|
void acquireCallbackJni(JNIEnv* env, CallbackJni& callbackUtils);
|
|
void releaseCallbackJni(JNIEnv* env, CallbackJni callbackUtils, jobject handler, jobject callback);
|
|
|
|
struct JniCallback : private filament::backend::CallbackHandler {
|
|
JniCallback(JniCallback const &) = delete;
|
|
JniCallback(JniCallback&&) = delete;
|
|
JniCallback& operator=(JniCallback const &) = delete;
|
|
JniCallback& operator=(JniCallback&&) = delete;
|
|
|
|
// create a JniCallback
|
|
static JniCallback* make(JNIEnv* env, jobject handler, jobject runnable);
|
|
|
|
// execute the callback on the java thread and destroy ourselves
|
|
static void postToJavaAndDestroy(JniCallback* callback);
|
|
|
|
// destroy ourselves without executing the callback
|
|
static void destroy(JniCallback* callback);
|
|
|
|
// CallbackHandler interface.
|
|
void post(void* user, Callback callback) override;
|
|
|
|
// Get the CallbackHandler interface
|
|
filament::backend::CallbackHandler* getHandler() noexcept { return this; }
|
|
|
|
jobject getCallbackObject() { return mCallback; }
|
|
|
|
protected:
|
|
JniCallback(JNIEnv* env, jobject handler, jobject runnable);
|
|
explicit JniCallback() = default; // this version does nothing
|
|
virtual ~JniCallback();
|
|
jobject mHandler{};
|
|
jobject mCallback{};
|
|
CallbackJni mCallbackUtils{};
|
|
};
|
|
|
|
|
|
struct JniBufferCallback : public JniCallback {
|
|
// create a JniBufferCallback
|
|
static JniBufferCallback* make(filament::Engine* engine,
|
|
JNIEnv* env, jobject handler, jobject callback, AutoBuffer&& buffer);
|
|
|
|
// execute the callback on the java thread and destroy ourselves
|
|
static void postToJavaAndDestroy(void*, size_t, void* user);
|
|
|
|
private:
|
|
JniBufferCallback(JNIEnv* env, jobject handler, jobject callback, AutoBuffer&& buffer);
|
|
virtual ~JniBufferCallback();
|
|
AutoBuffer mBuffer;
|
|
};
|
|
|
|
struct JniImageCallback : public JniCallback {
|
|
// create a JniImageCallback
|
|
static JniImageCallback* make(filament::Engine* engine, JNIEnv* env, jobject handler,
|
|
jobject runnable, long image);
|
|
|
|
// execute the callback on the java thread and destroy ourselves
|
|
static void postToJavaAndDestroy(void*, void* user);
|
|
|
|
private:
|
|
JniImageCallback(JNIEnv* env, jobject handler, jobject runnable, long image);
|
|
virtual ~JniImageCallback();
|
|
long mImage;
|
|
};
|