* utils: RefCountedInternPool/RefCountedMap
First, introduce RefCountedInternPool, a reference counted intern pool of
Slice<const T>. Just acquire() a slice that you want and you're guaranteed to
get exactly one canonical value-equal Slice<const T> back.
Additionally, introduce the concept of NullValue to RefCountedMap. A NullValue
defines what should be considered an uninitialized value; by default, it's the
default value of that type (0 for ints, nullptr for pointers, etc). This allows
us to lazily-initialize values in the map. A client can acquire() a bunch of
different resources which will be initialized only when get(factory) is called.
If a client attempts to get() a value without specifying a factory, and the
value is not initialized (i.e. equal to NullValue{}()), RefCountedMap will
panic.
* utils: add unit tests for ref-counted collections
* utils: remove C++20 features, fix memory issue
* utils: remove RefCounted from InternPool
249 lines
8.0 KiB
C++
249 lines
8.0 KiB
C++
/*
|
|
* Copyright (C) 2025 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
#ifndef TNT_UTILS_REFCOUNTEDMAP_H
|
|
#define TNT_UTILS_REFCOUNTEDMAP_H
|
|
|
|
#include <utils/Panic.h>
|
|
#include <utils/compiler.h>
|
|
#include <utils/debug.h>
|
|
|
|
#include <tsl/robin_map.h>
|
|
|
|
#include <optional>
|
|
#include <type_traits>
|
|
#include <utility>
|
|
|
|
namespace utils {
|
|
|
|
namespace refcountedmap {
|
|
|
|
template <typename T, typename = void>
|
|
struct is_pointer_like_trait : std::false_type {};
|
|
|
|
template <typename T>
|
|
struct is_pointer_like_trait<T, std::void_t<decltype(*std::declval<T&>())>> : std::true_type {};
|
|
|
|
template<typename T>
|
|
inline constexpr bool IsPointer = is_pointer_like_trait<T>::value;
|
|
|
|
template<typename T, typename = void>
|
|
struct PointerTraits {
|
|
using element_type = T;
|
|
};
|
|
|
|
template<typename T>
|
|
struct PointerTraits<T, std::enable_if_t<IsPointer<T>>> {
|
|
using element_type = typename std::pointer_traits<T>::element_type;
|
|
};
|
|
|
|
template<typename T>
|
|
struct DefaultValue {
|
|
T operator()() const noexcept {
|
|
return {};
|
|
}
|
|
};
|
|
|
|
} // namespace refcountedmap
|
|
|
|
/** A reference-counted map.
|
|
*
|
|
* Don't use RAII here, both because we sometimes want to deliberately leak memory, and because
|
|
* we're managing GL resources that require more managed destruction.
|
|
*/
|
|
template<typename Key, typename T, typename Hash = std::hash<Key>,
|
|
typename NullValue = refcountedmap::DefaultValue<T>>
|
|
class RefCountedMap {
|
|
// Use references for the key if the size of the key type is greater than the size of a pointer.
|
|
using KeyRef = std::conditional_t<(sizeof(Key) > sizeof(void*)), const Key&, Key>;
|
|
using TValue = typename refcountedmap::PointerTraits<T>::element_type;
|
|
|
|
struct Entry {
|
|
uint32_t referenceCount;
|
|
T value;
|
|
};
|
|
|
|
using Map = tsl::robin_map<Key, Entry, Hash>;
|
|
|
|
static constexpr TValue& deref(T& a) {
|
|
if constexpr (refcountedmap::IsPointer<T>) {
|
|
return *a;
|
|
} else {
|
|
return a;
|
|
}
|
|
}
|
|
|
|
static constexpr TValue const& deref(T const& a) {
|
|
if constexpr (refcountedmap::IsPointer<T>) {
|
|
return *a;
|
|
} else {
|
|
return a;
|
|
}
|
|
}
|
|
|
|
static constexpr const char* UTILS_NONNULL MISSING_ENTRY_ERROR_STRING =
|
|
"Cache is missing entry";
|
|
static constexpr const char* UTILS_NONNULL MISSING_VALUE_ERROR_STRING =
|
|
"Attempted to get missing value";
|
|
|
|
public:
|
|
/** Acquire and return a value by key, initializing it with F if it doesn't exist.
|
|
*
|
|
* If F returns NullValue{}(), this indicates a failure to create the object. If T is a value
|
|
* type, the returned pointer is valid only as long as the next call to acquire() or release().
|
|
*/
|
|
template<typename F>
|
|
TValue* UTILS_NULLABLE acquire(KeyRef key, size_t hash, F factory) noexcept {
|
|
auto it = mMap.find(key, hash);
|
|
if (it != mMap.end()) {
|
|
it.value().referenceCount++;
|
|
return &deref(it.value().value);
|
|
}
|
|
T r = factory();
|
|
if (r == NullValue{}()) {
|
|
return nullptr;
|
|
}
|
|
// TODO: how to use above computed hash here?
|
|
return &deref(mMap.insert({ key, Entry{ 1, std::move(r) } }).first.value().value);
|
|
}
|
|
|
|
template<typename F>
|
|
inline TValue* UTILS_NULLABLE acquire(KeyRef key, F factory) noexcept {
|
|
return acquire(key, Hash{}(key), std::move(factory));
|
|
}
|
|
|
|
/** Acquire and return a pointer to the value if one exists.
|
|
*
|
|
* It's possible to acquire a key before its value is initialized, in which case this function
|
|
* returns nullptr.
|
|
*
|
|
* If T is a value type, this pointer is valid only as long as the next call to acquire() or
|
|
* release().
|
|
*/
|
|
TValue* UTILS_NULLABLE acquire(KeyRef key, size_t hash) noexcept {
|
|
auto it = mMap.find(key, hash);
|
|
if (it != mMap.end()) {
|
|
it.value().referenceCount++;
|
|
return &deref(it.value().value);
|
|
}
|
|
// TODO: how to use above computed hash here?
|
|
mMap.insert({ key, Entry{ 1, NullValue{}() } });
|
|
return nullptr;
|
|
}
|
|
|
|
inline TValue* UTILS_NULLABLE acquire(KeyRef key) noexcept {
|
|
return acquire(key, Hash{}(key));
|
|
}
|
|
|
|
/** Release a reference to key, destroying it with F if reference count reaches zero.
|
|
*
|
|
* Panics if no entry found in map.
|
|
*/
|
|
template<typename F>
|
|
void release(KeyRef key, size_t hash, F releaser) {
|
|
auto it = mMap.find(key, hash);
|
|
FILAMENT_CHECK_PRECONDITION(it != mMap.end()) << MISSING_ENTRY_ERROR_STRING;
|
|
if (--it.value().referenceCount == 0) {
|
|
if (it.value().value != NullValue{}()){
|
|
releaser(deref(it.value().value));
|
|
}
|
|
// TODO: change to erase_fast
|
|
mMap.erase(it);
|
|
}
|
|
}
|
|
|
|
template<typename F>
|
|
inline void release(KeyRef key, F releaser) noexcept {
|
|
release(key, Hash{}(key), std::move(releaser));
|
|
}
|
|
|
|
/** Release a reference to key.
|
|
*
|
|
* Panics if no entry found in map.
|
|
*/
|
|
void release(KeyRef key, size_t hash) {
|
|
auto it = mMap.find(key, hash);
|
|
FILAMENT_CHECK_PRECONDITION(it != mMap.end()) << MISSING_ENTRY_ERROR_STRING;
|
|
if (--it.value().referenceCount == 0) {
|
|
// TODO: change to erase_fast
|
|
mMap.erase(it);
|
|
}
|
|
}
|
|
|
|
inline void release(KeyRef key) noexcept {
|
|
release(key, Hash{}(key));
|
|
}
|
|
|
|
/** Get a value by key, initializing it with F if it doesn't exist.
|
|
*
|
|
* If F returns NullValue{}(), this indicates a failure to create the object. If T is a value
|
|
* type, the returned pointer is valid only as long as the next call to acquire() or release().
|
|
*/
|
|
template<typename F>
|
|
TValue* UTILS_NULLABLE get(KeyRef key, size_t hash, F factory) {
|
|
auto it = mMap.find(key, hash);
|
|
FILAMENT_CHECK_PRECONDITION(it != mMap.end()) << MISSING_ENTRY_ERROR_STRING;
|
|
const T nullValue = NullValue{}();
|
|
if (it.value().value == nullValue) {
|
|
it.value().value = factory();
|
|
if (it.value().value == nullValue) {
|
|
return nullptr;
|
|
}
|
|
}
|
|
return &deref(it.value().value);
|
|
}
|
|
|
|
template<typename F>
|
|
inline TValue* UTILS_NULLABLE get(KeyRef key, F factory) noexcept {
|
|
return get(key, Hash{}(key), std::move(factory));
|
|
}
|
|
|
|
/** Return reference to existing value by key.
|
|
*
|
|
* This reference is valid only as long as the next call to acquire() or release().
|
|
*
|
|
* Panics if no entry found in map.
|
|
*/
|
|
TValue& get(KeyRef key, size_t hash) {
|
|
auto it = mMap.find(key);
|
|
FILAMENT_CHECK_PRECONDITION(it != mMap.end()) << MISSING_ENTRY_ERROR_STRING;
|
|
FILAMENT_CHECK_PRECONDITION(it.value().value != NullValue{}())
|
|
<< MISSING_VALUE_ERROR_STRING;
|
|
return deref(it.value().value);
|
|
}
|
|
|
|
inline TValue& get(KeyRef key) noexcept { return get(key, Hash{}(key)); }
|
|
|
|
TValue const& get(KeyRef key, size_t hash) const {
|
|
auto it = mMap.find(key);
|
|
FILAMENT_CHECK_PRECONDITION(it != mMap.end()) << MISSING_ENTRY_ERROR_STRING;
|
|
FILAMENT_CHECK_PRECONDITION(it.value().value != NullValue{}())
|
|
<< MISSING_VALUE_ERROR_STRING;
|
|
return deref(it->second.value);
|
|
}
|
|
|
|
inline TValue const& get(KeyRef key) const noexcept { return get(key, Hash{}(key)); }
|
|
|
|
/** Returns true if the map is empty. */
|
|
inline bool empty() const noexcept { return mMap.empty(); }
|
|
|
|
private:
|
|
Map mMap;
|
|
};
|
|
|
|
}
|
|
|
|
#endif // TNT_UTILS_REFCOUNTEDMAP_H
|