Files
filament/libs/utils/test/test_string.cpp
Romain Guy 8875806c5d Use locale-independent string->float conversion (#4885)
* Use locale-independent string->float conversion

strtof and friends are locale aware and won't parse decimal numbers
with a period ("12.6" for instance) in locales that use another
character for the decimal period ("," in French for instance).

This change introduces a new function called strtof_c that forces
the use of a specific locale (called "C") to make sure we always
parse floats in the desired "C" format ("12.6").

With C++17 we should be able to use std::from_chars but this API
is not implemented in clang for floats at the moment.

* Fix Linux
2021-11-23 12:32:54 -08:00

38 lines
1.1 KiB
C++

/*
* Copyright (C) 2019 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include <gtest/gtest.h>
#include <utils/string.h>
using namespace utils;
TEST(strtof_c, EmptyString) {
char* end = nullptr;
const char* start = "";
float r = strtof_c(start, &end);
EXPECT_EQ(start, end);
EXPECT_EQ(0.0f, r);
}
TEST(strtof_c, ValidString) {
char* end = nullptr;
const char* start = "42.24, independent of the locale";
float r = strtof_c(start, &end);
EXPECT_TRUE(end > start);
EXPECT_FLOAT_EQ(42.24f, r);
}