Mathias Agopian
f4a079f663
* Filament Error Handling Remediation and noexcept Cleanup - Replaced assert_invariant with FILAMENT_CHECK_PRECONDITION in Renderer::beginFrame for caller bugs. - Removed noexcept from Camera::setCustomProjection to allow precondition checks to throw. - Removed noexcept from Texture and InstanceBuffer methods using precondition checks. - Documented silent clamping in View::setBloomOptions. - Clarified comment in FrameGraphResources regarding preconditions. - Refined MaterialInstance::commit to split texture loop into check and update passes, preventing partial state changes on precondition failure. * backend: Propagate backend thread exceptions to the main thread. Introduce a mechanism to catch exceptions thrown on the backend thread and rethrow them on the main thread. This prevents deadlocks and allows the application to handle fatal backend failures gracefully. - Consolidate synchronization primitives in DriverBase. - Add mHasUnrecoverableError flag to interrupt blocked fence waits. - Optimize waitForFence to avoid extra atomic reads in common paths. - Propagate FenceStatus::ERROR across all backends. - CommandBufferQueue now stores a std::exception_ptr when the backend fails. - The backend enters a "zombie" state on failure, skipping further command execution but allowing clean shutdown. - Public APIs in Renderer and Engine now check for stored exceptions and rethrow them, documented with @throws. - Guarded by __EXCEPTIONS to ensure no overhead when exceptions are disabled. - Add unit test for fence interruption and document new APIs. BUGS=[407545700] * feat: harden backend exceptions and add hasUnrecoverableFailure API - Update Renderer::beginFrame() and Renderer::shouldRenderFrame() to return false early if an unrecoverable backend exception has been delivered to the main thread. - Document the new return behavior for beginFrame() and shouldRenderFrame() in Renderer.h. - Add Engine::hasUnrecoverableFailure() to the public API to allow apps to check for fatal errors without relying on exceptions. - Implement hasUnrecoverableFailure() in FEngine by delegating to CommandBufferQueue. - Expose Engine::hasUnrecoverableFailure() to Java bindings (Engine.java and JNI). - Expose Engine::hasUnrecoverableFailure() to JavaScript bindings (jsbindings.cpp). * java: propagate C++ Panics & exceptions to JAVA
77 lines
3.0 KiB
C++
77 lines
3.0 KiB
C++
/*
|
|
* Copyright (C) 2020 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#include <jni.h>
|
|
|
|
#include <filament/Engine.h>
|
|
#include <filament/SwapChain.h>
|
|
|
|
#include "common/CallbackUtils.h"
|
|
#include <common/JniUtils.h>
|
|
|
|
using namespace filament;
|
|
|
|
extern "C" JNIEXPORT void JNICALL
|
|
Java_com_google_android_filament_SwapChain_nSetFrameCompletedCallback(JNIEnv* env, jclass,
|
|
jlong nativeSwapChain, jobject handler, jobject runnable) {
|
|
SwapChain* swapChain = (SwapChain*) nativeSwapChain;
|
|
auto* callback = JniCallback::make(env, handler, runnable);
|
|
swapChain->setFrameCompletedCallback(callback->getHandler(),
|
|
[callback](SwapChain* swapChain) { JniCallback::postToJavaAndDestroy(callback); });
|
|
}
|
|
|
|
extern "C" JNIEXPORT jboolean JNICALL
|
|
Java_com_google_android_filament_SwapChain_nIsSRGBSwapChainSupported(
|
|
JNIEnv *, jclass, jlong nativeEngine) {
|
|
Engine* engine = (Engine*) nativeEngine;
|
|
return (jboolean)SwapChain::isSRGBSwapChainSupported(*engine);
|
|
}
|
|
|
|
extern "C" JNIEXPORT jboolean JNICALL
|
|
Java_com_google_android_filament_SwapChain_nIsMSAASwapChainSupported(
|
|
JNIEnv *, jclass, jlong nativeEngine, jint samples) {
|
|
Engine* engine = (Engine*) nativeEngine;
|
|
return (jboolean)SwapChain::isMSAASwapChainSupported(*engine, samples);
|
|
}
|
|
|
|
extern "C" JNIEXPORT jboolean JNICALL
|
|
Java_com_google_android_filament_SwapChain_nIsProtectedContentSupported(
|
|
JNIEnv *, jclass, jlong nativeEngine) {
|
|
Engine* engine = (Engine*) nativeEngine;
|
|
return (jboolean)SwapChain::isProtectedContentSupported(*engine);
|
|
}
|
|
|
|
extern "C" JNIEXPORT void JNICALL
|
|
Java_com_google_android_filament_SwapChain_nSetFrameScheduledCallback(JNIEnv* env, jclass,
|
|
jlong nativeSwapChain, jobject handler, jobject runnable) {
|
|
SwapChain* swapChain = (SwapChain*) nativeSwapChain;
|
|
auto* callback = JniCallback::make(env, handler, runnable);
|
|
filament::android::wrapJni<void>(env, [=]() {
|
|
swapChain->setFrameScheduledCallback(callback->getHandler(),
|
|
[callback](backend::PresentCallable) {
|
|
// Ignore PresentCallable, which is only meaningful with the Metal backend.
|
|
JniCallback::postToJavaAndDestroy(callback);
|
|
});
|
|
});
|
|
}
|
|
|
|
extern "C" JNIEXPORT jboolean JNICALL
|
|
Java_com_google_android_filament_SwapChain_nIsFrameScheduledCallbackSet(
|
|
JNIEnv *, jclass, jlong nativeSwapChain) {
|
|
SwapChain* swapChain = (SwapChain*) nativeSwapChain;
|
|
return (jboolean)swapChain->isFrameScheduledCallbackSet();
|
|
}
|