* Filament Error Handling Remediation and noexcept Cleanup - Replaced assert_invariant with FILAMENT_CHECK_PRECONDITION in Renderer::beginFrame for caller bugs. - Removed noexcept from Camera::setCustomProjection to allow precondition checks to throw. - Removed noexcept from Texture and InstanceBuffer methods using precondition checks. - Documented silent clamping in View::setBloomOptions. - Clarified comment in FrameGraphResources regarding preconditions. - Refined MaterialInstance::commit to split texture loop into check and update passes, preventing partial state changes on precondition failure. * backend: Propagate backend thread exceptions to the main thread. Introduce a mechanism to catch exceptions thrown on the backend thread and rethrow them on the main thread. This prevents deadlocks and allows the application to handle fatal backend failures gracefully. - Consolidate synchronization primitives in DriverBase. - Add mHasUnrecoverableError flag to interrupt blocked fence waits. - Optimize waitForFence to avoid extra atomic reads in common paths. - Propagate FenceStatus::ERROR across all backends. - CommandBufferQueue now stores a std::exception_ptr when the backend fails. - The backend enters a "zombie" state on failure, skipping further command execution but allowing clean shutdown. - Public APIs in Renderer and Engine now check for stored exceptions and rethrow them, documented with @throws. - Guarded by __EXCEPTIONS to ensure no overhead when exceptions are disabled. - Add unit test for fence interruption and document new APIs. BUGS=[407545700] * feat: harden backend exceptions and add hasUnrecoverableFailure API - Update Renderer::beginFrame() and Renderer::shouldRenderFrame() to return false early if an unrecoverable backend exception has been delivered to the main thread. - Document the new return behavior for beginFrame() and shouldRenderFrame() in Renderer.h. - Add Engine::hasUnrecoverableFailure() to the public API to allow apps to check for fatal errors without relying on exceptions. - Implement hasUnrecoverableFailure() in FEngine by delegating to CommandBufferQueue. - Expose Engine::hasUnrecoverableFailure() to Java bindings (Engine.java and JNI). - Expose Engine::hasUnrecoverableFailure() to JavaScript bindings (jsbindings.cpp). * java: propagate C++ Panics & exceptions to JAVA
163 lines
6.1 KiB
C++
163 lines
6.1 KiB
C++
/*
|
|
* Copyright (C) 2021 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#include <jni.h>
|
|
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
|
|
#include <filament/MorphTargetBuffer.h>
|
|
|
|
#include "common/CallbackUtils.h"
|
|
#include "common/NioUtils.h"
|
|
#include <common/JniUtils.h>
|
|
|
|
using namespace filament;
|
|
using namespace backend;
|
|
|
|
extern "C"
|
|
JNIEXPORT jlong JNICALL
|
|
Java_com_google_android_filament_MorphTargetBuffer_nCreateBuilder(JNIEnv*, jclass) {
|
|
return (jlong) new MorphTargetBuffer::Builder();
|
|
}
|
|
|
|
extern "C"
|
|
JNIEXPORT void JNICALL
|
|
Java_com_google_android_filament_MorphTargetBuffer_nDestroyBuilder(JNIEnv*, jclass,
|
|
jlong nativeBuilder) {
|
|
MorphTargetBuffer::Builder* builder = (MorphTargetBuffer::Builder *) nativeBuilder;
|
|
delete builder;
|
|
}
|
|
|
|
extern "C"
|
|
JNIEXPORT void JNICALL
|
|
Java_com_google_android_filament_MorphTargetBuffer_nBuilderVertexCount(JNIEnv*, jclass,
|
|
jlong nativeBuilder, jint vertexCount) {
|
|
MorphTargetBuffer::Builder* builder = (MorphTargetBuffer::Builder *) nativeBuilder;
|
|
builder->vertexCount((size_t) vertexCount);
|
|
}
|
|
|
|
extern "C"
|
|
JNIEXPORT void JNICALL
|
|
Java_com_google_android_filament_MorphTargetBuffer_nBuilderCount(JNIEnv*, jclass,
|
|
jlong nativeBuilder, jint count) {
|
|
MorphTargetBuffer::Builder* builder = (MorphTargetBuffer::Builder *) nativeBuilder;
|
|
builder->count((size_t) count);
|
|
}
|
|
|
|
extern "C" JNIEXPORT void JNICALL
|
|
Java_com_google_android_filament_MorphTargetBuffer_nBuilderWithPositions(JNIEnv*, jclass,
|
|
jlong nativeBuilder, jboolean enabled) {
|
|
MorphTargetBuffer::Builder* builder = (MorphTargetBuffer::Builder*) nativeBuilder;
|
|
builder->withPositions(enabled);
|
|
}
|
|
|
|
extern "C" JNIEXPORT void JNICALL
|
|
Java_com_google_android_filament_MorphTargetBuffer_nBuilderWithTangents(JNIEnv*, jclass,
|
|
jlong nativeBuilder, jboolean enabled) {
|
|
MorphTargetBuffer::Builder* builder = (MorphTargetBuffer::Builder*) nativeBuilder;
|
|
builder->withTangents(enabled);
|
|
}
|
|
|
|
extern "C" JNIEXPORT void JNICALL
|
|
Java_com_google_android_filament_MorphTargetBuffer_nBuilderEnableCustomMorphing(JNIEnv*,
|
|
jclass, jlong nativeBuilder, jboolean enabled) {
|
|
MorphTargetBuffer::Builder* builder = (MorphTargetBuffer::Builder*) nativeBuilder;
|
|
builder->enableCustomMorphing(enabled);
|
|
}
|
|
|
|
extern "C"
|
|
JNIEXPORT jlong JNICALL
|
|
Java_com_google_android_filament_MorphTargetBuffer_nBuilderBuild(JNIEnv* env, jclass,
|
|
jlong nativeBuilder, jlong nativeEngine) {
|
|
MorphTargetBuffer::Builder* builder = (MorphTargetBuffer::Builder *) nativeBuilder;
|
|
Engine *engine = (Engine *) nativeEngine;
|
|
return filament::android::wrapJni<jlong>(env, [=]() {
|
|
return (jlong) builder->build(*engine);
|
|
});
|
|
}
|
|
|
|
// ------------------------------------------------------------------------------------------------
|
|
|
|
extern "C"
|
|
JNIEXPORT jint JNICALL
|
|
Java_com_google_android_filament_MorphTargetBuffer_nSetPositionsAt(JNIEnv* env, jclass,
|
|
jlong nativeObject, jlong nativeEngine,
|
|
jint targetIndex, jfloatArray positions, jint count) {
|
|
MorphTargetBuffer *morphTargetBuffer = (MorphTargetBuffer *) nativeObject;
|
|
Engine *engine = (Engine *) nativeEngine;
|
|
return filament::android::wrapJni<jint>(env, [=]() {
|
|
jfloat* data = env->GetFloatArrayElements(positions, NULL);
|
|
morphTargetBuffer->setPositionsAt(*engine, targetIndex,
|
|
(math::float4*) data, size_t(count));
|
|
env->ReleaseFloatArrayElements(positions, data, JNI_ABORT);
|
|
return 0;
|
|
});
|
|
}
|
|
|
|
extern "C"
|
|
JNIEXPORT jint JNICALL
|
|
Java_com_google_android_filament_MorphTargetBuffer_nSetTangentsAt(JNIEnv* env, jclass,
|
|
jlong nativeObject, jlong nativeEngine,
|
|
jint targetIndex, jshortArray tangents, jint count) {
|
|
MorphTargetBuffer *morphTargetBuffer = (MorphTargetBuffer *) nativeObject;
|
|
Engine *engine = (Engine *) nativeEngine;
|
|
return filament::android::wrapJni<jint>(env, [=]() {
|
|
jshort* data = env->GetShortArrayElements(tangents, NULL);
|
|
morphTargetBuffer->setTangentsAt(*engine, targetIndex,
|
|
(math::short4*) data, size_t(count));
|
|
env->ReleaseShortArrayElements(tangents, data, JNI_ABORT);
|
|
return 0;
|
|
});
|
|
}
|
|
|
|
extern "C"
|
|
JNIEXPORT jint JNICALL
|
|
Java_com_google_android_filament_MorphTargetBuffer_nGetVertexCount(JNIEnv*, jclass,
|
|
jlong nativeObject) {
|
|
MorphTargetBuffer *morphTargetBuffer = (MorphTargetBuffer *) nativeObject;
|
|
return (jint)morphTargetBuffer->getVertexCount();
|
|
}
|
|
|
|
extern "C"
|
|
JNIEXPORT jint JNICALL
|
|
Java_com_google_android_filament_MorphTargetBuffer_nGetCount(JNIEnv*, jclass,
|
|
jlong nativeObject) {
|
|
MorphTargetBuffer *morphTargetBuffer = (MorphTargetBuffer *) nativeObject;
|
|
return (jint)morphTargetBuffer->getCount();
|
|
}
|
|
|
|
extern "C" JNIEXPORT jboolean JNICALL
|
|
Java_com_google_android_filament_MorphTargetBuffer_nHasPositions(JNIEnv*, jclass,
|
|
jlong nativeObject) {
|
|
MorphTargetBuffer* morphTargetBuffer = (MorphTargetBuffer*) nativeObject;
|
|
return (jboolean) morphTargetBuffer->hasPositions();
|
|
}
|
|
|
|
extern "C" JNIEXPORT jboolean JNICALL
|
|
Java_com_google_android_filament_MorphTargetBuffer_nHasTangents(JNIEnv*, jclass,
|
|
jlong nativeObject) {
|
|
MorphTargetBuffer* morphTargetBuffer = (MorphTargetBuffer*) nativeObject;
|
|
return (jboolean) morphTargetBuffer->hasTangents();
|
|
}
|
|
|
|
extern "C" JNIEXPORT jboolean JNICALL
|
|
Java_com_google_android_filament_MorphTargetBuffer_nIsCustomMorphingEnabled(JNIEnv*, jclass,
|
|
jlong nativeObject) {
|
|
MorphTargetBuffer* morphTargetBuffer = (MorphTargetBuffer*) nativeObject;
|
|
return (jboolean) morphTargetBuffer->isCustomMorphingEnabled();
|
|
}
|