From 9ae7e2c2a8a127db610b33c5ddbc026fbc7d02e8 Mon Sep 17 00:00:00 2001 From: Niels Lohmann Date: Sun, 11 Oct 2026 05:54:32 +0200 Subject: [PATCH] Silence a clang-tidy C++17 finding in the image test bugprone-suspicious-stringview-data-usage flags data() of the source view under C++17, although the length is passed and checked by the REQUIRE before it. Signed-off-by: Niels Lohmann --- tests/src/unit-json_view_image.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/src/unit-json_view_image.cpp b/tests/src/unit-json_view_image.cpp index f470ae9e9..3d030fbcd 100644 --- a/tests/src/unit-json_view_image.cpp +++ b/tests/src/unit-json_view_image.cpp @@ -450,7 +450,7 @@ TEST_CASE("json_view images: edited documents") // prefix const ordered_json_document l = ordered_json_document::load(image); REQUIRE(l.source().size() > text.size()); - CHECK(std::string(l.source().data(), text.size()) == text); + CHECK(std::string(l.source().data(), text.size()) == text); // NOLINT(bugprone-suspicious-stringview-data-usage): the size is given and checked above } SECTION("a loaded document can be edited and saved again")