From b59fc6c902f668a855efded64c7f7080cfff6710 Mon Sep 17 00:00:00 2001 From: Niels Lohmann Date: Thu, 1 Oct 2026 10:26:18 +0200 Subject: [PATCH] Mark string_ref's strlen as a Flawfinder false positive string_ref(const char*) requires a null-terminated string, like std::string_view's constructor. Signed-off-by: Niels Lohmann --- include/nlohmann/detail/view/string_ref.hpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/nlohmann/detail/view/string_ref.hpp b/include/nlohmann/detail/view/string_ref.hpp index bb9605bf6..d401500ec 100644 --- a/include/nlohmann/detail/view/string_ref.hpp +++ b/include/nlohmann/detail/view/string_ref.hpp @@ -40,6 +40,8 @@ class string_ref using const_iterator = const char*; string_ref() noexcept = default; + // s must be null-terminated, as for std::string_view(const char*) + // flawfinder: ignore string_ref(const char* s) : m_data(s), m_size(std::strlen(s)) {} // NOLINT(google-explicit-constructor,hicpp-explicit-conversions) string_ref(const char* s, std::size_t n) noexcept : m_data(s), m_size(n) {} template