Scarfski/json
1
0
Fork 0
mirror of https://github.com/nlohmann/json.git synced 2026-10-15 21:35:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Delete json_document::root() on temporary documents

Browse Source 
auto v = json_document::parse(text).root() compiled and left the view
dangling. Delete the overload for rvalue documents, take a named document
in the tests, and document the lifetime rule.

Signed-off-by: Niels Lohmann <mail@nlohmann.me>
This commit is contained in:
Niels Lohmann
2026-10-09 16:22:39 +02:00
parent 6952ff6363
commit f4aceabef3
4 changed files with 80 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
include/nlohmann/json_view.hpp
View File

@@ -358,7 +358,7 @@ class basic_json_document
////////////
/// the root value (discarded if parsing failed without exceptions)
view_type root() const noexcept
view_type root() const& noexcept
{
if (!m_data || m_data->discarded)
{
@@ -367,6 +367,9 @@ class basic_json_document
return view_type(m_data.get(), m_data->tape);
}
/// deleted: the view of a temporary document would dangle
view_type root() const&& = delete;
bool is_discarded() const noexcept
{
return !m_data || m_data->discarded;