Commit Graph
167 Commits
Author SHA1 Message Date
Domenico Albani 433986a5a4 Implement more complex area modifications (#260)
This implements rcAreaModification which allows combining of area types when they overlap
and otherwise usage of the area type as a bit mask.
2017-03-12 12:18:29 +01:00
Domenico Albani dfd40071c5 Assertion failure custom function (#250)
Implement custom functions to be called when an assertion fails.
2017-01-23 23:02:46 +01:00
Ben Hymers d11c1bdbac Fix multiline comment warning 2017-01-12 11:31:29 +00:00
Acai 787ce2c18d Fix log errors in rcBuildLayerRegions. (#242) 2016-11-27 12:12:54 +01:00
Jakob Botsch Nielsen 7a88c13946 Add an assertion for alloc in rcIntArray::doResize (#219)
Fix #170
2016-07-13 11:30:13 +02:00
Jakob Botsch Nielsen 9763478a9a Detect all overflows in rcBuildHeightfieldLayers (#214)
The function now fails if it fails to insert all layers because the
array overflowed. Previously this would silently corrupt the heap.
2016-07-08 01:51:23 +03:00
grahamboree c9bacf3c9c Unit tests for a good number of Recast functions.
These are by no means complete coverage of the functions they test, but are at least a start.  For consistency, all floating point comparisons use Approx(), regardless of whether they need to or not.

Removed unnecessary C++11 unique_ptr stuff, now that rcHeightfield has a constructor and destructor.
2016-03-29 01:04:51 -04:00
grahamboree 61dbce80e9 Added Constructor and Destructor to rcHeightfield. 2016-03-20 18:42:14 -04:00
Ben Hymers d9c6fc58ce Remove redundant double assignment 2016-03-15 08:02:28 +00:00
Ben Hymers e344fe8295 Remove dead code in rcBuildRegions
The code is checking for an invalid region ID, after setting it to a valid value
2016-03-15 07:56:57 +00:00
Ben Hymers c208fd332c Minor typo and style changes 2016-03-14 09:03:40 +00:00
Graham Pentheny 6ee79b25a8 Merge pull request #169 from wbierman/master
Detect, log and fail in the event of an overflow of region ids in watershed partitioning
2016-01-21 13:21:03 -05:00
Bill Bierman e49017ac63 Detect, log and fail in the event of an overflow of region ids in watershed partitioning 2016-01-21 07:07:40 -10:00
Graham Pentheny b7a83e0afb Fixed rule of 3 violations in many places.
* Added virtual qualifier to a few destructors in subclasses.
* Removed a few empty destructors that didn't need to be explicitly defined.
* Fixed a few typos
* Removed unnecessary empty virtual destructors in some classes with parent's who derrived from a class with a virtual destructor
2016-01-20 11:57:32 -05:00
Bill Bierman 92bc6ce5bd Change if to else-if to avoid unnecessary comparison 2016-01-19 11:34:04 -10:00
Ben Hymers 551d1b250e Use size_t for rcAlloc and dtAlloc
This was already partly done by @cexikitin in #65, I'm just finishing it
off in their absence!

Closes #65
2016-01-15 00:36:18 +00:00
Jakob Botsch Nielsen 0143337a64 Merge pull request #154 from Janiels/fix-detail-unsampled-heights
Increase recover radius for unsampled heights
2016-01-14 22:18:43 +01:00
Jakob Botsch Nielsen b99d62047b Increase recover radius for unsampled heights
When the detail mesh sampling sees an unset height it previously tried
to recover by looking for heights of neighbors. When the heightfield was
not eroded this recovery would fail since the contour simplification
could mean that the nearest valid cell was further away than a neighbor.
We now walk adjacent cells in a spiral to find a height and do this
depending on the max simplification error.

Fix #153
2016-01-14 19:20:43 +01:00
Jakob Botsch Nielsen f002387afc Merge pull request #151 from Janiels/fix-detail-sampling
Use flood fill for potentially overlapping polys
2016-01-14 16:48:13 +01:00
Jakob Botsch Nielsen 5fce286267 Use flood fill for potentially overlapping polys
This changes the detail sampling to find height data by using the flood
fill method for polygons that were merged because of a border vertex
removal. This could potentially cause overlapping polygons to receive
the same region IDs which would later make the fast-path sampling in
getHeightData sample the wrong heights.

Also includes optimizations for this path and getHeightData itself.
Previously the seeding was responsible for 25% of the total time spent
in getHeightData in these cases. We now use the direction and prefer
moving directly towards the center of the polygon. This makes the
overhead of seedArrayWithPolyCenter virtually nonexistent (~2%
according to profiling).

Fix #146
2016-01-14 11:25:48 +01:00
Jakob Botsch Nielsen c1f9fd8406 Fix heap corruption when collecting region layers
The collecting could overflow the neighbours array due to a missing boundary
check.

Fix #30
2016-01-02 13:33:27 +01:00
Rafael Stahl 15025e8519 handle the case when allocSpan fails to allocate memory. adds bool return types to rcAddSpan, rcRasterizeTriangle and rcRasterizeTriangles 2015-12-18 16:41:02 +01:00
Rafael Stahl 6d3c9b38ba add rcScopedTimer to fix timers not being stopped on all paths and to prevent it in the future. 2015-12-18 14:48:31 +01:00
jackpoz 18b537c23f Fix 2 "unused parameter" build warnings 2015-06-28 21:32:16 +02:00
CharlesJClark 6730d4ddda Update RecastMesh.cpp
Fixed validation checks of allocations.
2015-06-19 09:33:27 -07:00
Kromster80 3ca4db4864 Fixed loop overrun 2015-02-19 14:03:59 +03:00
Kromster80 ce304d195f Removed superflous memset
We have already filled whole set of layers with zeroes at line 477. It looks like we don't need to fill the layers once again. Right?
2014-12-23 11:10:05 +03:00
Mikko Mononen ff7549bb57 Merge pull request #51 from Kromster80/HULL-UNDEF
Renamed enums to avoid name collisions with "hull" variables
2014-12-13 13:55:33 +02:00
Mikko Mononen b869953fd2 Merge pull request #54 from Kromster80/var
Removed unnecessary variable assignment
2014-12-13 13:44:45 +02:00
Mikko Mononen ace7f1f19a Merge pull request #52 from Kromster80/typo-fixes
Typo fixes
2014-12-13 13:35:40 +02:00
Kromster80 a94ecdc079 Removed unneeded assignment 2014-12-13 10:55:04 +03:00
Kromster80 d1bdd8192e Update Recast.cpp 2014-11-13 17:36:22 +03:00
Kromster80 ccc346fd53 Fixed typos 2014-11-13 16:52:10 +03:00
Kromster80 5dfb3b01e7 Renamed enum to avoid name collisions with "hull" variables 2014-11-10 15:23:28 +03:00
Kromster80 d9652b362e Update RecastMeshDetail.cpp 2014-11-10 15:08:03 +03:00
Kromster80 f9ddd31493 Update RecastMesh.cpp 2014-11-10 15:07:17 +03:00
Kromster80 519b148451 Update RecastContour.cpp 2014-11-10 15:06:43 +03:00
Kromster80 6c3b575052 Rolled back to pull 2014-10-30 21:19:19 +04:00
Kromster80 a7a67af47b Typo fixes 2014-10-30 17:05:39 +03:00
Kromster80 e3d5c9904e Renamed local variable to avoid scope collisions
I'm not sure if C++ vars are scoped into {} blocks, but in ported code that is an issue. It's easier to have vars names unique. Does not harm anyone I guess? ;-)
2014-10-30 16:59:51 +03:00
Mikko Mononen 129efa5833 Fix for issue #38 and improvements to detail mesh tessellation
- do circumCircle calculations relative to first vertex for adde
precision
- improved the results of triangulateHull(), produces less degen
triangles
- fixed case with contour merging when outline is null
2014-06-24 15:23:53 +03:00
Mikko Mononen 480f56e94d Fixed memory allocation in detail mesh and memcpy in polymesh copy 2014-06-24 15:23:53 +03:00
Mikko Mononen 24a11a2823 Fixed silly mistake in detail mesh next(), prev() functions 2014-06-14 15:59:32 +03:00
Mikko Mononen e6fc6a3817 Removed unused code 2014-06-13 13:28:46 +03:00
Mikko Mononen 3cb87f2432 Merge branch 'master' of https://github.com/memononen/recastnavigation 2014-06-13 13:25:07 +03:00
Mikko Mononen a89bb843d7 Added new method to partition heighfield
- added layer based heighfield partitioning
- the method is a bit slower than monotone partitioning, but does not
suffer from the long thin ploys
- the method partitions the heighfield into non-overlapping areas, but
does not try to resolve holes
- improved contour hole merging so that it can properly handle all
kinds of holes
- improved polygon triangulation to handle overlapping segments
- improved small and long polygon detail mesh generation
- updated samples to include all 3 partition methods and little
documentation to help to choose between them
2014-06-13 13:25:01 +03:00
Mikko Mononen 740a7ba516 Merge pull request #18 from jackpoz/rcMergePolyMeshes_portals_fix
Fix rcMergePolyMeshes() ignoring portals of input meshes.
2014-02-21 10:35:39 +02:00
Mikko Mononen 3e8b413036 Fix for detail mesh height data generation
- if the new region based height data generation fails, use the old
flood fill based method
2014-02-21 10:32:35 +02:00
jackpoz 77ebf64353 Fix rcMergePolyMeshes() ignoring portals of input meshes.
Copy the portals from input meshes on border to the output mesh.
2014-02-19 21:00:14 +01:00
axelrodR adcd4f472e bugfix: divPoly could produce an 8th point after several calls because some of the old clipPoly code on which it was based
can add the same point twice consecutively (interpolation+adding the point).
Rather than raising the buffer I rewrote divPoly to avoid adding the same point twice.
2014-01-21 22:05:40 +02:00