Scarfski/tracy
1
0
Fork 0
mirror of https://github.com/wolfpld/tracy.git synced 2026-09-11 04:48:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Store kernel symbol end address, not size.

Browse Source 
The end address is now readily available in lower_bound search, instead
of needing to be calculated constantly in the lambda.

The size can be equivalently calculated from the end address, but this
only happens once, after the symbol is found.
This commit is contained in:
Bartosz Taudul
2026-05-10 00:15:18 +02:00
parent a6c72f1cc7
commit 5cb283073e
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
public/client/TracyCallstack.cpp
View File

@@ -1145,7 +1145,7 @@ static FastVector<DebugInfo>* s_di_known;
struct KernelSymbol
{
uint64_t addr;
uint32_t size;
uint64_t endAddr;
const char* name;
const char* mod;
};
@@ -1226,7 +1226,7 @@ static void InitKernelSymbols()
auto sym = tmpSym.push_next();
sym->addr = addr;
sym->size = 0;
sym->endAddr = addr;
sym->name = strname;
sym->mod = strmod;
}
@@ -1237,7 +1237,7 @@ static void InitKernelSymbols()
std::sort( tmpSym.begin(), tmpSym.end(), []( const KernelSymbol& lhs, const KernelSymbol& rhs ) { return lhs.addr < rhs.addr; } );
for( size_t i=0; i<tmpSym.size()-1; i++ )
{
if( tmpSym[i].name ) tmpSym[i].size = tmpSym[i+1].addr - tmpSym[i].addr;
if( tmpSym[i].name ) tmpSym[i].endAddr = tmpSym[i+1].addr;
}
s_kernelSymCnt = validCnt;
@@ -1825,13 +1825,13 @@ CallstackEntryData DecodeCallstackPtr( uint64_t ptr )
#ifdef __linux
else if( s_kernelSym )
{
auto it = std::lower_bound( s_kernelSym, s_kernelSym + s_kernelSymCnt, ptr, []( const KernelSymbol& lhs, const uint64_t& rhs ) { return lhs.addr + lhs.size < rhs; } );
auto it = std::lower_bound( s_kernelSym, s_kernelSym + s_kernelSymCnt, ptr, []( const KernelSymbol& lhs, const uint64_t& rhs ) { return lhs.endAddr < rhs; } );
if( it != s_kernelSym + s_kernelSymCnt )
{
cb_data[0].name = CopyStringFast( it->name );
cb_data[0].file = CopyStringFast( "<kernel>" );
cb_data[0].line = 0;
cb_data[0].symLen = it->size;
cb_data[0].symLen = it->endAddr - it->addr;
cb_data[0].symAddr = it->addr;
return { cb_data, 1, it->mod ? it->mod : "<kernel>" };
}