From 607f6a7caf10ee9675d259eb045d4c9c96480a07 Mon Sep 17 00:00:00 2001 From: Bartosz Taudul Date: Sun, 11 Oct 2026 21:40:43 +0200 Subject: [PATCH] Award the manual achievement from the shared window state. All ManualWindow instances share the show state, so one check covers the welcome screen and the view; the old copies were button-only and gated on a construction-time config snapshot. --- profiler/src/main.cpp | 6 +++--- profiler/src/profiler/TracyView.cpp | 1 - 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/profiler/src/main.cpp b/profiler/src/main.cpp index de13ed11..027e2290 100644 --- a/profiler/src/main.cpp +++ b/profiler/src/main.cpp @@ -835,7 +835,6 @@ static void DrawContents() if( ImGui::Button( ICON_FA_BOOK " Manual" ) ) { s_manualWindow.Show() = true; - if( tracy::s_config.achievements ) s_achievements->Achieve( "manual" ); } ImGui::SameLine(); if( ImGui::Button( ICON_FA_EARTH_AMERICAS " Web" ) ) @@ -1587,9 +1586,10 @@ Would you like to enable achievements? } } - if( !viewPtr && s_manualWindow.Show() ) + if( s_manualWindow.Show() ) { - s_manualWindow.Draw( s_manualMarkdown ); + if( tracy::s_config.achievements ) s_achievements->Achieve( "manual" ); + if( !viewPtr ) s_manualWindow.Draw( s_manualMarkdown ); } bptr->EndFrame(); diff --git a/profiler/src/profiler/TracyView.cpp b/profiler/src/profiler/TracyView.cpp index 99a454ac..06f9fbbb 100644 --- a/profiler/src/profiler/TracyView.cpp +++ b/profiler/src/profiler/TracyView.cpp @@ -769,7 +769,6 @@ bool View::DrawImpl() if( m_worker.GetZoneCount() > 100 * 1000 * 1000 ) Achieve( "100million" ); if( m_worker.GetCallstackSampleCount() > 0 ) Achieve( "samplingIntro" ); if( m_worker.AreFramesUsed() ) Achieve( "instrumentFrames" ); - if( m_manualWindow.Show() ) Achieve( "manual" ); } Attention( m_attnWorking );