Scarfski/tracy
1
0
Fork 0
mirror of https://github.com/wolfpld/tracy.git synced 2026-11-01 21:45:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reject client configurations that cannot work.

Browse Source 
TRACY_NO_CALLSTACK, TRACY_NO_SYSTEM_TRACING, TRACY_NO_SAMPLING and
TRACY_SAMPLING_PROFILER_MANUAL_START either fail to build (the external
target API lives in the callstack code) or silently produce an empty
capture (no sampling event fails, so IsSystemTracingFailed stays false).
The first three are #error'd at compile time; the TRACY_NO_SYS_TRACE /
TRACY_NO_SAMPLING environment variables are refused at startup.
This commit is contained in:
Bartosz Taudul
2026-08-31 01:12:41 +02:00
parent 6d794801c6
commit 893439772f
1 changed files with 35 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
monitor/src/monitor.cpp
+35
View File
@@ -23,6 +23,24 @@
#include "../public/client/TracyCallstack.hpp"
#include "GitRef.hpp"
// The monitor is only meaningful with the client's full sampling +
// symbolication stack. These configurations would either fail to build
// (TRACY_NO_CALLSTACK: the external-target API lives in the callstack
// code) or silently produce an empty capture (IsSystemTracingFailed()
// cannot see them), so reject them here rather than in the client.
#if defined TRACY_NO_CALLSTACK
# error "tracy-monitor requires callstack support: TRACY_NO_CALLSTACK is not supported"
#endif
#if defined TRACY_NO_SYSTEM_TRACING
# error "tracy-monitor requires system tracing: TRACY_NO_SYSTEM_TRACING is not supported"
#endif
#if defined TRACY_NO_SAMPLING
# error "tracy-monitor requires callstack sampling: TRACY_NO_SAMPLING is not supported"
#endif
#if defined TRACY_SAMPLING_PROFILER_MANUAL_START
# error "tracy-monitor starts sampling itself via StartupProfiler(): TRACY_SAMPLING_PROFILER_MANUAL_START is not supported"
#endif
static volatile sig_atomic_t s_shouldQuit = 0;
static pid_t s_targetPid = 0;
static bool s_isForked = false;
@@ -833,6 +851,23 @@ int main( int argc, char** argv )
sigaction( SIGHUP, &sa, nullptr );
sigaction( SIGQUIT, &sa, nullptr );
// TRACY_NO_SYS_TRACE / TRACY_NO_SAMPLING would silently disable the monitor's
// primary data sources (IsSystemTracingFailed() stays false); refuse them up front.
const char* noSysTrace = getenv( "TRACY_NO_SYS_TRACE" );
const char* noSampling = getenv( "TRACY_NO_SAMPLING" );
if( ( noSysTrace && noSysTrace[0] == '1' ) || ( noSampling && noSampling[0] == '1' ) )
{
if( noSysTrace && noSysTrace[0] == '1' )
{
fprintf( stderr, "tracy-monitor: TRACY_NO_SYS_TRACE=1 is set; the monitor requires system tracing. Unset the variable and retry.\n" );
}
if( noSampling && noSampling[0] == '1' )
{
fprintf( stderr, "tracy-monitor: TRACY_NO_SAMPLING=1 is set; the monitor requires callstack sampling. Unset the variable and retry.\n" );
}
return 1;
}
pid_t attachPid = 0;
char attachName[128] = {};
bool wantAttach = false;